Re: Merge tags in master branch?

2020-11-23 Thread Luigi Toscano
Harald Sitter ha scritto:
> Hej
> 
> On 23.11.20 16:11, Bhushan Shah wrote:
>> Hello,
>>
>> So I have one question regarding the how we do the framework versioning.
>> Namely the tags,
>>
>> So currently some packages have a versioned tags on their master branch,
>>
>> i.e
>>
>> karchive:
>>
>> ➜ git describe
>> v5.76.0-1-g7304c28
>>
>> While in case of some frameworks where translations needs to be taken
>> from svn, it is something super weird like,
>>
>> kdesu:
>>
>> ➜ git describe
>> v5.2.0-234-gb7ba89f
>>
>> Some packagers who package -git versions in their unstable repos check
>> the git describe to figure out what is current revision of the package
>> and having "wrong" version there bugs out weirdly.
>>
>> Do anyone have any opinion on "merging" latest git tag in master branch?
>> and potentially doing that for next releases as well?
> 
> At that point we could just have scripty push the translations on the
> daily runs surely? There's little point taking a round trip through the
> release scripting if we effectively end up having translations in the
> repo anyway, so we could just treat them like the desktop/xml
> translations and have scripty forward them from svn into git.
> 
> I'm rather +1 to streamlining the translation handling. At the same time
> I'm not sure if only doing this only for frameworks is all that cool,
> but then I suppose frameworks is the less complicated. *shrug* I guess ;)


We need some work for that.

https://phabricator.kde.org/T13519

-- 
Luigi


D28861: Sonnet add Malayalam trigram

2020-10-01 Thread Luigi Toscano
ltoscano changed the visibility from "All Users" to "Public (No Login 
Required)".

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D28861

To: aiswaryak, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29802: Require in-source build

2020-05-16 Thread Luigi Toscano
ltoscano added a comment.


  I believe a few sentences in the the commit message contradicts each other.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29802

To: ngraham, #frameworks, #vdg, ognarb, davidre
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Luigi Toscano
ltoscano added a comment.


  In D29711#670470 , @ngraham wrote:
  
  > In D29711#670458 , @cfeck wrote:
  >
  > > Sorry if I don't understand the scope, but does this mean I am forced to 
install systemsettings to be able to use KCMs?
  >
  >
  > Why, is the "I'm using Plasma but I don't have System Settings installed" 
use case something that you think we should handle?
  >
  > The context is that users were requesting for KCMs to be opened in System 
Settings, not KCMShell (https://bugs.kde.org/show_bug.cgi?id=402790) and we 
implemented that for the KCM runner for Plasma 5.19. The issue fixed here is an 
inconsistency in that opening KCMs from Plasma applet context menu would still 
open it in KCMShell, not System Settings or Info Center (which in 5.19 is now 
just System Settings; the same app shows both).
  
  
  If the scope of this change is just about Plasma applet, of course 
systemsettings is going to be around.
  But are you sure you want to kill kcmshell? KCMs are not for Plasma only. 
Opening them outside Plasma would still require a minimal shell.
  
  Regarding this change, I guess you may have discussed it already, but 
wouldn't it be possible to find out whether systemsettings is available (and 
then kinfocenter) and use it, without adding a new function?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-09 Thread Luigi Toscano
ltoscano added a comment.


  In D29575#667175 , @winterz wrote:
  
  > I'm guessing it's ok to depend on K5I18N ?
  
  
  KHolidays is a Tier 1 framework, so it can't depend on KI18n. Just use 
QCoreApplication::translate as used already in src/holidayregion.cpp.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29575

To: winterz, vkrause
Cc: ltoscano, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-01 Thread Luigi Toscano
Ben Cooksley ha scritto:
> On Fri, May 1, 2020 at 4:38 PM Nate Graham  wrote:
>>
>>
>>
>> On 4/30/20 5:59 PM, Aleix Pol wrote:
>>> El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid
 Am I the only person that just has all the repos on the same folder? I 
 thought it was the common thing to do :?
>>>
>>> I do too
>>
>> Same here. kdesrc-build's default settings do this, and download all
>> repos into ~/kde/src without any of the levels of hierarchy. This would
>> seem to require unique repo names, no?
> 
> Not necessarily.
> 
> Git allows you to override the name that the local folder is called
> when cloning, so there is no reason why we can't specify something in
> the metadata to override the local name that the folder gets called in
> your local checkout folder.
> This would allow for example:
> 
> - frameworks/kcoreaddons on Gitlab continues to be called
> 'kcoreaddons' in your local checkout folder
> - maui/dialer on Gitlab gets called 'maui-dialer' in your local checkout 
> folder
> 
> This allows for the URLs on Gitlab to make sense, while simultaneously
> allowing your local source checkout folders to continue to work in the
> manner in which they do currently.
> Note that we do not expect people to hit this in many cases - this is
> about giving us the flexibility for the long term without imposing
> unnecessary bureaucracy and limits on projects within the KDE
> umbrella.
> 
> Automated tooling such as kdesrc-build and the proposed clone script
> (that searches in namespaces) should be able to handle this without
> much issue.
> In the case of manually done clones, it is reasonable to expect people
> to know what they're doing with their clones, and name them
> appropriately in the event they have a collision.
> 
> Does this sound acceptable?

I'd like to add that this would solve an issue we have on the translation side.

Right now, a few translation files use the repository names as the base part
of the template file name. For example, the translation files for the desktop
and json files, which are called ._desktop_.po(t) and
._json_.po(t) respectively.

In the case where the repository name is not unique we would need to record
the expected name for the template somewhere. If this  information is added to
the repository metadata, would have scripty rely on that and don't need to
write it down somewhere else.

So yes, if you can please add this optional override which sets a unique name
to the metadata, that would help, thanks!

-- 
Luigi


D27419: Update Japanese holidays

2020-02-16 Thread Luigi Toscano
ltoscano added a comment.


  Just did it:
  https://commits.kde.org/kholidays/263bc0f2d601bcf9a5d3632f8535e0bbd8f50255

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27419

To: nhiga, dvratil, winterz, cgiboudeaux
Cc: ltoscano, aacid, #kde_pim, kde-frameworks-devel, LeGast00n, cblack, 
fbampaloukas, GB_2, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, 
winterz, vkrause, mlaurent, knauss, dvratil


D27419: Update Japanese holidays

2020-02-16 Thread Luigi Toscano
ltoscano added a comment.


  Please revert and commit it with the correct authorship.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27419

To: nhiga, dvratil, winterz, cgiboudeaux
Cc: ltoscano, aacid, #kde_pim, kde-frameworks-devel, LeGast00n, cblack, 
fbampaloukas, GB_2, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, 
winterz, vkrause, mlaurent, knauss, dvratil


D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Luigi Toscano
ltoscano added a comment.


  In D24423#594728 , @guoyunhe wrote:
  
  > if we copy `applications.menu` to plasma-workspace and patch it there, it 
will only be shipped with future plasma releases.
  
  
  Isn't it going to conflict with the kservice-provided one? I simply don't 
know, but it should be answered before deciding.
  If it does not conflict, do you mean postpone the kservice patch until 
Frameworks 6?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Luigi Toscano
ltoscano added a comment.


  In D24423#594718 , @guoyunhe wrote:
  
  > Then how about I copy this file `applications.menu` to plasma-workspace? 
After one or two years, we can delete this file from frameworks. But for 
compatibility, it will exist in both repositories for some time.
  
  
  It is still does not answer the question on what happens with *already 
released* Plasma.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Luigi Toscano
ltoscano added a comment.


  The question is the same. What happens with older Plasma with newer 
Frameworks?
  It may be that nothing really breaks, of course.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D24932: Add button to open the folder in filelight to view more details

2019-12-31 Thread Luigi Toscano
ltoscano added a comment.


  As a reference for the future: this change broke the two weeks string freeze 
- which we haven't enforced so strongly in the past months, but please keep an 
eye on it. Expecially this time of the year with many countries on vacation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks
Cc: ltoscano, pino, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Luigi Toscano
ltoscano added a comment.


  In D26317#585315 , @aacid wrote:
  
  > Isn't it better to just use `Qt::endl` ?
  >
  > I think it's much clearer to understand `Qt::endl` than `QLatin1Char('\n')`
  >
  > But if we prefer to change to use \n it should be merged into the existing 
strings, doesn't make much sense to do 
  >  `outStream << "" << QLatin1Char('\n');`
  >  instead of
  >  `outStream << "\n';`
  
  
  I agree with Albert here; I think it's a bit more painful but it's probably 
going to be cleaner.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: ltoscano, aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, 
LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D26306: Define more documentation search paths (also custom)

2019-12-30 Thread Luigi Toscano
ltoscano added subscribers: asturmlechner, maximilianocuria, rikmills, arojas, 
rdieter, lbeltrame, cgiboudeaux.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26306

To: ltoscano
Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, 
asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D26306: Define more documentation search paths (also custom)

2019-12-30 Thread Luigi Toscano
ltoscano created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
ltoscano requested review of this revision.

REVISION SUMMARY
  New search paths:
  
  - (GenericDataLocation)/help
  - a custom path (absolute path), which can be defined during compile time by 
setting KDOCTOOLS_CUSTOM_DOC_PATH
  
  Also, make sure that the first item looks into
  KDE_INSTALL_DOCSBUNDLEDIR anyway.
  
  The addition of /help (usually /usr/share/help) paves
  the way for using that directory as new default value for
  KDE_INSTALL_DOCSBUNDLEDIR.

TEST PLAN
  The test passes and the list of directories contains
  the expected entries.

REPOSITORY
  R238 KDocTools

BRANCH
  extra-doc-paths

REVISION DETAIL
  https://phabricator.kde.org/D26306

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/documentcustomdirtest.cpp
  autotests/documentdirstest.cpp
  config-kdoctools.h.cmake
  src/xslt.cpp

To: ltoscano
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna


D26167: Update holidays and add flagdays and namedays for Sweden

2019-12-22 Thread Luigi Toscano
ltoscano added a comment.


  Try to use 
  [easter] + 50 days
  
  Example (from Italian holidays):
  
  "Ascensione (Chiesa Cattolica)"   religious on ((year >= 1977) ? ([easter] + 
42 days): noop)
  
  https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?#n47

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D26167

To: riiga
Cc: ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

2019-12-06 Thread Luigi Toscano
ltoscano added a comment.


  Oh sorry, I missed that. It's the kind of information I wouldn't expect in 
the commit message.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  configure-keyboard-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg, ndavis
Cc: ltoscano, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

2019-12-06 Thread Luigi Toscano
ltoscano added a comment.


  Please commit it after the commit for the new Frameworks is made (so probably 
from Sunday onwards).

REPOSITORY
  R265 KConfigWidgets

BRANCH
  configure-keyboard-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25793

To: ngraham, #vdg, ndavis
Cc: ltoscano, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D25630: Port to json metadata

2019-11-30 Thread Luigi Toscano
ltoscano added inline comments.

INLINE COMMENTS

> ktp_integration_module.json:3
> +"KPlugin": {
> +"Description": "Module providing deeper integration of Instant 
> Messaging with KDE.",
> +"Name": "Telepathy Integration Module",

I can't comment on the rest of the reivew, but as you are changing this string, 
I think it would be worth to change the "with KDE" part (it comes from the old 
definition of KDE). Maybe the entire sentence needs to be re-though, I don't 
have a clear alternative right now.

REPOSITORY
  R150 KDE Telepathy KDE Daemon Module

REVISION DETAIL
  https://phabricator.kde.org/D25630

To: nicolasfella, #frameworks, #kde_telepathy
Cc: ltoscano


D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-11-24 Thread Luigi Toscano
ltoscano added a comment.


  Maybe pinging a few Plasma people may be more effective, or though a mailing 
list thread. I don't know.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D25435: [Network Ioslave] Add Display name to network:/

2019-11-22 Thread Luigi Toscano
ltoscano added inline comments.

INLINE COMMENTS

> Messages.sh:2
> +#! /usr/bin/env bash
> +$XGETTEXT *.cpp -o $podir/kio5_network.pot

This does not work as it is, because it does not look into the subdirectories. 
Hint for testing:
https://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-to-create.html

I'm going to fix it (replace *.cpp with $(find . -name '*.cpp') )

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25435

To: meven, ngraham, #frameworks
Cc: ltoscano, broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov


Re: Bulk replacement of projects.kde.org on Frameworks modules

2019-11-16 Thread Luigi Toscano
Luigi Toscano ha scritto:
> Hi,
> basically all Frameworks components reference the ECM website
> using the old projects.kde.org URL, which is long gone and
> it is just a (partial) redirect.
> 
> See for example:
> 
> set_package_properties(ECM PROPERTIES TYPE REQUIRED
> DESCRIPTION "Extra CMake Modules."
> URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;)
> 
> Can I go around a bulk-replace all the URLs with
> https://commits.kde.org/extra-cmake-modules, so that it would look like:
> 
> set_package_properties(ECM PROPERTIES TYPE REQUIRED
> DESCRIPTION "Extra CMake Modules."
> URL "https://commits.kde.org/extra-cmake-modules;)
> 
> There are few additional URLs which use the old website and I would replace
> them as well using the same pattern.
> 
> I'm asking to avoid ~70 almost-identical review requests.

Apart from Elvis (here) and Volker (on IRC), any other ack? (looking
especially for dfaure :)

Ciao
-- 
Luigi


Re: Bulk replacement of projects.kde.org on Frameworks modules

2019-11-11 Thread Luigi Toscano
Elvis Angelaccio ha scritto:
> 
> 
> On 11/11/19 22:52, Luigi Toscano wrote:
>> Hi,
>> basically all Frameworks components reference the ECM website
>> using the old projects.kde.org URL, which is long gone and
>> it is just a (partial) redirect.
>>
>> See for example:
>>
>> set_package_properties(ECM PROPERTIES TYPE REQUIRED
>> DESCRIPTION "Extra CMake Modules."
>> URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;)
>>
>> Can I go around a bulk-replace all the URLs with
>> https://commits.kde.org/extra-cmake-modules, so that it would look like:
>>
>> set_package_properties(ECM PROPERTIES TYPE REQUIRED
>> DESCRIPTION "Extra CMake Modules."
>> URL "https://commits.kde.org/extra-cmake-modules;)
> 
> +1
> 
> Using commits.kde.org like this feels weird though (i.e. using it
> without a commit hash).

commits.kde.org is the general redirector, and it will continue to work even
after the switch to gitlab. We have a bit of documentation here:
https://techbase.kde.org/Projects/Documentation/KDE_(health_table)#Links_to_kde_repos

Ciao
-- 
Luigi


Bulk replacement of projects.kde.org on Frameworks modules

2019-11-11 Thread Luigi Toscano
Hi,
basically all Frameworks components reference the ECM website
using the old projects.kde.org URL, which is long gone and
it is just a (partial) redirect.

See for example:

set_package_properties(ECM PROPERTIES TYPE REQUIRED
DESCRIPTION "Extra CMake Modules."
URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;)

Can I go around a bulk-replace all the URLs with
https://commits.kde.org/extra-cmake-modules, so that it would look like:

set_package_properties(ECM PROPERTIES TYPE REQUIRED
DESCRIPTION "Extra CMake Modules."
URL "https://commits.kde.org/extra-cmake-modules;)

There are few additional URLs which use the old website and I would replace
them as well using the same pattern.

I'm asking to avoid ~70 almost-identical review requests.

Ciao
-- 
Luigi


D25225: Symlink microphone to audio-input-microphone on all sizes

2019-11-10 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes.
Closed by commit R267:99f892b26058: Symlink microphone to 
audio-input-microphone on all sizes (authored by ltoscano).

REPOSITORY
  R267 Oxygen Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25225?vs=69492=69525

REVISION DETAIL
  https://phabricator.kde.org/D25225

AFFECTED FILES
  128x128/devices/microphone.png
  48x48/devices/microphone.png
  64x64/devices/microphone.png

To: ltoscano, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25225: Symlink microphone to audio-input-microphone on all sizes

2019-11-08 Thread Luigi Toscano
ltoscano created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ltoscano requested review of this revision.

REVISION SUMMARY
  Right now microphone.png (which is a fall-back for icons like
  microphone-sensitivity-{muted,low,medium,high}) exists
  as a symbolic link to audio-input-microphone.png for small
  icon sizes (16x16, 22x22, 32x32) only.
  
  There is no reason to not have the symlink for all sizes.
  
  As a side effect, the icon is used as OSD for the microphone
  keyboard button and having bigger sizes makes it non-blurry.
  
  BUG: 398160

TEST PLAN
  The microphone OSD is no more blurry.

REPOSITORY
  R267 Oxygen Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25225

AFFECTED FILES
  128x128/devices/microphone.png
  48x48/devices/microphone.png
  64x64/devices/microphone.png

To: ltoscano
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


Re: Quick Charts in KDE Review

2019-10-22 Thread Luigi Toscano
Jonathan Riddell ha scritto:
> There's a file called LICENSE which contains a copy of the LGPL 2.1
> 
> But all the files with an explicit licence seem to be GPL 2+3+KDEeV
> 
> Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove
> LICENSE and put a copy of the GPL 2 called COPYING which is our normal 
> practice.
> 

Also, if the goal is to make it part of Frameworks, it can't be GPL (but LGPL
or less restrictive licenses).

https://community.kde.org/Policies/Licensing_Policy

-- 
Luigi


D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-15 Thread Luigi Toscano
ltoscano added a comment.


  In D24477#547779 , @ndavis wrote:
  
  > For some reason, Arc made me the committer and the author instead of just 
the committer.
  
  
  Maybe because patches sent through the phabricator web interface have no 
authorship information. Please revert, apply the same commit again but amend it 
with the proper authorship information and then commit again.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24477

To: masonm, #vdg, ndavis
Cc: ltoscano, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Luigi Toscano
ltoscano added a comment.


  I wonder how to untangle this dependency, because a change in Frameworks 
can't (shouldn't?) depend on a change in a consumer (yes, same issues as toys).

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Luigi Toscano
ltoscano added a comment.


  Can you please at least remove the steam example from the commit message, as 
it is not relevant (it is a downstream change) and remove the reference to the 
bug?
  Does it also mean that kf5-toys.directory is not used anymore? (not sure 
whether it can't be removed anyway for compatibility?)

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24384

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns


D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Luigi Toscano
ltoscano added a comment.


  In D7446#526741 , @ngraham wrote:
  
  > And maybe we should also discuss moving kio-extras to the frameworks 
release cycle. It's not an app so I'm not sure it makes sense to have it 
distributed with KDE Applications right now.
  
  
  It's probably a matter of dependency and guarantee of stability for all the 
librraries included, which may not be trivial
  (I don't want to reopen old discussions right now, but the bundle also ships 
several libraries, despite the name; so the name itself shouldn't be a blocker 
for keeping kio-extras as part of KDE Applications.)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov


D23730: Add new protocol for 7z archives

2019-09-05 Thread Luigi Toscano
ltoscano added a comment.


  Does it work when the older KIO is installed?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23730

To: nhiga, meven
Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov


Re: Proposing Quick Charts as a new framework

2019-09-02 Thread Luigi Toscano
Arjen Hiemstra ha scritto:
> Hi,
> 
> I have been working on a library the past few months that provides a QtQuick
> module for rendering gpu-accelerated charts. It currently lives in a 
> playground
> repository, here: https://invent.kde.org/kde/kf5quickcharts . I would like for
> this library to be included as a Tier 1 Framework.

Hi,
I've noticed that some time ago (I didn't enable the translations yet, but
maybe it's not needed). I have a question and a comment:

- what is the difference between this one and the existing kqtquickcharts,
part of the KDE Applications bundle, from the KDEEdu project? At least their
description overlaps. Is there any transition path? Having two duplicate
libraries with the exact same goal may not be the best scenario.
- I don't think that "5" should be part of the name; in two years from now we
may have a Frameworks 6, and having a kf5quickchart as part of it may be
confusing.

Ciao
-- 
Luigi


D23465: Add new non standard mime type for ROOT cern files

2019-08-26 Thread Luigi Toscano
ltoscano added a comment.


  The idea is good, but it should be proposed to shared-mime-info repository 
instead. As far as I remember from the previous discussions, this file is meant 
to contain a limited number of entities and possibiy disappear over time.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23465

To: alexde, #vdg
Cc: ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-26 Thread Luigi Toscano
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  (sorry, time off) thanks!

REPOSITORY
  R238 KDocTools

BRANCH
  kdeinstalldirs

REVISION DETAIL
  https://phabricator.kde.org/D23229

To: asturmlechner, #frameworks, ltoscano
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D23119: Fix dates being on the wrong locale when setting an application language individually

2019-08-20 Thread Luigi Toscano
ltoscano added inline comments.

INLINE COMMENTS

> asemke wrote in kxmlgui_unittest.cpp:1089
> does this test work? The name of the month is "январь" in russian, not 
> "января".

Declensions: 
https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: ltoscano, apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, 
ngraham, bruns


D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-17 Thread Luigi Toscano
ltoscano added a comment.


  I can't check now, but I think the case were "the deprecated variable is set, 
but the new one is not, then the old one is used" should be  considered.

INLINE COMMENTS

> KF5DocToolsMacros.cmake:236
> +if (NOT KDE_INSTALL_MANDIR)
> +set(KDE_INSTALL_MANDIR share/man)
>  endif()

I wonder if we should consider the deprecated variable as well. It's 
deprecated, but if it has been set, and the new one is not set, the old one 
should be probably used.

> KF5DocToolsMacros.cmake:239
> +if (NOT KDE_INSTALL_DOCBUNDLEDIR)
> +set(KDE_INSTALL_DOCBUNDLEDIR share/doc/HTML)
>  endif()

Aee above.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D23229

To: asturmlechner, #frameworks
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna


D22715: Save and load page margins

2019-07-27 Thread Luigi Toscano
ltoscano added subscribers: aacid, ltoscano.
ltoscano added a comment.


  I think @aacid recently (well, some time ago) worked on the Qt printing code 
and he may at least have an idea of the status of this.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22715

To: hoffmannrobert, cullmann
Cc: ltoscano, aacid, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, 
univerz, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, sars


D22698: Support passing target to ki18n_wrap_ui macro

2019-07-26 Thread Luigi Toscano
ltoscano added a comment.


  In D22698#502791 , @daandemeyer 
wrote:
  
  > @alexmerry I think I added the wrong reviewer for this. I noticed your name 
in the git blame of `k18n_wrap_ui`, perhaps you know who I should add as a 
reviewer for ki18n revisions?
  
  
  The maintainer is already marked as reviewer. Please also note that the 
reviewer is not really important: all revision of Frameworks modules are copied 
to the kde-frameworks-devel@ list, which is a subscriber, and which is read by 
people interested in the development of Frameworks.

REVISION DETAIL
  https://phabricator.kde.org/D22698

To: daandemeyer, ilic
Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, ngraham, bruns


D22689: Replace QString::null with QString

2019-07-24 Thread Luigi Toscano
ltoscano added a comment.


  I can see that several frameworks can't build anymore on build.kde.org after 
the change.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22689

To: aacid, apol, nicolasfella
Cc: ltoscano, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns


D22659: Fix bracket

2019-07-22 Thread Luigi Toscano
ltoscano added a comment.


  This should be backported to Applications/19.08.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22659

To: vonreth, brute4s99
Cc: ltoscano, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, 
sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov


D9033: man ioslave: asserts trying to display pam(8)

2019-07-18 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:87215e7ea765: man ioslave: asserts trying to display 
pam(8) (authored by marten, committed by ltoscano).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9033?vs=23118=61979

REVISION DETAIL
  https://phabricator.kde.org/D9033

AFFECTED FILES
  man/kio_man.cpp
  man/man2html.cpp

To: marten, #plasma, kfm-devel, mkoller
Cc: ltoscano, kde-frameworks-devel, apol, plasma-devel, aprcela, fprice, 
LeGast00n, sbergeron, jraleigh, gennad, fbampaloukas, alexde, GB_2, feverfew, 
ragreen, Pitel, meven, michaelh, spoorun, navarromorales, ZrenBot, firef, 
ngraham, andrebarros, bruns, skadinna, himcesjf, emmanuelp, lesliezhai, 
ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, mart


D7820: man ioslave: spurious numbers included in clang(1) man page

2019-07-10 Thread Luigi Toscano
ltoscano added a comment.


  Apologize for the long delay - I can't reproduce the issue with the current 
master. The mentioned structure of the clang man page seems to be the same 
(clang 8).
  
  Adding @mkoller too.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

To: marten, #plasma, kfm-devel, mkoller
Cc: ltoscano, kde-frameworks-devel, plasma-devel, fprice, LeGast00n, jraleigh, 
fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, spoorun, 
navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, himcesjf, 
emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, 
apol, mart


D7820: man ioslave: spurious numbers included in clang(1) man page

2019-07-10 Thread Luigi Toscano
ltoscano added a reviewer: mkoller.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

To: marten, #plasma, kfm-devel, mkoller
Cc: kde-frameworks-devel, plasma-devel, fprice, LeGast00n, jraleigh, 
fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, spoorun, 
navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, himcesjf, 
emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, 
apol, mart


D9033: man ioslave: asserts trying to display pam(8)

2019-07-10 Thread Luigi Toscano
ltoscano added a comment.


  Apologize for the long delay. It looks like that the fix still applies and 
works according the comment.
  
  I added @mkoller, the historical maintainer of kio-man, who can probably 
validate the change better than me, but let's try to push this for the upcoming 
KDE Applications 19.04.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D9033

To: marten, #plasma, kfm-devel, mkoller
Cc: ltoscano, kde-frameworks-devel, apol, plasma-devel, fprice, LeGast00n, 
jraleigh, gennad, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, 
michaelh, spoorun, navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, 
skadinna, himcesjf, emmanuelp, lesliezhai, ali-mohamed, mikesomov, 
jensreuterberg, abetts, sebas, mart


D9033: man ioslave: asserts trying to display pam(8)

2019-07-10 Thread Luigi Toscano
ltoscano added a reviewer: mkoller.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D9033

To: marten, #plasma, kfm-devel, mkoller
Cc: kde-frameworks-devel, apol, plasma-devel, fprice, LeGast00n, jraleigh, 
gennad, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, 
spoorun, navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, skadinna, 
himcesjf, emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, 
abetts, sebas, mart


D22107: Add MediaTransport API

2019-06-27 Thread Luigi Toscano
ltoscano added inline comments.

INLINE COMMENTS

> mweichselbaumer wrote in a2dp-codecs.h:33
> Yes, this has also been fixed by bluez as of 2018-12-28.

Will it work with older versions of bluez?

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22107

To: mweichselbaumer, drosca
Cc: ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D17595: Upstream Dolphin's file rename dialog

2019-05-10 Thread Luigi Toscano
ltoscano added inline comments.

INLINE COMMENTS

> meven wrote in renamefiledialog.h:5
> We can email Peter Penz to ask about doing a license change.
> 
> I wish we would ask its contributors to allow the kde foundation to update 
> code distribution license on their behalf, provided the license stays 
> FOSS/mostly compatible and they keep their copyright.
> Some projects do so, but I can't remember which ones.

We do, but people sign it on a vuluntary basis:

https://ev.kde.org/rules/fla.php

Also, there is this which pre-dates the FLA but it is useful too (and still in 
use):

https://cgit.kde.org/kde-dev-scripts.git/tree/relicensecheck.pl

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: ngraham, #frameworks, #dolphin, broulik
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, michaelh, 
ngraham


D19812: Add a web page to view and compare icons of different sizes

2019-04-26 Thread Luigi Toscano
ltoscano added a comment.


  The documentation website of krita is a different type of repository. This 
project is going to be distributed and compiled by the distributions, and many 
of them will have to patch out the minified javascript and replace it with a 
dependency on a proper packaged version. The idea is that the minified 
(obscured) version is not the preferred form of distribution (not the "source 
code"), more or less. So special care should be taken here.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: ltoscano, filipf, trickyricky26, GB_2, pino, bcooksley, ngraham, 
kde-frameworks-devel, michaelh, bruns


D20806: Add HiDPI support

2019-04-25 Thread Luigi Toscano
ltoscano added a comment.


  The KSane library is not a framework.

REPOSITORY
  R382 KSane Library

REVISION DETAIL
  https://phabricator.kde.org/D20806

To: volkov, sars, #frameworks
Cc: ltoscano, ngraham


Re: MacOS Builds - KArchive & KDocTools

2019-04-24 Thread Luigi Toscano

Ben Cooksley ha scritto:

Hi all,

While getting Mac builds back on their feet this morning we've run
into a rather terminal build failure issue, centering around KArchive
and KDocTools.

The issue is struck during the build of KDocTools, when the linking of
libKF5DocTools.dylib fails with the following message:

Undefined symbols for architecture x86_64:
"KFilterDev::KFilterDev(QString const&)", referenced from:
 KDocTools::saveToCache(QString const&, QString const&) in 
xslt_kde.cpp.o
 "KCompressionDevice::open(QFlags)",
referenced from:
 KDocTools::saveToCache(QString const&, QString const&) in 
xslt_kde.cpp.o
 "KCompressionDevice::close()", referenced from:
 KDocTools::saveToCache(QString const&, QString const&) in 
xslt_kde.cpp.o
 "KCompressionDevice::~KCompressionDevice()", referenced from:
 KDocTools::saveToCache(QString const&, QString const&) in 
xslt_kde.cpp.o
   ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Anyone got any ideas?



It was reported as https://bugs.kde.org/show_bug.cgi?id=406663 less than one 
week ago, but to be honest I have no idea. Is it a new issue, or have the 
failure started recently?

The only relevant change to KFilterDev is:
https://commits.kde.org/karchive/710ffdc3c45a1c683ccca988138798f9945c26b1
The code of KDocTools has been pretty stable for a while.

Ciao
--
Luigi


D17500: Get mobipocket extractor up-to-date, but keep disabled

2019-04-11 Thread Luigi Toscano
ltoscano added a comment.


  The proposed solution to remove the loop is moving the extractor to the 
kdegraphics-mobipocket repository.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


D17500: Get mobipocket extractor up-to-date, but keep disabled

2019-04-09 Thread Luigi Toscano
ltoscano added a comment.


  So no plans for moving it to kdegraphics-mobipocket? It's a dependency loop.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


D19092: Add bison minimum version of 2.4.1 due to %code

2019-03-29 Thread Luigi Toscano
ltoscano added a comment.


  Ups, sorry! So according https://community.kde.org/Schedules/Frameworks there 
are no special provisions when the change doesn't touch translatable strings 
and the change is properly tested.

REPOSITORY
  R309 KService

BRANCH
  bison_min_version (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19092

To: hindenburg, #frameworks, winterz
Cc: pino, ltoscano, winterz, kde-frameworks-devel, michaelh, ngraham, bruns


D19092: Add bison minimum version of 2.4.1 due to %code

2019-03-29 Thread Luigi Toscano
ltoscano added a comment.


  Not on the 19.04 branch, the dependency freeze happened few weeks ago - you 
may want to ask to release-team@ for an exception if you think it's important 
there too.

REPOSITORY
  R309 KService

BRANCH
  bison_min_version (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19092

To: hindenburg, #frameworks, winterz
Cc: ltoscano, winterz, kde-frameworks-devel, michaelh, ngraham, bruns


D19696: Add blender thumbnailer

2019-03-12 Thread Luigi Toscano
ltoscano added a comment.


  In D19696#429476 , @broulik wrote:
  
  > Since this one is a bit more specific, perhaps it should indeed go into 
kdegraphics-thumbnailers, don't really mind. I think I have asked this often 
before but is kdegraphics-thumbnailers a thing that is installed out of the box 
in most distros?
  
  
  Our organizational decision shouldn't be affected by downstream consumers if 
they don't affect them in a bad way (as in this case).
  
  Distributions can surely install kdegraphics-thumbnailers as they do with 
kio-extras, if we tell them so.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks
Cc: broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov


D19696: Add blender thumbnailer

2019-03-11 Thread Luigi Toscano
ltoscano added a comment.


  I have my usual question: shouldn't this go into kdegraphics-thumbnailers? 
kio-extras shouldn't be a "dump everything which is not somewhere else".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks
Cc: ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D19557: Update design to look more similar to kde.org

2019-03-10 Thread Luigi Toscano
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Thank you! And sorry for the ping-pong.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna


D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano added a comment.


  In D19557#428619 , @ognarb wrote:
  
  > In D19557#428618 , @ltoscano 
wrote:
  >
  > > In D19557#428617 , @ognarb 
wrote:
  > >
  > > > They use the old link for the image, also the jpg version instead of 
the png. I tested with new page and old page and the result is visually the 
same.
  > >
  > >
  > > But do the existing pages use the old link for the image with the new CSS?
  >
  >
  > Yes the link to the css didn't change, only the content. So even the old 
page links to the new CSS.
  
  
  Ok, so let's back one minute, and maybe it was the case in the original 
review, despite what myself and other people suggested, what if:
  
  - the changes to the XSL files are reverted
  - top-kde.jpg is rewritten using the same size of the original, and of course 
same format. No need to add the new kde.png. You may want to add it, but same 
format, so that we can switch in KF6.
  
  This should ensure no unexpected changes if any user expect the image to be 
that size, and both newly-generated pages and the old ones will have the same 
aspect.
  
  Sorry if it was the case in the first review.
  
  The point about the commit message is still valid.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna


D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano added a comment.


  In any case, please change the commit message. When this is committed and 
rechecked in one year from now, the aspect of the linked website may not be 
relevant anymore and the images are not visible when you run git log.
  Please describe what the change is about. 
https://chris.beams.io/posts/git-commit/

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna


D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano added a comment.


  In D19557#428617 , @ognarb wrote:
  
  > They use the old link for the image, also the jpg version instead of the 
png. I tested with new page and old page and the result is visually the same.
  
  
  But do the existing pages use the old link for the image with the new CSS?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna


D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


  No, wait a minute. What happens with pages which are not regenerated?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna


D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna


D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


  Can you please not overwrite top-kde.jpg too, or at least use the same size? 
Because the change of size may be a problem for existing users (if any, but I 
consider those files as part of the public interface of KDocTools

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna


D19646: Redesign KDE Connect and bluetooth config pages

2019-03-10 Thread Luigi Toscano
ltoscano added a comment.


  Less technical note: I think that the commit message should not really about 
KDE Connect, as the change is reflected on all Purpose's users.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19646

To: nicolasfella, #vdg, apol, ngraham
Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns


D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano added a subscriber: yurchor.
ltoscano added a comment.


  On the graphical side I'm not the most qualified to talk :)
  Apart from the VDG, I'm sure that @yurchor can give some hints, as he manages 
the templates used to generate the PDFs.
  
  From the technical point of view, I wouldn't remove any of the exiting files 
right now, at least not until KF6. I'd suggest using new names, just to avoid 
the possible confusion between the old top-kde.jpg and the new top-kde.png.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna


D19335: [kdoctools] make it compile without foreach

2019-02-26 Thread Luigi Toscano
ltoscano added a comment.


  Isn't it a duplicate of D19271  ?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19335

To: mlaurent, dfaure
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna


D19224: Only report DocBookXML as found if it was actually found

2019-02-22 Thread Luigi Toscano
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Right, sorry.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19224

To: apol, #frameworks, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna


D19224: Only report DocBookXML as found if it was actually found

2019-02-22 Thread Luigi Toscano
ltoscano added a comment.


  Sorry, I forgot to save a comment.

INLINE COMMENTS

> FindDocBookXML4.cmake:88
> +else()
> +message(WARNING "${found_dir}: Could not find docbookx.dtd in 
> ${CMAKE_SYSTEM_PREFIX_PATH} with suffixes ${DTD_PATH_LIST}")
> +endif()

Isn't ${found_dir} undefined at this point?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19224

To: apol, #frameworks, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna


D19224: Only report DocBookXML as found if it was actually found

2019-02-22 Thread Luigi Toscano
ltoscano requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19224

To: apol, #frameworks, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna


D19054: Port cross-compilation support to KF5_HOST_TOOLING

2019-02-15 Thread Luigi Toscano
ltoscano added subscribers: habacker, ltoscano.
ltoscano added a comment.


  I trust @vkrause  that this complicated part works, but I need to ask 
@habacker too, as he contributed part of the cross-compiling code.
  
  If anyone else from the #windows  
project would like to comment to, that would be nice.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19054

To: vkrause
Cc: ltoscano, habacker, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna


D18883: Add PDF thumbnailer

2019-02-09 Thread Luigi Toscano
ltoscano added a comment.


  Why can't this go to kdegraphics-thumbnailer? Kio-extras shouldn't be, IMHO, 
a "drop everything which does not fit elsewhere"

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D17956: DocumentPrivate: Fix broken doc links in qCWarning

2019-01-04 Thread Luigi Toscano
ltoscano resigned from this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Fine by me regarding the change; I can't answer to the question whether the 
warning should be localized or not (maybe not), so I'm resigning from the 
review to not block it

REVISION DETAIL
  https://phabricator.kde.org/D17956

To: loh.tar, #ktexteditor, sars, dhaumann
Cc: cullmann, pino, ltoscano, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann


D17956: DocumentPrivate: Fix broken doc links in qCWarning

2019-01-04 Thread Luigi Toscano
ltoscano requested changes to this revision.
ltoscano added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> katedocument.cpp:4592
>  "Please replace with 
> 'remove-trailing-spaces modified;', see "
> -
> "http://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
> +
> "https://docs.kde.org/stable5/en/applications/katepart/config-variables.html#variable-remove-trailing-spaces;);
>  m_config->setRemoveSpaces(state ? 1 : 0);

Please use:

https://docs.kde.org/index.php?application=katepart=stable5=config-variables.html#variable-remove-trailing-spaces

> katedocument.cpp:4597
>  "Please replace with 
> 'remove-trailing-spaces all;', see "
> -
> "http://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
> +
> "https://docs.kde.org/stable5/en/applications/katepart/config-variables.html#variable-remove-trailing-spaces;);
>  m_config->setRemoveSpaces(state ? 2 : 0);

See above

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17956

To: loh.tar, #ktexteditor, sars, ltoscano
Cc: ltoscano, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-18 Thread Luigi Toscano
ltoscano added a comment.


  The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is 
exported), and in general it should not exist in the same build root of its 
kdelibs 4.x counterpart.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D17649

To: habacker
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, 
skadinna


D17620: Make setHelp() public

2018-12-16 Thread Luigi Toscano
ltoscano added a comment.


  There may be another way: add a new public method which wraps the protected 
one, and when moving to KF6 a) make setHelp public and b) deprecate the new 
wrapper. I think - suggestions needed

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D17620

To: yurchor, #frameworks
Cc: ltoscano, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns


D17500: Restore mobipocket extractor

2018-12-14 Thread Luigi Toscano
ltoscano added a comment.


  In D17500#376854 , @astippich 
wrote:
  
  > In D17500#376221 , @aacid wrote:
  >
  > > In D17500#375753 , @astippich 
wrote:
  > >
  > > > Oh, thanks for the hint, didn't know that. That makes it a lot more 
complicated than a straight port :(
  > > >  Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail 
extractor actually be part of kio-extras? Seems quite KIO-specific, and a quick 
look at lxr didn't reveal any usages of the thumbnailer.
  > >
  > >
  > > Why would it be part of kio-extras? the beauty of plugins is that they 
can live wherever, no?
  >
  >
  > My thinking here was that a lot of other thumbnailers are located in 
kio-extras. Moving the thumbnailer there too would lift the KIO dependency and 
make qmobipocket easier to deploy and to be used by others.
  
  
  Just a note about this: kio-extras was not meant to be a collector of all 
possible kios. It's becaming as such, but if this continues we may end up 
revisiting it and splitting it.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams


D14998: Add AppImage thumbnailer

2018-12-06 Thread Luigi Toscano
ltoscano added a comment.


  In D14998#372293 , @probono wrote:
  
  > Can it be included/installed in KDE neon?
  
  
  You should ask on Neon request channels.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14998

To: broulik, #plasma, #vdg, TheAssassin, anthonyfieroni
Cc: ltoscano, kde-frameworks-devel, kfm-devel, probono, michaeltunnell, 
ngraham, abetts, anthonyfieroni, alexde, sourabhboss, feverfew, shubham, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov


D17079: Provide a qqc2/kirigami-based about page

2018-11-22 Thread Luigi Toscano
ltoscano added a comment.


  In D17079#364157 , @mart wrote:
  
  > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  
  
  kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


D17079: Provide a qqc2/kirigami-based about page

2018-11-21 Thread Luigi Toscano
ltoscano added a comment.


  That's a great idea! Would it be possible:
  
  - to also (optionally) support the translators' information, like in the 
current about box? (probably in a future patch, but maybe some groundwork is 
needed here)
  - to move this about page to some common kirigami-addons library?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16751: Various grammar and capitalization fixes for UI consistency

2018-11-15 Thread Luigi Toscano
ltoscano added a comment.


  Please see the comments in D16749  and 
D16750 , many of them apply also here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16751

To: snoordhuis, #vdg, #localization
Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns


D16395: Update the "About KDE" text

2018-10-24 Thread Luigi Toscano
ltoscano added a comment.


  
  
  In D16395#347938 , @rizzitello 
wrote:
  
  > Why does this dialog not say anything about the version of KDE.
  
  
  There is *no* version of KDE. KDE is only the community. It's clearly stated 
in that message.
  
  > I think here the KF5 version and maybe the Qt Version should be shown here. 
I always found it kinda odd that the "About Application" dialog contains this 
and not the About KDE dialog.
  
  That's the right place where they belong: information about the application 
and its dependencies.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications
Cc: rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh, 
ngraham, bruns


D16395: Update the "About KDE" text

2018-10-24 Thread Luigi Toscano
ltoscano added a comment.


  I'd say that the respecting the string freeze this time makes sense, as we 
need a bit more time to discuss this. Maybe the promo team can help too, as 
this is an important message.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications
Cc: ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh, ngraham, bruns


D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-21 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes.
Closed by commit R238:1caa28ea5614: Use specified Perl interpreter instead of 
relying on PATH (authored by zrax, committed by ltoscano).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15927?vs=42808=44024

REVISION DETAIL
  https://phabricator.kde.org/D15927

AFFECTED FILES
  cmake/uriencode.cmake
  src/CMakeLists.txt

To: zrax, ltoscano
Cc: ltoscano, vonreth, kde-doc-english, kde-frameworks-devel, michaelh, 
ngraham, bruns, skadinna


D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-04 Thread Luigi Toscano
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Uhm, I guess than this can go in then.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15927

To: zrax, ltoscano
Cc: ltoscano, vonreth, kde-doc-english, kde-frameworks-devel, michaelh, 
ngraham, bruns, skadinna


D15795: Fix warnings about deprecated install dirs

2018-09-27 Thread Luigi Toscano
ltoscano added inline comments.

INLINE COMMENTS

> KDEInstallDirs.cmake:564
>  "documentation bundles generated using kdoctools"
> -HTML_INSTALL_DIR)
> +KDE_INSTALL_DOCBUNDLEDIR)
>  _define_relative(KCFGDIR DATAROOTDIR "config.kcfg"

I'm going to comment only on this, but the others (most, if not all) are the 
same. If you check the definition of _define_relative, this parameter is:

oldstylename (optional): the old-style name of the variable
===

So this command is exactly defining the old variable in addition to the new one.
We can't remove the definition of the old variables until they are in use, and 
for sure not during the lifetime of Frameworks 5.x.

Unless of course I misunderstood the code...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15795

To: dinoh, apol, bruns, dfaure
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D15718: Do not index the path if the path has no execute permissions.

2018-09-24 Thread Luigi Toscano
ltoscano requested changes to this revision.
ltoscano added a comment.


  I agree with all the objections raised so far, and I'm not sure about the 
rationale of this change. I'd like to add one point:
  
  In D15718#330844 , @smithjd wrote:
  
  > In D15718#330836 , @ngraham 
wrote:
  >
  > > Wouldn't this have the effect of un-indexing most files? A quick check of 
my documents (text, word processing, excel, etc) reveals that none of them have 
the execute bit set. As-is, I think this would render Baloo mostly useless.
  >
  >
  > A default mask of 0002 or more permissive looks fairly common across 
distros, and is permissive enough to index files by default.
  
  
  No, because even if the default umask is 002, or 022, POSIX says that the 
default permissions of a file on creation are going to be 0666, not 0777:
  
  
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap01.html#tag_17_01_01_04
  
  So not only file downloaded by browsers won't have the executable bit, but 
*every* file on the system. Let's leave the executable bit on files to scripts 
and other real programs.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15718

To: smithjd, ngraham, #baloo, ltoscano
Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams


Re: Quality of Frameworks announcements

2018-09-11 Thread Luigi Toscano
On Sunday, 9 September 2018 16:07:43 CEST Yuri Chornoivan wrote:
> Hi,
> 
> I think that several latest Frameworks announcements are not of even medium
> quality. It is hard to translate them because the commit messages list looks
> like some kind of puzzle. 

This is a good point, but the i18n list is not the right place. Redirecting to 
kde-frameworks-devel.

> Examples:
> 
> no need to new/delete hash on each doHighlight, clearing it is good enough
> 
> ensure we can handle invalid attribute indices that can happen as left overs
> after HL switch for a document
> 
> let smart pointer handle deletion of objects, less manual stuff to do
> 
> remove map to lookup additional hl properties
> 
> KTextEditor uses the KSyntaxHighlighting framework for all
> 
> use character encodings as provided by the definitions
> 
> non-bold text no longer renders with font weight thin but (bug 393861)
> 
> footer separator line visually lighter
> 
> make can break bit more like in word code
> 
> no linked list without any reason
> 
> cleanup properties init
> 
> etc.
> 
> There are meaningless to the end-user messages:
> 
> Merge branch 'master' into syntax-highlighting
> 
> Merge branch 'master' into syntax-highlighting (again)
> 
> There are also some workflow things (commit -> revert -> commit again,
> commit (5.49) -> revert (5.50)).
> 
> If announce is some kind of advertisement it can be some kind of meaningful.
> 
> Is it possible to ask developers/release team/marketing team to give us,
> translators, the material that can be retranslated to community on the
> quality that KDE deserves?
> 
> Thanks in advance for your help.
> 
> Best regards,
> Yuri

-- 
Luigi





Re: KDE apps have missing icons when not on Breeze

2018-08-29 Thread Luigi Toscano

Albert Astals Cid ha scritto:

El dimecres, 29 d’agost de 2018, a les 21:13:03 CEST, Albert Vaca va escriure:

Do you think it's a good idea to ask packagers to make KIconThemes depend
on Breeze icons?


I think depend is probably "too strong", but recommend for sure.



Did you also consider to find a way to add icons to the Adwaita theme? That 
would cover most of the use cases. Not sure how much their developer would 
like to add more icons, but still...


Ciao
--
Luigi


D15131: add acronym ASCII to general.entities

2018-08-28 Thread Luigi Toscano
ltoscano accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15131

To: lueck, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna


D15105: add JSON to general.entities

2018-08-27 Thread Luigi Toscano
ltoscano accepted this revision as: ltoscano.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15105

To: lueck, #documentation, yurchor, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna


D14896: Fix bzip main page

2018-08-17 Thread Luigi Toscano
ltoscano closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14896

To: ltoscano, svuorela
Cc: svuorela, kde-frameworks-devel, michaelh, ngraham, bruns


D14896: Fix bzip main page

2018-08-17 Thread Luigi Toscano
ltoscano created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ltoscano requested review of this revision.

REVISION SUMMARY
  The known domain is lost:
  https://lwn.net/Articles/762264/
  https://lwn.net/Articles/762340/

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14896

AFFECTED FILES
  CMakeLists.txt

To: ltoscano
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14817: Convert manual install test to an autotest

2018-08-14 Thread Luigi Toscano
ltoscano added a comment.


  This worked with Qt 5.9 on the CI and locally with 5.10 too, but the CI seems 
to be unhappy for openSUSE/Qt 5.10 and Windows/Qt 5.10 (it works on openSUSE/Qt 
5.9 and FreeBSD/Qt 5.10):
  
  - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/46/
  - 
https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/35/
  - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20FreeBSDQt5.10/
  - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.9/32/
  
  Do the logs ring any bell about the possible reason?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D14817

To: habacker, ltoscano
Cc: kde-frameworks-devel, ltoscano, kde-doc-english, michaelh, ngraham, bruns, 
skadinna


D14643: Bump the minimum logging category to Warning

2018-08-06 Thread Luigi Toscano
ltoscano abandoned this revision.
ltoscano added a comment.


  Thanks for confirming. I will work on setting the default to Info for 
Frameworks components when it's not the case already, and tuning the debug 
messages.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14643

To: ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns


D14643: Bump the minimum logging category to Warning

2018-08-06 Thread Luigi Toscano
ltoscano added a comment.


  I was under the impression that we were generally moving towards less chatty 
components by default, which included having Warning as minimum default level.
  
  Unfortunately I don't remember anymore how I've got this idea, but I remember 
some patches setting the default level to Warning.
  Is there then an official policy for Frameworks? And outside Frameworks?
  
  It is true that Debian dropped the default qtlogging.ini file, but the first 
feedback from Fedora, for example, showed a strong desire of non-chatty at all.
  If you think that this can be achieved by reevaluating all the current qCInfo 
to fit them to qCDebug, then I will write more specific patches (in this case, 
for example, kf5.kio.favicons is too chatty; another case is 
kf5.kservice.sycoca).
  
  But an official policy would be needed at least for Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14643

To: ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns


D14572: Check the build directory for po/ as well

2018-08-06 Thread Luigi Toscano
ltoscano accepted this revision.
ltoscano added a comment.


  It was basically already approved, and it already made sense. The only 
requested change (a comment) was applied.

REPOSITORY
  R249 KI18n

BRANCH
  arcpatch-D14572

REVISION DETAIL
  https://phabricator.kde.org/D14572

To: apol, #frameworks, ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns


D14643: Bump the minimum logging category to Warning

2018-08-05 Thread Luigi Toscano
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ltoscano requested review of this revision.

REVISION SUMMARY
  Also, break the long statements when needed, trying to follow
  the style of the rest of the file.

TEST PLAN
  It compiles.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14643

AFFECTED FILES
  src/core/CMakeLists.txt
  src/gui/CMakeLists.txt
  src/ioslaves/remote/CMakeLists.txt
  src/ioslaves/trash/CMakeLists.txt
  src/ioslaves/trash/tests/CMakeLists.txt
  src/kioexec/CMakeLists.txt
  src/widgets/CMakeLists.txt

To: ltoscano
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14528: Android: Make sure we're looking for .mo files in the right path

2018-08-01 Thread Luigi Toscano
ltoscano added a comment.


  Is this a possible Qt bug where the output of QStandardPaths should be tuned 
on Android?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D14528

To: apol, #frameworks, ilic, ckertesz
Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns


D9446: WIP: Allow to autogenerate and install categories file

2018-06-28 Thread Luigi Toscano
ltoscano added a comment.


  In D9446#284288 , @cgiboudeaux 
wrote:
  
  >
  
  
  
  
  > There are several issues that need fixes:
  > 
  > - Installation dir for categories, /etc/xdg on linux has always been wrong. 
categories are not config files
  
  That's something that should be addressed separately and it requires support 
in kdebugsettings for few cycles before switching, otherwise people will not be 
able to use the new categories file generated. At this point it could be 
probably a TODO KF6...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9446

To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, habacker, michaelh, 
ngraham, bruns


  1   2   3   4   5   6   7   >