D27268: Fixed handling of relative paths by KUrlNavigator

mdlubakowski added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27268 To: mdlubakowski, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27268: Fixed handling of relative paths by KUrlNavigator

mdlubakowski created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mdlubakowski requested review of this revision. REVISION SUMMARY Typing a relative path (one that doesn't start with / or protocol) into KUrlNavigator widget currently

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski added a comment. In D23989#532692 , @ngraham wrote: > I wonder if this should maybe be backported to 5.62, since it represents a regression introduced in that release. Thoughts? I would say yes, since I imagine this may be

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski marked 3 inline comments as done. mdlubakowski added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:390 > Can you split this into two "else if" conditions? It will be more readable > (both the condition, and the comment). This only duplicates a trivial "canRun > =

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski updated this revision to Diff 66226. mdlubakowski added a comment. - Incorporated feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23989?vs=66215=66226 BRANCH exe-file-handling REVISION DETAIL https://phabricator.kde.org/D23989

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski added a comment. In D22510#532295 , @broulik wrote: > This patch breaks running Windows EXE files. Clicking them does nothing now. Right clicking and explicitly choosing "Run with wine program launcher" works. Indeed it

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski retitled this revision from "Fixed DOS/Windows executable handling by KRun" to "Fixed interaction with DOS/Windows executables in KRun::runUrl". mdlubakowski edited the summary of this revision. mdlubakowski added reviewers: dfaure, Frameworks. REPOSITORY R241 KIO REVISION DETAIL

D23989: Fixed DOS/Windows executable handling by KRun

mdlubakowski created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mdlubakowski requested review of this revision. REPOSITORY R241 KIO BRANCH exe-file-handling REVISION DETAIL https://phabricator.kde.org/D23989 AFFECTED FILES

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks, dfaure, cfeck, pino Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked an inline comment as done. mdlubakowski added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:147 > Hmm, because isExecutable(mimetype) also returns true for desktop files. > > So this would change behaviour for users of this API. (see why we try to > limit

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 65302. mdlubakowski added a comment. - Reverted change to KRun::isExecutableFile REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=65265=65302 BRANCH arcpatch-D22510 REVISION DETAIL

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks, dfaure, cfeck, pino Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked 6 inline comments as done. mdlubakowski added a comment. Fixed according to comments, hope I haven't forget anything this time. Sorry for the API change, I thought it may make sense to add it like this since `isExecutableFile` and `isExecutable` are a part of it. I

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 65265. mdlubakowski added a comment. - Incorporated feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=65260=65265 BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski added a comment. Thanks for your guidance! I don't have developer account, so can't land myself. Should I fix those two other comments before landing? REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski,

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 65260. mdlubakowski added a comment. - Removed leftover kfileitem.h include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=65258=65260 BRANCH arcpatch-D22510 REVISION DETAIL

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked 6 inline comments as done. mdlubakowski added a comment. Reversed my changes to `isExecutableFile` method as per D23660 , since my changes aren't needed anymore. Also added `hasExecuteBit` method. REPOSITORY R241 KIO REVISION DETAIL

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 65258. mdlubakowski added a comment. - Reverse change to KRun::isExeutableFile - Incorporated feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=64930=65258 BRANCH arcpatch-D22510 REVISION DETAIL

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks, dfaure, cfeck, pino Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked 4 inline comments as done. mdlubakowski added a comment. First of all, sorry for the mess I made here with Arcanist. My SSD died recently and I lost original repository with those changes, so I used `arc patch` to pull it back, updated the code and pushed here with `arc

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 64930. mdlubakowski added a comment. Incorporated feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=61918=64930 BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 AFFECTED

D23559: Incorporated feedback

mdlubakowski created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mdlubakowski requested review of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D23559 AFFECTED FILES

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski added a comment. In D22510#496804 , @ngraham wrote: > If the use case you're targeting is specifically AppImage files, it might make sense to coordinate with upstream, where they're working on ways to improve this:

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski edited the summary of this revision. mdlubakowski added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks Cc: ngraham, probono, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 61918. mdlubakowski added a comment. One of the commits did not upload REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=61917=61918 BRANCH make-executable-prompt REVISION DETAIL

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mdlubakowski requested review of this revision. REVISION SUMMARY Currently if you try to run executable file for which you don't have execute permission, KRun will either