D29390: Respect QIcon::fallbackSearchpaths()

2020-06-13 Thread Marco Martin
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  go for it :)

REPOSITORY
  R302 KIconThemes

BRANCH
  fallback

REVISION DETAIL
  https://phabricator.kde.org/D29390

To: nicolasfella, #plasma, #frameworks, mart
Cc: mart, kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D27223: add kirigami-gallery icon

2020-06-08 Thread Marco Martin
mart added a comment.


  can we fix this and go ahead?
  @mbruchert can you still work on it? want to put it on invent?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns


Re: Recent breakage in kwallet

2020-05-26 Thread Marco Martin
would the recent patch
https://invent.kde.org/frameworks/kwallet/-/merge_requests/1
fix anything?

On Sat, May 16, 2020 at 10:40 AM David Faure  wrote:
>
> On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote:
> > Hi all,
> > Recently, the package of KWallet framework for neon (devel unstable,
> > package built out of current master state) seems to be broken: kwallet
> > now can't open anymore wallets previously created (it works if the
> > local kwallet data is deleted and recreated)
> > the weird thing is that it seems that with a manual build it works instead.
> > The only kinda suspicious commit is
> > 850219f83e7d746 fix compilation with -Werror=undef
> > which seems to fix.. big endian for everyone?
>
> It was supposed to only fix compiler warnings without changing behaviour at
> all.
>
> #if Q_BYTE_ORDER == Q_BIG_ENDIAN
> when neither is defined, evaluates to #if 0 == 0  (and warns)
>
> I defined both to 1, for the same result, but so that -Wundef doesn't warn.
>
> > still no idea why is broken only the distro-built package
>
> Any neon-specific patches to kwallet?
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>


D29232: Introduce the Header color set

2020-05-20 Thread Marco Martin
mart closed this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack, ndavis
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns


D29232: Introduce the Header color set

2020-05-20 Thread Marco Martin
mart marked 9 inline comments as done.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns


D29232: Introduce the Header color set

2020-05-20 Thread Marco Martin
mart retitled this revision from "[WIP][RFC]Introduce the Header color set" to 
"Introduce the Header color set".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns


D29232: [WIP][RFC]Introduce the Header color set

2020-05-20 Thread Marco Martin
mart updated this revision to Diff 83090.
mart added a comment.


  - update to new colors

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29232?vs=81363=83090

BRANCH
  arcpatch-D29232

REVISION DETAIL
  https://phabricator.kde.org/D29232

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns


D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-05-19 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29463

To: Zren, #kirigami, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-19 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  create-kcmshell-openSystemSettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-15 Thread Marco Martin
mart added a comment.


  hmm, should probably check before whether systemsettings5 and kinfocenter 
exist beforehand and fallback to kcmshell if not?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


Recent breakage in kwallet

2020-05-15 Thread Marco Martin
Hi all,
Recently, the package of KWallet framework for neon (devel unstable,
package built out of current master state) seems to be broken: kwallet
now can't open anymore wallets previously created (it works if the
local kwallet data is deleted and recreated)
the weird thing is that it seems that with a manual build it works instead.
The only kinda suspicious commit is
850219f83e7d746 fix compilation with -Werror=undef
which seems to fix.. big endian for everyone?
still no idea why is broken only the distro-built package

-- 
Marco Martin


D29527: Add MapProxySource

2020-05-08 Thread Marco Martin
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  works perfectly :)

REPOSITORY
  R1049 KQuickCharts

BRANCH
  mapproxysource

REVISION DETAIL
  https://phabricator.kde.org/D29527

To: ahiemstra, mart
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29412: Add smallFont to Kirigami plasma style

2020-05-04 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  cblack/smallfont-kirigami (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29412

To: cblack, #kirigami, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29222: Fix update auto selection

2020-05-04 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-update-autoselection (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29222

To: leinir, #frameworks, #plasma, bugseforuns, ngraham, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28701: Add KPackage support to KNewStuffCore

2020-05-04 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Marco Martin
mart added a comment.


  indeed, a bit more documentation then go for it

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D28701: Add KPackage support to KNewStuffCore

2020-04-30 Thread Marco Martin
mart added a comment.


  +1 from me.
  does it need to go into next release or can also get in next+1?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29232: [WIP][RFC]Introduce the Header color set

2020-04-28 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> davidre wrote in kcolorscheme.cpp:271
> Because the new colors are the replacement for theses colors. I thought one 
> of those might map to this

i also added a question on the task, whether final colors are decided for it, 
they should go up here
https://phabricator.kde.org/T10201

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns


D29232: [WIP][RFC]Introduce the Header color set

2020-04-27 Thread Marco Martin
mart requested review of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29232: [WIP][RFC]Introduce the Header color set

2020-04-27 Thread Marco Martin
mart retitled this revision from "[WIP][RFC]Introduce the Tools color set" to 
"[WIP][RFC]Introduce the Header color set".
mart edited the summary of this revision.
mart edited the test plan for this revision.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29232: [WIP][RFC]Introduce the Tools color set

2020-04-27 Thread Marco Martin
mart updated this revision to Diff 81363.
mart added a comment.


  call it Header

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29232?vs=81352=81363

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29232: [WIP][RFC]Introduce the Tools color set

2020-04-27 Thread Marco Martin
mart retitled this revision from "Introduce the Tools color set" to 
"[WIP][RFC]Introduce the Tools color set".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29232: Introduce the Tools color set

2020-04-27 Thread Marco Martin
mart created this revision.
mart added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  This introduces two concepts: a new color set for Tools (or: titlebar?
  open question)
  and the possibility for a color set to have a different config group (a
  sub group) for different states (there, for inactive)
  
  the Tools area should probably also going to slowly relace the WM
  section of color themes
  
  This is needed for implement properly T10201 
, this graphical union
  between the titlebar and the toolbar.
  
  There is a problem of NColorSets that has been recently added,
  because it makes impossible to hard/impossible to
  properly add a set in a 100% abi compatible way, strictly speaking it
  should be compatible tough keeping NColorSets as the last value, is a
  kindof behavior change, though *should* be acceptable (old users would
  get the Tools value as NColorSets but everything working never the less)

TEST PLAN
  doing a color set with Tools group, the proper values get read

REPOSITORY
  R265 KConfigWidgets

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: mart, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28701: Add KPackage support to KNewStuffCore

2020-04-24 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> kpackagejob.cpp:55
> +
> +class KPackageTask : public QObject, public QRunnable
> +{

is it worth encapsulating it in a runnable? the installation of a package is 
already in a separathe thread.

> kpackagejob.cpp:97
> +});
> +loop.exec();
> +} else {

this would freeze a thread waiting another thread is done, while just using the 
job in an async wayshouldn't be much more heavy on the gui thread?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D28805: Tweak kcmcontrols docs

2020-04-20 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  tweakdocs

REVISION DETAIL
  https://phabricator.kde.org/D28805

To: nicolasfella, #frameworks, jucato, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-14 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> iconitem.cpp:40
>  
> +class IconItemSource : public QObject
> +{

does it have to be a QObject? it doesn't have properties, signals or 
invokables.. qobject is an expensive class so if you don't have to use oits 
features is better to avoid

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns


D28620: Add readmes clarifying state of plasma component versions

2020-04-06 Thread Marco Martin
mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28620

To: davidedmundson, #plasma, apol, romangg, mart
Cc: romangg, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D28606: Add iconSize property to PC2 ToolButton

2020-04-06 Thread Marco Martin
mart added a comment.


  I don't think we should put any new feature in plasmacomponents2. it will be 
removed in qt6 anyways and work should be more concentrated to a) port away 
from it altogether abd b) if the pc3 version doesn't work, put effort in fixing 
that

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma, mart
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns


D28466: Added Page element

2020-04-03 Thread Marco Martin
mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28466

To: niccolove, #plasma, ngraham, mart
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns


D28372: Added a merged look to the plasmoidheading and remove roundedborders

2020-03-29 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> niccolove wrote in PlasmoidHeading.qml:77
> I'd go with no SVG, to make sure that the theme creators will see that it's 
> broken and add a merged- look. Keep in mind that the plasmoidheading svg was 
> added barely one month ago, and no big Plasma release had it yet, so I find 
> it very hard to believe that any third party theme already has it.

agree with nicolove

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D28144: Make animation durations consistent with Kirigami values

2020-03-20 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28033: Create ExpandableListItem

2020-03-19 Thread Marco Martin
mart added a comment.


  In D28033#630450 , @ngraham wrote:
  
  >
  
  
  
  
  > shortDuration: 150ms
  >  longDuration: 250ms
  >  veryLongDuration: 500ms
  
  veryLongDuration doesn't sound too good, but if longduration goes 500ms 
probably a lot of existing things are going to look way too slow so +1 for 
compatibility

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham


D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:cebaeb4daf59: Introduce api for passive notifications 
(authored by mart).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77983=77987

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart, broulik
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D28131: listen to passiveNotificationRequested

2020-03-19 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:3fe22e067a73: listen to passiveNotificationRequested 
(authored by mart).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28131?vs=77984=77988

REVISION DETAIL
  https://phabricator.kde.org/D28131

AFFECTED FILES
  src/kcmoduleqml.cpp

To: mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28131: listen to passiveNotificationRequested

2020-03-19 Thread Marco Martin
mart updated this revision to Diff 77984.
mart added a comment.


  - const QVariant 

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28131?vs=77941=77984

BRANCH
  phab/passiveNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28131

AFFECTED FILES
  src/kcmoduleqml.cpp

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
mart updated this revision to Diff 77983.
mart added a comment.


  - const QVariant &

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77982=77983

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
mart updated this revision to Diff 77982.
mart added a comment.


  - const QVariant &

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77940=77982

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
mart added a comment.


  In D28130#630325 , @davidre wrote:
  
  > I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?
  
  
  doesn't really *need* it, but matches the existing api already existing in 
ApplicationWindow which is better to not have inconsitencies

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D28033: Create ExpandableListItem

2020-03-19 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ExpandableListItem.qml:230
> If it's multiplied by a factor it's not a "standard duration" anymore.

to me this tells more that

- default durations right now are waaay too short
- we don't take into account that for movements and resizes, the actual 
duration should be a function of the travel distance, rather than a fixed 
duration

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham


D28033: Create ExpandableListItem

2020-03-19 Thread Marco Martin
mart added a comment.


  In D28033#630073 , @ngraham wrote:
  
  > (WRT duration) What should I do then? Hardcode something? Add a new 
duration in a separate patch? The only standard durations we have are all quite 
short; neither one feels suitable for the animation I'm using here.
  
  
  to me the real problem is really the default settings for durations 
longDuration became 150ms or so, (shortduration is something so short that 
usually the animation frames just gets dropped altogether so it's pointless to 
even use it ever)
  I know this was done in the attempt of improving animations, but the end 
effect is ridiculous and makes animations actually looking worse, either 
comically fast (super fast fades are ok, item movements or resizes shouldn't 
actually be too fast, or be perceived as threatening) or no frames rendered at 
all even if there is code for it
  the original default values of 150 and 250 msecs for short and long were 
quite fine actually
  
  also, we should probably start into looking using SmoothedAnimation speed 
more rather than durations (to not fix travel time, but travel speed) (as 
animators don't support it and we would need something that reacts to global 
animations settings probably we would need our implementation of the speed 
concept)
  
  https://valhead.com/2016/05/05/how-fast-should-your-ui-animations-be/
  https://www.nngroup.com/articles/too-fast-ux/
  
https://uxdesign.cc/the-ultimate-guide-to-proper-use-of-animation-in-ux-10bd98614fa9

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham


D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin
mart added a comment.


  In D28130#630325 , @davidre wrote:
  
  > I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?
  
  
  doesn't really *need* it, but matches the existing api already existing in 
ApplicationWindow

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D28131: listen to passiveNotificationRequested

2020-03-18 Thread Marco Martin
mart edited the test plan for this revision.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28131

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28131: listen to passiveNotificationRequested

2020-03-18 Thread Marco Martin
mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  show passive notifications when the kcm asks to
  see D28130 

REPOSITORY
  R295 KCMUtils

BRANCH
  phab/passiveNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28131

AFFECTED FILES
  src/kcmoduleqml.cpp

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28130: Introduce api for passive notifications

2020-03-18 Thread Marco Martin
mart edited the summary of this revision.
mart edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28130: Introduce api for passive notifications

2020-03-18 Thread Marco Martin
mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  showPassiveNotification which mirrors
  ApplicationWindow.showPassiveNotification
  some kcms need to show a tiny non interrupting message for which neither
  a dialog nor an InlineMessage are adapt.

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28033: Create ExpandableListItem

2020-03-18 Thread Marco Martin
mart added a comment.


  to me it should be in plasma extracomponents
  
  (and with a warning in the docs that such an item should be used only in 
lists that are known to have always very few items)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham


D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

2020-03-13 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28028

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> PlasmoidHeading.qml:52
> +enabledBorders: {
> +var borders = new Array()
> +borders.push('LeftBorder')

this can be an int
and instead of borders.push('LeftBorder')
borders |= PlasmaCore.FrameSvg.LeftBorder

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Marco Martin
mart added a comment.


  In D27695#621985 , @niccolove 
wrote:
  
  > - Is code on line 51 fine? Lines are a bit long there
  
  
  yeah, is fine..
  unfortunately sunch superlong lines end up being very common in QML

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Marco Martin
mart added a comment.


  I would call the component PlasmoidHeading, to make clear it's only for use 
in plasmoids

INLINE COMMENTS

> TopArea.qml:28
> +
> +property bool flipped: false
> + 

enum Location {

  Header,
  Footer

(maybe a middle as well?)

  }

property Location location

> TopArea.qml:30
> + 
> +Layout.fillWidth: true
> +Layout.bottomMargin: flipped ? 0 : topAreaSvg.margins.top

shouldn't assume it's in a layout..
maybe keep Layout.fillwidth to keep it compact, layout margins shouldn't be 
necessary.

> TopArea.qml:37
> +
> +leftInset: -topAreaSvg.margins.left
> +rightInset: -topAreaSvg.margins.right

topAreaSvg.fixedMargins so works also when you disable them

> TopArea.qml:43
> +background: PlasmaCore.FrameSvgItem {
> +id: topAreaSvg
> +imagePath: "test"

you can check for headers:
plasmoid.location === Plasmacore.Types.TopEdge and disable the top border

same thing for footers, disabling bottom edge when 
plasmoid.location === Plasmacore.Types.BottomEdge

> TopArea.qml:44
> +id: topAreaSvg
> +imagePath: "test"
> +prefix: flipped? 'flipped' : ''

"plasmoidheading" svg name

> TopArea.qml:45
> +imagePath: "test"
> +prefix: flipped? 'flipped' : ''
> +}

prefixes as "header" and "footer"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns


D27628: Buttons: allow to scale up icons

2020-03-02 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0b89e7f3f089: Buttons: allow to scale up icons (authored 
by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27628?vs=76310=76769

REVISION DETAIL
  https://phabricator.kde.org/D27628

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/toolbutton3.qml

To: mart, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns


D27589: Try to apply the colorscheme of the current theme to QIcons

2020-03-02 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack, ngraham, mart
Cc: mart, wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns


D27628: Buttons: allow to scale up icons

2020-02-24 Thread Marco Martin
mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27628

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27628: Buttons: allow to scale up icons

2020-02-24 Thread Marco Martin
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  always scale icons unless a size is specified in the api.
  this makes icon sizing more in line with plasma components 2

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/anothersizehint

REVISION DETAIL
  https://phabricator.kde.org/D27628

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/toolbutton3.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27589: Try to apply the colorscheme of the current theme to QIcons

2020-02-24 Thread Marco Martin
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> iconitem.cpp:600
>  } else if (!m_icon.isNull()) {
> +
> KIconLoader::global()->setCustomPalette(KColorScheme::createApplicationPalette(Plasma::Theme().colorScheme()));
>  result = m_icon.pixmap(QSize(size, size) * (window() ? 
> window()->devicePixelRatio() : qApp->devicePixelRatio()));

maybe Plasma::Theme should have a qpalette getter?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack, ngraham, mart
Cc: mart, wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns


D27444: Added top area

2020-02-20 Thread Marco Martin
mart added a comment.


  i also wonder if the normal "toolbar2 element already existing can be used..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27444: Added top area

2020-02-20 Thread Marco Martin
mart added a comment.


  some considerations:
  
  - this toparea will need to "overflow" its parent for the exact distance 
needed to perfectly fuse with the background, and has to work with both dialogs 
and widgets-on-desktop (so we're kinda assuming those 2 backgrounds have the 
exact same shape) for this reason also fallback should be disabled and be used 
only in themes that directly provide it.
  - we need 2 margins here: how much we want to overflow, which i would say 
should be the actual framesvg margins, so one doesn't have to *ever* access the 
dialog instance or the applet background, and the margins we want to actually 
use as padding for its contents. we can decide either to put both as hints in 
the svg, or to use units.smallspacing as padding for the contents and be happy 
with it
  - i would provide one single svg with top and bottom areas so one can use 
something like that as a footer as well (and probably a frame that has nothing 
rounded)
  - if you have a top panel the top won't be rounded, we need a way to know 
this.. perhaps with plasmoid.location... not sure yet

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27460: fix layout size hints for button labels

2020-02-19 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ba0b637de94a: fix layout size hints for button labels 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75976=75977

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml
  tests/components/tabbar3.qml
  tests/components/toolbutton3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-19 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Button.qml:62
> I don't understand this part about constraining the width to the parent 
> height  (for all 3)
> 
> If I remove it all the tests still pass.

was an extra constraint to have buttons always square, but i added some test 
and removed this , they seem to behave always well without it

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-19 Thread Marco Martin
mart updated this revision to Diff 75976.
mart marked an inline comment as done.
mart added a comment.


  - remove extra check for squareness

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75972=75976

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml
  tests/components/tabbar3.qml
  tests/components/toolbutton3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-19 Thread Marco Martin
mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in button3.qml:90
> You didn't even run this :(
> 
> 1. icon.name not icon.source
> 2. now the comment next to it is wrong
> 3. there's a binding loop
> 
> 4. if I make a test without any text, which is what the thing you're 
> supposedly fixing was doing, I don't get an icon

sorry,
tested, fixed the problem and added new tests

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-19 Thread Marco Martin
mart updated this revision to Diff 75972.
mart marked an inline comment as done.
mart added a comment.


  - fix button display property
  - add a test for tabbar

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75927=75972

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml
  tests/components/tabbar3.qml
  tests/components/toolbutton3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-18 Thread Marco Martin
mart updated this revision to Diff 75927.
mart added a comment.


  - add an icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75922=75927

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-18 Thread Marco Martin
mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in button3.qml:90
> this doesn't contain an icon, which is the majority of what this patch is 
> about

added

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-18 Thread Marco Martin
mart added a comment.


  latest version, plasmacontrols 2 and 3 one beside the other
  F8110874: Screenshot_20200218_160904.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-18 Thread Marco Martin
mart updated this revision to Diff 75922.
mart added a comment.


  - some quirks to make it more similar to pc2

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75833=75922

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-17 Thread Marco Martin
mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27460: fix layout size hints for button labels

2020-02-17 Thread Marco Martin
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  icon sizes and label placements tested correct in  several scenarios
  
  - control.icon.width/height is used as maximum size of the icon
  - if the button is smaller icons always scale down
  - icons stay ccentered regardless of button size when there is no text

TEST PLAN
  fixes icon sizes without workarounds like D27260 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D26769: Always strip html if server does not support it

2020-02-17 Thread Marco Martin
mart accepted this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  stripcorrently

REVISION DETAIL
  https://phabricator.kde.org/D26769

To: nicolasfella, #frameworks, broulik, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27399: make sure the size hints are integer and even

2020-02-14 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:667dce502acf: make sure the size hints are integer and 
even (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27399?vs=75681=75688

REVISION DETAIL
  https://phabricator.kde.org/D27399

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27399: make sure the size hints are integer and even

2020-02-14 Thread Marco Martin
mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  for retrocompatibility with pc2 units.gridUnit * 1.6 is used
  a lot as size hint (we have to guarantee buttons and
  textfields have the same height by default for perfect
  horizontal alignment.
  tough we have make sure that size is integer and even otherwise
  we'll have a lot of internal misalignments

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/sizefixes

REVISION DETAIL
  https://phabricator.kde.org/D27399

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27396: support icon.width/height

2020-02-14 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3de1c2462eda: support icon.width/height (authored by 
mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75677=75678

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27396: support icon.width/height

2020-02-14 Thread Marco Martin
mart updated this revision to Diff 75677.
mart added a comment.


  - don't expose externally default size

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75675=75677

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27396: support icon.width/height

2020-02-14 Thread Marco Martin
mart updated this revision to Diff 75675.
mart added a comment.


  - default icon sizes

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75672=75675

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27396: support icon.width/height

2020-02-14 Thread Marco Martin
mart added a comment.


  In D27396#611425 , @broulik wrote:
  
  > Don't we want to set a default? I keep seeing people hardcoding 
`icon.width` all over the place when they used PC3 and I want that to stop
  
  
  then should be i think smallMedium size for toolbuttons (and i guess 
tabbuttons) and small for normal pushbuttons

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27396: support icon.width/height

2020-02-14 Thread Marco Martin
mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27396: support icon.width/height

2020-02-14 Thread Marco Martin
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  support the icon size hint of the control. Reinstate it in ToolButton
  and add the support for the other controls
  CCBUG:417514

TEST PLAN
  possible to control buttons icon sizes

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27200: Make the attached property a simple QObject

2020-02-10 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:68a273aef6c1: Make the attached property a simple QObject 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27200?vs=75133=75383#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27200?vs=75133=75383

REVISION DETAIL
  https://phabricator.kde.org/D27200

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml

To: mart, bshah, #plasma
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D27200: Make the attached proeprty a simple QObject

2020-02-06 Thread Marco Martin
mart edited the test plan for this revision.
mart added reviewers: bshah, Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27200

To: mart, bshah, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D27200: Make the attached proeprty a simple QObject

2020-02-06 Thread Marco Martin
mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  move all the logic in an attached property QObject
  it's a bit less heavy to create so should make things slightly better
  when this is used in delegates

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/qobject

REVISION DETAIL
  https://phabricator.kde.org/D27200

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h

To: mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26898: expose an id for the wallpaper

2020-01-24 Thread Marco Martin
mart updated this revision to Diff 74320.
mart added a comment.


  plasmoidId to avoid potential future clashes with QML id

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26898?vs=74319=74320

BRANCH
  phab/wallpaperid

REVISION DETAIL
  https://phabricator.kde.org/D26898

AFFECTED FILES
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.h

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26898: expose an id for the wallpaper

2020-01-24 Thread Marco Martin
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  The id of the wallpaper, is really the id of the containment, as there will 
always
  be a perfect 1:1 correspondence between them

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/wallpaperid

REVISION DETAIL
  https://phabricator.kde.org/D26898

AFFECTED FILES
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.h

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26573: Add missing Import Env Variable

2020-01-20 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  add_missing_env_var

REVISION DETAIL
  https://phabricator.kde.org/D26573

To: tcanabrava, mart
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns


D26791: prefer the new kcm plugins to the old

2020-01-20 Thread Marco Martin
mart marked an inline comment as done.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26791

To: mart, #plasma, sitter, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D26791: prefer the new kcm plugins to the old

2020-01-20 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:9afc55415793: prefer the new kcm plugins to the old 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26791?vs=73932=73936#toc

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26791?vs=73932=73936

REVISION DETAIL
  https://phabricator.kde.org/D26791

AFFECTED FILES
  src/kcmoduleloader.cpp

To: mart, #plasma, sitter, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D26791: prefer the new kcm plugins to the old

2020-01-20 Thread Marco Martin
mart created this revision.
mart added reviewers: Plasma, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  swap the logic, if the same kcm has both the new and old plugins format
  (for instance a stray build from source) now it prefers the new plugin format,
  as it tries plugins/kcms beforehand

TEST PLAN
  still loads both new and old kcms

REPOSITORY
  R295 KCMUtils

BRANCH
  phab/prefernew

REVISION DETAIL
  https://phabricator.kde.org/D26791

AFFECTED FILES
  src/kcmoduleloader.cpp

To: mart, #plasma, sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-15 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:02e57319f791: Same behavior for scrollbar as the desktop 
style (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73631=73632

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-15 Thread Marco Martin
mart marked 3 inline comments as done.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-15 Thread Marco Martin
mart updated this revision to Diff 73631.
mart added a comment.


  - round things

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73621=73631

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-15 Thread Marco Martin
mart updated this revision to Diff 73621.
mart added a comment.


  - only show when *not* a plasmoid

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73545=73621

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-15 Thread Marco Martin
mart added a comment.


  I would put for now an exception for plasmoids to not have such line, thenin 
a second moment we think about a proper and more complicated solution to update 
plasmoids design to have something along the lines of the latter mockup

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-15 Thread Marco Martin
mart added a comment.


  actually, doesn't look that good.
  F7884183: Screenshot_20200115_16.png 

  
  this is because the scrollview has some margins and no frame, so now the 
scrollbar appears not centered.
  those plasmoids would need to not have any margin with their content, or 
preferably, having the scrollviews enlarging to touch exactly the applet borders

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-15 Thread Marco Martin
mart added a comment.


  In D26664#594322 , @ngraham wrote:
  
  > I don't see the separator lines in plasma applets. Is that intentional?
  
  
  most of them are still qqc1, i can look into adding them there as well

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-14 Thread Marco Martin
mart updated this revision to Diff 73545.
mart added a comment.


  - add missing property

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73543=73545

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-14 Thread Marco Martin
mart updated this revision to Diff 73543.
mart added a comment.


  - smoother transition

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73525=73543

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26664: Same behavior for scrollbar as the desktop style

2020-01-14 Thread Marco Martin
mart retitled this revision from "same behavior for scrollbar as the desktop 
style" to "Same behavior for scrollbar as the desktop style".
mart edited the test plan for this revision.
mart added a reviewer: ngraham.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26664: same behavior for scrollbar as the desktop style

2020-01-14 Thread Marco Martin
mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  bigger scrollbar and add a small line separator
  to look consistent with D26655  and 
D26654 
  
  same behavior for mobile scrollbar

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26540: Consistency: colored selected buttons

2020-01-09 Thread Marco Martin
mart added a comment.


  In D26540#590924 , @davidedmundson 
wrote:
  
  > Can you update tests/components/button.qml   tests/components/button3.qml
  >
  > just a button with "focus: true" and some label that says "this should be 
highlighted on load"
  
  
  done post landing

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26540

To: mart, #plasma, #vdg, #goal_consistency, ngraham
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns


D26540: Consistency: colored selected buttons

2020-01-09 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1d6870b15624: Consistency: colored selected buttons 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26540?vs=73122=73138

REVISION DETAIL
  https://phabricator.kde.org/D26540

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmastyle/ButtonStyle.qml
  src/desktoptheme/breeze/widgets/button.svg

To: mart, #plasma, #vdg, #goal_consistency, ngraham
Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns


  1   2   3   4   5   6   7   8   9   10   >