mwoehlke added inline comments.
INLINE COMMENTS
> kcolorutils.cpp:60
> *c = khcy.c;
> *h = khcy.h;
> *y = khcy.y;
I guess it will be less confusing if this is also normalized?
*h = khcy.h + (khcy.h < 0.0 ? 1.0 : 0.0);
> kcolorutils.h:36
> +/**
> + * Calculate the hue of a
mwoehlke added inline comments.
INLINE COMMENTS
> broulik wrote in kcolorutils.h:42
> This doesn't mention hcy anywhere and there's `QColor::hue`.
> But we already have `luma` in the same way, so I guess this is alright.
I expect it wouldn't hurt to mention that `luma`, `chroma` and `hue` all
mwoehlke added a comment.
Indeed, we could have been having this conversation here instead of via
e-mail . But, six of one...
I believe `luma` and `chroma` are already guaranteed to return normalized
values; it's just `hue` that you may want to normalize if you don't want to
*that* still remove
tabs? (Seems like you'd want it too in that case...)
- Matthew Woehlke
On April 22, 2014, 5:06 p.m., Sven Brauch wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
On 2013-06-18 11:54, Aleix Pol wrote:
On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote:
On 2013-06-18 03:10, Dominik Haumann wrote:
On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote:
On Monday 17 June 2013 19:43:33 Aleix Pol wrote:
So I was looking at KGlobalSettings to see what we
On 2013-06-18 03:10, Dominik Haumann wrote:
On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote:
On Monday 17 June 2013 19:43:33 Aleix Pol wrote:
So I was looking at KGlobalSettings to see what we need to do to finally
deprecate all KGlobalSettings, as suggested by the required kdelibs
On 2012-08-18 03:50, David Faure wrote:
On Thursday 09 August 2012 17:16:27 Matthew Woehlke wrote:
I think you're going to have to either:
a. Accept a SIC and just let some roles be wrong for old code
b. Have a suffix on all the new flags
c. Put the new flags in some namespace that isn't
