D23484: gcc naming conflict

[Mickael Bosch]

mickaelbo updated this revision to Diff 64727.
mickaelbo added a comment.


  It makes sense.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23484?vs=64719=64727

REVISION DETAIL
  https://phabricator.kde.org/D23484

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: mickaelbo, #framework_syntax_highlighting, cullmann
Cc: jriddell, cullmann, kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23484: gcc naming conflict

[Mickael Bosch]

mickaelbo created this revision.
mickaelbo added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mickaelbo requested review of this revision.

REVISION SUMMARY
  With  gcc 7.4.0 (and maybe some other versions), "major" and "minor" are set 
as macro and expand to "gnu_dev_major" and "gnu_dev_minor".  
  See: https://bugzilla.redhat.com/show_bug.cgi?id=130601 

  
  These strings are used in the affected file for variable naming.
  The attached patch undef the gcc renaming.
  
  A syntax-highlighting user, Jonathan, reported the issue, provided the patch 
and tested it  after trying to compile the project when the last commit was 
authored by me. Thank you Jonathan.

TEST PLAN
  The compilation shall not fail with gcc 7.4.0.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23484

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: mickaelbo, #framework_syntax_highlighting
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23447: Set the OpenSCAD indenter to C-style instead of none.

[Mickael Bosch]

mickaelbo added a comment.


  Yup, 
  Mickael Bosch
  mickael.bo...@linux.com
  Thanks,

REVISION DETAIL
  https://phabricator.kde.org/D23447

To: mickaelbo, #framework_syntax_highlighting, cullmann
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, julianstirling, 
LeGast00n, GB_2, domson, michaelh, bruns, demsking, sars, dhaumann

D23447: Set the OpenSCAD indenter to C-style instead of none.

[Mickael Bosch]

mickaelbo added a comment.


  Thank you for the "js way" to modify the indentation. I will have a look at 
this tomorrow.
  
  From what I see, the *.scad* files in the autotest directory are exclusively 
related to hightlighting and folding, nothing is related to the indenter 
expected behavior (ie. indent as you type). Did I miss something ?

REVISION DETAIL
  https://phabricator.kde.org/D23447

To: mickaelbo, #framework_syntax_highlighting
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, julianstirling, 
LeGast00n, GB_2, domson, michaelh, bruns, demsking, sars, dhaumann

D23447: Set the OpenSCAD indenter to C-style instead of none.

[Mickael Bosch]

mickaelbo updated this revision to Diff 64607.
mickaelbo added a comment.


  Set the section to 3D and few style changes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23447?vs=64598=64607

REVISION DETAIL
  https://phabricator.kde.org/D23447

AFFECTED FILES
  data/syntax/openscad.xml

To: mickaelbo, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, julianstirling, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23447: Set the OpenSCAD indenter to C-style instead of none.

[Mickael Bosch]

mickaelbo created this revision.
mickaelbo added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mickaelbo requested review of this revision.

REVISION SUMMARY
  OpenSCAD uses braces enclosed blocks, you can see examples at 
https://en.wikibooks.org/wiki/OpenSCAD_User_Manual/Commented_Example_Projects 
 
.
  
  The brace and indentation style is close to C (optional braces if there is 
only one sub statement and one-line blocks are allowed). Therefore, the C-style 
indenter is well fitted IMHO.
  
  Side question: the C indenter indents the next line when a block keyword if 
found (for, if, etc.) even when no opening brace is typed. Is there a way to 
extend this list of indenter keywords for OpenSCAD (rotate, linear_extrude, 
etc.) ?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23447

AFFECTED FILES
  data/syntax/openscad.xml

To: mickaelbo, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, julianstirling, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22276: Add an action to insert a non-indented newline

[Mickael Bosch]

mickaelbo added a comment.


  Another way to avoid indented empty line is to clear the trailing 
spaces/indentation when pressing enter while the cursor is at the end of a line 
containing only spaces or \t. This can lead to a nightmare though if someone 
want to keep trailing spaces...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22276

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: mickaelbo, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann