D29223: Update Taiwanese holidays

[N. Higa]

nhiga set the repository for this revision to R175 KHolidays.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D29223: Update Taiwanese holidays

[N. Higa]

nhiga added a comment.


  Officially-recognized days (including 言論自由日) and the dates for 2020 can be 
found in this document 
.
 Names without ※ means it is officially-recognized but is not stated in the law.
  
  There are many (>60) commemorative days (days without ※) so I do not plan to 
include them in the file (for the time being).

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D29223: Update Taiwanese holidays

[N. Higa]

nhiga updated this revision to Diff 82085.
nhiga added a comment.


  Added 植樹節.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29223?vs=81833=82085

REVISION DETAIL
  https://phabricator.kde.org/D29223

AFFECTED FILES
  holidays/holidays.qrc
  holidays/plan2/holiday_tw_zh
  holidays/plan2/holiday_tw_zh-tw

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D29223: Update Taiwanese holidays

[N. Higa]

nhiga added a comment.


  Some historical arrangements of some holidays (e.g. Children's Day between 
1998-2010) are currently ignored, but I believe this is less important.

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D29223: Update Taiwanese holidays

[N. Higa]

nhiga marked 6 inline comments as done.

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D29223: Update Taiwanese holidays

[N. Higa]

nhiga updated this revision to Diff 81833.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29223?vs=81321=81833

REVISION DETAIL
  https://phabricator.kde.org/D29223

AFFECTED FILES
  holidays/holidays.qrc
  holidays/plan2/holiday_tw_zh
  holidays/plan2/holiday_tw_zh-tw

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D29223: Update Taiwanese holidays

[N. Higa]

nhiga added a comment.


  > On the Spring festival 春節 of 2020, the publicholidays.tw page and the 
official source listed on that page both showed Jan 23 to 29 as the days off.
  
  I think both of us can be correct:
  
  - I referred to this document by Ministry of the Interior, R. O. C. (Taiwan) 
for 2020 
.
 I believe that document is showing the "minimum requirements by law", which 
means all employees should be able to haves days off on the listed holidays.
  - For government offices, I believe that the regulations "政府機關調整上班日期處理要點" 
will be applied and civil servants have extra days off in some conditions. For 
example it says " 
四、上班日為星期一或星期五，其後一日或前一日逢星期二或星期四之紀念日及節日之放假，調整該上班日為放假日。農曆除夕前一日為上班日者，調整該上班日為放假日。 ", 
so I think this is why Jan 23 is also a day off for them.
  
  > Would you also indicate the plan for the festivals specified as "2020" in 
this diff for future years?
  
  I plan to follow the format in the `holiday_hk_*` files, so it will be 
something like:
  
:: 應放假之紀念日及節日（以農曆為基礎）

: Chinese New Year's Eve
"農曆除夕"  public cultural on 24 January 2020
: Spring festival
"春節"  public cultural on 25 January 2020 length 
5 days
: Tomb Sweeping Day
"民族掃墓節"public cultural on 4 April 2020
: Dragon Boat Festival
"端午節"public cultural on 25 June 2020
: Mid-Autumn Festival   
"中秋節"public cultural on 1 October 2020

"農曆除夕"  public cultural on DD MM 2021
"春節"  public cultural on DD MM 2021 length Y 
days
"民族掃墓節"public cultural on DD MM 2021
"端午節"public cultural on DD MM 2021
"中秋節"public cultural on DD MM 2021

:: Substitute holidays
:: 補假

"兒童節補假"public on 3 April 2020
"民族掃墓節補假"public on 2 April 2020

"XX補假"public on DD MM 2021
"XX補假"public on DD MM 2021

INLINE COMMENTS

> weisi wrote in holiday_tw_zh-tw:38
> Do you intend to use 3 days here?
> 
> According to 紀念日及節日實施辦法 
> :
> 
> > 下列民俗節日，除春節放假三日外，其餘均放假一日... (3 days off for the Spring festival, 1 day off 
> > otherwise, for the following...)

I intentionally included substitute holidays (Jan 28-29 2020) when writing the 
length, since `holiday_hk_*`also include substitute holidays in the length for 
Spring Festival.

> weisi wrote in holiday_tw_zh-tw:62
> I think this one is more religious than commemorative.

True. Maybe mark it as "religious commemorative"?

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, 
fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D29372: Taiwan: Use "zh_TW" language code

[N. Higa]

nhiga added a comment.


  I would say that the file should also be renamed.
  
  //My comment from D29223 ://
  
  > The new file name follows the same naming scheme used by the PRC (mainland 
China) holiday file, holiday_cn_zh-cn (holiday_region_Language-Region). It is 
also less ambiguous because zh alone does not indicate the character set being 
used (i.e. Simplified Chinese or Traditional Chinese).

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29372

To: weisi, winterz
Cc: nhiga, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

[N. Higa]

nhiga added a comment.


  > specified the start year of Peace Memorial Day 228和平紀念日
  
  Great! This is what I have missed in my patch.
  
  > The star * ones are specified using the "lunar new year date" minus/plus 
some days, hoping to make it easier to adapt to additional years in the future.
  
  I appreciate this new idea and I think it is worth discussing which way of 
dealing lunar calendar-based holidays is better.
  I consider my method a no-brainer because:
  
  - In many cases, Lunar calendar-based (public) holidays in Taiwan are 
actually the same as (or similar to) those in Hong Kong, so basically we can 
refer to the dates in `holiday_hk_en-gb` (which contains the dates up to 2030). 
One notable exception is the Mid-Autumn Festival - for Hong Kong the holiday is 
on the day **after** Mid-Autumn Festival.
  - Or, just refer to the document published by the Ministry of the Interior, 
R. O. C. (Taiwan), which is really straightforward.
  
  For your method:
  
  - We can see the patterns for those holidays (i.e. Lunar new year date + XX 
days + extra months or days (leap month 閏月 / leap days 閏日))
  - If you are (very) familiar with lunar calendar, this method may actually be 
better. Otherwise, you will have to be really careful with the leap months/days.
  
  > There are holidays entries regarding specific arrangements (an extra day is 
observed in lieu of an extra working day) that can't be calculated in advance
  
  If you are referring to 補假 (substitute holiday / supplementary holiday), the 
logic is stated in the law (紀念日及節日實施辦法 
):
  
  > 
紀念日及節日之放假日逢例假日應予補假。例假日為星期六者於前一個上班日補假，為星期日者於次一個上班日補假。但農曆除夕及春節放假日逢例假日，均於次一個上班日補假。
  
  I believe that means:
  
  - If a public holiday is on Saturday, the substitute holiday will be the 
previous working day;
  - If a public holiday is on Sunday, the substitute holiday will be the next 
working day;
  - However, for Lunar New Year's eve and Lunar New Year, the substitute 
holiday will always be the previous working day.
  
  > I think there are still issues with the 4 season dates
  
  I have not enabled "Astronomical Events" plugin, but the astronomical seasons 
(especially June solstice, which is not a holiday for Japan and Hong Kong) are 
still automatically displayed for me. And apparently kholidays has the 
astronomical seasons support already in `src/astroseasons.cpp`.
  Some other issues:
  
  - Official holiday names should be used.
  - Using a third-party and non-official site such as `publicholidays.tw` as 
reference seems unreliable. My patch refers to the law and official documents 
to ensure accuracy.
  - Hence, I excluded all non-official holidays, such as Easter, which has been 
included in your patch.
  - But I cannot say I am 100% sure that I have not missed any official 
**commemorative** days. For example, Wikipedia says the Freedom of Expression 
Day (言論自由日) is an official one, but I wonder why it is not included in the law 
紀念日及節日實施辦法. The website I linked above should be displaying the latest (and 
official) revision of the law. I hope someone from Taiwan can provide more 
information on this.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29373

To: weisi, winterz, cgiboudeaux
Cc: nhiga, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

[N. Higa]

nhiga added a reviewer: cgiboudeaux.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29373

To: weisi, winterz, cgiboudeaux
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29223: Update Taiwanese holidays

[N. Higa]

nhiga added a comment.


  @cgiboudeaux 
  Thanks for the heads-up.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D29223: Update Taiwanese holidays

[N. Higa]

nhiga added a comment.


  In D29223#658229 , @cgiboudeaux 
wrote:
  
  > I suppose you rename the file for a good reason. Are there different 
"official" languages for Taiwan?
  
  
  The new file name follows the same naming scheme used by the PRC (mainland 
China) holiday file, `holiday_cn_zh-cn` (holiday_region_Language-Region). It is 
also less ambiguous because `zh` alone does not indicate the character set 
being used (i.e. Simplified Chinese or Traditional Chinese).
  
  Actually the holiday file for Hong Kong, `holiday_hk_zh-cn`, should be 
renamed to `holiday_hk_zh-hk` because `zh-cn` means Simplified Chinese, but 
Hong Kong uses Traditional Chinese, but this will be another story.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D29223: Update Taiwanese holidays

[N. Higa]

nhiga added a comment.


  Notes:
  
  1. Holidays for indigenous peoples have not been included. Some of them seem 
to have a fixed date, but for other festivals we know the range but not the 
exact dates. For example, it is known that 豐年祭(收穫祭) is celebrated between July 
1 and September 30 (source 
),
 but the actual date (which is also a day off for the respective ethnic group) 
is picked by the Amis people. This calendar 

 does not give us any hint on the exact date of 豐年祭.
  2. 勞動節 (Labor Day) is a day off for many people, but at the same time civil 
servants, teachers, etc. do not have a day off, so I did not mark it as 
"public". Similarly, "軍人節" is a day off for military members only, and others 
do not have a day off.
  3. Some holidays such as Children's Day are referred to as festivals (節日) and 
not as commemorative days (紀念日), but for simplicity, I am marking them as 
"commemorative".

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux
Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D29223: Update Taiwanese holidays

[N. Higa]

nhiga created this revision.
nhiga added reviewers: winterz, cgiboudeaux.
nhiga added projects: KDE PIM, Frameworks.
nhiga requested review of this revision.

REVISION SUMMARY
  This patch improves upon @shrapnel 's work 
 on the accuracy of the Taiwanese holidays 
file:
  
  - Some holidays are determined based on the Lunar Calendar, and their 
specific dates have to be manually specified for each year
  - Official holiday names are now used
  - Try to put a holiday in the correct categories
  
  The following has been excluded:
  
  - Holidays (Festivals) for indigenous peoples (原住民族歲時祭儀)
  - Non-official holidays such as Halloween and Christmas

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

AFFECTED FILES
  holidays/holidays.qrc
  holidays/plan2/holiday_tw_zh
  holidays/plan2/holiday_tw_zh-tw

To: nhiga, winterz, cgiboudeaux
Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D28874: Taiwanese holidays

[N. Higa]

nhiga added a comment.


  By the way, the holiday file for People's Republic of China (i.e. mainland 
China) also needs update too because the dates of Lunar calendar based holidays 
are only available for 2009.
  The comment in the file says "these have to wait for lunar calendar support", 
but it looks like Qt and KDE have yet to support Lunar calendar, so we have to 
update the dates manually for the time being.
  
  I will see whether I can update the holiday files for both Taiwan and 
mainland China to make them more accurate.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: nhiga, ngraham, winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D28874: Taiwanese holidays

[N. Higa]

nhiga added a comment.


  Thank you for your attempt to add Taiwanese holidays to KDE. However, I am 
afraid that this patch has to be reviewed again.
  
  The dates for some holidays (including, but not limited to, Spring Festival 
(also known as "Lunar New Year") and the Mid-Autumn Festival) are different 
every year because some holidays are determined based on the Lunar Calendar 
(農曆). That means one has to specify the exact dates for each year, just like 
the `holiday_hk_*` files.
  If you look at the table in the English Wikipedia entry for Public holidays 
in Taiwan  carefully, 
you will notice that some holidays follow Chinese calendar instead of the 
Gregorian calendar.
  
  Therefore, we should try to refer to the relevant laws and regulations, and 
use government-published documents as sources for accuracy. In this case, we 
should refer to the law "紀念日及節日實施辦法" (only available in Chinese) 
. In addition, the 
Ministry of the Interior, R. O. C. (Taiwan) publishes a document listing the 
exact dates of public holidays each year ("public" here means "放假", carrying 
the meaning of being a day off). The document for 2020 can be found here 

 (Note that the ROC era is used, so Year 109 means 2020).
  
  The public holidays as well as the official commemorative holidays are 
already complicated, so I think for the time being it would be better to 
exclude non-official holidays such as Halloween or Christmas.
  
  Thank you for your attention.

INLINE COMMENTS

> holiday_tw_zh:16
> +country "TW"
> +language"tw_zh"
> +:name"optional - defaults to country name"

Shouldn't this line be `zh` (or `zh_TW`) instead? It looks like the format for 
the "language" metadata entry has been `` or `_`.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: nhiga, ngraham, winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27419: Update Japanese holidays

[N. Higa]

nhiga added a comment.


  In D27419#612064 , @winterz wrote:
  
  > I tested these changes locally.  works
  >
  > do you have commit access?
  
  
  No, I do not have commit access. (I think commit access is only granted to 
active developers/contributors? )

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27419

To: nhiga, dvratil, winterz, cgiboudeaux
Cc: aacid, #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, 
GB_2, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D27419: Update Japanese holidays

[N. Higa]

nhiga created this revision.
nhiga added reviewers: dvratil, winterz.
nhiga added projects: KDE PIM, Frameworks.
nhiga requested review of this revision.

REVISION SUMMARY
  This patch is purely cosmetic since the predicted Vernal and Autumnal Equinox 
Days of 2021 are the same as the official announcement 
.
  The source URLs in the comment section are now in HTTPS. (When using the HTTP 
version , a notice on 
"always-on" TLS of Cabinet Office Website 
 will be displayed.)

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27419

AFFECTED FILES
  holidays/plan2/holiday_jp_en-us
  holidays/plan2/holiday_jp_ja

To: nhiga, dvratil, winterz
Cc: #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D23730: Add new protocol for 7z archives

[N. Higa]

nhiga edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23730

To: nhiga, meven
Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D23780: Add new protocol for 7z archives

[N. Higa]

nhiga created this revision.
nhiga added reviewers: Frameworks, cfeck, pino, dfaure, meven.
nhiga added a project: Frameworks.
nhiga requested review of this revision.

REVISION SUMMARY
  D23730  adds the `sevenz` protocol for 7z 
archives by utilizing K7Zip, so this patch is needed for proper URL navigation.
  
  Depends on: D23730 
  See also: D20424 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23780

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: nhiga, #frameworks, cfeck, pino, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23730: Add new protocol for 7z archives

[N. Higa]

nhiga added a comment.


  @meven
  
  There is a weird bug if I name the protocol as "7z" or "7zip":
  
  1. If I double click on the 7z file, Dolphin gives the "invalid protocol" 
error.
  2. If I try to manually enter the URL in Dolphin, i.e. `7z:/tmp/bar.7z` or 
`7zip:/tmp/bar.7z`, it does not work too - it is somehow being treated as a 
host (hostname) instead of a protocol.
  
  I suspect that a KIO protocol should not have a name that starts with a 
number, otherwise there will be bugs.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23730

To: nhiga, meven
Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D23730: Add new protocol for 7z archives

[N. Higa]

nhiga added a comment.


  Notes:
  
  1. This patch requires D23490  and the 
following KIO patch:
  
diff --git a/src/filewidgets/kurlnavigator.cpp 
b/src/filewidgets/kurlnavigator.cpp
index 80aa975..5a6c720 100644
--- a/src/filewidgets/kurlnavigator.cpp
+++ b/src/filewidgets/kurlnavigator.cpp
@@ -1046,8 +1046,8 @@ void KUrlNavigator::setLocationUrl(const QUrl )
 // code locationUrl() and url become the same URLs
 QUrl firstChildUrl = KIO::UrlUtil::firstChildUrl(locationUrl(), url);
 
-if ((url.scheme() == QLatin1String("tar")) || (url.scheme() == 
QLatin1String("zip")) || (url.scheme() == QLatin1String("krarc"))) {
-// The URL represents a tar- or zip-file, or an archive file 
supported by krarc.
+if ((url.scheme() == QLatin1String("tar")) || (url.scheme() == 
QLatin1String("zip")) || (url.scheme() == QLatin1String("sevenz")) || 
(url.scheme() == QLatin1String("krarc"))) {
+// The URL represents a tar-, zip- or 7z-file, or an archive file 
supported by krarc.
 // Check whether the URL is really part of the archive file, 
otherwise
 // replace it by the local path again.
 bool insideCompressedPath = d->isCompressedPath(url);
@@ -1064,7 +1064,7 @@ void KUrlNavigator::setLocationUrl(const QUrl )
 }
 }
 if (!insideCompressedPath) {
-// drop the tar: or zip: or krarc: protocol since we are not
+// drop the tar:, zip:, sevenz: or krarc: protocol since we 
are not
 // inside the compressed path
 url.setScheme(QStringLiteral("file"));
 firstChildUrl.setScheme(QStringLiteral("file"));
  
  2. If I name the protocol as "7z", "Invalid protocol" error will be thrown, 
so I use "sevenz" instead.
  3. I am not sure whether it is needed to include `k7zip.h` in 
`archive/kio_archivebase.cpp`.
  4. It can take some time to load the 7z archive using this new protocol.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23730

To: nhiga
Cc: kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23730: Add new protocol for 7z archives

[N. Higa]

nhiga created this revision.
nhiga added a project: Frameworks.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
nhiga requested review of this revision.

REVISION SUMMARY
  This patch adds a new protocol, sevenz, for 7z archives by utilizing K7Zip. 
Previously, users have to install Krusader to use its `krarc` protocol to 
navigate a 7z archive using Dolphin.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23730

AFFECTED FILES
  archive/CMakeLists.txt
  archive/kio_archive.cpp
  archive/kio_archivebase.cpp
  archive/sevenz.protocol

To: nhiga
Cc: kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga added a comment.


  When this patch is applied and Krusader is not installed:
  
  Dolphin (with "Open archives as folder" enabled): Opens the 7z/RAR archive 
using Ark.
  Gwenview: 7z/RAR archives will not appear (probably because it is unsupported 
without krarc).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga edited the summary of this revision.
nhiga edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga added a comment.


  This patch may be related to Bug 411330 
.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, kde-frameworks-devel
Cc: LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga created this revision.
nhiga added a reviewer: kde-frameworks-devel.
nhiga added a project: Frameworks.
nhiga requested review of this revision.

REVISION SUMMARY
  With D23476 , this patch should let users 
who have Krusader installed to view files inside a 7z or RAR archive in KDE 
applications (such as Gwenview) without decompressing the whole archive to 
another location. They will also be able to navigate the archive using Dolphin.

TEST PLAN
  1. Apply D23476  (and add 
`application/vnd.rar` to `archiveMimetype` in `krArc/krarc.protocol` if it does 
not work) to Krusader.
  2. Apply this patch to KIO.
  3. Enable "Open archives as folder" in Dolphin, then open a 7z/RAR file. It 
should be using the `krarc` protocol.
  4. Browse (Navigate) and look around the archive. Click on the breadcrumb in 
the location area for a parent folder which is outside the archive to make sure 
Bug 386448 does not occur.
  5. Open Gwenview and view a 7z/RAR archive with photos. Browse and view an 
image inside the archive.
  6. To be safe, uninstall Krusader and see if there is any bug if `krarc` is 
unavailable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: nhiga, kde-frameworks-devel
Cc: LeGast00n, GB_2, michaelh, ngraham, bruns

D22297: Add id="current-color-scheme" to collapse-all icons

[N. Higa]

nhiga edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22297

To: nhiga, #vdg, davidhurka
Cc: davidhurka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22297: Add id="current-color-scheme" to collapse-all icons

[N. Higa]

nhiga added a reviewer: davidhurka.
nhiga added a subscriber: davidhurka.
nhiga added a comment.


  @davidhurka
  
  Would you please try this diff and see if it resolves the bug?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22297

To: nhiga, #vdg, davidhurka
Cc: davidhurka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22297: Add id="current-color-scheme" to collapse-all icons

[N. Higa]

nhiga added a comment.


  Summary will be filled in later.
  
  Related: D19575 , Bug 409546 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22297

To: nhiga, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22297: Add id="current-color-scheme" to collapse-all icons

[N. Higa]

nhiga created this revision.
nhiga added a reviewer: VDG.
nhiga added a project: Frameworks.
nhiga requested review of this revision.

REVISION SUMMARY
  BUG: 409546

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22297

AFFECTED FILES
  icons-dark/actions/16/collapse-all.svg
  icons-dark/actions/22/collapse-all.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/32/collapse-all.svg
  icons/actions/16/collapse-all.svg
  icons/actions/22/collapse-all.svg
  icons/actions/24/collapse-all.svg
  icons/actions/32/collapse-all.svg

To: nhiga, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

[N. Higa]

nhiga added a comment.


  With `krarc`, users can open 7z and RAR files as folder in Dolphin (with 
patches [1] [2]). This is also useful for Gwenview - if you have pictures in a 
7z or RAR archive, then you can view them in Gwenview without decompressing the 
whole archive to another location. However, I'm not sure whether it's 
appropriate to add these Krusader-specific things to KIO.
  
  [1] For Krusader, add `application/vnd.rar` to `archiveMimetype` in 
`krArc/krarc.protocol`
  [2] For KIO, add `mime.inherits(QStringLiteral("application/vnd.rar"))` and 
`mime.inherits(QStringLiteral("application/x-7z-compressed"))` to 
`KUrlNavigator::Private::isCompressedPath` in 
`src/filewidgets/kurlnavigator.cpp`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20424

To: nhiga, kde-frameworks-devel, ngraham
Cc: bcooksley, aacid, ngraham, michaelh, bruns

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

[N. Higa]

nhiga added a comment.


  I've just updated my KDE Identity account - my full name and email address 
can now be found by searching the username "nhiga" on KDE Identity - People 
. I'm sorry for the 
inconvenience caused.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20424

To: nhiga, kde-frameworks-devel, ngraham
Cc: ngraham, michaelh, bruns

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

[N. Higa]

nhiga created this revision.
nhiga added a reviewer: kde-frameworks-devel.
nhiga added a project: Frameworks.
nhiga requested review of this revision.

REVISION SUMMARY
  If Krusader is installed, the `krarc` protocol is available and Dolphin may 
use it to open ZIP archives. In this case, when the user goes back to a parent 
folder outside the archive, a "file or folder does not exist" error will be 
returned. This can be fixed by including krarc in the URL scheme check inside 
the `KUrlNavigator::setLocationUrl` method.
  
  BUG: 386448

TEST PLAN
  1. Install Krusader and Dolphin.
  2. Enable "Open archives as folder" in Dolphin and open a zip file using the 
`krarc` protocol. (Change `zip:` to `karc:` when applicable.)
  3. Click on the breadcrumb in the location area for a parent folder which is 
outside the archive.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20424

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: nhiga, kde-frameworks-devel
Cc: michaelh, ngraham, bruns