D25307: kwriteconfig: add delete option

2019-11-14 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, davidre, dfaure, meven, cfeck. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25307 To: esjeon, #frameworks, davidre, dfaure, meven, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

2019-11-14 Thread Nathaniel Graham
ngraham added a comment. In D25015#562362 , @niccolove wrote: > Meanwhile, I tried to do a more sparse and equal-all-around shadow (to address Nate+Filip), but I'm not 100% okay with it. Opinions? > > F7762929:

D25296: [RFC] Fix Display Configuration icon margins

2019-11-13 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The icon's old margins were too large, causing it to stick out. However in

D24957: Add new baloo icons

2019-11-13 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

2019-11-13 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b9dd7fd5a672: Use an eyedropper for color-picker icons (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25132?vs=69699=69708 REVISION

D24959: Add new preferences search icons

2019-11-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. LGTM, let's try not to torture this icon to death. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26, bruns,

D25132: Use an eyedropper for color-picker icons

2019-11-13 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

2019-11-13 Thread Nathaniel Graham
ngraham updated this revision to Diff 69699. ngraham added a comment. Thicken side lines REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25132?vs=69471=69699 BRANCH eyedropper-style-color-picker-icon (branched from master) REVISION DETAIL

D25291: Add "all applications" category icon

2019-11-13 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:f249a14c70b4: Add all applications category icon (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25291?vs=69687=69695 REVISION DETAIL

D25291: Add "all applications" category icon

2019-11-13 Thread Nathaniel Graham
ngraham updated this revision to Diff 69687. ngraham added a comment. Optimize icons with scour REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25291?vs=69686=69687 BRANCH all-apps-icon (branched from master) REVISION DETAIL

D25291: Add "all applications" category icon

2019-11-13 Thread Nathaniel Graham
ngraham added a reviewer: broulik. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25291 To: ngraham, #vdg, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25291: Add "all applications" category icon

2019-11-13 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY We currently have no accepted "all apps" icon. This patch creates one, inspired by the

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

2019-11-13 Thread Nathaniel Graham
ngraham added a comment. Last question: give the button text, or stick with the icon only? I ask because `go-jump` is kind of an odd icon IMO: F7761220: Screenshot_20191113_093303.png REPOSITORY R241 KIO REVISION DETAIL

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

2019-11-13 Thread Nathaniel Graham
ngraham updated this revision to Diff 69684. ngraham marked an inline comment as done. ngraham added a comment. Use more semantically correct icon REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25226?vs=69493=69684 BRANCH

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

2019-11-13 Thread Nathaniel Graham
ngraham added a comment. Actually I played with that and in retrospect I don't think it would work. If we give it a "link-like" appearance, that would suggest that clicking on it would actually open the destination file/folder (i.e. the typical link behavior), which is not what we want

D20508: [udisks2] fix media change detection for external optical drives

2019-11-12 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R245:4aa39aed1bd6: [udisks2] fix media change detection for external optical drives (authored by rokmandeljc, committed by ngraham). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D20508: [udisks2] fix media change detection for external optical drives

2019-11-12 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20508 To: rokmandeljc, bruns, broulik, dfaure, #frameworks, ngraham Cc: ngraham, bugseforuns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D20508: [udisks2] fix media change detection for external optical drives

2019-11-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'm very sorry that this patch appears to have been lost along the way. I've tested it and it works for me. @bruns, are you okay with this? REPOSITORY R245 Solid REVISION DETAIL

D25123: [WIP] New yakuake logo/icon

2019-11-09 Thread Nathaniel Graham
ngraham added a comment. Agreed, C for me too. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, michaelh, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

2019-11-08 Thread Nathaniel Graham
ngraham added a comment. Or maybe should the UI be changed to show a clickable link and an "edit" button that temporarily turns it into a text field that lets you edit it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25226 To: ngraham, #vdg, #frameworks Cc:

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

2019-11-08 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 413002 FIXED-IN: 5.65 Undecided on the button. Should it be

D25221: Add OBS to screenrecorders

2019-11-08 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH obs-branch REVISION DETAIL https://phabricator.kde.org/D25221 To: meven, leinir, ngraham Cc: nicolasfella, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Nathaniel Graham
ngraham added a comment. No problem, I wasn't being very clear myself. :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25215 To: meven, leinir, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

2019-11-08 Thread Nathaniel Graham
ngraham added a comment. In an ideal world the OBS stuff would be in a separate patch. :) REPOSITORY R304 KNewStuff BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 To: meven, leinir, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25132: Use an eyedropper for color-picker icons

2019-11-08 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

2019-11-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 69471. ngraham added a comment. Update to be a bit more Breezey and address review comments REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25132?vs=69232=69471 BRANCH eyedropper-style-color-picker-icon

D25219: Only create a session config when actually restoring a session

2019-11-08 Thread Nathaniel Graham
ngraham added a dependent revision: D11382: Add an option to show tabs from last time when Dolphin starts. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25219 To: ngraham, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

2019-11-08 Thread Nathaniel Graham
ngraham added a comment. Done, see D25219 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25219: Only create a session config when actually restoring a session

2019-11-08 Thread Nathaniel Graham
ngraham retitled this revision from "Also only create a session config when actually restoring a session" to "Only create a session config when actually restoring a session". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25219 To: ngraham, #frameworks,

D25219: Also only create a session config when actually restoring a session

2019-11-08 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This allows manually invoking session restoration logic without

D25216: Fix translations of $GenericName

2019-11-08 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH arcpatch-D25216 REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham, #localization Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25216: Fix translations of $GenericName

2019-11-08 Thread Nathaniel Graham
ngraham added a reviewer: Localization. ngraham added a comment. LGTM but please wait for approval from a translator too. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham, #localization Cc: aspotashev, kde-frameworks-devel,

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

2019-11-08 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. While you're touching this stuff, it'll probably be easy to implement https://bugs.kde.org/show_bug.cgi?id=412320 REPOSITORY R304 KNewStuff BRANCH arcpatch-D25215 REVISION DETAIL

D25215: Fix a couple of broken links

2019-11-08 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. We should use the kde.org/applications links, e.g. https://kde.org/applications/system/org.kde.kdf, not https://utils.kde.org/projects/kdf REPOSITORY R304 KNewStuff

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

2019-11-08 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH be-more-friendly-during-initial-load (branched from master) REVISION DETAIL https://phabricator.kde.org/D25173 To: leinir, #knewstuff, #frameworks, ngraham, #vdg Cc:

D25197: Show a "Loading more..." busy indicator when loading view data

2019-11-08 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH reduce-some-noise (branched from master) REVISION DETAIL https://phabricator.kde.org/D25197 To: leinir, #knewstuff, #frameworks, #plasma, ngraham Cc: kde-frameworks-devel,

D25106: Also allow invoking session restoration logic when apps are manually launched

2019-11-08 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

2019-11-07 Thread Nathaniel Graham
ngraham added a comment. Ah, pixel-perfect before-and-after images make it much easier to see. I will reiterate my belief that the shadows now need to be bigger if we're going to make them lighter and weaker. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25197: Show a "Loading more..." busy indicator when loading view data

2019-11-07 Thread Nathaniel Graham
ngraham added a comment. Cool, I'm okay with that. The "Loading more" indicator is aligned to the top, not centered like the other loading indicator is. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25197 To: leinir, #knewstuff, #frameworks, #plasma,

D25149: Add a new template for KCMs

2019-11-07 Thread Nathaniel Graham
ngraham retitled this revision from "Add a new Template for KCM's." to "Add a new template for KCMs". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava Cc: yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n,

D25189: Add an overlay component for item activity feedback

2019-11-07 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good stuff. INLINE COMMENTS > FeedbackOverlay.qml:63 > +} else { > +statusLabel.text = i18nc("Label for the busy indicator > which should only be

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

2019-11-07 Thread Nathaniel Graham
ngraham added a comment. I still see "Loading Data" in a passiveNotification as well as in text under the loading indicator. Do we really need the passiveNotifications at all? I think we can probably improve the user experience vy removing them entirely. For example instead of "Loading one

D25168: Use the pointing hand cursor for the single-clickable delegates

2019-11-06 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH use-finger-cursor-for-single-clickable-bits (branched from master) REVISION DETAIL https://phabricator.kde.org/D25168 To: leinir, #knewstuff, #frameworks, ngraham Cc:

D25165: Only show DownloadItemsSheet if there's more than one download item

2019-11-06 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH dont-show-downloaditemssheet-if-only-one-download (branched from master) REVISION DETAIL https://phabricator.kde.org/D25165 To: leinir, #knewstuff, #frameworks, ngraham Cc:

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

2019-11-06 Thread Nathaniel Graham
ngraham added a comment. Now you don't need those PassiveNotifications anymore, because otherwise you wind up with duplicate messages: F7745214: loading.png REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25173 To:

D25015: Update breeze theme shadows

2019-11-06 Thread Nathaniel Graham
ngraham added a comment. In D25015#559367 , @ndavis wrote: > I haven't said much about this idea because I just have a hard time seeing the difference from the screenshots. I must admit having the same problem. :) REPOSITORY R242

D25067: Fix the header layouts for EntryDetails and Page components

2019-11-05 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-page-and-entrydetails-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D25067 To: leinir, ngraham, #knewstuff, #frameworks, #plasma Cc:

D25067: Fix the header layouts for EntryDetails and Page components

2019-11-04 Thread Nathaniel Graham
ngraham added a comment. With that Kirigami patch, this *almost* works. There's still an empty area on the right: F7735292: Screenshot_20191104_092108.png F7735295: Screenshot_20191104_092215.png

D25132: Use an eyedropper for color-picker icons

2019-11-03 Thread Nathaniel Graham
ngraham added a comment. Like this maybe? F7730326: Screenshot_20191103_154347.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25132: Use an eyedropper for color-picker icons

2019-11-03 Thread Nathaniel Graham
ngraham added a comment. I dunno, the alternative you've produced looks has a really chunky and unattractive tip to me, but I like some of the other elements. I could maybe square off the little protruding wings on the side though, and make the squeezey bit on the top part more straight. I

D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Nathaniel Graham
ngraham added a comment. In D25123#558205 , @ndavis wrote: > #vdg , Should we allow some types of icons to be vertically off center? If not that, should we allow some icons to not reach all the way to the

D25132: Use an eyedropper for color-picker icons

2019-11-03 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

2019-11-03 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The current icon is a black droplet which doesn't really communicate "pick a color from

D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Nathaniel Graham
ngraham added subscribers: hein, ngraham. ngraham added a comment. My vote is for A. I love it. It looks like a pull-down terminal just like the parent icon, re-uses the `>_` iconography common to our terminal icons, but adds a flair that makes the > look like a Y, conjuring up the app's

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-02 Thread Nathaniel Graham
ngraham added reviewers: ndavis, mart, alex-l. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc: broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24898: Add KLocalizedString::untranslatedText

2019-11-01 Thread Nathaniel Graham
ngraham added a comment. Makes sense to me. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid, ilic Cc: ngraham, apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

2019-11-01 Thread Nathaniel Graham
ngraham added a dependent revision: D11382: Add an option to show tabs from last time when Dolphin starts. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

2019-11-01 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: davidedmundson, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now session restoration logic only ever gets invoked when

D24621: [RFC] New Konsole and Yakuake icons

2019-10-31 Thread Nathaniel Graham
ngraham added a comment. In D24621#547787 , @ngraham wrote: > I really like the Yakuake icon that has a subtle "Y" in it. If everyone else does too, maybe that should be moved into a separate patch so we can get it in quickly and then

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

2019-10-31 Thread Nathaniel Graham
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R295:47f23c0f6ad1: Conditionally show navigation buttons in the header for multi-page KCMs (authored by ngraham).

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

2019-10-31 Thread Nathaniel Graham
ngraham added a comment. No regressions found and seems low-risk. Landing now to get it into 5.64 ahead of tagging on Nov 2nd. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25049 To: ngraham, #vdg, #plasma, mart Cc: GB_2, kde-frameworks-devel, LeGast00n,

T11950: Reduce the pain of working on monochrome Breeze icons

2019-10-31 Thread Nathaniel Graham
ngraham added a project: Frameworks. ngraham added a subscriber: Frameworks. TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham Cc: #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas,

D25067: Fix the header layouts for EntryDetails and Page components

2019-10-31 Thread Nathaniel Graham
ngraham added a comment. Now that's fixed on the main page but it's missing margins on the right side: F7702718: Screenshot_20191031_081429.png And it's still broken on details pages: F7702721: Screenshot_20191031_081517.png

D25084: Allow a Multiple instances to become Unique

2019-10-31 Thread Nathaniel Graham
ngraham added a comment. Put this on invent maybe? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D25084 To: tcanabrava Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-31 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25070: Make KCModuleQml conform to the defaulted() signal

2019-10-30 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham added a dependency: D25069: Adjust KCModule to also channel information about defaults. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25070 To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure Cc:

D25069: Adjust KCModule to also channel information about defaults

2019-10-30 Thread Nathaniel Graham
ngraham added a dependent revision: D25070: Make KCModuleQml conform to the defaulted() signal. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25069 To: ervin, #frameworks, #plasma, mart, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25067: Fix the header layouts for EntryDetails and Page components

2019-10-30 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Close, but not quite: F7695250: Screenshot_20191030_095130.png F7695252: Screenshot_20191030_095200.png

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

2019-10-29 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This makes the navigeability of multi-page KCMs completely obvious. The

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH ensure-changedentries-is-forwarded (branched from master) REVISION DETAIL https://phabricator.kde.org/D25041 To: leinir, #frameworks, #knewstuff, apol, ngraham Cc:

D24959: Add new preferences search icons

2019-10-29 Thread Nathaniel Graham
ngraham added a comment. Better now @trickyricky26? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D24959: Add new preferences search icons

2019-10-29 Thread Nathaniel Graham
ngraham added a comment. All of our other icons that consist of a white symbol in a blur circle have the shadow, so it's probably best to at least be consistent. If we decided we don't like the shadow, we should remove them from all of these icons at once. REPOSITORY R266 Breeze Icons

D25041: Ensure that the changedEntries property is correctly propagated

2019-10-29 Thread Nathaniel Graham
ngraham added a dependent revision: D24942: Require and use the new NewStuffQuick Button component. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25041 To: leinir, #frameworks, #knewstuff, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24958: Delete nepomuk icon

2019-10-29 Thread Nathaniel Graham
ngraham added a comment. Actually I guess it needs to. I'll fix the icon in Dolphin. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

2019-10-29 Thread Nathaniel Graham
ngraham added a comment. Gross, it even uses a pixmap rather than just using the icon directly. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

2019-10-28 Thread Nathaniel Graham
ngraham added a comment. If anything I wonder if we should make them bigger too, to better match the default Breeze shadows. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: ngraham, filipf, kde-frameworks-devel,

D24993: Add integrated inline spelling menu to KTextEdit

2019-10-27 Thread Nathaniel Graham
ngraham added a comment. Very nice! Could you attach a screenshot or a screen recording in the Test Plan section that shows what this is and how it works? it's nice to do this when you add #vdg as a reviewer since not all VDG people can test out

D24993: Add integrated inline spelling menu to KTextEdit

2019-10-27 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, cullmann, cfeck. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D24993 To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: [WIP]: Add Button to open the folder in filelight for more details

2019-10-27 Thread Nathaniel Graham
ngraham added a comment. Copy some other code that's already doing it this way I guess. For example, in plasma: https://cgit.kde.org/plasma-workspace.git/tree/libtaskmanager/tasktools.cpp#n767 If you don't already know about it, let me introduce you to the magic of LXR:

D24975: Change some 32px action icons to color style

2019-10-27 Thread Nathaniel Graham
ngraham added a comment. In D24975#554805 , @ndavis wrote: > I don't have time to do all 32px icons at once, but thankfully, they're usually only used in the desktop shell (I can put 32px monochrome icons in the desktop theme), or in

D24318: Make 32px document-save icon colorful

2019-10-27 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Abandoned in favor of D24975 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg, ndavis Cc: churaev, GB_2, ndavis, kde-frameworks-devel,

D24975: Change some 32px action icons to color style

2019-10-27 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. These look great to me. REPOSITORY R266 Breeze Icons BRANCH color32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg, ngraham Cc:

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

2019-10-26 Thread Nathaniel Graham
ngraham added a comment. In D24951#554516 , @dfaure wrote: > I'm not 100% sure that things jumping around while typing is a good idea though. That's exactly what already happens though, as the list of search narrows itself while you

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

2019-10-26 Thread Nathaniel Graham
ngraham added a comment. In D24951#554468 , @ahmadsamir wrote: > The user typing 'arc' then pressing Enter, and getting the file opened with wireshark is broken behaviour form the user's POV, that's the crux of the bug report in question.

D24593: Modified breeze shadows

2019-10-26 Thread Nathaniel Graham
ngraham added a comment. Still not working, sorry. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

2019-10-26 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D24951#554226 , @ahmadsamir wrote: > In D24951#554138 , @ngraham wrote: > > >

D24932: [WIP]: Add Button to open the folder in filelight for more details

2019-10-26 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. It doesn't compile: /home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:1389:72: error: ‘QString::QString(const char*)’ is private within this context 1389 |

D24957: Add new baloo icons

2019-10-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. REPOSITORY R266 Breeze Icons BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: kde-frameworks-devel,

D24959: Add new preferences search icons

2019-10-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. So after this, you'll change https://cgit.kde.org/systemsettings.git/tree/categories/settings-workspace-search.desktop#n7, right? REPOSITORY R266 Breeze Icons BRANCH

D24957: Add new baloo icons

2019-10-26 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham added a task: T7878: Create or find Icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

2019-10-26 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH deleteNepomuk REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: [WIP]: Add Button to open the folder in filelight for more details

2019-10-25 Thread Nathaniel Graham
ngraham added a comment. Much better, thanks. INLINE COMMENTS > kpropertiesdialog.cpp:1097 > + > +if (QStandardPaths::findExecutable(QStringLiteral("filelight")) != > QString()) { > +d->m_sizeDetailsButton = new QPushButton(i18n("Explore in > Filelight?"),

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

2019-10-25 Thread Nathaniel Graham
ngraham added a comment. Why wouldn't you want the first result chosen when there's more than one result? If you enter a search term and get (say) 2 results and the one you want to select is the first one, this patch would regress that, no? REPOSITORY R241 KIO REVISION DETAIL

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

2019-10-25 Thread Nathaniel Graham
ngraham added a comment. You're right that the code is quite convoluted. But it would seem to make sense to fix the value there rather than conditionally overriding it later. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24941 To: meven, ngraham, #frameworks Cc:

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

2019-10-25 Thread Nathaniel Graham
ngraham added a comment. Do we know why `d->oldname` is empty or `.` in the first place? Feels like maybe this should be fixed there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24941 To: meven, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24476: [KPropertiesDialog] Only show volume-related info for volumes

2019-10-25 Thread Nathaniel Graham
ngraham added a subscriber: Zren. ngraham added a comment. In D24476#553860 , @broulik wrote: > > Don't you already have the free space information in the status bar though? > > Isn't that supposed to be removed by default in that ominous

D24476: [KPropertiesDialog] Only show volume-related info for volumes

2019-10-25 Thread Nathaniel Graham
ngraham added a comment. Ping. #VDG opinions? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: [WIP]: Add Button to open the folder in filelight for more details

2019-10-24 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kpropertiesdialog.cpp:444 > { > -for (KPropertiesDialogPlugin *it : qAsConst(d->m_pageList)) { > +foreach (KPropertiesDialogPlugin *it,

D24909: [PC3/button] Elide text always

2019-10-24 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D24909 To: davidedmundson, #plasma, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

2019-10-24 Thread Nathaniel Graham
ngraham added a comment. Darn. :/ Is the problem only with years, or with other kinds of numbers too? Maybe we need a "don't localize this number" flag. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik, aacid

  1   2   3   4   5   6   7   8   9   10   >