D17816: Support for xattrs on kio copy/move

2020-10-29 Thread Nathaniel Graham
ngraham added a comment. Phabricator didn't actually close the revision after I landed it because @bruns forgot to change his status to accepted. You can close this now, @arrowd. Great work! REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns,

D17816: Support for xattrs on kio copy/move

2020-10-29 Thread Nathaniel Graham
ngraham added a comment. After almost two years, I'm so happy to see this land! REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann,

D17816: Support for xattrs on kio copy/move

2020-10-28 Thread Nathaniel Graham
ngraham added a comment. Can you change your status to approved? @dfaure, one final look maybe? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho,

D17816: Support for xattrs on kio copy/move

2020-10-18 Thread Nathaniel Graham
ngraham added a comment. @bruns? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham
ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx, dmenig, nikolaik, pberestov,

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham
ngraham added a comment. Yeah, that's weird. Let's throw it on the pile. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx,

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham
ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage,

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

2020-09-17 Thread Nathaniel Graham
ngraham abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, Orage, LeGast00n,

D28745: Skip caching thumbnails on encrypted filesystems

2020-08-29 Thread Nathaniel Graham
ngraham added a comment. @bruns and @meven? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx,

D17816: Support for xattrs on kio copy/move

2020-08-26 Thread Nathaniel Graham
ngraham added a comment. Good now, @bruns? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson,

D28745: Skip caching thumbnails on encrypted filesystems

2020-08-17 Thread Nathaniel Graham
ngraham added a subscriber: dfaure. ngraham added a comment. @dfaure, what do you think here? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: dfaure, thiago, bruns, meven, ngraham,

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2020-08-08 Thread Nathaniel Graham
ngraham added a task: T9795: Use Places Panel code from KIO instead of private implementation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26067 To: broulik, #frameworks, #vdg, #dolphin, elvisangelaccio Cc: elvisangelaccio, meven, ngraham, kde-frameworks-devel,

D7563: Add privilegeExecution field to file protocol description

2020-08-07 Thread Nathaniel Graham
ngraham added a comment. Oh and thanks for taking this over, @cblack. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865,

D7563: Add privilegeExecution field to file protocol description

2020-08-07 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > file_unix.cpp:1349 > +case ActionType::UTIME: return QStringLiteral("Authentication is > required to modify this file's last updated time."); > +case ActionType::UNKNOWN: return QStringLiteral("Authentication is > required to

D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

2020-08-02 Thread Nathaniel Graham
ngraham added a comment. I did too, but time marches on. :) You can Abandon this patch now. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D29872 To: enriquem, jgrulich Cc: ngraham, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D24895: [RFC] Drop implicit size from PC buttons

2020-07-29 Thread Nathaniel Graham
ngraham commandeered this revision. ngraham added a reviewer: nicolasfella. ngraham added a comment. Let's continue in https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/57. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895

D24895: [RFC] Drop implicit size from PC buttons

2020-07-29 Thread Nathaniel Graham
ngraham abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: ngraham, #plasma, mart, #vdg, davidedmundson, nicolasfella Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, cblack, michaelh, bruns

D20026: Go up in folder hierachy when in "edit mode"

2020-07-11 Thread Nathaniel Graham
ngraham added a comment. Great! Can you Abandon this? REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham, #dolphin Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D20026: Go up in folder hierachy when in "edit mode"

2020-07-11 Thread Nathaniel Graham
ngraham added a comment. Thanks for resuming the work on this! We've since moved to GitLab; could you open this up as a merge request at https://invent.kde.org/system/dolphin/-/merge_requests/? Thanks! REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham,

D27197: Add symbolic screenshot icons

2020-06-30 Thread Nathaniel Graham
ngraham added a comment. Thanks, that's better now. However the camera silhouette still doesn't match that of other monochrome camera images we have. I'd like to stick to standard iconography if possible. Do you think we should switch the other related icons to use your new camera icon, or

D17816: Support for xattrs on kio copy/move

2020-06-22 Thread Nathaniel Graham
ngraham added a comment. @bruns? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D24476: [KPropertiesDialog] Only show volume-related info for volumes

2020-06-13 Thread Nathaniel Graham
ngraham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik, ndavis Cc: pino, ndavis, Zren, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26898: expose an id for the wallpaper

2020-06-12 Thread Nathaniel Graham
ngraham added a task: T10495: wallpaper cache. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26898 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions

2020-06-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D29207 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-06-09 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29463 To: Zren, #kirigami, mart Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-06-08 Thread Nathaniel Graham
ngraham added a comment. The proposed additions to the spec are non-controversial IMO. Let's push that forward. I left a supportive comment in the email thread, so maybe it's time to put together a patch that people can comment on. REPOSITORY R241 KIO REVISION DETAIL

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-06-01 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson, anthonyfieroni Cc: ngraham, anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-06-01 Thread Nathaniel Graham
ngraham added a comment. Fair enough. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson, anthonyfieroni Cc: ngraham, anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-06-01 Thread Nathaniel Graham
ngraham added a comment. You might have more luck migrating this to https://invent.kde.org. https://community.kde.org/Infrastructure/GitLab REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: ngraham, anthonyfieroni,

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

2020-05-31 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D29774 To: meven, davidedmundson, zzag, #frameworks, #kwin, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-25 Thread Nathaniel Graham
ngraham added a comment. Here's where the spec lives, FWIW: https://gitlab.freedesktop.org/xdg/xdg-specs Expanding it is mostly just a matter of writing up a reasonable proposal in the form of a merge request and getting enough people to agree. Discussing on the mailing list first can

D29832: Fix Endianness issue during wallet decryption

2020-05-25 Thread Nathaniel Graham
ngraham added a reviewer: aacid. ngraham added a comment. Thanks for the patch! FWIW we have moved patch review to GitLab; consider abandoning this and re-submitting it as a merge request at https://invent.kde.org/frameworks/kwallet/-/merge_requests Here's some documentation:

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-25 Thread Nathaniel Graham
ngraham added a comment. The approach makes sense then. I agree that making high DPI a part of the FDO spec would be nice, but IMO that shouldn't block this. The approach currently taken is logical and it could be submitted as an extension to the spec later. INLINE COMMENTS > ngraham wrote

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. LGTM. @bruns? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure, ngraham Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29525: Make Previews devicePixelRatio aware

2020-05-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. (once the dependent patches have landed) REPOSITORY R318 Dolphin BRANCH arcpatch-D29525 REVISION DETAIL https://phabricator.kde.org/D29525 To: meven, #dolphin, #frameworks,

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-24 Thread Nathaniel Graham
ngraham added a comment. Overall seems sane. Two questions though: INLINE COMMENTS > previewjob.cpp:401 > +thumbPath = thumbRoot + QLatin1String(cacheWidth == 128 ? "normal" : > "large"); > +thumbPath.append(qFuzzyCompare(devicePixelRatio, 2) ? > QStringLiteral("@2x/") :

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-20 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma, ahiemstra Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29436: Use font: instead of font.pointSize: where possible

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29436 To: ngraham, #plasma, cblack Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. @ahiemstra #frameworks #plasma ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: ahiemstra,

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

2020-05-18 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29483 To: ngraham, #frameworks, #vdg, cfeck, cblack Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-18 Thread Nathaniel Graham
ngraham added a comment. Haha the "before" image is hilarious! INLINE COMMENTS > thumbnail.cpp:415 > +} else > +if ((image.size().height() > imageTargetSize.height()) && > (imageTargetSize.height() != 0)) { > +scaling = float(imageTargetSize.height()) / >

D29802: Require out-of-source builds

2020-05-17 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:7abe60d96609: Require in-source build (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29802?vs=83008=83021 REVISION DETAIL

D29802: Require out-of-source builds

2020-05-17 Thread Nathaniel Graham
ngraham added a comment. I think this patch meets the world record for number of acceptances! REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol,

D29802: Require out-of-source builds

2020-05-16 Thread Nathaniel Graham
ngraham retitled this revision from "Require in-source build" to "Require out-of-source builds". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack,

D29802: Require in-source build

2020-05-16 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY In addition to just being a good idea in general, the dynamic icon

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 82971. ngraham added a comment. Only open in System Settings or Info Center if systemsettings is installed REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29711?vs=82751=82971 BRANCH

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-15 Thread Nathaniel Graham
ngraham added a comment. In D29711#671616 , @mart wrote: > hmm, should probably check before whether systemsettings5 and kinfocenter exist beforehand and fallback to kcmshell if not? Yeah Christoph and Luigi brought that up too. Will do.

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-14 Thread Nathaniel Graham
ngraham added a comment. In D29711#670503 , @ltoscano wrote: > If the scope of this change is just about Plasma applet, of course systemsettings is going to be around. Yes the scope of this change is purely for Plasma applets; look at

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

2020-05-14 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29483 To: ngraham, #frameworks, #vdg, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

2020-05-14 Thread Nathaniel Graham
ngraham added a comment. @dfaure git bisect says this caused https://bugs.kde.org/show_bug.cgi?id=421213. After fixing, maybe we should get a test for that use case? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: ngraham,

D29739: Add 48px places icons

2020-05-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks fantastic to me. All good now, @ndavis? REPOSITORY R266 Breeze Icons BRANCH 48px-places (branched from master) REVISION DETAIL https://phabricator.kde.org/D29739 To:

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

2020-05-14 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29738 To: marten, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

2020-05-14 Thread Nathaniel Graham
ngraham added a comment. Nice work! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH dont-remain-pressed (branched from master) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma, ngraham Cc:

D29745: look for kded as runtime dep

2020-05-14 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R241 KIO BRANCH kded REVISION DETAIL https://phabricator.kde.org/D29745 To: sitter, dfaure, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

2020-05-14 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-13 Thread Nathaniel Graham
ngraham updated this revision to Diff 82786. ngraham marked an inline comment as done. ngraham added a comment. Address review comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29534?vs=82311=82786 BRANCH

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a comment. In D29711#670458 , @cfeck wrote: > Sorry if I don't understand the scope, but does this mean I am forced to install systemsettings to be able to use KCMs? Why, is the "I'm using Plasma but I don't have System

D29678: Fix incorrect colours in the KNS Quick messagebox

2020-05-13 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-colour-issue-for-messagebox (branched from master) REVISION DETAIL https://phabricator.kde.org/D29678 To: leinir, #frameworks, #knewstuff, #plasma, bugseforuns, ngraham

D29634: sftp: break large writes into multiple requests

2020-05-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Nice work. In D29634#670159 , @feverfew wrote: > I imagine something similar should be done for FileJob::write? Yeah. REPOSITORY R320 KIO Extras BRANCH release/20.04

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29716: [applet] Show KCM in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29715: [applet] Show KCM in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29714: [applets] Show KCMs in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29713: [applets] Show KCMs in System Settings. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29711 To: ngraham, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Many Plasma applets use `kcmshell.open` to open the appropriate KCM. However

D29678: Fix incorrect colours in the KNS Quick messagebox

2020-05-13 Thread Nathaniel Graham
ngraham added a comment. Does this even need to be a TextEdit? Or is that to get mouse-selectability for the error text? If so, +1 but please add comments indicating this reason. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29678 To: leinir, #frameworks,

T13144: Remove deprecated code from Kirigami example

2020-05-12 Thread Nathaniel Graham
ngraham closed this task as "Resolved". ngraham claimed this task. ngraham added a comment. Phabricator is used for task tracking, not bug reporting. Since this is a simple documentation fix, can you submit a patch? That would be lovely. :) TASK DETAIL https://phabricator.kde.org/T13144

D7563: Add privilegeExecution field to file protocol description

2020-05-12 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-05-12 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, chinmoyr Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel,

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-05-12 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, chinmoyr Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel,

D29680: Fix modified line marker in kate minimap

2020-05-12 Thread Nathaniel Graham
ngraham added a comment. Ah right, that's still here. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29680 To: davidedmundson, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, bruns, demsking, cullmann, sars,

D29680: Fix modified line marker in kate minimap

2020-05-12 Thread Nathaniel Graham
ngraham added a comment. Kate patches are at https://invent.kde.org/kde/kate/-/merge_requests, BTW. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29680 To: davidedmundson, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D27203: Don't try to open files we can't figure out where they are

2020-05-11 Thread Nathaniel Graham
ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=408174? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir Cc: ngraham, plasma-devel, Orage,

D27203: Don't try to open files we can't figure out where they are

2020-05-11 Thread Nathaniel Graham
ngraham added reviewers: meven, ahmadsamir. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27203: Don't try to open files we can't figure out where they are

2020-05-11 Thread Nathaniel Graham
ngraham added a reviewer: dfaure. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks, #plasma, dfaure Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D18883: Add PDF thumbnailer

2020-05-11 Thread Nathaniel Graham
ngraham added a comment. Yeah, seems like this got bikeshedded to death but I think it would still be quite worthwhile to have. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: meven, bruns, dhaumann, ngraham, pino,

D29511: Label: Add ping-pong logic

2020-05-10 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. Yeah, This should be a new component, or at most enabled by an off-by-default property. The default behavior should not change. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham added a comment. In D29534#666554 , @ndavis wrote: > I don't like the look of those +/- buttons. I think this makes it harder to know that you can drag the panel height up and down. That would be a comment for D29535

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham retitled this revision from "Implement wheel/touchpad scrolling for SpinBox control" to "Implement scroll and drag adjustment of values for SpinBox control". ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham added a task: T9460: Consider a more user-friendly SpinBox control. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 82311. ngraham added a comment. Implement click-and-drag (along both the X and Y axes) to modify the value REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29534?vs=82276=82311 BRANCH

D29536: Adds a missing LibreOffice icon shortcut

2020-05-08 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fixlo16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D29536 To: manueljlin, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 82276. ngraham marked 4 inline comments as done. ngraham added a comment. More control, less parseInt REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29534?vs=82274=82276 BRANCH

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 82274. ngraham added a comment. Mark the value has having been modified after adjusting by scrolling REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29534?vs=82273=82274 BRANCH

D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Currently adjusting the value by scrolling is not implemented. This patch

D29513: [kcm trash] Change kcm trash size percent to 2 decimal places

2020-05-07 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH trash REVISION DETAIL https://phabricator.kde.org/D29513 To: shubham, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-05-07 Thread Nathaniel Graham
ngraham added a comment. I like #2 the best! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29503: Pixel align children of GridViewInternal

2020-05-07 Thread Nathaniel Graham
ngraham added a comment. I can't reproduce it, but I wonder if this could fix or help https://bugs.kde.org/show_bug.cgi?id=417488? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29503 To: fvogt, #frameworks, broulik, mart, davidedmundson Cc: ngraham,

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-07 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R304 KNewStuff BRANCH arcpatch-D29123_1 REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R135:f9f3f6ca260a: Use Standard Show/Hide Hidden files shortcuts in directory chooser dialog (authored by ngraham). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-06 Thread Nathaniel Graham
ngraham added a comment. In D29485#664977 , @ahmadsamir wrote: > I couldn't seem to test the m_privilegeExecutionEnabled stuff, i.e. using dolphin, the paste action is disabled if the dir isn't owned by me. See D7563

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

2020-05-06 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D29238 To: ngraham, #plasma, #frameworks Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D29434: Use small font for ExpandableListItem subtitle

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R242:416f82f8f7f5: Use small font for ExpandableListItem subtitle (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

2020-05-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 82102. ngraham added a comment. Spell "oddities" correctly REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29483?vs=82101=82102 BRANCH

  1   2   3   4   5   6   7   8   9   10   >