D25139: LaTeX: fix backslash delimiter in some keywords

2019-11-04 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25139 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking,

D25139: LaTeX: fix backslash delimiter in some keywords

2019-11-04 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH latex-keys-del REVISION DETAIL https://phabricator.kde.org/D25139 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D25139: LaTeX: fix backslash delimiter in some keywords

2019-11-04 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25139 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham,

D25139: LaTeX: fix backslash delimiter in some keywords

2019-11-04 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, jpoelen. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 413493

D25102: VHDL: all keywords are insensitive

2019-11-01 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25102 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D24983: KateModeMenuList: improve word wrap

2019-11-01 Thread Nibaldo González
nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24983 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25102: VHDL: all keywords are insensitive

2019-11-01 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 413409 In the

D24983: KateModeMenuList: improve word wrap

2019-11-01 Thread Nibaldo González
nibags updated this revision to Diff 69150. nibags added a comment. - Increase the menu size according to the font size, to improve the display This achieves a better visualization if the user increases the font size in the Plasma preferences. REPOSITORY R39 KTextEditor CHANGES SINCE

D24983: KateModeMenuList: improve word wrap

2019-10-29 Thread Nibaldo González
nibags updated this revision to Diff 69022. nibags added a comment. - Increase margin of list - search bar in Windows REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24983?vs=69005=69022 BRANCH improve-word-wrap REVISION DETAIL

D24983: KateModeMenuList: improve word wrap

2019-10-29 Thread Nibaldo González
nibags updated this revision to Diff 69005. nibags added a comment. - Restore scroll bar margins REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24983?vs=68974=69005 BRANCH improve-word-wrap REVISION DETAIL https://phabricator.kde.org/D24983

D24983: KateModeMenuList: improve word wrap

2019-10-29 Thread Nibaldo González
nibags updated this revision to Diff 68974. nibags added a comment. - Fix font size/style REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24983?vs=68828=68974 BRANCH improve-word-wrap REVISION DETAIL https://phabricator.kde.org/D24983 AFFECTED

D24982: Small improvements in some XML files

2019-10-28 Thread Nibaldo González
nibags added a comment. No, the dynamic flag is used to insert the captures already stored in `%N` (the captures are stored in the RegExpr rules and then "inserted" in the rules with the dynamic flag) REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24981: Modelines: fix end of comment

2019-10-28 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes. Closed by commit R216:73489a79f9fd: Modelines: fix end of comment (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24981?vs=68820=68870 REVISION DETAIL

D24983: KateModeMenuList: improve word wrap

2019-10-28 Thread Nibaldo González
nibags added a comment. `QFontMetrics::boundingRect(text).width()` doesn't deliver an exact value of the text width, since I detected that in some translations and some desktop themes the text goes below the scroll bar. This problem doesn't exist with

D24982: Small improvements in some XML files

2019-10-28 Thread Nibaldo González
nibags added a comment. I had also thought about using `QRegularExpression::DontCaptureOption`, which is equivalent to using `(?:...)`, but I wasn't sure how much the real improvement in performance is. However, disabling captures avoids allocating unnecessary QString for each capture.

D24983: KateModeMenuList: improve word wrap

2019-10-27 Thread Nibaldo González
nibags updated this revision to Diff 68828. nibags added a comment. - Fixes REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24983?vs=68827=68828 BRANCH improve-word-wrap REVISION DETAIL https://phabricator.kde.org/D24983 AFFECTED FILES

D24983: KateModeMenuList: improve word wrap

2019-10-27 Thread Nibaldo González
nibags created this revision. nibags added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY - Use `QFontMetrics::horizontalAdvance(text)`

D24982: Small improvements in some XML files

2019-10-27 Thread Nibaldo González
nibags updated this revision to Diff 68824. nibags added a comment. - Increase version of javascript.xml REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24982?vs=68823=68824 BRANCH improve-some-xml REVISION DETAIL

D24982: Small improvements in some XML files

2019-10-27 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY **Changes:** - Replace

D24981: Modelines: fix end of comment

2019-10-27 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Use `fallthroughContext` to

D24355: TypeScript: update grammar and fixes

2019-10-10 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c6f2bd8ba96d: TypeScript: update grammar and fixes (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24355?vs=67588=67624 REVISION

D24357: KateModeMenuList: force the vertical position above the button

2019-10-10 Thread Nibaldo González
nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24357 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D24355: TypeScript: update grammar and fixes

2019-10-09 Thread Nibaldo González
nibags updated this revision to Diff 67588. nibags added a comment. - TypeScript React: fix end-line regex REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24355?vs=67587=67588 BRANCH update-typescript REVISION DETAIL

D24355: TypeScript: update grammar and fixes

2019-10-09 Thread Nibaldo González
nibags updated this revision to Diff 67587. nibags added a comment. typescript-react: increase version. javascript: use non-capturing groups in RegExpr REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24355?vs=67162=67587 BRANCH

D24355: TypeScript: update grammar and fixes

2019-10-09 Thread Nibaldo González
nibags added a comment. ups! i will correct it REPOSITORY R216 Syntax Highlighting BRANCH update-typescript REVISION DETAIL https://phabricator.kde.org/D24355 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D24354: Mustache/Handlebars: minor fixes

2019-10-04 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D24354: Mustache/Handlebars: minor fixes

2019-10-03 Thread Nibaldo González
nibags added a comment. As the delimiters in WordDetect rules were changed in D24378 , I updated this diff only by making minor fixes in the Mustache/Handlebars definition. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24354: Mustache/Handlebars: minor fixes

2019-10-03 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D24354: Mustache/Handlebars: minor fixes

2019-10-03 Thread Nibaldo González
nibags retitled this revision from "Mustache/Handlebars: fix delimiters in HTML tags" to "Mustache/Handlebars: minor fixes". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc:

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-03 Thread Nibaldo González
nibags updated this revision to Diff 67297. nibags added a comment. Minor corrections: - Restore WordDetect rules - Use **kateversion="5.44"** (WordDetect with insensitive). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D24378: WordDetect rule: detect delimiters at the inner edge of the string

2019-10-03 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24378 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D24378: WordDetect rule: detect delimiters at the inner edge of the string

2019-10-03 Thread Nibaldo González
nibags updated this revision to Diff 67238. nibags added a comment. - Add comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24378?vs=67237=67238 BRANCH fix-worddetect REVISION DETAIL https://phabricator.kde.org/D24378 AFFECTED FILES

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-03 Thread Nibaldo González
nibags added a comment. i did it in: D24378 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D24378: WordDetect rule: detect delimiters at the inner edge of the string

2019-10-03 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, vkrause, jpoelen. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Nibaldo González
nibags added a comment. I think it makes sense to change this in WorDetect: verify delimiter characters on the left and right edge of the string, either inside or outside the string. I will make another diff with this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Nibaldo González
nibags added a comment. Indeed, WordDetect checks only the boundaries. What happens is that when using WordDetect with `". It's correct to use RegExpr with `https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D24357: KateModeMenuList: force the vertical position above the button

2019-10-02 Thread Nibaldo González
nibags created this revision. nibags added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Always display the menu above the trigger

D24355: TypeScript: update grammar and fixes

2019-10-01 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY TypeScript: - Add

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-01 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Using `WordDetect` rules

D24210: KadeModeMenuList: fix memory leaks and others

2019-09-29 Thread Nibaldo González
nibags updated this revision to Diff 67026. nibags added a comment. - Fix allocation in search names REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24210?vs=66864=67026 BRANCH fix-mode-menu REVISION DETAIL https://phabricator.kde.org/D24210

D24210: KadeModeMenuList: fix memory leaks and others

2019-09-25 Thread Nibaldo González
nibags added a comment. `m_searchName` is a pointer to an attribute of a KateFileType object (which may be the string `translatedName` or `name`), but in some cases a new string is created. I added the boolean `m_bHasNewSearchName` that is true when a new QString is created for search.

D24210: KadeModeMenuList: fix memory leaks and others

2019-09-25 Thread Nibaldo González
nibags updated this revision to Diff 66864. nibags added a comment. - Update - Add boolean `m_bHasNewSearchName` to verify removal of `m_searchName`. - Correct format in some comments. - Remove `friend KateModeMenuList` and replace it with the "Factory" class. REPOSITORY R39

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

2019-09-25 Thread Nibaldo González
nibags updated this revision to Diff 66863. nibags added a comment. - Undo changes in Mustache REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24211?vs=66799=66863 BRANCH add-syntax-srt REVISION DETAIL https://phabricator.kde.org/D24211

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

2019-09-25 Thread Nibaldo González
nibags added a comment. Sorry, that could go in another diff. In the definition of Mustashe, I realized that using WordDetect requires a delimiter before `` doesn't match the WordDetect rule, so I changed it to RegExpr. In HTML, I only put the Tags in a different context to make it

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

2019-09-25 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Add highlighting for the

D24210: KadeModeMenuList: fix memory leaks and others

2019-09-25 Thread Nibaldo González
nibags created this revision. nibags added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY - Remove strings `m_searchName` in the

D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared

2019-09-23 Thread Nibaldo González
nibags added a comment. In the function `KateModeMenuList::updateSelectedItem()` an empty QIcon is also created when selecting an item. It would be better to put `emptyIcon` as an attribute of the class and use it every time. I will do it in another commit, I have seen others bugs in

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

2019-09-14 Thread Nibaldo González
nibags marked an inline comment as done. nibags added inline comments. INLINE COMMENTS > dhaumann wrote in katemodemenulist.cpp:175 > QStringLiteral("") us discouraged and should simply be QString(). Fixed in 3aa9c13f5a8b

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

2019-09-14 Thread Nibaldo González
nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23935 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

2019-09-14 Thread Nibaldo González
nibags edited the summary of this revision. nibags added reviewers: KTextEditor, cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23935 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

2019-09-14 Thread Nibaldo González
nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R39 KTextEditor BRANCH modemenu-search REVISION DETAIL https://phabricator.kde.org/D23935 AFFECTED

D23691: C & ISO C++: add digraphs (folding & preprocessor)

2019-09-03 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23691 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D23691: C & ISO C++: add digraphs (folding & preprocessor)

2019-09-03 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 411508 1. ISO C

D23688: Allow to customize attributes for KSyntaxHighligting themes

2019-09-02 Thread Nibaldo González
nibags retitled this revision from "Allow customizing theme attributes in KSyntaxHighligting themes" to "Allow to customize attributes for KSyntaxHighligting themes". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23688 To: nibags, #ktexteditor, dhaumann, cullmann

D23688: Allow customizing theme attributes in KSyntaxHighligting themes

2019-09-02 Thread Nibaldo González
nibags created this revision. nibags added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY The diff D23516

D23657: Markdown, TypeScript & Logcat: some fixes

2019-09-02 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23657 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D23657: Markdown, TypeScript & Logcat: some fixes

2019-09-01 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY **Markdown:** - Fix

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

2019-08-30 Thread Nibaldo González
nibags updated this revision to Diff 65018. nibags added a comment. - Update function names REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23516?vs=64780=65018 BRANCH turnoff-attr REVISION DETAIL https://phabricator.kde.org/D23516 AFFECTED FILES

D23515: Format class: add functions to know if XML files set style attributes

2019-08-30 Thread Nibaldo González
nibags updated this revision to Diff 65017. nibags added a comment. - Update function names REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23515?vs=64779=65017 BRANCH format-new-functions REVISION DETAIL https://phabricator.kde.org/D23515

D23515: Format class: add functions to know if XML files set style attributes

2019-08-30 Thread Nibaldo González
nibags added a comment. I also like `hasXXOverride()`. In the case of **bold**, **italic**, **underline** and **strikeout**, functions such as `hasXXOverride()` are needed, since they are boolean values that can be turned off. But for the case **color**, **selectedColor**,

D23515: Format class: add functions to know if XML files set style attributes

2019-08-27 Thread Nibaldo González
nibags added a dependent revision: D23516: Fix for all themes: allow turn off attributes in XML highlighting files. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc:

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

2019-08-27 Thread Nibaldo González
nibags created this revision. nibags added reviewers: KTextEditor, cullmann, vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Depends on D23515

D23515: Format class: add functions to know if XML files set style attributes

2019-08-27 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY The functions

D23422: Fix: allow turn off attributes in XML highlighting files

2019-08-25 Thread Nibaldo González
nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23422 To: nibags, #ktexteditor, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23422: Fix: allow turn off attributes in XML highlighting files

2019-08-25 Thread Nibaldo González
nibags added a comment. Yes, it has to do with that bug. Later I will add the functions to the KSyntaxHighlighting API to correct this. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D23422 To: nibags, #ktexteditor, dhaumann, cullmann Cc:

D23422: Fix: allow turn off attributes in XML highlighting files

2019-08-25 Thread Nibaldo González
nibags created this revision. nibags added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In syntax highlighting XML files, it doesn't

D23371: Markdown: multiple improvements and fixes

2019-08-24 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23371 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann,

D23371: Markdown: multiple improvements and fixes

2019-08-24 Thread Nibaldo González
nibags updated this revision to Diff 64463. nibags added a comment. - Fix bug in blockquotes and improve integration with R Markdown REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23371?vs=64395=64463 BRANCH improve-markdown REVISION DETAIL

D23371: Markdown: multiple improvements and fixes

2019-08-23 Thread Nibaldo González
nibags edited the summary of this revision. nibags added reviewers: cullmann, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23371 To: nibags, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham,

D23371: Markdown: multiple improvements and fixes

2019-08-23 Thread Nibaldo González
nibags added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23371 To: nibags, cullmann, dhaumann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham,

D23371: Markdown: multiple improvements and fixes

2019-08-23 Thread Nibaldo González
nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH improve-markdown REVISION DETAIL https://phabricator.kde.org/D23371

D23272: JavaScript: remove unnecessary "Conditional Expression" context

2019-08-20 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes. Closed by commit R216:4bc333ee2509: JavaScript: remove unnecessary Conditional Expression context (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23272: JavaScript: remove unnecessary "Conditional Expression" context

2019-08-19 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY The "Conditional

D23034: implicit fallthough if there is fallthoughContext

2019-08-09 Thread Nibaldo González
nibags added a comment. I think it's an improvement, but the ideal would be to maintain support for `fallthrough="bool"`. That is, if the `fallthroughContext` attribute is present, assume `fallthrough="true"`, unless "fallthrough=" is explicitly written. What I don't agree with is

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-08 Thread Nibaldo González
nibags added a comment. There are many improvements to the Latex highlighter! Recently I marked bugs 274440, 322081 and others as duplicates (in fact, this patch fixes them well) REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL

D22848: Rust: add missing keywords and minor improvements

2019-08-01 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22848 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns,

D22848: Rust: add missing keywords and minor improvements

2019-07-31 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY **Changes:** - Add new

D22567: TypeScript: fix keywords in conditional expressions

2019-07-20 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22567 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking,

D22568: Fix generator and test paths of CMake

2019-07-20 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0b7e23a81a94: Fix generator and test paths of CMake (authored by nibags). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22568?vs=62078=62146#toc REPOSITORY R216 Syntax Highlighting

D22567: TypeScript: fix keywords in conditional expressions

2019-07-19 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Now, keywords are

D22568: Fix generator and test paths of CMake

2019-07-19 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In D22095

D21713: Fortran: implement free & fixed formats

2019-07-06 Thread Nibaldo González
nibags added a comment. The files are re-licensed to MIT at: 9c5875af2713 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting,

D22253: Improve the Fortran fixed format syntax highlighting

2019-07-06 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22253 To: nononux, nibags Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22253: Improve the Fortran fixed format syntax highlighting

2019-07-06 Thread Nibaldo González
nibags accepted this revision. nibags added a comment. This revision is now accepted and ready to land. That is complicated to do, we would have to make rules for all the columns before 72 and for all the possible matchings, which is a lot of work and would make the code difficult to

D22253: Improve the Fortran fixed format syntax highlighting

2019-07-04 Thread Nibaldo González
nibags added a comment. Now I checked the patch well and I want to add some final recommendations before merging. I think it's okay. INLINE COMMENTS > fortran-fixed.xml:368 > > > > I recommend moving lines 374 and 375 (`` and ``) to the beginning of the

D21713: Fortran: implement free & fixed formats

2019-07-03 Thread Nibaldo González
nibags added inline comments. INLINE COMMENTS > dhaumann wrote in fortran-free.xml:3 > Is it correct that include keywords was added with 5.53? Include keywords was added in KF5.52, but the implementation had a bug that was fixed in KF5.53. So far, the files that use this (SCSS and TypeScript)

D21713: Fortran: implement free & fixed formats

2019-07-03 Thread Nibaldo González
nibags added a comment. Franchin Matteo & Janus Weil responded and agree to the MIT license. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: nononux, kwrite-devel,

D22253: Improve the Fortran fixed format syntax highlighting

2019-07-03 Thread Nibaldo González
nibags added a comment. Only a small detail needs to be added. You also have to increase the version of the file. INLINE COMMENTS > fortran-fixed.xml:557 > firstNonSpace="true"/> > column="0"/> > Here add the rule: `` In the previous fortran.xml file it was

D21713: Fortran: implement free & fixed formats

2019-07-02 Thread Nibaldo González
nibags added a comment. > Is there any progress with the licensing? > Otherwise I assume LGPL would be good enough, if a change isn't possible. Sorry, I forgot to ask the authors (Franchin Matteo & Janus Weil) about the license change to MIT. Now I send an email to them asking. When I

D21960: AppArmor: update syntax

2019-06-23 Thread Nibaldo González
nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21960 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D21960: AppArmor: update syntax

2019-06-21 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Changes: - Add new

D21712: KateModeMenuList: move to QListView

2019-06-15 Thread Nibaldo González
nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21712 To: nibags, #ktexteditor, cullmann, dhaumann Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D21711: Julia: update syntax and add constants keywords

2019-06-15 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c91c2554215d: Julia: update syntax and add constants keywords (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21711?vs=59476=59854

D21712: KateModeMenuList: move to QListView

2019-06-12 Thread Nibaldo González
nibags updated this revision to Diff 59631. nibags added a comment. - Update tooltip of search bar REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21712?vs=59577=59631 BRANCH move-qlistview REVISION DETAIL https://phabricator.kde.org/D21712

D21712: KateModeMenuList: move to QListView

2019-06-11 Thread Nibaldo González
nibags updated this revision to Diff 59577. nibags added a comment. - Correct code style Remove `this->` and `return` at the end of void functions. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21712?vs=59480=59577 BRANCH move-qlistview

D21713: Fortran: implement free & fixed formats

2019-06-10 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking,

D21713: Fortran: implement free & fixed formats

2019-06-10 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY FEATURE: 372950 REPOSITORY

D20958: New menu of syntax highlighting in the status bar

2019-06-10 Thread Nibaldo González
nibags marked 2 inline comments as done. nibags added a comment. I changed QListWidget by QListView in D21712 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann Cc:

D21712: KateModeMenuList: move to QListView

2019-06-10 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21712 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21712: KateModeMenuList: move to QListView

2019-06-10 Thread Nibaldo González
nibags created this revision. nibags added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY The new Mode menu introduced in D20958

  1   2   3   4   >