Re: KDE review for KWeatherCore

2020-12-21 Thread Nicolas Fella



On 12/21/20 3:19 PM, Friedrich W. H. Kossebau wrote:

Am Montag, 21. Dezember 2020, 07:16:09 CET schrieb hanyoung:

KWeatherCore: https://invent.kde.org/libraries/kweathercore is a library for
querying weather forecast data. During the development of KWeather, we
found the need to have a weather library. KWeatherCore is the result of
extracting weather data fetching code from KWeather. I think having a
dedicated weather library can serve the following propose: - simplify the
KWeather code
- easier to develop a weather daemon
- potentially less code duplication across KDE

Many of you may have already seen my previous email to kde-devel mailing
list.
Thank you for your constructive suggestions. Here are something I want to

clarify:

I would also propose to consider doing a demon instead, so different
programs/processes all interested in weather forecast data could share the
data

   The end goal is a daemon indeed, but we want to build the daemon upon the
library. This would give us flexibility in the future if we don't want a
daemon. At least KWeather and other projects can still benefit from the
code.

My idea/proposal there is that the library internally makes use of that demon.
So code which uses KWeatherCore does not need to know that implementation-wise
there is a demon (which might also need to be a build-time option, think app
bundles who do not like separate demon processes).
So the demon would not use KWeatherCore, but be a(n optional) backend part of
it.


Please keep in mind that having such a daemon would be challenging to
impossible to implement on Android and possibly other platforms as well.

Let's not overengineer the wheel without having to and focus on use
cases relevant for our current apps and less on hypothetical use cases.

Cheers

Nico



D22544: [RFC] Deprecate KPassivePopup

2020-12-07 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22544

To: nicolasfella, #frameworks, broulik
Cc: ngraham, davidedmundson, aspotashev, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, bruns


D22093: Don't show progress window for jobs that don't report progress

2020-12-06 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22093

To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D23835: Add TabKCM

2020-12-06 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: broulik, onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


Re: Would distributions have an issue if KF 5.77+ would require Qt >= 5.14 (instead of >= 5.13 as of now)?

2020-12-01 Thread Nicolas Fella

Hi,

with my KDE Android hat on this would be fine, we use Qt 5.15. For KDE's
own Windows/Mac builds I'd expect it to be similar.

What most/all not-traditional-Linux-distro users have in common is that
they are not bound to the specific Qt version decided and shipped by a
vendor and instead either build themselves or download official binaries.

The two major "distributions" that are potential frameworks users but
can't because of Qt versions (SailfishOS and Ubuntu Touch) don't ship
5.13 either, so it doesn't make the problem worse.

Cheers

Nico


On 12/1/20 1:29 PM, Jonathan Riddell wrote:

Not from KDE neon of course, we're on 5.15.  And not from the KDE
snaps build either.  But I suppose there's more than just Linux
distros to consider as we ship apps using KDE frameworks on Flatpak,
Android, Windows, even Mac to ponder too.

Jonathan


On Tue, 1 Dec 2020 at 12:14, Friedrich W. H. Kossebau
mailto:kosse...@kde.org>> wrote:

Hi,

last week KDE Frameworks master saw a bump in the
required/expected minimal Qt
version to Qt 5.13, following rules once agreed and noted here:
https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements


I would like to challenge that former decision though and propose
to instead
go straight to Qt 5.14 as minimum requirement now.


QUESTION:
Would any of the distributions have an issue with requiring Qt
5.14 instead of
Qt 5.13?


From some quick checks using https://repology.org/
 it seems that any
distribution versions which currently use Qt 5.13 have also
settled on some
older KF version, so will not update to just KF 5.77 and thus be
screwed.

Motivation:
* KDE CI not setup ATM to cover builds with Qt 5.13 (no build, no
unit tests)
* Qt 5.14 added some new API, chance to miss out when using that
in new code
* C++: no need to write #if QT_VERSION < QT_VERSION_CHECK(5, 14,
0) variants
* QML: no need to do hard-to-read generation tricks to support <
Qt 5.14
* Qt 5.13 went out-of-support in June
* App bundle builders would rather use some recent Qt 5.14/5.15

So by restraining to Qt 5.13 as minimum version IMHO we would
make/keep life
complicated for KF contributors without adding any value for anyone.

With most of KDE Frameworks in my local checkout:
    grep "QT_VERSION_CHECK(5, 14, 0)"  frameworks/*/src -r
2>/dev/null | \
        grep "QT_VERSION " | wc -l
gives me "92", so there are quite some code variants which need
support in
current code.

From the emails at least in
https://mail.kde.org/pipermail/kde-frameworks-devel/2020-July/112712.html

I could not see a discussion whether Qt 5.13 makes
sense at all now, seems mainly the algorithm was applied. I
propose to match
the result to known real world needs now. Or teach me what I have
missed here
:)

Cheers
Friedrich




PSA: Frameworks depends on Qt 5.13 now

2020-11-26 Thread Nicolas Fella

Hi,

per our Qt dependency policy [0] Frameworks depends on Qt 5.13 6 months
after the release of Qt 5.15, which is now.

Have fun with the new stuff.

Nico

[0] https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements



D24443: Add a plugin system

2020-11-18 Thread Nicolas Fella
nicolasfella abandoned this revision.
nicolasfella added a comment.


  Moving to invent: 
https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/20

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dvasin, rodsevich, winterz, cgiboudeaux, mlaurent, 
knauss


D28834: Add metadata properties to calendar

2020-11-18 Thread Nicolas Fella
nicolasfella abandoned this revision.
nicolasfella added a comment.


  moving to invent: 
https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/19

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz
Cc: winterz, kde-pim, fbampaloukas, dvasin, rodsevich, cgiboudeaux, vkrause, 
mlaurent, knauss, dvratil


D29020: Add example/test application

2020-11-02 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29020

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29391: Introduce setWindow and CloseWhenWindowActivated

2020-11-02 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29391

To: nicolasfella, #frameworks, broulik
Cc: anthonyfieroni, kossebau, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


Re: Stepping down as KRunner maintainer

2020-10-08 Thread Nicolas Fella

Thanks for all your work Kai and congratulations Alexander, this is well
deserved!

Cheers

Nico

On 08.10.20 19:17, Kai Uwe Broulik wrote:

Hi everyone,

you might not even have known this but officially I have been KRunner's 
maintainer for several years at this point :-)

However, I have decided to step down as its maintainer as I believe won't be 
able to really move KRunner forward for KF6 despite a grand vision [1] for a 
lack of time and, frankly, motivation.

Therefore, I'd like to pass the torch to Alexander Lohnau. He's bringing many 
fresh ideas to the table and is very enthusiastic about making KRunner shine 
again. He's also surely done more in the past months than I did in the past 
years and so it's only fair to not have his ambitions hindered by my 
unresponsiveness on code reviews.

Alexander, thank you again for hosting that KRunner BoF at your first ever 
Akademy - the stage is yours ;-)

Cheers
Kai Uwe

[1] https://phabricator.kde.org/T12031


D25705: Deprecate KIO::pixmapForUrl

2020-09-20 Thread Nicolas Fella
nicolasfella abandoned this revision.
nicolasfella added a comment.


  Moved to https://invent.kde.org/frameworks/kio/-/merge_requests/144

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25705

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

2020-08-31 Thread Nicolas Fella
nicolasfella added a subtask: T13555: Create replacement for 
KPluginInfo::kcmServices.

TASK DETAIL
  https://phabricator.kde.org/T12173

To: nicolasfella
Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ekasprzak, 
ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato, cfeck, 
cgiboudeaux, cullmann, vkrause, cordlandwehr, knauss


D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-17 Thread Nicolas Fella
nicolasfella closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-13 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83348.
nicolasfella added a comment.


  - Use menus font metric

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26448?vs=83346=83348

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

AFFECTED FILES
  src/CMakeLists.txt
  src/krecentfilesmenu.cpp
  src/krecentfilesmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-11 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83346.
nicolasfella added a comment.


  - Use widgets font metrics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26448?vs=83338=83346

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

AFFECTED FILES
  src/CMakeLists.txt
  src/krecentfilesmenu.cpp
  src/krecentfilesmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-03 Thread Nicolas Fella
nicolasfella marked an inline comment as done.
nicolasfella added inline comments.

INLINE COMMENTS

> dfaure wrote in krecentfilesmenu.cpp:150
> Depending on QtConcurrent is just fine. However QtConcurrent::filtered is for 
> CPU-intensive operations, not for I/O operations. 1) you don't want to put 
> blocking runnables in the global thread pool [can be solved by assigning to a 
> different threadpool], 2) I don't think you really want to parallelize 16 
> calls to QFile::exists, for the case of a local physical harddisk? Not sure 
> it would really harm (we're not reading 16 files, at least), but for sure the 
> overhead of dispatching runnables to 16 threads would make it slower... One 
> solution here might be just a dedicated thread iterating over the list.
> 
> However: note that the usual KIO way to do file operations async isn't 
> multithreading, it's rather KIO jobs.
> This would move the "5 minutes waiting for an NFS server" horror case into a 
> kioslave rather than a thread, both achieve the desired outcome which is to 
> not block the GUI thread.
> 
> Keeping the order of the entries is going to be interesting. I guess we need 
> a temporary data structure which stores "exists | does not exist" for each 
> entry, and once all jobs are done, we go through that and fill the menu. Note 
> that remote URLs should just be assumed to exist, we don't want to actually 
> check (slow; might prompt for password; might error on different networks; 
> etc.).
> 
> Unlike Kai-Uwe, I think this should be a separate merge request though, it's 
> all quite orthogonal to your work. As long as you confirm that filling the 
> menu "later" has no negative impact on the API (i.e. the user of the class 
> cannot assume that the menu is filled in immediately).

> As long as you confirm that filling the menu "later" has no negative impact 
> on the API (i.e. the user of the class cannot assume that the menu is filled 
> in immediately).

Should be fine

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-03 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83338.
nicolasfella marked an inline comment as done.
nicolasfella added a comment.


  - Fix @since
  - Add underscore to filename
  - Reserve vector

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26448?vs=83337=83338

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

AFFECTED FILES
  src/CMakeLists.txt
  src/krecentfilesmenu.cpp
  src/krecentfilesmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-03 Thread Nicolas Fella
nicolasfella marked 6 inline comments as done.

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-03 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83337.
nicolasfella marked an inline comment as done.
nicolasfella added a comment.


  - Make findEntry return non-const iterator
  - Use std::vector
  - Truncate entries when setting maximum

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26448?vs=73172=83337

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

AFFECTED FILES
  src/CMakeLists.txt
  src/krecentfilesmenu.cpp
  src/krecentfilesmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-07-28 Thread Nicolas Fella
nicolasfella added inline comments.

INLINE COMMENTS

> broulik wrote in krecentfilesmenu.cpp:150
> If we're rewriting this thing anyway, can we please make sure it does not 
> block application startup checking if those files exist, as can happen if you 
> had opened files on an NFS mount before.
> 
> Either do it only when the menu is opened (aboutToShow) and/or asynchronously.

I'm wondering how to best make this async without selling my soul to the 
mulitthreading devil. QtConcurrent::filtered looks interesting, but depending 
on QtConcurrent wouldn't be feasible, would it?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


Frameworks support for Qt 5.12

2020-07-15 Thread Nicolas Fella

Hi,

I received a question on how long KF5 will continue to support Qt 5.12.

Given that 5.12 is an LTS release according to our policy it would be
supported "until the next Qt release after the next Qt release", which
would be 5.16, which will never exist.

Our policy states "With Qt6 this changes a little bit again. To avoid
supporting 5.12 LTS and 5.15 LTS for ever, 5.15 LTS will be the minimum
required version 18 months after its release.". This however does not
answer what will happen with 5.12.

If I remember correctly our intention when formalizing this was to
extrapolate the hypothetical releases and apply the existing rules to
it. This would mean that by the time Qt 5.16 would be released (6 months
after Qt 5.15) KF5 would drop support for Qt 5.12 and require 5.13.

Is my interpretation of this correct? If so the wiki page should be
updated with this information.

Cheers

Nico




D29020: Add example/test application

2020-07-02 Thread Nicolas Fella
nicolasfella added a comment.


  Ping?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29020

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D26918: Improve KNotification API docs

2020-07-02 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83322.
nicolasfella marked 8 inline comments as done.
nicolasfella added a comment.


  - Address comments

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26918?vs=78423=83322

BRANCH
  arcpatch-D26918

REVISION DETAIL
  https://phabricator.kde.org/D26918

AFFECTED FILES
  Mainpage.dox
  docs/Doxyfile.local
  src/knotification.h

To: nicolasfella, #frameworks, broulik, jucato, cblack
Cc: cblack, class, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns


D29390: Respect QIcon::fallbackSearchpaths()

2020-06-13 Thread Nicolas Fella
nicolasfella closed this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29390

To: nicolasfella, #plasma, #frameworks, mart
Cc: mart, kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29358: Implement lock-screen visibility control on Android

2020-05-22 Thread Nicolas Fella
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29358

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D25551: Mark KXmlRpcClient as porting aid

2020-05-21 Thread Nicolas Fella
nicolasfella closed this revision.

REPOSITORY
  R312 KXmlRpcClient

REVISION DETAIL
  https://phabricator.kde.org/D25551

To: nicolasfella, #frameworks, dvratil
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29358: Implement lock-screen visibility control on Android

2020-05-20 Thread Nicolas Fella
nicolasfella requested changes to this revision.
nicolasfella added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> notifybyandroid.cpp:110
>  n.setField("urgency", (jint)(notification->urgency() == 
> KNotification::DefaultUrgency ? KNotification::HighUrgency : 
> notification->urgency()));
> +n.setField("visibility", 
> QAndroidJniObject::fromString(notification->hints().value(QLatin1String("visibility")).toString().toLower()).object());
>  

The hint name should be something like x-kde-visibility

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29358

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29358: Implement lock-screen visibility control on Android

2020-05-20 Thread Nicolas Fella
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D29358

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29420: Generate DBus interface

2020-05-20 Thread Nicolas Fella
nicolasfella closed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29420

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-18 Thread Nicolas Fella
nicolasfella edited the test plan for this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29391

To: nicolasfella, #frameworks, broulik
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-18 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83051.
nicolasfella added a comment.


  - Address APIdocs issues
  - Remove timer

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29391?vs=81822=83051

BRANCH
  closewin

REVISION DETAIL
  https://phabricator.kde.org/D29391

AFFECTED FILES
  src/knotification.cpp
  src/knotification.h

To: nicolasfella, #frameworks, broulik
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D24025: Don't use KCrash on Android

2020-05-18 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24025

To: nicolasfella, dfaure
Cc: vkrause, apol, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D22868: Revamp Kirigami.AboutPage

2020-05-18 Thread Nicolas Fella
nicolasfella added a comment.


  can this be closed?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22868

To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella
Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson, mart


D25551: Mark KXmlRpcClient as porting aid

2020-05-18 Thread Nicolas Fella
nicolasfella added a comment.


  ping?
  
  Only kblog is using it, but according to T12157 
 that is supposed to go away too

REPOSITORY
  R312 KXmlRpcClient

REVISION DETAIL
  https://phabricator.kde.org/D25551

To: nicolasfella, #frameworks, dvratil
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D23968: Use app specific location for DB on Android

2020-05-18 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D23968

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28312: Implement urls using hints

2020-05-18 Thread Nicolas Fella
nicolasfella closed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28312

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29802: Require out-of-source builds

2020-05-17 Thread Nicolas Fella
nicolasfella accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  require-in-source-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29802

To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29390: Respect QIcon::fallbackSearchpaths()

2020-05-11 Thread Nicolas Fella
nicolasfella updated this revision to Diff 82600.
nicolasfella added a comment.


  - Use array

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29390?vs=81821=82600

BRANCH
  fallback

REVISION DETAIL
  https://phabricator.kde.org/D29390

AFFECTED FILES
  src/kiconloader.cpp

To: nicolasfella, #plasma, #frameworks
Cc: kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29390: Respect QIcon::fallbackSearchpaths()

2020-05-11 Thread Nicolas Fella
nicolasfella added inline comments.

INLINE COMMENTS

> aacid wrote in kiconloader.cpp:1142
> I just realized that function is private, not really easy to use :/
> 
> anyhow do you think we should remove svgz?
> 
> Also i think using
> 
> const QStringList extensions = { QStringLiteral(".png"), 
> QStringLiteral(".svg"), QStringLiteral(".svgz"), QStringLiteral(".xpm") };
> 
> should be a bit faster

I copied that list from somewhere else in KIconLoader. It would seem weird to 
me to support a different set of formats in the fallback than in the regular 
path

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29390

To: nicolasfella, #plasma, #frameworks
Cc: kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:a70e9a0162f7: [android] Allow specifying APK install 
location (authored by nicolasfella).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29631?vs=82531=82569

REVISION DETAIL
  https://phabricator.kde.org/D29631

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
nicolasfella updated this revision to Diff 82531.
nicolasfella added a comment.


  - Rename variable

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29631?vs=82527=82531

BRANCH
  androinstall

REVISION DETAIL
  https://phabricator.kde.org/D29631

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
nicolasfella marked 2 inline comments as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
nicolasfella added a comment.


  This is used in https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/68

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29631

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, Android, apol, vkrause.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This allows `make create-apk` to directly write the APK to /output instead of 
the cp-with-prefix step in /opt/helpers/create-apk. It's also useful for manual 
development builds where one would need to copy it to some output location 
manually or for CI setups that expect the output in a certain location.
  
  If ANDROID_APK_INSTALL_DIR is not set the current behaviour is kept.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  androinstall

REVISION DETAIL
  https://phabricator.kde.org/D29631

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake

To: nicolasfella, #frameworks, #android, apol, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns


D29420: Generate DBus interface

2020-05-07 Thread Nicolas Fella
nicolasfella updated this revision to Diff 82237.
nicolasfella added a comment.


  - Use q as parent
  - Change reply type
  - Use ranged-for

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29420?vs=81920=82237

BRANCH
  geninterface

REVISION DETAIL
  https://phabricator.kde.org/D29420

AFFECTED FILES
  src/notifybypopup.cpp
  src/notifybypopup.h

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29420: Generate DBus interface

2020-05-07 Thread Nicolas Fella
nicolasfella marked 3 inline comments as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29420

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29420: Generate DBus interface

2020-05-05 Thread Nicolas Fella
nicolasfella added inline comments.

INLINE COMMENTS

> broulik wrote in notifybypopup.cpp:115
> Previously it would accept the signal from any service which I find odd, 
> though. Could you maybe check git logs to see if there was a reason for this?
> It should survive restarts anyway and the service name is defined, so I 
> really don't see why it used to be a blind connect.

git history until the frameworks split isn't really telling, I didn't bother 
looking further back

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29420

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29420: Generate DBus interface

2020-05-04 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  We already use a generated interface in kstatusnotifieritem, but not in 
notifybypopup.
  
  Compile-time checks++
  code--

TEST PLAN
  Spawned, updated, closed notifications, triggered actions

REPOSITORY
  R289 KNotifications

BRANCH
  geninterface

REVISION DETAIL
  https://phabricator.kde.org/D29420

AFFECTED FILES
  src/notifybypopup.cpp
  src/notifybypopup.h

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29336: Remove galago from method/variable naming

2020-05-04 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:2012f675aed2: Remove galago from method/variable naming 
(authored by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29336?vs=81680=81892

REVISION DETAIL
  https://phabricator.kde.org/D29336

AFFECTED FILES
  src/imageconverter.h
  src/notifybypopup.cpp
  src/notifybypopup.h
  src/notifybyportal.cpp

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella added a comment.


  In D29405#662963 , @apol wrote:
  
  > Won't this make it harder to put together the notifications kcm?
  
  
  Good point, we use the notifyrc file to know which apps send notifications 
ahead of time. Maybe we need something similar to 
`X-GNOME-UsesNotifications=true`

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29405

To: nicolasfella, #frameworks, broulik, vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella added a comment.


  We want to phase out notifyrc files for several reasons:
  
  - They are an overkill for many simple use cases
  - A common pitfall when using KNotifications are missing or incorrect 
notifyrc files
  - Most of the information in there is duplicate/overridden at runtime anyway
  - We want to reduce the level of detail of the configurability anyway since 
it currently is quite an overkill
  
  See T11875  for some discussion

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29405

To: nicolasfella, #frameworks, broulik, vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  In KNotificationManager when reading the actions default to Popup when no 
actions are found. In notifybypopup default to 
QGuiApplication::applicationDisplayName() when reading the app name. The logic 
for the icon is not changed, worst case we get empty which may get overridden 
by the user.
  
  Other backends are still todo

TEST PLAN
  Deleted notifyrc file from KDE Connect. Still get notifications. As a side 
effect the pairing notification now shows "KDE Connect Daemon" instead of "KDE 
Connect". This could be changed with a new setter or x-kde-display-appname

REPOSITORY
  R289 KNotifications

BRANCH
  nonotifyrc

REVISION DETAIL
  https://phabricator.kde.org/D29405

AFFECTED FILES
  src/knotificationmanager.cpp
  src/notifybypopup.cpp

To: nicolasfella, #frameworks, broulik, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-03 Thread Nicolas Fella
nicolasfella added a comment.


  In D29391#662471 , @broulik wrote:
  
  > The `QWidget` one has some additional features, like closing the 
notification when the window is destroyed (cf. its docs), which would be useful?
  
  
  lol, turns out that doesn't even work when using setWidget instead of the 
ctor with a widget because of 30b10492 


REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29391

To: nicolasfella, #frameworks, broulik
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-03 Thread Nicolas Fella
nicolasfella added a comment.


  In D29391#662471 , @broulik wrote:
  
  > Generally +1
  >  The `QWidget` one has some additional features, like closing the 
notification when the window is destroyed (cf. its docs), which would be useful?
  
  
  I'll take a look
  
  > Not a fan of the timer.
  
  Me neither, but the widgets code has this too, so I kept it. I can remove it 
though if we decide we don't want it
  
  > Also, we might want to deprecate the `QWidget` one now?
  
  That's my plan, but I still need to port some things

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29391

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29021: Remove checks for notification service and fallback to KPassivePopup

2020-05-03 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:a5f0b1f7c812: Remove checks for notification service and 
fallback to KPassivePopup (authored by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29021?vs=80687=81823

REVISION DETAIL
  https://phabricator.kde.org/D29021

AFFECTED FILES
  src/notifybypopup.cpp
  src/notifybypopup.h

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-03 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This is a replacement for CloseOnWidgetActivated that operates on a QWindow 
instead of QWidget.

TEST PLAN
  PoC port of Yakuake:

REPOSITORY
  R289 KNotifications

BRANCH
  closewin

REVISION DETAIL
  https://phabricator.kde.org/D29391

AFFECTED FILES
  src/knotification.cpp
  src/knotification.h

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29390: Respect QIcon::fallbackSearchpaths()

2020-05-03 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When an icon isn't found within a theme we are supposed to look for it in 
QIcon::fallbackSearchpaths() (https://doc.qt.io/qt-5/qicon.html#fromTheme).
  
  BUG: 405522

TEST PLAN
  Create /home/nico/foo.svg
  Add QIcon::setFallbackSearchPaths(QIcon::fallbackSearchPaths() << 
QStringLiteral("/home/nico/myicons")); to my app
  Use foo icon somewhere

REPOSITORY
  R302 KIconThemes

BRANCH
  fallback

REVISION DETAIL
  https://phabricator.kde.org/D29390

AFFECTED FILES
  src/kiconloader.cpp

To: nicolasfella, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29339: Implement updating of notifications on Android

2020-05-01 Thread Nicolas Fella
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29339

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29342: Implement support for notification urgency on Android

2020-05-01 Thread Nicolas Fella
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29342

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29335: Implement notification grouping on Android

2020-05-01 Thread Nicolas Fella
nicolasfella added inline comments.

INLINE COMMENTS

> vkrause wrote in NotifyByAndroid.java:171
> That seems counter-productive to me, as the Android API documentation always 
> speaks about API level numbers, so you'd need to do an additional translation 
> to/from the letters in your head. So for that I find "26" more useful here 
> than "O". It's also consistent with the rest of the code in this file.

You have a point

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29335

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29335: Implement notification grouping on Android

2020-05-01 Thread Nicolas Fella
nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Haven't tested it, but the code looks sensible

INLINE COMMENTS

> NotifyByAndroid.java:171
> +Notification.Builder builder;
> +if (Build.VERSION.SDK_INT >= 26) {
> +builder = new Notification.Builder(m_ctx, 
> notification.channelId);

Please use 
https://developer.android.com/reference/android/os/Build.VERSION_CODES instead 
of hardcoding numbers

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29335

To: vkrause, nicolasfella
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D29021: Remove checks for notification service and fallback to KPassivePopup

2020-05-01 Thread Nicolas Fella
nicolasfella added a dependent revision: D29336: Remove galago from 
method/variable naming.

REPOSITORY
  R289 KNotifications

BRANCH
  nofallback2

REVISION DETAIL
  https://phabricator.kde.org/D29021

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29336: Remove galago from method/variable naming

2020-05-01 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  With D29021  the fallback notification 
system is gone and with it the need for differentating naming. Remove galago 
from the naming since it's outdated and might confuse readers unfamiliar with 
the code and its history. Also inline a now not needed function.

TEST PLAN
  Still get notifications, action invoked signal is correctly sent
  
  Depends on D29021 

REPOSITORY
  R289 KNotifications

BRANCH
  nogalago

REVISION DETAIL
  https://phabricator.kde.org/D29336

AFFECTED FILES
  src/imageconverter.h
  src/notifybypopup.cpp
  src/notifybypopup.h
  src/notifybyportal.cpp

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Nicolas Fella
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29323

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D26604: Check if there is an activatable service when notification service owner changes

2020-04-29 Thread Nicolas Fella
nicolasfella abandoned this revision.
nicolasfella added a comment.


  I favor of  D29021 

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26604

To: nicolasfella, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D26605: Remove fallback to KPassivePopup

2020-04-29 Thread Nicolas Fella
nicolasfella abandoned this revision.
nicolasfella added a comment.


  In favor of  D29021 

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26605

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29269: Consistently use knotify-config.h to pass in flags about Canberra/Phonon

2020-04-28 Thread Nicolas Fella
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R305 KNotifyConfig

BRANCH
  useconsistentlyconfigfile

REVISION DETAIL
  https://phabricator.kde.org/D29269

To: kossebau, #frameworks, broulik, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29079: android: include the architecture on the apk name

2020-04-28 Thread Nicolas Fella
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29079

To: apol, #android, #frameworks, nicolasfella
Cc: vkrause, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
bencreasy, michaelh, ngraham, bruns


D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella
nicolasfella edited the summary of this revision.
nicolasfella edited the test plan for this revision.
nicolasfella added reviewers: Frameworks, Plasma, broulik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29021

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella
nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  nofallback2

REVISION DETAIL
  https://phabricator.kde.org/D29021

AFFECTED FILES
  src/notifybypopup.cpp
  src/notifybypopup.h

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29020: Add example/test application

2020-04-20 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80685.
nicolasfella added a comment.


  - Add license header

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29020?vs=80684=80685

BRANCH
  example

REVISION DETAIL
  https://phabricator.kde.org/D29020

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/notificationtester.cpp
  examples/notificationtester.qml
  examples/resources.qrc

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29020: Add example/test application

2020-04-20 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The purpose of this is twofold. It serves as a code example, but most 
importantly it can be used to test changes in KNotifications. It is currently 
very basic, but can be expanded in the future

REPOSITORY
  R289 KNotifications

BRANCH
  example

REVISION DETAIL
  https://phabricator.kde.org/D29020

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/notificationtester.cpp
  examples/notificationtester.qml
  examples/resources.qrc

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28805: Tweak kcmcontrols docs

2020-04-20 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:b8accaad1eda: Tweak kcmcontrols docs (authored by 
nicolasfella).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28805?vs=80044=80640

REVISION DETAIL
  https://phabricator.kde.org/D28805

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: nicolasfella, #frameworks, jucato, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D22701: [kfileutils] Add isExecutableFile from KRun

2020-04-20 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D22701

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28020: New class ProcessLauncherJob in KIOGui

2020-04-18 Thread Nicolas Fella
nicolasfella added a comment.


  IIRC startup notification is still a big question mark in Wayland, but other 
Plasma devs know better

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28020

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

2020-04-16 Thread Nicolas Fella
Hi,

this looks like a simple prison build failure to me. However, I cannot 
reprocuce this with
the binary factory container and the current Prison Android CI builds is blue. 
There is a
single red Android build in the Prison CI history 
(https://build.kde.org/job/Frameworks/
job/prison/job/kf5-qt5%20AndroidQt5.14/5/[1]) with what appears to be the same
error message. Not sure how to explain that though.

Nico


On Donnerstag, 16. April 2020 21:10:44 CEST Ben Cooksley wrote:
> On Fri, Apr 17, 2020 at 6:37 AM Johan Ouwerkerk  
> wrote:
> > On Thu, Apr 16, 2020 at 10:51 AM Ben Cooksley  wrote:
> >> Hi all,
> >>
> >> Does anyone know why the below would have suddenly started failing a
> >> little while back?
> >>
> >> Thanks,
> >> Ben
> >
> > Based on the error message I would expect this to be related to the effort
> > to fix Android pkgs not being generated for both 32bit and 64bit ARM.
> I see. Do we have a timeline for this being fixed?
>
> > Regards,
> >
> > - Johan
>
> Cheers,
> Ben




[1] 
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.14/5/


D28851: Mark KStatusBarOfflineIndicator as deprecated

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:cd53f10cad27: Mark KStatusBarOfflineIndicator as 
deprecated (authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28851?vs=80190=80201

REVISION DETAIL
  https://phabricator.kde.org/D28851

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kstatusbarofflineindicator.cpp
  src/filewidgets/kstatusbarofflineindicator.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella
nicolasfella planned changes to this revision.
nicolasfella added a comment.


  Seems like I missed some usages

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25705

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80199.
nicolasfella added a comment.


  - Fix update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25705?vs=80197=80199

BRANCH
  arcpatch-D25705_1

REVISION DETAIL
  https://phabricator.kde.org/D25705

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/pixmaploader.cpp
  src/widgets/pixmaploader.h

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella
nicolasfella added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25705

To: nicolasfella, #frameworks, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80197.
nicolasfella added a comment.


  - Update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25705?vs=72413=80197

BRANCH
  arcpatch-D25705_1

REVISION DETAIL
  https://phabricator.kde.org/D25705

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/pixmaploader.cpp
  src/widgets/pixmaploader.h

To: nicolasfella, #frameworks
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns


D17805: Allow specifying multiple mimetypes as constraints

2020-04-15 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17805

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28851: Mark KStatusBarOfflineIndicator as deprecated

2020-04-15 Thread Nicolas Fella
nicolasfella added a task: T12373: Move or kill KStatusBarOfflineIndicator.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28851

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28851: Mark KStatusBarOfflineIndicator as deprecated

2020-04-15 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Conceptually it doesn't really belong to KIO and KTorrent was its only user. 
The code has been imported into KTorrent so we don't have any users left.

TEST PLAN
  builds

REPOSITORY
  R241 KIO

BRANCH
  offl

REVISION DETAIL
  https://phabricator.kde.org/D28851

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kstatusbarofflineindicator.cpp
  src/filewidgets/kstatusbarofflineindicator.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D26034: Replace KLocalSocket with QLocalSocket

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:28da79f2119e: Replace KLocalSocket with QLocalSocket 
(authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26034?vs=71642=80188

REVISION DETAIL
  https://phabricator.kde.org/D26034

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/klocalsocketservertest.cpp
  autotests/klocalsocketservertest.h
  autotests/klocalsockettest.cpp
  autotests/klocalsockettest.h
  src/core/CMakeLists.txt
  src/core/connection.cpp
  src/core/connectionbackend.cpp
  src/core/connectionbackend_p.h
  src/core/connectionserver.cpp
  src/core/klocalsocket.cpp
  src/core/klocalsocket.h
  src/core/klocalsocket_p.h
  src/core/klocalsocket_unix.cpp
  src/core/klocalsocket_win.cpp

To: nicolasfella, #frameworks, dfaure
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D28831: Add note about porting loadMimeTypeIcon

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:fe3f59b27dcf: Add note about porting loadMimeTypeIcon 
(authored by nicolasfella).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28831?vs=80128=80186

REVISION DETAIL
  https://phabricator.kde.org/D28831

AFFECTED FILES
  src/kiconloader.h

To: nicolasfella, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D25443: [chmodjob] Port away from QLinkedList

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e18ae3ea52dc: [chmodjob] Port away from QLinkedList 
(authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25443?vs=80139=80187

REVISION DETAIL
  https://phabricator.kde.org/D25443

AFFECTED FILES
  src/core/chmodjob.cpp

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham


D19913: [plasma-desktop] make it compiles without foreach

2020-04-14 Thread Nicolas Fella
nicolasfella added a comment.


  The title says plasma-desktop, but this is plasma-framework?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns


D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread Nicolas Fella
nicolasfella edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  ll

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham


D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella
nicolasfella marked an inline comment as done.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil


D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80150.
nicolasfella added a comment.


  - default to ReadWrite
  - rename icon to iconname to reflect that it's just the name

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28834?vs=80140=80150

BRANCH
  props

REVISION DETAIL
  https://phabricator.kde.org/D28834

AFFECTED FILES
  src/calendar.cpp
  src/calendar.h
  src/calendar_p.h

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, 
mlaurent, knauss, dvratil


D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella
nicolasfella planned changes to this revision.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss


D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80142.
nicolasfella added a comment.


  - Convert license headers to SPDX

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=80141=80142

BRANCH
  arcpatch-D24443_2

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss


D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80141.
nicolasfella added a comment.


  - Remove calendarentry

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=71067=80141

BRANCH
  arcpatch-D24443_2

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss


D24443: Add a plugin system

2020-04-14 Thread Nicolas Fella
nicolasfella edited the summary of this revision.
nicolasfella added a dependency: D28834: Add metadata properties to calendar.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: z3ntu, ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, 
dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss


D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella
nicolasfella added a dependent revision: D24443: Add a plugin system.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil


D28834: Add metadata properties to calendar

2020-04-14 Thread Nicolas Fella
nicolasfella added reviewers: Frameworks, KDE PIM, vkrause.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D28834

To: nicolasfella, #frameworks, #kde_pim, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil


D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80139.
nicolasfella added a comment.


  - Update comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25443?vs=70143=80139

BRANCH
  ll

REVISION DETAIL
  https://phabricator.kde.org/D25443

AFFECTED FILES
  src/core/chmodjob.cpp

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham


D25443: [chmodjob] Port away from QLinkedList

2020-04-14 Thread Nicolas Fella
nicolasfella marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25443

To: nicolasfella, #frameworks, dfaure
Cc: dfaure, bruns, fabiank, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham


  1   2   3   4   5   6   7   8   9   >