D25334: Added transparent blue background to tabbars

2019-11-21 Thread Noah Davis
ndavis added a comment. Here's the fixed file: F680: tabbar.svg Unfortunately, it still doesn't look right. F681: Screenshot_20191121_160905.png REPOSITORY R242 Plasma Framework (Library) REVISION

D25334: Added transparent blue background to tabbars

2019-11-21 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > ndavis wrote in tabbar.svg:47 > Oh wait, this must be where the color problem is. It's hardcoded to a light > color. It should be ButtonFocus with semi-transparency instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25334: Added transparent blue background to tabbars

2019-11-21 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > tabbar.svg:47 > + > + height="12" fill="#93cee9" opacity=".34"/> > + height="12" fill="#93cee9" opacity=".34"/> Oh wait, this must be where the color problem is. It's hardcoded to a light color. REPOSITORY R242 Plasma

D25334: Added transparent blue background to tabbars

2019-11-21 Thread Noah Davis
ndavis added a comment. In D25334#565851 , @ngraham wrote: > Are you talking about the effect itself in terms of its background color, or how it fits in the space available when displayed by widgets? The latter will require many complicated

D25334: Added transparent blue background to tabbars

2019-11-21 Thread Noah Davis
ndavis added a comment. In D25334#565798 , @ngraham wrote: > Honestly I think this is fine to land now. We can incrementally improve things with patches to individual widgets, but for the most part I think this is a big improvement already.

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Noah Davis
ndavis added a comment. F7769041: Screenshot_20191117_203818.png 15% Inactive BG opacity 10% Minimized BG opacity REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc:

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Noah Davis
ndavis added a comment. In D25340#563908 , @ngraham wrote: > Decreasing the opacity of the icon itself? Maybe that could work. Not the icon, the background. > A pet peeve I have with the status quo is that minimized apps/windows have

D25340: Added background colors to active and inactive icon view

2019-11-17 Thread Noah Davis
ndavis added a comment. In D25340#563783 , @ngraham wrote: > I don't hate the current state, let me note. It's just not what I expected, and I feel like I would need to get used to it rather than immediately falling in love with it.

D25334: Added transparent blue background to tabbars

2019-11-17 Thread Noah Davis
ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel,

D25334: Added transparent blue background to tabbars

2019-11-17 Thread Noah Davis
ndavis added a comment. Even if the colors are fixed, there are a number of other places that need fixes in order for this to look right, so I think we should hold off landing this until these issues are fixed: Not extending to the edge: F7768790: Screenshot_20191117_171047.png

D25334: Added transparent blue background to tabbars

2019-11-17 Thread Noah Davis
ndavis added a comment. These colors don't look right F7768670: Screenshot_20191117_152000.png REPOSITORY R242 Plasma Framework (Library) BRANCH tabbar_blue_background (branched from master) REVISION DETAIL https://phabricator.kde.org/D25334

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis
ndavis added a comment. I wonder if the Light gray line on the inactive mode should be a little brighter (up to 35% opacity) or if the background for inactive and minimized should be a little darker (down to 15% opacity) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis
ndavis added a comment. Here's a cleaned up version of the file with the changes Nate and I requested: F7767647: tasks.svg F7767649: Screenshot_20191117_005703.png REPOSITORY R242 Plasma Framework (Library)

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis
ndavis added a comment. Unfortunately, InactiveText doesn't work and neither does DisabledText. I might need to change whatever library handles stylesheets for plasmashell. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis
ndavis added a comment. In D25340#563388 , @niccolove wrote: > > @ndavis said: > > Here's what I think: > > > > - The line should indicate that the app is opened, the window is not minimized and the window is focused (opaque blue) or

D25340: Added background colors to active and inactive icon view

2019-11-16 Thread Noah Davis
ndavis added a comment. This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove,

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Noah Davis
ndavis added a comment. In D25334#563295 , @niccolove wrote: > In D25334#563285 , @ngraham wrote: > > > Perfect, all issues fixed, and thanks for pointing me in the direction of the cache files.

D25334: Added transparent blue background to tabbars

2019-11-16 Thread Noah Davis
ndavis added a comment. In D25334#563346 , @ngraham wrote: > Found the bug report tracking that requested change: https://bugs.kde.org/show_bug.cgi?id=370465 > > Based on the comments there, it's likely that this proposal would receive

D25296: [RFC] Fix Display Configuration icon margins

2019-11-15 Thread Noah Davis
ndavis added a comment. I figured it out. The 22px version needs the `22-22-` prefix in its ID. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25296 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25296: [RFC] Fix Display Configuration icon margins

2019-11-15 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > preferences.svg:4 > +.ColorScheme-Text { > color:#7B7C7E; >} Wrong default colors. Just replace the whole stylesheet with this one:

D25296: [RFC] Fix Display Configuration icon margins

2019-11-15 Thread Noah Davis
ndavis added a comment. It's blurry in your screenshot because you're scaling a 22px icon up to 32px. The solution is to make a 32px version named `32-32-preferences-desktop-display-randr`. BTW, the icon is not actually aligned with the grid. It's a little off here and there. You should be

D25132: Use an eyedropper for color-picker icons

2019-11-13 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM, but I noticed that there is a 32px monochrome icon. Should we keep using 32px monochrome icons for now? It seems like we can't make up our minds on this issue and the amount of work

D25291: Add "all applications" category icon

2019-11-13 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH all-apps-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D25291 To: ngraham, #vdg, broulik, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

2019-11-10 Thread Noah Davis
ndavis added a comment. In D25226#560363 , @ngraham wrote: > Or maybe should the UI be changed to show a clickable link and an "edit" button that temporarily turns it into a text field that lets you edit it? So like this?

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

2019-11-10 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1120 > +QPushButton *goThereButton = new QPushButton(d->m_frame); > +goThereButton->setIcon(QIcon::fromTheme(QStringLiteral("go-next"))); > + `go-jump` is more semantically correct. REPOSITORY R241 KIO

D25015: Update breeze theme shadows

2019-11-09 Thread Noah Davis
ndavis added a comment. In D25015#560516 , @cblack wrote: > In D25015#560515 , @ndavis wrote: > > > One thing we might need to do in order to finally stop changing the shadows is come up with a math

D25015: Update breeze theme shadows

2019-11-09 Thread Noah Davis
ndavis added a comment. One thing we might need to do in order to finally stop changing the shadows is come up with a system for deciding how shadows should look based on the elevation we want certain UI elements to have. We could copy Material Design shadows, but I don't think we should.

D25015: Update breeze theme shadows

2019-11-09 Thread Noah Davis
ndavis added a comment. In D25015#560498 , @niccolove wrote: > In D25015#559344 , @filipf wrote: > > > I'd prefer the shadows to have equal strength all around, I couldn't get used to weaker

D25123: [WIP] New yakuake logo/icon

2019-11-09 Thread Noah Davis
ndavis added a comment. I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: ndavis, KonqiDragon,

D25132: Use an eyedropper for color-picker icons

2019-11-08 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I still think the lines on the side of the tube need to be a bit thicker. They're almost half a pixel thick, which is not in line with what we normally do and it makes them fuzzy

D25015: Update breeze theme shadows

2019-11-07 Thread Noah Davis
ndavis added a comment. I see the difference now as well. @niccolove BTW, the top right corner is a bit messed up. It's rising above the rest of the shadow on the top edge. Rather than painstakingly making shadows by hand in Inkscape, perhaps we should be using KWin for the shadows?

D25015: Update breeze theme shadows

2019-11-06 Thread Noah Davis
ndavis added a comment. I haven't said much about this idea because I just have a hard time seeing the difference from the screenshots. It seems like a good amount of effort went into this, and I know from experience that adjusting shadows in Inkscape is a major PITA, but I can't approve

D25132: Use an eyedropper for color-picker icons

2019-11-04 Thread Noah Davis
ndavis added a comment. another set F7736364: Screenshot_20191104_154914.png F7736366: Screenshot_20191104_154930.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132

D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Noah Davis
ndavis added a comment. In D25123#558353 , @mglb wrote: > Breaking nice-looking proportions just to fill vertical space is not good IMO. Making the bar a bit higher might make it look more reasonably. Your second proposition (icon C) looks nice

D25132: Use an eyedropper for color-picker icons

2019-11-03 Thread Noah Davis
ndavis added a comment. The chunky look works well at 16px, but I can see it sticking out at larger sizes. These ones have pointier tips: 1x F7730340: Screenshot_20191103_174917.png 4x F7730343: Screenshot_20191103_175058.png

D25132: Use an eyedropper for color-picker icons

2019-11-03 Thread Noah Davis
ndavis added a comment. Here's another idea: F7730258: Screenshot_20191103_173337.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25132: Use an eyedropper for color-picker icons

2019-11-03 Thread Noah Davis
ndavis added a comment. I think it needs to be a little more Breezy. Here are 2 of my attempts with the 16px version: F7730187: Screenshot_20191103_172328.png F7730173: Screenshot_20191103_172121.png F7730179:

D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Noah Davis
ndavis added a comment. A or C for me. `A` looks more like how I imagine a "drop down terminal", but it's got a lot of margin below the bottom of it. I tried seeing how it would look extended down to the bottom margin: F7728707: Screenshot_20191103_135015.png

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-02 Thread Noah Davis
ndavis added a comment. I'm not sure if my review is really necessary since I lack the technical expertise to know what the right solution is, but +1 to light and dark Breeze icon support on other platforms. REPOSITORY R266 Breeze Icons REVISION DETAIL

T11950: Reduce the pain of working on monochrome Breeze icons

2019-10-31 Thread Noah Davis
ndavis added a comment. I don't trust optimizers unless it's `scour`. That's the only one I know of that doesn't seem to cause problems occasionally. Inkscape's Optimized SVG save option actually uses `scour` to do the optimization. I'm somewhat open to the idea of only requiring

D24975: Change some 32px action icons to color style

2019-10-27 Thread Noah Davis
ndavis added a comment. I don't have time to do all 32px icons at once, but thankfully, they're usually only used in the desktop shell (I can put 32px monochrome icons in the desktop theme), or in preferences or navigation sidebars. I suppose it also affects people who raise the toolbar

D24975: Change some 32px action icons to color style

2019-10-27 Thread Noah Davis
ndavis added a subscriber: ngraham. ndavis added a comment. In D24975#554721 , @mglb wrote: > Why do you replace action icons instead of adding separate colorful icons for use in preference dialogs? Right now all action icons are "monochrome",

D24975: Change some 32px action icons to color style

2019-10-27 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

2019-10-27 Thread Noah Davis
ndavis added a comment. In D24959#554523 , @trickyricky26 wrote: > On the technical side, we usually convert everything to paths, and even though I can't imagine Qt SVG Renderer would have a problem with `circle`, it might be better to convert

D24975: Change some 32px action icons to color style

2019-10-27 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

2019-10-27 Thread Noah Davis
ndavis added a task: T10165: Large category icons should all be colorful. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

2019-10-27 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY - document-open-recent, document-save-all, document-save-as, document-save,

D24652: Add folder-recent, extend hand of clock in folder-temp

2019-10-26 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:2a36922a8cc4: Add folder-recent, extend hand of clock in folder-temp (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24652?vs=67939=68773

D24625: Fill middle mouse button area

2019-10-26 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:8732c6a99ad1: Fill middle mouse button area (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D24476: [KPropertiesDialog] Only show volume-related info for volumes

2019-10-25 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. In D24476#554110 , @pino wrote: > Please remember that the properties dialog is a general dialog offered by the KIO framework, and

D24476: [KPropertiesDialog] Only show volume-related info for volumes

2019-10-25 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I agree with this change. REPOSITORY R241 KIO BRANCH only-show-volume-info-for-volumes (branched from master) REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg,

D24871: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

2019-10-22 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH more-appropriate-ghns-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24871 To: ngraham, #vdg, leinir, ndavis Cc: kde-frameworks-devel, ndavis,

D24753: Add edit-opacity icons

2019-10-18 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D24753 REVISION DETAIL https://phabricator.kde.org/D24753 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

2019-10-16 Thread Noah Davis
ndavis added a comment. Oh yes, that would be a good thing. Any of these will be fine: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL

D24537: Icons for windy weather

2019-10-16 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I'm fine with this blue. REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-15 Thread Noah Davis
ndavis added a comment. For some reason, Arc made me the committer and the author instead of just the committer. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham,

D24652: Add folder-recent, extend hand of clock in folder-temp

2019-10-14 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24652 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24652: Add folder-recent, extend hand of clock in folder-temp

2019-10-14 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY folder-recent is merely a symlink to folder-temp since they both normally use the same

D24627: [icons/media.svg] Add 16 & 32px icons, update style

2019-10-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R242:15ed55b4cb71: [icons/media.svg] Add 16 32px icons, update style (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D24628: Fix incorrect margins in 16/22px media icons

2019-10-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:83c8768b2a70: Fix incorrect margins in 16/22px media icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24628?vs=67887=67924 REVISION

D24627: [icons/media.svg] Add 16 & 32px icons, update style

2019-10-14 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

2019-10-14 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24628 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

2019-10-14 Thread Noah Davis
ndavis added a dependent revision: D24627: [icons/media.svg] Add 16 & 32px icons, update style. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24628 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

2019-10-14 Thread Noah Davis
ndavis added a dependency: D24628: Fix incorrect margins in 16/22px media icons. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

2019-10-14 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY For some reason, the margins on these icons were 1 px larger on each side than they were

D24627: [icons/media.svg] Add 16 & 32px icons, update style

2019-10-14 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

2019-10-14 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Fixes blurry icons in the desktop shell REPOSITORY R242 Plasma Framework

D24625: Fill middle mouse button area

2019-10-14 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24625 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24625: Fill middle mouse button area

2019-10-14 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The negative space in the middle didn't quite look right REPOSITORY R266 Breeze Icons

D24612: Use the text rather than highlight color for rating/star emblem

2019-10-14 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This icon never needed to be blue. I think I just kept it blue because that's what it was originally. REPOSITORY R266 Breeze Icons BRANCH monochrome-rating-emblem (branched from

D24621: [RFC] New Konsole and Yakuake icons

2019-10-13 Thread Noah Davis
ndavis added a comment. The Yakuake icon is a major improvement. The little angled rectangle making the prompt arrow look like a Y is a little distracting, but also kind of charming and helps to distinguish it from Konsole. I kind of still prefer the plainer ">_" version though. I

D24537: Icons for windy weather

2019-10-13 Thread Noah Davis
ndavis added a comment. In D24537#546733 , @cblack wrote: > I think cyan is an appropriate choice considering that people tend to associate air with shades of blue, even if air is transparent and that's just the colour of the sky. The shade

D24537: Icons for windy weather

2019-10-11 Thread Noah Davis
ndavis added a comment. In D24537#545451 , @kossebau wrote: > BTW, when it come to weather status icon, I dream of the possibility to simply compose the current status from base elements, instead of having pre-rendered icons. > > So there

D24555: Add draw-arrow icons

2019-10-11 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. > The design is based on `draw-line` with an arrowhead. I think this is a good design. I noticed that LibreOffice already uses a different icon for drawing arrows, but I think this one

D24537: Icons for windy weather

2019-10-11 Thread Noah Davis
ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis Cc: ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

2019-10-11 Thread Noah Davis
ndavis added a comment. That cyan looks odd. It sticks out way too much and AFAIK, it isn't commonly used to represent wind. Gray on more gray is going to be tricky as well though, especially when you've got partly cloudy vs cloudy. What if the wind was a bit more monochromatic? Wind is

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-10 Thread Noah Davis
ndavis added a comment. In D24453#543063 , @ngraham wrote: > Nice. Is there any way to make it touch the edges of its parent view rather than having those small margins? I would like this. I'm not aware of any place where we use margins

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-10 Thread Noah Davis
ndavis added a comment. Why do the gray rectangles have margins around them? I don't like the look very much. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation,

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis
ndavis added a comment. Thanks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:7fea43c57c59: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24477?vs=67456=67586

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis
ndavis retitled this revision from "[PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation" to "Add PATH/LD_LIBRARY_PATH to qrcAlias invocation". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg,

D24477: [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24493: Add draw-highlight action icons

2019-10-08 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH add-highlight-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24493 To: trickyricky26, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Eh, it doesn't bother me that much. If you think this is the right thing to do, go ahead. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Noah Davis
ndavis added a comment. If we're just renaming the category, we don't need to also rename the icon in this case. It would break compatibility with 3rd party icon themes and the only upside is a semantically better name. REPOSITORY R266 Breeze Icons REVISION DETAIL

D24412: Add edit-line-width icons

2019-10-05 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH add-line-width-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24412 To: trickyricky26, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel,

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > kstyle.cpp:428 > +case QStyle::SP_DialogSaveAllButton: > +return QIcon::fromTheme(QStringLiteral("document-save")); > +case QStyle::SP_DialogAbortButton: why not `document-save-all`? REPOSITORY R252 Framework Integration

D24412: Add edit-line-width icons

2019-10-04 Thread Noah Davis
ndavis added a comment. I think something similar to this line width icon would work well: F6304104: Lines.png Inkscape uses a similar icon, but for all line styles: F7517386: Screenshot_20191004_143517.png

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis
ndavis added a comment. In D24318#541952 , @churaev wrote: > In D24318#541839 , @ndavis wrote: > > > How about this? > > F7513643: document-save.svg > >

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis
ndavis added a comment. In D24318#542043 , @ngraham wrote: > @ndavis You wanna just submit a patch with that and I'll abandon this? Alright REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To:

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis
ndavis added a comment. How about this? F7513643: document-save.svg F7513644: montage.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg, ndavis Cc:

D24253: Make 22px squiggle more like 16px squiggle

2019-10-01 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:e0ef6b7ed41a: Make 22px squiggle more like 16px squiggle (authored by ndavis). REPOSITORY R266 Breeze Icons

D24318: Make 32px document-save icon colorful

2019-09-30 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. - I think this doesn't look enough like the monochrome versions and it looks too much like the KFloppy icon. - Make the label area more similar to the monochrome icons. -

D24314: Improve KFloppy icon

2019-09-30 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH better-kfloppy-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24314 To: ngraham, #vdg, ndavis Cc: ndavis,

D24253: Make 22px squiggle more like 16px squiggle

2019-09-27 Thread Noah Davis
ndavis added a comment. In D24253#538662 , @trickyricky26 wrote: > Visually I think this is fine and a good improvement. > > I wonder why your SVGs have two seperate paths as opposed to unifying them into one path (as I usually do)? Just

D24253: Make 22px squiggle more like 16px squiggle

2019-09-26 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24253 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

2019-09-26 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24253 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

2019-09-26 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH squiggle (branched from master) REVISION DETAIL

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. 16px F7426808: format-text-underline-squiggle.svg REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg,

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. F7426794: Screenshot_20190924_222405.png F7426789: Screenshot_20190924_222520.png REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION

  1   2   3   4   5   6   7   8   9   10   >