D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-20 Thread Rik Mills
rikmills added a comment.


  In D28765#673191 , @wbauer wrote:
  
  > This caused a crash in openSUSE:
  >  https://bugs.kde.org/show_bug.cgi?id=421566
  
  
  The same crash can been seen in Kubuntu when trying to launch the external 
software-properties app (driver manager) via systemsettings.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela
Cc: rikmills, wbauer, kossebau, svuorela, cblack, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns


D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-27 Thread Rik Mills
rikmills added a comment.


  Fails to build.
  
  
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/135/console
  
  
https://launchpadlibrarian.net/457575337/buildlog_ubuntu-eoan-amd64.kcoreaddons_5.65.0+p19.10+git20191227.0406-0_BUILDING.txt.gz

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26226

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: rikmills, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24754: Fix KNSCore::Cache fetching when initialising Engine

2019-10-18 Thread Rik Mills
rikmills accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-knscore-cache (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24754

To: leinir, rikmills, #frameworks, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24754: Fix KNSCore::Cache fetching when initialising Engine

2019-10-18 Thread Rik Mills
rikmills added a comment.


  Patched knewstuff build with this and tested. Switching between KCMs in 
systemsettings now seems to pull the correct KNS results.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D24754

To: leinir, rikmills, #frameworks, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D22143: Add proper logging using ECMQtDeclareLoggingCategory

2019-09-06 Thread Rik Mills
rikmills added a comment.


  This is installing BOTH /etc/xdg/kactivities-stats.categories 
AND/usr/share/qlogging-categories5/kactivities-stats.categories which is surely 
wrong?

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks, kossebau
Cc: rikmills, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns


D22346: Should we install bluezqt_dbustypes.h?

2019-07-09 Thread Rik Mills
rikmills added a comment.


  > We detected this thing because we have a test in our packaging which checks 
if the installed headers can be built and fails if they are missing bits. I ran 
the test in question with the attached patch and it doesn't fail.
  
  The KDE CI has the acc test as well:
  
  
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/28/console
  
  13:33:41  Checking header(s) 5.60.0 ...
  13:33:44  ERROR: some errors occurred when compiling headers
  13:33:44  ERROR: see log for details:
  13:33:44/home/jenkins/workspace/Frameworks/bluez-qt/kf5-qt5 
SUSEQt5.12/logs/KF5BluezQt/5.60.0/log.txt
  13:33:44  
  13:33:44  ERROR: can't compile header(s)
  13:33:44  ERROR:root:abi-compliance-checker exited with 5
  
  Bizarrely though, failing that test doesn't even make the KDE CI go 
yellow/fail the jobs tests.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22346

To: joselema, drosca, mweichselbaumer
Cc: rikmills, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D12378: Properly search for NetworkManager

2019-05-28 Thread Rik Mills
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D12378

To: jgrulich, #frameworks
Cc: kde-frameworks-devel, rikmills, #frameworks, michaelh, ngraham, bruns


D19888: Add runtime guard that pages are KCMs in KCMultiDialog

2019-03-19 Thread Rik Mills
rikmills added a comment.


  Patch seemed to fix the crash. I don't use Kontact (apart from testing things 
like this), but on a quick test all seems functional once more.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D19888

To: davidedmundson
Cc: rikmills, kde-frameworks-devel, michaelh, ngraham, bruns


D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-19 Thread Rik Mills
rikmills added a comment.


  I guess it is very likely, but all the same for the record I will request 
that this results in a 5.56.2 release of plasma-framework.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns


D18610: Introduce KF5AuthCore

2019-02-09 Thread Rik Mills
rikmills added subscribers: sitter, rikmills.
rikmills added a comment.


  Is this not breaking ABI? even if just moving to another lib?
  
  @sitter FYI I get https://paste.ubuntu.com/p/NHsbqg7DbN/

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: rikmills, sitter, apol, kde-frameworks-devel, michaelh, ngraham, bruns


D18178: fix environment setup of klanguagename test

2019-01-11 Thread Rik Mills
rikmills accepted this revision.
rikmills added a comment.
This revision is now accepted and ready to land.


  Build and passes on Kubuntu CI now.
  
  
https://launchpadlibrarian.net/405807438/buildlog_ubuntu-disco-amd64.kconfigwidgets_5.54.0+p19.04+git20190111.1036-0_BUILDING.txt.gz

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18178

To: sitter, aacid, rikmills
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D10446: Add KLanguageName

2019-01-11 Thread Rik Mills
rikmills added a comment.


  Kubuntu CI builds
  
  2/4 Test #3: klanguagenametest ***Failed0.03 sec
  
  - Start testing of KLanguageNameTest *
  
  Config: Using QtTest library 5.11.3, Qt 5.11.3 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 8.2.0)
  PASS   : KLanguageNameTest::initTestCase()
  FAIL!  : KLanguageNameTest::testNameForCode() Compared values are not the same
  
Actual   (KLanguageName::nameForCode("en")): "English"
Expected ("US English"): US English
Loc: 
[/<>/kconfigwidgets-5.54.0+p19.04+git20190111.0330/autotests/klanguagenametest.cpp(46)]
  
  PASS   : KLanguageNameTest::testNameForCodeInLocale()
  PASS   : KLanguageNameTest::testNoTranslation()
  PASS   : KLanguageNameTest::testNoEntry()
  PASS   : KLanguageNameTest::testNoString()
  PASS   : KLanguageNameTest::cleanupTestCase()
  Totals: 6 passed, 1 failed, 0 skipped, 0 blacklisted, 6ms
  
  - Finished testing of KLanguageNameTest *

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: rikmills, vkrause, dhaumann, hein, kde-frameworks-devel, sitter, markg, 
apol, michaelh, ngraham, bruns


D16867: Don't generate appstream data for files that lack a description

2018-11-21 Thread Rik Mills
rikmills added a comment.


  And we have a casualty from this ;)
  
  Marble 18.12 branch:
  
  >   CMake Warning at 
/usr/lib/x86_64-linux-gnu/cmake/KF5Package/KF5PackageMacros.cmake:68 (message):
  >couldn't generate metainfo for org.kde.plasma.worldmap: Package type
  >"Plasma/Wallpaper" not found
  >
  >Error: description missing, will result in broken appdata field as
  > is mandatory.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D16867

To: apol, #plasma, #frameworks, ngraham
Cc: rikmills, ngraham, kde-frameworks-devel, michaelh, bruns


D6513: Add support for Attica tags support

2018-09-15 Thread Rik Mills
rikmills added a comment.


  In D6513#326071 , @ngraham wrote:
  
  > FYI, this included an ABI change to `SearchRequest` that broke Discover: 
https://bugs.kde.org/show_bug.cgi?id=398412
  
  
  I see this revision has been reverted in master in 
293ae2448f54fd1b1f7cacc86cd40b30a3fb087d 


REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, 
kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns


D13488: Make XDGShellV5 co-compilable with XDGWMBase

2018-07-17 Thread Rik Mills
rikmills added a comment.


  In libkf5waylandclient5 and libkf5waylandserver5 I see the previously emitted 
symbol xdg_shell_interface@Base is now reported as MISSING.
  
  Can you confirm this is private and/or not an ABI break?
  
  Build symbols output: https://paste.kde.org/pfpkps1mb#line-109

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13488

To: davidedmundson, #plasma, romangg
Cc: rikmills, romangg, kde-frameworks-devel, michaelh, ngraham, bruns


D11925: Add "SkipSwitcher" to API

2018-04-28 Thread Rik Mills
rikmills added a comment.


  D11924  and D11926 
 have been pushed, so kwin master branch 
builds are now broken with:
  
  14:49:26 /home/jenkins/workspace/Plasma kwin kf5-qt5 
SUSEQt5.10/abstract_client.cpp: In member function 'void 
KWin::AbstractClient::setupWindowManagementInterface()':
  14:49:26 /home/jenkins/workspace/Plasma kwin kf5-qt5 
SUSEQt5.10/abstract_client.cpp:712:8: error: 'class 
KWayland::Server::PlasmaWindowInterface' has no member named 'setSkipSwitcher'; 
did you mean 'setSkipTaskbar'?
  14:49:26  w->setSkipSwitcher(skipSwitcher());
  14:49:26 ^~~
  14:49:26 setSkipTaskbar
  14:49:26 /home/jenkins/workspace/Plasma kwin kf5-qt5 
SUSEQt5.10/abstract_client.cpp: In lambda function:
  14:49:26 /home/jenkins/workspace/Plasma kwin kf5-qt5 
SUSEQt5.10/abstract_client.cpp:728:16: error: 'class 
KWayland::Server::PlasmaWindowInterface' has no member named 'setSkipSwitcher'; 
did you mean 'setSkipTaskbar'?
  14:49:26  w->setSkipSwitcher(skipSwitcher());
  14:49:26 ^~~
  14:49:26 setSkipTaskbar
  
  https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.10/2/console
  
  https://build.neon.kde.org/job/xenial_unstable_kde_kwin/

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: rikmills, davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns


D12064: Don't alter memory management to hide an item

2018-04-09 Thread Rik Mills
rikmills added a comment.


  Applied this to 5.44 in test package for Ubuntu 18.04
  
  Switched containment folderview -> desktop and back several times. No longer 
any crash.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12064

To: davidedmundson, #plasma
Cc: rikmills, #frameworks, michaelh, ngraham, bruns


D10671: Fix auto-mount regression

2018-02-19 Thread Rik Mills
rikmills added a comment.


  I assume this would be safe to backport to 5.43, should it be accepted?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D10671

To: dkhlestkov, #frameworks, broulik
Cc: rikmills, #frameworks, michaelh


D10054: Fix: View jumps when Scroll past end of document is enabled

2018-02-12 Thread Rik Mills
rikmills added a comment.


  This change appears to cause ktexteditor to fail it's vimode_completion 
autotests.
  
  From KDE CI: 
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/35/testReport/junit/(root)/TestSuite/vimode_completion/
  
  Ubuntu autotests: F5707888: testsuite-stdout 

  
  Reported as bug https://bugs.kde.org/show_bug.cgi?id=390333 as this currently 
blocks 5.43 from getting into Ubuntu.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10054

To: dhaumann, cullmann
Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, 
sars, dhaumann


D7891: expose the colorset for the stylesheet

2017-09-29 Thread Rik Mills
rikmills added a comment.


  Since this change, polkit-kde-agent-1 fails to build from source with the 
error:
  
  >   In file included from /usr/include/KF5/KIconThemes/KIconLoader:1:0,
  >   from 
/<>/polkit-kde-agent-1-5.10.95+p17.10+git20170929.1419/AuthDialog.cpp:37:
  >   /usr/include/KF5/KIconThemes/kiconloader.h:31:10: fatal error: 
kcolorscheme.h: No such file or directory
  >   #include 
  >   ^~~~
  >   compilation terminated.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D7891

To: mart, #frameworks, #plasma, hein, dfaure
Cc: rikmills, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


Re: Kirigami in Frameworks

2017-07-02 Thread Rik Mills
On 01/07/17 12:48, David Faure wrote:
> On vendredi 30 juin 2017 15:16:17 CEST Marco Martin wrote:
>> Hi,
>> I have moved it, should be good to go.
>> one sidenote (hoping is not a problem) for historical reasons, the
>> tarballs were called kirigami2-version instead of just kirigami (or
>> distributions may have some problems in upgrading).. do release
>> scripts need to be adapted in some way?
> 
> Isn't this the right time to drop that historic baggage?
> 
> I suppose it's not just the tarball name that ends with 2, but also the name 
> of what's extracted from it. Which means renaming the checkout, which breaks 
> the next run of kdesrc-build... lots of trouble.
> 
> If this framework was supposed to be called kirigami2, let's call it 
> kirigami2, otherwise I'd say, the tarball name is changing to kirigami.

Reverting to kirigami from kirigami2 could potentially cause issues in
ubuntu/kubuntu.



D5889: Keep QIcon::fromTheme in main thread

2017-06-07 Thread Rik Mills
rikmills added a comment.


  This breaks build on Neon and Kubuntu CI with Qt 5.7.1
  
  
http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console
  
  05:10:59 In file included from 
/workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0,
  05:10:59  from 
/workspace/build/build-qt4/kstyle/breeze_automoc.cpp:33:
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:24: 
error: ‘KWayland’ was not declared in this scope
  05:10:59  QMap _widgetSurfaces;
  05:10:59 ^
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:51: 
error: template argument 2 is invalid
  05:10:59  QMap _widgetSurfaces;

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5889

To: davidedmundson, #plasma, graesslin
Cc: rikmills, graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas