D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat added a comment. @aacid, I've just sent file to the e-mail. I also attached the same file to this message: F6223361: tar_non_ascii_file_name.tar.gz REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibra

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat added a comment. Thanks! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat marked 2 inline comments as done. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat updated this revision to Diff 39537. ibragimovrinat added a comment. Updated diff to use QString everywhere instead of QStringLiteral and QLatin1String. As those are in tests, performance penalty shouldn't matter. Also using QCOMPARE for comparisons. REPOSITORY R243 KArchive

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat updated this revision to Diff 39480. ibragimovrinat added a comment. Added couple of tests. One tests that file name's not truncated, and the other tests that checksum is calculated in a correct way. REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kd

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat added inline comments. INLINE COMMENTS > cfeck wrote in ktar.cpp:777 > Does the spec say `> 99` or `> 100`? The comment and the code should match. The comment is right in some sense, 100 bytes means 99 bytes of name and 1 byte of '\0'. I don't know for sure if there is a (single

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ibragimovrinat requested review of this revision. REVISION SUMMARY BUG: 266141 As UTF-8 may use multiple bytes per character, it's requi