D4778: Add include that is needed in msys2

2017-04-04 Thread Russell Greene
russellg added a comment. Alright, I will in the future :) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D4778 To: russellg, #frameworks, kfunk Cc: kfunk

D4778: Add include that is needed in msys2

2017-04-03 Thread Russell Greene
russellg added a comment. So where does this go now? Sorry I've never submitted a patch in phabricator before :P Am I supposed to merge this, or is somebody else? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D4778 To: russellg, #frameworks, kfunk Cc: kfunk

[Differential] [Request, 1 line] D4778: Add include that is needed in msys2

2017-02-24 Thread Russell Greene
russellg created this revision. russellg added projects: Frameworks, Windows. REVISION SUMMARY In the latest msys2, they updated some windows headers to require this extra include. It's not specific to this project, openFrameworks had to do it as well

[Differential] [Abandoned] D4628: Add ability to disable saving in `KTextEditor::Document`

2017-02-19 Thread Russell Greene
russellg abandoned this revision. REVISION DETAIL https://phabricator.kde.org/D4628 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, #frameworks

[Differential] [Commented On] D4628: Add ability to disable saving in `KTextEditor::Document`

2017-02-19 Thread Russell Greene
russellg added a comment. Sounds good, that's good idea! REVISION DETAIL https://phabricator.kde.org/D4628 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, #frameworks

[Differential] [Updated, 70 lines] D4628: Add ability to disable saving in `KTextEditor::Document`

2017-02-15 Thread Russell Greene
russellg removed R39 KTextEditor as the repository for this revision. russellg updated this revision to Diff 11390. russellg added a comment. Updated the test to be slightly better. Use `QVERIFY(...)` instead of `QCOMPARE(..., true)` in one case, and make sure that `saveEnabled()` is false

[Differential] [Request, 69 lines] D4628: Add ability to disable saving in `KTextEditor::Document`

2017-02-15 Thread Russell Greene
russellg created this revision. russellg set the repository for this revision to R39 KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY I'm currently writing an application where the user is

Re: Review Request 126774: Fix many warnings presented by clazy

2016-02-20 Thread Russell Greene
marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes --- Submitted with commit dc81eb9be52d8027cf80192ea3c693270cee979c by David Faure on behalf of Russell Greene to branch master. Repository: kio Description --- Fix many warnings presented

Re: Review Request 126774: Fix many warnings presented by clazy

2016-01-19 Thread Russell Greene
) Errors while running CTest Makefile:106: recipe for target 'test' failed make: *** [test] Error 8 Thanks, Russell Greene ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel