D29254: [RenameDialog] Add an arrow indicating direction from src to dest

2020-04-30 Thread Safa Alfulaij
safaalfulaij added inline comments. INLINE COMMENTS > ahmadsamir wrote in renamedialog.cpp:299 > @pino, right; dolphin isn't rtl-aware (or if it is, I couldn't find out how > to switch it to rtl). But I agree the code here should account for rtl anyway. > > @ngraham: I think we should stick to

D22069: Localize long number strings

2019-06-25 Thread Safa Alfulaij
safaalfulaij added a comment. This is great! Thanks! Same issue in here: https://phabricator.kde.org/D13219 I'm not sure if this is the correct way of fixing it, but I think there isn't any other prvoided by Qt, other then `QLocale::toString`. Maybe it's the easy way here :) REPOSITORY

D19785: DocumentPrivate: Review del/backspace

2019-03-17 Thread Safa Alfulaij
safaalfulaij added a comment. Wow! Great :) Thanks for looking into this, but I'm afraid that the problem isn't with backspace/del, but with the cursor positioning, at least for RTL and mixed text. I actually found this to be a problem in Qt after trying to solve it myself in

Re: CI system disruption

2019-01-06 Thread Safa Alfulaij
Thank you for all of your work, Ben! I hope that you can get to a conclusion to stop using Crowdin and syncing all the files with almost only one line change “PO-Revision-Date” that does not even count as a translation work! This is what happens when teams just do what they want regardless of

D16421: Improve emblem contrast, legibility and consistency

2019-01-06 Thread Safa Alfulaij
safaalfulaij added a comment. mmm, sorry. I saw this today and I just took a minute to understand it. How does this looks consistent with the theme, or even nice (really sorry)? Please teach me. Thank you. F6529631: Screenshot_٢٠١٩٠١٠٦_١٣١٠٠٤.png

D15829: make units and prefixes of formatValue translatable

2018-10-07 Thread Safa Alfulaij
safaalfulaij added inline comments. INLINE COMMENTS > kformatprivate.cpp:124 > +{ KFormat::UnitPrefix::Milli, 1e-3, bpow(-10), tr("m", "SI prefix > for 10^⁻3") , QString() }, > +{ KFormat::UnitPrefix::Unity, 1.0, 1.0 , QString() > , QString()}, > +

D15829: make units and prefixes of formatValue translatable

2018-10-07 Thread Safa Alfulaij
safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Thanks! I think this solved all my issues. I can for meter unit change the formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep the dot

D15829: make units and prefixes of formatValue translatable

2018-09-29 Thread Safa Alfulaij
safaalfulaij added a comment. I came into anther problem, this time with the unit selection. In Arabic, we don't put a dot between the prefix and the unit if we're talking about meters (mm, cm, km), but we do with other units (k.Byte, M.Byte, G.Byte). If ki18n was used here, all of

D15829: make units and prefixes of formatValue translatable

2018-09-29 Thread Safa Alfulaij
safaalfulaij added a comment. Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen. INLINE COMMENTS > kformatprivate.cpp:115 > const PrefixMapEntry map[] = { > -{

D15309: [Calendar] Wrap day name index around

2018-09-06 Thread Safa Alfulaij
safaalfulaij added a comment. I thought that this is a feature/cool look :D Thanks a lot! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15309 To: broulik, #plasma, Zren Cc: safaalfulaij, kde-frameworks-devel, michaelh, ngraham, bruns

D14733: [KFormat] Add human readable list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij retitled this revision from "[KFormat] Add human readble list displaying function" to "[KFormat] Add human readable list displaying function". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14733 To: safaalfulaij, #frameworks Cc: bruns,

D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij added a comment. In D14733#306325 , @bruns wrote: > You should start with > a) a use case > b) show it actually matches the needs of different languages. > > For e.g. englisch and the most european languages, two different

D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij updated this revision to Diff 39425. safaalfulaij added a comment. Fix test No unrelated changes REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14733?vs=39418=39425 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14733

D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij added a comment. Tbh I don't fully understand the `struct` and `find` statments (just saw working similar code and edited-copy-pasted). I prefer if someone can continue this instead of me. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14733 To:

D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij created this revision. safaalfulaij added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. safaalfulaij requested review of this revision. REVISION SUMMARY Add formatList() to convert

D13584: KFormat: Replace byte specific implementation with generic one

2018-08-09 Thread Safa Alfulaij
safaalfulaij added a comment. Can we please take a look at this before continuing here? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13584 To: bruns, #frameworks Cc: safaalfulaij, dfaure, astippich,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

2018-08-07 Thread Safa Alfulaij
safaalfulaij added a comment. > Yes. As you said, these are symbols. For the names there may be transliterations, the symbols stay the same, to avoid ambiguities. This also matches my experience with datasheets, the text may be chinese, but measurements are given in SI units. I just

D14565: Fix overflow in rounding code

2018-08-02 Thread Safa Alfulaij
safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Worked great, thanks! Maybe you should use `largeValue` instead of `largevalue`. But please take an approval from a developer, it worked for me but I have no idea if it can

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

2018-07-29 Thread Safa Alfulaij
safaalfulaij added a comment. In D14345#297340 , @ngraham wrote: > 1. Does this mean that PlasmaComponents is semi or fully deprecated or "legacy", and we should be porting Plasma stuff to Kirigami instead? > 2. Since there's no Kirigami

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

2018-07-26 Thread Safa Alfulaij
safaalfulaij added a comment. Great! Now I know why the port to PC3 didn't start :D Now to the patch. First, by this we will allow the user to get text under the icon, which will be impossible to read. Second is what I'm here for :) The clear button placement and icon should not follow

D12130: Use the more user-friendly string "File type" in the save dialogs

2018-04-14 Thread Safa Alfulaij
safaalfulaij added a comment. Btw, the `qt` tag is from Qt3 days. I'm not sure if it must be richtext, if so then a simple `html` or even KUIT markups are better choice :) Not sure about string freeze though.. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Safa Alfulaij
safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Now since I'm a reviewer, sure :) REPOSITORY R242 Plasma Framework (Library) BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma,

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Safa Alfulaij
safaalfulaij added a comment. In D10592#209670 , @mvourlakos wrote: > @safaalfulaij is there a green light for this? Sure. Go ahead and commit. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10592: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > -LayoutMirroring.enabled: true > +// HACK: When the ComboBox is not inside the base Item, it does > not inherit > +// the LayoutMirroring options.

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added a comment. Reported: https://bugreports.qt.io/browse/QTBUG-66446 Although this is really unlikly to happen, a widget having a combobox, but this is the case of Latte where the whole config overlay is just a `MouseArea`. REPOSITORY R242 Plasma Framework (Library)

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added a comment. In D9275#207623 , @mvourlakos wrote: > Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3 :) Ok, I can assume that Latte doens't have a

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added a comment. I've done some more testing and read some Qt docs. `Popup` item get reparented to the window once displayed, so LayoutMirroring is applied to it only at that point (applying it to the contentItem). So my comments above about `Popup` not inheerting `Item` are

D9275: fix RTL appearance for ComboBox

2018-02-15 Thread Safa Alfulaij
safaalfulaij added a comment. In D9275#207435 , @mvourlakos wrote: > > Would you please add a HACK so that we know when to remove this? > > You mean as a comment ? Yes, preferably with the Qt bug number and some explanation.

D9275: fix RTL appearance for ComboBox

2018-02-15 Thread Safa Alfulaij
safaalfulaij added a comment. In D9275#207260 , @mvourlakos wrote: > @mart I fixed this issue by changing these lines to: > > 113LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft > 114

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Safa Alfulaij
safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > +LayoutMirroring.enabled: true > +LayoutMirroring.childrenInherit: true So it is true even for LTR locales? REPOSITORY R242 Plasma Framework (Library)

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190606, @mvourlakos wrote: > To test it in Latte I added in the head of /shell/package/contents/configuration/AppearanceConfig.qml > > import org.kde.plasma.components 3.0 as PlasmaComponents3 > > > and I set

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote: > with your example me I cant reproduce it either... > I can only reproduce it with Latte Settings window, all other components are aligned correctly except the PlasmaComponent3.Combobox list

D9275: fix RTL appearance for ComboBox

2018-01-13 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote: > how did you test it? > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"... > If your system is already using in RTL language, have you tried with --reverse?

D9275: fix RTL appearance for ComboBox

2018-01-13 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190464, @mvourlakos wrote: > In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > > > Can you please explain why these are needed? I tested plasmacomponents3 and the

D9793: Fall back to language name for translations lookup if locale name fails

2018-01-11 Thread Safa Alfulaij
safaalfulaij added a comment. > Why is this an issue? > There's no difference really in loading ar/LC_MESSAGES/xxx.qm and LC_MESSAGES/xxx_ar.qm (or something like that), i.e. you would have the same problem if all translations would be in the same folder. Well, we were to simplify

D9793: Fall back to language name for translations lookup if locale name fails

2018-01-11 Thread Safa Alfulaij
safaalfulaij added a comment. I went through Qt code, as Qt applications are opened with my language correctly where KF ones (those with QM) don't. The whole issue is that we have each locale's translations in a separate folder (`ar/LC_MESSAGES`, `en/LC_MESSAGES`, `de/LC_MESSAGES`, etc.)

Re: Problem in loading QM translations with LANGUAGE="" envar

2018-01-10 Thread Safa Alfulaij
Systemsettings sets that, and there is no ar_BH language, but ar only. That's the standard for Arabic translations. On Jan 10, 2018 10:09 PM, "Albert Astals Cid" <aa...@kde.org> wrote: > El dimecres, 10 de gener de 2018, a les 5:49:54 CET, Safa Alfulaij va > escriure:

Re: Problem in loading QM translations with LANGUAGE="" envar

2018-01-10 Thread Safa Alfulaij
causing the trouble. Note: Qt prioritizes LANGUAGE which has no country code, and that was the problem. I'll be sending a small patch to use LANG if the first choice in LANGUAGE is the same as LANG's main language. Regards 2018-01-10 5:49 GMT+03:00 Safa Alfulaij <safa1996alful...@gmail.com>:

Re: Problem in loading QM translations with LANGUAGE="" envar

2018-01-09 Thread Safa Alfulaij
;Arabic (Bahrain)" locale. And it's the only thing that is not getting translated which is obviously a bug. Regards On Jan 10, 2018 12:20 AM, "Albert Astals Cid" <aa...@kde.org> wrote: > El dimarts, 9 de gener de 2018, a les 20:08:02 CET, Safa Alfulaij va > escriure: > &g

Problem in loading QM translations with LANGUAGE="" envar

2018-01-09 Thread Safa Alfulaij
Hello all. After doing some investigation about a problem, I came into an issue in loading correct translations in Frameworks (that has the “_qt” suffix in translation system). Previously, I had my LANGUAGE enviroment variable containing “ar”, which is because I added Arabic in my “Language” KCM

D7660: Fix a regression caused by changing backspace key behavior

2017-12-24 Thread Safa Alfulaij
This revision was automatically updated to reflect the committed changes. Closed by commit R39:0f2335f3edc0: Fix compilation (authored by safaalfulaij). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=24349=24361 REVISION DETAIL

D7660: Fix a regression caused by changing backspace key behavior

2017-12-23 Thread Safa Alfulaij
safaalfulaij updated this revision to Diff 24349. safaalfulaij added a comment. Fix compilation issues REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=24338=24349 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7660 AFFECTED

D7660: Fix a regression caused by changing backspace key behavior

2017-12-23 Thread Safa Alfulaij
This revision was automatically updated to reflect the committed changes. Closed by commit R39:c9b412d40334: Fix a regression caused by changing backspace key behavior (authored by safaalfulaij). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D7660: Fix a regression caused by changing backspace key behavior

2017-11-23 Thread Safa Alfulaij
safaalfulaij added a comment. I can commit but it is showing as not accepted. So I'll just wait for the final confirmation. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff, cullmann Cc:

D7660: Fix a regression caused by changing backspace key behavior

2017-11-05 Thread Safa Alfulaij
safaalfulaij updated this revision to Diff 21916. safaalfulaij added a comment. - Applying last comment (hopefully I did what you meant :!) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19781=21916 BRANCH master REVISION DETAIL

D7660: Fix a regression caused by changing backspace key behavior

2017-10-25 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D7660#158479, @ngraham wrote: > @safaalfulaij, any progress on the latest comments? Not really. I was busy with college. I'll try finishing it in the coming week. REPOSITORY R39 KTextEditor REVISION DETAIL

D7660: Fix a regression caused by changing backspace key behavior

2017-09-22 Thread Safa Alfulaij
safaalfulaij updated this revision to Diff 19781. safaalfulaij added a comment. - Typos and better if statement structure REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19370=19781 BRANCH master REVISION DETAIL

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
safaalfulaij added a comment. Sorry, my mistake. The post-commit trigger thing didn't close this, maybe because the #post part is there /me how come I didn't notice! :| https://cgit.kde.org/ktexteditor.git/commit/?id=bb328146ecd64f97710eb09f568001cd4d40f622 REPOSITORY R39 KTextEditor

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
This revision was automatically updated to reflect the committed changes. Closed by commit R39:bb328146ecd6: Fix trailing space visualization for RTL lines. (authored by safaalfulaij). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7840?vs=19564=19568

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D7840#146110, @kfunk wrote: > Indeed, thanks for those fixes. /me can see a nice blog post coming a long...? :) Not yet maybe There are other visualizations that are not working for RTL lines, like non-printable

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
safaalfulaij added a comment. Before: F3912046: Screenshot_٢٠١٧٠٩١٥_١٧٥٣٥٦.png After: F3912047: Screenshot_٢٠١٧٠٩١٥_١٧٥٦٢٨.png REPOSITORY R39 KTextEditor REVISION DETAIL

D7840: Fix trailing space visualization for RTL lines.

2017-09-15 Thread Safa Alfulaij
safaalfulaij created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Fix trailing space visualization for RTL lines. It was getting paint on top of the character (to the right of the cursor). TEST

D7839: Fix trailing space visualization for RTL lines

2017-09-15 Thread Safa Alfulaij
safaalfulaij abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7839 To: safaalfulaij Cc: kwrite-devel, #frameworks, cullmann, sars, dhaumann

D7839: Fix trailing space visualization for RTL lines

2017-09-15 Thread Safa Alfulaij
safaalfulaij created this revision. safaalfulaij added a project: Frameworks. Restricted Application added a project: Kate. REVISION SUMMARY Fix trailing space visualization for RTL lines. TEST PLAN N/A REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL

D7660: Fix a regression caused by changing backspace key behavior

2017-09-11 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D7660#144736, @jgrulich wrote: > The bug report is not publicly available, but it was about kate not removing composed characters, while other software do that. I now checked this with LibreOffice and QtCreator and it seems to

D7660: Fix a regression caused by changing backspace key behavior

2017-09-11 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D7660#144706, @jgrulich wrote: > Not sure I can say much, I wrote this patch because I got a bug report where for Indic locales they were not able to remove composed characters. while other software (QtCreator, Libreoffice)

D7660: Fix a regression caused by changing backspace key behavior

2017-09-10 Thread Safa Alfulaij
safaalfulaij updated this revision to Diff 19370. safaalfulaij added a comment. - Fix global and local view values REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19368=19370 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7660

D7660: Fix a regression caused by changing backspace key behavior

2017-09-10 Thread Safa Alfulaij
safaalfulaij updated this revision to Diff 19368. safaalfulaij added a comment. - Add the implementation of backspaceRemoveComposed REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19097=19368 BRANCH master REVISION DETAIL

D7715: [Plasma Components 3] Fix RTL in some widgets.

2017-09-10 Thread Safa Alfulaij
This revision was automatically updated to reflect the committed changes. Closed by commit R242:940adc7e6e69: [Plasma Components 3] Fix RTL in some widgets. (authored by safaalfulaij). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D7715: [Plasma Components 3] Fix RTL in some widgets.

2017-09-09 Thread Safa Alfulaij
safaalfulaij added a comment. It seems that the `TabBar`'s problem is an upstream issue with `ListView` and highlighting animation. Will report about it soon. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7715 To:

D7715: [Plasma Components 3] Fix RTL in some widgets.

2017-09-09 Thread Safa Alfulaij
safaalfulaij retitled this revision from "[WIP] Fix RTL in some plasmacomponents3 widgets." to "[Plasma Components 3] Fix RTL in some widgets.". REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7715 To: safaalfulaij, #plasma,

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

2017-09-06 Thread Safa Alfulaij
safaalfulaij added inline comments. INLINE COMMENTS > broulik wrote in ProgressBar.qml:33 > That's pretty clever, actually, > > > A negative scale causes the item to be mirrored when rendered. > > However, not sure we can just blatantly mirror that graphic Actually, it’s used in default QQC2

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

2017-09-06 Thread Safa Alfulaij
safaalfulaij added a comment. One widget I didn't know how to fix is the TabBar (The blue line that flows from left to right for the first item.) Other widgets are behaving the same as QQC2 ones, like BusyIndicator and Dial, so I didn't change them. Not sure if they should be flipped or

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

2017-09-06 Thread Safa Alfulaij
safaalfulaij created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some widgets are missed up in RTL mode, this should fix it. REPOSITORY R242 Plasma Framework (Library) BRANCH master

D7660: Fix a regression caused by changing backspace key behavior

2017-09-02 Thread Safa Alfulaij
safaalfulaij added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor Cc: kwrite-devel, #frameworks

D7660: Fix a regression caused by changing backspace key behavior

2017-09-02 Thread Safa Alfulaij
safaalfulaij created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY This is a patch trying to fix the regression caused by an old patch .

D7659: Fix a regression caused by changing backspace key behavior

2017-09-02 Thread Safa Alfulaij
safaalfulaij abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7659 To: safaalfulaij, #ktexteditor Cc: kwrite-devel, #frameworks

D7659: Fix a regression caused by changing backspace key behavior

2017-09-02 Thread Safa Alfulaij
safaalfulaij created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is a patch trying to fix the regression caused by an old patch . Backspace key