Re: KEmoticons, emoticons kcm

[Sandro Knauß]

Hi,

> Now while I know why this exists, it feels like it's more of a thing
> of the past from when people wrote :) instead of . 

Okay now I feeling old :-) -  I don't even know how to create a unicode 
smiley, that's why I always create these :-) smileys. 

hefee

Re: New Framework Review: KDAV

[Sandro Knauß]

Hi,

> In mostly all files it is not clear if the LGPL or the GPL is meant (stating
> "GNU Library General Public License" and referring to the GPL text at the
> end of the statement). This license statement is used for all files except
> autotests/fakesever.cpp and autotests/fakeserver.h.
> Luckily, from the copyright statements there are only 3 copyright holders:
> Tobias, Sandro and Gregory. I put all 3 into CC.
> 
> @Tobias, Sandro, Gregory: Can you clarify that the code you are holding
> copyright about in this repository is licensed according to
> LGPL-2.0-or-later?

I'm fine with (re-)licensing this code to  LGPL-2.0-or-later.

Sandro



signature.asc
Description: This is a digitally signed message part.

T11542: Remove KHTML

[Sandro Knauß]

knauss reopened subtask T11575: Port Parley away from KHTML as Open.

TASK DETAIL
  https://phabricator.kde.org/T11542

To: knauss
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, 
#frameworks, knauss, GB_2, kpiwowarski, asturmlechner, vkrause, dfaure

D23801: Port kpac from QtScript

[Sandro Knauß]

knauss added a task: T11530: Investigate removal of KIO's KPAC in favor of 
QNetworkProxy.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23801

To: carewolf, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D21168: create-abi-dump: Handle clang/*/include 
directories..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D20769: abi-compliance-checker: disable clang include 
directories completly..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss added a task: T10716: Add check for accidental http: usage.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54680.
knauss added a comment.


  fixing a typo.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54679=54680

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/base.htignore
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py
  kde-modules/nossl.htignore
  kde-modules/reduce-warning.htignore
  kde-modules/xml.htignore

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54679.
knauss added a comment.


  make parallel network requests.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54663=54679

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/base.htignore
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py
  kde-modules/nossl.htignore
  kde-modules/reduce-warning.htignore
  kde-modules/xml.htignore

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54663.
knauss added a comment.


  complete diff.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54662=54663

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/base.htignore
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py
  kde-modules/nossl.htignore
  kde-modules/reduce-warning.htignore
  kde-modules/xml.htignore

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54662.
knauss added a comment.


  now with glob matching and another round of renaming blacklist files.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54640=54662

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/base.htignore
  kde-modules/blacklist.list
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py
  kde-modules/nossl.htignore
  kde-modules/reduce-warning.htignore
  kde-modules/xml.htignore

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54640.
knauss added a comment.


  remove BLACKLSIT for httpcheck

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54639=54640

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/blacklist.list
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54639.
knauss added a comment.


  add httpupdate and split out blacklist file

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54617=54639

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/blacklist.list
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss added a comment.


  In D19996#436824 , @winterz wrote:
  
  > this would be a nice addition to Krazy.  on my todo list.
  
  
  we are actually planing to push the list of blacklisted matches to a single 
file, so other scripts can take the list too.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54617.
knauss added a comment.


  search for http://\S
  
  and update blacklist.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54615=54617

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/httpcheck.py

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54615.
knauss added a comment.


  add more excludes.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54613=54615

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/httpcheck.py

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54613.
knauss added a comment.


  update http regex

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54612=54613

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/httpcheck.py

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54612.
knauss added a comment.


  update python script.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54611=54612

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/httpcheck.py

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a subtask: T10504: Abi compliance checker flaky/not working.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19410: create-abi-dump: Do not break for library, 
that don't have a SONAME..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19377: check-abi: refactor script.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19376: remove unnessary include..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19375: check-abi: make it possible to break the 
build..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19374: create-abi-dump: set logging for 
paramiko.transport to WARNING.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  Please  merge the commits in following order:
  D19219 
  D19220 
  D19221 
  D19222 
  D19218 
  
  I don't want to merge the different patches, as it is a lot easier to review 
and to understand what is going on.  I did not find a way to bundle different 
patches.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19218: create-abi-dump: small cleanup.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19221: create-abi-dump: Let make it possible for 
create-abi-dump to break a build..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19222: create-abi-dump/check-abi: implement new 
accMetadata..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19220: create-abi-dump: match new jenkings log 
format..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D19219: create-abi-dumps: do more debugging..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  In T3689#175858 , @danders wrote:
  
  > Afaiu abi-dumper is the new way of creating dumps. From home page:
  >  "This new way is based on the analysis of the debug-info from binary 
objects. It's more reliable, faster and simple way. "
  >  Any particular reason for not to use abi-dumper? (Just curious)
  
  
  IMO the homepage is not that clear about this. It tells me yes I can use 
abi-dumper for the library dump, but  abi-complience-checker  can also check 
the header files, that is so far not possible to check with abi-dumper.
  
  > Anyway, I compiled both stable and unstable versions myself, created dumps 
with abi-dumper and got a clean bill.
  >  So I'm pretty certain the problem reported on CI is not correct (but I 
have been wrong before).
  
  Thanks for checking. So we need to give acc the information to not check 
internal Qt structures.
  
  @bcooksley: Did Qt 5.10 got a minor update recently, that is compiled 
differently?

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  To create a dump by hand this isn't that easy. see 
sysadmins/ci-tooling/helpers/create-abi-dump.py.
  
  > I was unsuccesful using abi-dumper
  
  So far I understood abi-dumper is something different - I use 
abi-complience-checker to create those dumps.
  
  As you need some more environment for this script, I ended up using 
docker-composer and a script to test this locally.
  
  F6606201: docker-compose.yml 
  
  F6606202: ci-build.sh 

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  I'm not a expert in abi-complience-checker, so we need to find out together...
  
  In T3689#175022 , @danders wrote:
  
  >
  
  
  The ABI error started with build 4:
  https://build.kde.org/job/Calligra/job/kdiagram/job/kf5-qt5%20SUSEQt5.10/4/
  
  but yes I can't see why the symbols are changed. Maybe the Qt version was 
switched in between. But from the error type it sounds like, that acc do not 
get the needed information of the underlying structure of QSet/QPair and can't 
garantee that this structure will be the same in future.
  
  > Afaics these lines have not been changed since last release.
  
  Well we don't have a released version with ABI, so we just check them against 
a470d77be5a33529a95eb89243ddfaef6ee27ee7 
. 
This will change if the next version is released.
  
  > Also it does not complain about similar use in calligra (although not 
*exactly* the same, calligra uses other datatypes)
  
  
  
  > Can anybody shed any light on this?
  
  well you can dig more into it by getting the abi dumps:
  https://build-artifacts.kde.org/production/ABIReference/
  
  after you downloaded two of the dumps you can check them again locally:
  
abi-compliance-checker -l KGrantt --old  --new 
  
  than you can look to all outputs yourself.
  
  The abidumps look different:
  
  for a470d77be5a33529a95eb89243ddfaef6ee27ee7 
:
  
'90987' => {
 'Algn' => 1,
 'Header' => 'qpair.h',
 'Line' => '49',
 'Memb' => {
 '0' => {
  'algn' => 1,
  'name' => 'first',
  'type' => '11416'
},
 '1' => {
  'algn' => 1,
  'name' => 'second',
  'type' => '11416'
}
   },
 'Name' => 'QPair',
 'TParam' => {
   '0' => {
'name' => 'struct QDateTime'
  },
   '1' => {
'name' => 'struct QDateTime'
  }
 },
 'Type' => 'Struct'
   },
  
  and for f7f9ca1a7a8bfd550022ca4aafe3bb2985a1bee4 

  
'90223' => {
 'Algn' => 1,
 'Header' => 'qpair.h',
 'Line' => '49',
 'Name' => 'QPair',
 'TParam' => {
   '0' => {
'name' => 'struct QDateTime'
  },
   '1' => {
'name' => 'struct QDateTime'
  }
 },
 'Type' => 'Struct'
   },
  
  so yeah somehow it does not get as much information out of qpair.h as before.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

22.-26. March 2019, Leipzig - KDE Privacy Sprint

[Sandro Knauß]

Hi,

The Privacy sprint is coming  we're happy to announce the preliminary
date as 22.-26. March 2019 in Leipzig, Germany and we're looking forward to 
seeing you there. So please give us feedback, if you want to come. You can 
also get reimbursement via https://reimbursements.kde.org

We're working hard on making this sprint amazing and look forward to all
the constructive fun we're going to have.

Best, the privacy goal sprint team 
Florian, Louise and Sandro

--

On Mittwoch, 28. November 2018 13:56:54 CET Sandro Knauß wrote:
> Hey,
> 
> We volunteered to organize a KDE Privacy Sprint. We wanted to make it happen
> in March. We think at a sprint of five days. The main goal for the sprint
> is to locate privacy issues and after locating them hopefully fix them.
> Let's take the advantage to speak in person with multiple people of
> different part in KDE to find solutions. Currently the date is not fixed,
> so we doodle for one:
> 
> https://bitpoll.mafiasi.de/poll/8BYKJA5B/
> 
> Please add yourself to the doodle fast, so that we can have a fixed date
> within the next weeks.
> 
> Explicitly we would like to invite people from following teams:
> Plasma
> Plasma mobile
> Vault
> Falkon
> Choqok
> KDE Pim
> Frameworks
> 
> Please feel also invited, if you are not in such a team an be simply
> interested in that topic!
> 
> The sprint will either be located in Leipzig(Germany) or Les Magnas (France)
> http://auxsaisons.free.fr/. At the moment both options are still open, but
> soon we need to decide. What is your preference of place?
> 
> Some issues that came into my mind:
> 
> *  currently when clicking on a link in an email the url is accessed within
> Plasma and than forward this to Firefox. If the user wants to use TorBrowser
> as default browser it is a Privacy Breach.
>  *  having an interface to torify/vpn applications
> 
> Wifi:
> 
> * detect wiki login pages - do not access internet before, e.g. you are
> using inet of a hotel
> *  have a way to allow/dissallow applications interact with inet for
> specific wifis, e.g. you are using inet of a hotel
> 
> TLS:
> 
> * detecting bad SSL standards aka only TLS 1.0...
> * more helpful SSL problem dialog (properly if you have a wifi login page)
> 
> Mails:
> 
> * Encrypting headers of mails to give less metadata to surveillance T742.
> * Make it possible to search in encrypted mails, as until now, the encrypted
> data are a binary blob for the search. The search important to find mails
> again T8447.
> * Add GnuPG TOFU (Trust On First Use) trust model support for KMail. With
> TOFU you will get more security without exchanging the gpg fingerprints. To
> make it clear, exchanging fingerprints gives better security, but is
> exhausting.
> * Make Akregator webviewer protect against ad trackers T7528.
> 
> For more information look at https://phabricator.kde.org/T8622.
> 
> Share your thoughts and see you!
> 
> louise and hefee

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  YEAH so far the abi-compatibility-results.yaml for pim and Frameworks, as far 
as they got update the last days.
  So we are surly hitting the end of this and catching up the loosen tails of 
all of this. I'll focus currently on other stuff, will look at it and fix stuff 
in a week or so.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17880: check-abi: Fix error logging for non 
compatible builds..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17843: python3.6 has no capture_output paramenter for 
subprocess.run..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17837: Switch to the new syntax (spaces -> tabs)..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17836: add clang/7.0.0/include to make 
abi-compliance-checker happy again..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17798: publish acc build logs as artifacts..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  In T3689#170799 , @davidedmundson 
wrote:
  
  > > kwayland
  > > 
  > >   KWayland/Client/xdgforeign_v2.h -> missing include "xdgforeign.h"
  >
  > This is now hopefully fixed. Please let me know if it's still an issue.
  
  
  Thx, it looks fine so far. You see that now KF5Wayland_compat_report.html is 
created:
  
  https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/6/

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17770: create a YAML file for further processing the 
output of abi-compliance-checker..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17769: activate syntax ( replace spaces -> tabs..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  I have made sure that kde/pim is now cleanup in terms of the issue of "not 
runnig ABI", by triggering a rebuilt. So it is a good test if the patch is 
working.
  With more tests I have detected, that builds still use the oldest commit 
instead of tags commits (fix D17745 ) .

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17745: resolve tags to the commit, that was tagged..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  In T3689#170601 , @bcooksley wrote:
  
  > I checked execution of KDav on all four build nodes, and the process ran 
fine when done manually.
  >  Given there is no output from check-abi.py, this is quite hard to diagnose.
  
  
  In the last `for l in libraries:` loop, we get output for every item in that 
list, etiher because there are candidates or there are not.
  That means the only way to produce no output at all is that libraries list 
must be empty. We do not remove any entry from that list, so the initial search 
do not find any matching entry.
  And the only way the list can be empty is that the `for key, entry in 
ourArchive.serverManifest.items()` don't find any matching entry.
  
  > Can you propose some debug output which might point out why it's doing 
nothing?
  
  I added D17710  to retry to reload the 
serverManiphest file again after 5secs to sleep. The added output is hopefully 
enough to spot the issue.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17710: check-abi.py: Reload serverManiphest several 
times, if we don't find matching entries..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  In T3689#170284 , @bcooksley wrote:
  
  > In regards to `akonadi-mime` I have now re-run it, and it seems to work 
fine.
  >  As long as you're relying only on the master manifest.yaml, then it should 
be impossible for any publishing failure to cause issues.
  
  
  Well if if would be just `akonadi-mime`, I would not care. but it is actually 
a lot more failing with the same pattern.
  
  What I did for checking:
  *download this  consoleText: 
https://build.kde.org/job/Applications/job/kdav/job/kf5-qt5%20SUSEQt5.10/lastCompletedBuild/consoleText
  
  - than do some simple regex:
- (Successfully created a dump (`^.*Dump path: abi_dumps/.*/ABI\.dump\s*$`)
- search for  "Comparing ABIs"
  
  F6487824: ci-check.py 
  
  And the outcome is overwhelming - a lot of is broken. I checked a lot locally 
via docker and could not reproduce this bug. That's why I think it is something 
with publishing the packages. Is it just one server, or is there any load 
balancing come into account so request are answered by a different sever, that 
isn't synced?
  
  for kde/pim/*:
  
  [ ] kblog
  [ ] mailcommon
  [ ] kmbox
  [ ] kontactinterface
  [ ] kpimtextedit
  [ ] akonadi-import-wizard
  [ ] kpkpass
  [ ] kldap
  [ ] kalarmcal
  [ ] libgravatar
  [ ] libkgapi
  [ ] libkleo
  [ ] grantleetheme
  [ ] kcontacts
  [ ] akonadi-notes
  [ ] kitinerary
  [ ] ktnef
  [ ] akonadi-mime
  [ ] kcalutils
  
  for frameworks:
  
  [ ] kcrash
  [ ] kwallet
  [ ] kpackage
  [ ] kholidays
  [ ] kparts
  [ ] syndication
  [ ] frameworkintegration
  [ ] khtml
  [ ] krunner
  [ ] knotifyconfig
  [ ] kidletime
  [ ] kitemviews
  [ ] kjobwidgets
  [ ] kmediaplayer
  [ ] kpeople
  [ ] prison
  [ ] kxmlrpcclient
  [ ] sonnet
  [ ] kcoreaddons
  [ ] kunitconversion
  [ ] kfilemetadata
  [ ] baloo
  [ ] kitemmodels
  [ ] kpty
  [ ] kconfig
  [ ] kxmlgui
  [ ] kconfigwidgets
  [ ] kdbusaddons
  [ ] kjsembed
  [ ] kplotting
  [ ] kactivities
  [ ] kdesu
  [ ] ki18n
  [ ] knotifications
  [ ] kactivities-stats
  [ ] attica
  [ ] ktexteditor
  [ ] solid
  [ ] kirigami
  [ ] syntax-highlighting
  [ ] kauth
  
  > In terms of the `akonadi-search` issue, using something like that YAML file 
should be fine yes and is historically how we've solved such issues.
  
  okay create D17672  for this.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17672: Move settings for abi-complience-checker to 
own yaml file..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D17579: Handle cases where tailing "/" in 
CMAKE_PREFIX_PATH fails the detection of additional include directories..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  @bcooksley for akonadi-search we need some special settings for the 
abi-create step. Where we should  store such settings?
  
  This is a more general solution, that we can also modify the settings for 
other platforms etc.
  
  `ci-tooling/local-metadata/abi-complience-checker.yaml`:
  
gcc_options:
- "-std=c++11"
- "-fPIC"
skip_include_paths:
- /usr/lib/python3.6/site-packages/utils/fake_libc_include
- /usr/include/clang/AST
- /usr/lib64/clang/6.0.1/include
add_include_paths:
- /usr/lib64/qt5/mkspecs/linux-g++

# "SUSEQt5.10":# platform specific
# gcc_options:
#- "-DSUSE5.10"

#"kde/*":# special settings for all repos in kde (fnmatch)
#   gcc_options:
#   - "-DKDE"

#"kde/pim/*":# special settings for all repos in kde/pim
#   gcc_options:
#   - "-DKDEPIM"
#  "SUSEQt5.10":   # for one specific platform
# gcc_options:
# - "-DKDEPIMSUSEQT5.10"

"kde/pim/akonadi-search": # for one repo
  "SUSEQt5.10":   # for one specific platform
gcc_options:
  - "-std=c++11"
  - "-fPIC"
  - "-DQT_NO_KEYWORDS"
  
  and the Python code to handle this:
  rules are:
  
  - anthing overwrites defauls (outer level)
  - most matching path overwrites less matching path
  - platform specific overwrites non platform stuff
  
  general -> specific
  default -> "basepath/*" -> "basepath/* - platform" -> "basepath/repo" ->  
"basepath/* - platform"
  
import yaml, fnmatch, copy

metadata = yaml.load(open('local-metadata/abi-complience-checker.yaml'))

def getSettings(path, platform):

entries = []
for key in metadata:
if fnmatch.fnmatch(path, key):
entries.append(key)

# sorting all entries - the entries at the end overwrites the former 
settings
# len is efficient, but would fail if we have single letter repo names
entries.sort(key=len)
entries.insert(0, platform) # add platform settings at the start

d = copy.copy(metadata) # load default settings
for entry in entries:
try:
  content = metadata[entry]
  d.update(content)
  d.update(content[platform]) # try to load platform specific 
settings
except KeyError:
  pass
return d

getSettings("kde/pim/akonadi-search",  "SUSEQt5.10")

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  okay with merging D17534  CI now 
successfully builds the abis for the mentioned packages. (I modified the last 
comment)

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  I use the ci-docker images to test the create-abi, but I can't reproduce why 
those are failing:
  
  - messagelib
  - kdav
  - libksieve
  - akonadi-import-wizard
  - kpkpass
  - libkgapi
  
  maybe those are also fixed by D17534  
otherwise I need more details.
  
  @bcooksley there is also an issue with akonadi-mime - that I don't understand.
  Build #2 

 is fine:
  
  - create-abi-dump.py is run successful
  - check-abi.py is happy: "Let's do a ABI check 
32025ac9cc671b7adf956d117555336703725ee4 
 
against 1dae8da6ab3ebe1f8f5acf5cd0c563557cd3cbda 
"
  
  but at Build #3 
:
  
  - create-abi-dump.py is run successful
  - check-abi does NOT check anything.
  
  running this step locally machine is successful:
  "Let's do a ABI check 327ed59cd15e6038bf3303ca5f30b4b51b2f61f0 
 
against 1dae8da6ab3ebe1f8f5acf5cd0c563557cd3cbda 
 "
  May this be an issue of publishing the buildArtifacts?

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  I now looked at every repository that failed to build successfully a ABI dump 
  for Pim. Most of them build successful, but a few of them have issues:
  
  - kmime has an unexported header in kmime/kmime_newsarticle.h: `#include 
` that lives in src/supertrait.h
  
  - akonadi-search is unhappy that xapian.h is not imported as first file.
  
  F6473684: log.txt 
  
  - kitinerary has an unexported header in KPim/kitinerary/airportdb.h: 
`#include "timezonedb.h"` that lives in src/knowledgedb/timezonedb.h
  
  - PimCommonAkonadi adds 
$ to 
target_include_directories, but KF5::IMAP is a private dependency. Can we 
remove this?
  
  - kdepim-apps-libs: FollowupReminder adds 
$ to 
target_include_directories. But both files in src/libfollowupreminder/src/*h 
don't use relative links to AkonadiCore. Can we remove this?

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added subscribers: kde-frameworks-devel, dfaure.
knauss added a comment.


  I now looked at every repository that failed to build successfully a ABI dump 
for Frameworks.
  As I'm not really deep into the Framworks code, so I'm unsure, if those are 
real issues or if those Frameworks need special handling.
  Please give me any response you have to those issues. (@aacid , @dfaure, 
@kde-frameworks-devel)
  
  From 79 packages inside Frameworks a lot run successfully. From those 5 
packages I'm quite sure, that those are real issues, that needs to get fixed:
  
  - kdelibs4support
- missing dependency to frameworks/kitemmodels
- failed to find #include 
  
  F6473565: log.txt 
  
  - kwayland
- KWayland/Client/xdgforeign_v2.h ->  missing `include "xdgforeign.h"`
  
  - kjs
- no include/KF5/kjs in INTERFACE_INCLUDE_DIRECTORIES
- CompileState.h includes non exported opcodes.h and bytecodes/opcodes.h 
#401955
  
  *plasma-framework
  
  - no include/KF5/KF5PlasmaQuick in INTERFACE_INCLUDE_DIRECTORIES for 
KF5PlasmaQuick
  
  compiles but has still error on the log:
  
  - networkmanager-qt
- failing building headers
  
  F6473566: log.txt 
  
  And some repositories, that have no public library. Is this intended?
  
  - KF5NewStuffQuick has no library (KF5NewStuff is fine)
  - extra-cmake-modules
  - kdesignerplugin
  - kinit
  - qqc2-desktop-style
  
  How this ABI checker tool works. As input the tool uses the output made while 
installing the package.
  
  - It scans this output for installs of ".*Config.cmake$" files
  - runs cmake in trace-expand mode for "find_package({name} CONFIG REQUIRED)"
  - scans this cmake output for
- PACKAGE_VERSION -> this is the library version
- IMPORTED_SONAME_DEBUG,  -> to get the soversion
- IMPORTED_LOCATION_DEBUG -> the the path of the lib
- INTERFACE_INCLUDE_DIRECTORIES -> all needed include directories
  
  - each exported header file is tried to be compiled and symbols are extracted.
  
  The sourcecode of this script you find in 
sysadmin/ci-tooling/helpers/create-abi-dump.py

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

KDE Privacy Sprint - Find a date

[Sandro Knauß]

Hey,

We volunteered to organize a KDE Privacy Sprint. We wanted to make it happen 
in March. We think at a sprint of five days. The main goal for the sprint is 
to locate privacy issues and after locating them hopefully fix them. Let's 
take the advantage to speak in person with multiple people of different part 
in KDE to find solutions. Currently the date is not fixed, so we doodle for 
one:

https://bitpoll.mafiasi.de/poll/8BYKJA5B/

Please add yourself to the doodle fast, so that we can have a fixed date 
within the next weeks.

Explicitly we would like to invite people from following teams:
Plasma
Plasma mobile
Vault
Falkon
Choqok
KDE Pim
Frameworks

Please feel also invited, if you are not in such a team an be simply 
interested in that topic!

The sprint will either be located in Leipzig(Germany) or Les Magnas (France) 
http://auxsaisons.free.fr/. At the moment both options are still open, but 
soon we need to decide. What is your preference of place?

Some issues that came into my mind:

*  currently when clicking on a link in an email the url is accessed within 
Plasma and than forward this to Firefox. If the user wants to use TorBrowser 
as default browser it is a Privacy Breach.
 *  having an interface to torify/vpn applications

Wifi:

* detect wiki login pages - do not access internet before, e.g. you are 
using inet of a hotel
*  have a way to allow/dissallow applications interact with inet for specific 
wifis, e.g. you are using inet of a hotel

TLS:

* detecting bad SSL standards aka only TLS 1.0...
* more helpful SSL problem dialog (properly if you have a wifi login page)

Mails:

* Encrypting headers of mails to give less metadata to surveillance T742.
* Make it possible to search in encrypted mails, as until now, the encrypted 
data are a binary blob for the search. The search important to find mails 
again T8447.
* Add GnuPG TOFU (Trust On First Use) trust model support for KMail. With 
TOFU you will get more security without exchanging the gpg fingerprints. To 
make it clear, exchanging fingerprints gives better security, but is 
exhausting.
* Make Akregator webviewer protect against ad trackers T7528.

For more information look at https://phabricator.kde.org/T8622.

Share your thoughts and see you!

louise and hefee

signature.asc
Description: This is a digitally signed message part.

D10075: Make pacakge usefull for cross compilation

[Sandro Knauß]

knauss added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in CMakeLists.txt:45
> the 3rd parameter is a bool. This change won't do what you expect.
> 
> (https://cmake.org/cmake/help/v3.0/command/option.html)

well it compiles like I expected it... but yeah I see this is a bug not a 
feature :)

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10075

To: knauss, #frameworks, skelly
Cc: cgiboudeaux, #frameworks, michaelh, bruns

D10075: Make pacakge usefull for cross compilation

[Sandro Knauß]

knauss added a comment.


  @skelly: IMO it makes sense to discuss also the needed change in ECM, to 
solve the issue popperly.
  
  Just a side note - me personally is not very deep into the cross compilation 
topic. That's why I can understand, if you have many questions and do not get 
it, why this is needed :D
  
  Please feel free to ask any questions, I will try to anwser them, of forward 
them, if needed.
  Also feel welcome to join #debian-qt-kde on irc.debian.org to discuss this 
more direct.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10075

To: knauss, #frameworks, skelly
Cc: #frameworks

D10075: Make pacakge usefull for cross compilation

[Sandro Knauß]

knauss added reviewers: Frameworks, skelly.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10075

To: knauss, #frameworks, skelly
Cc: #frameworks

D10075: Make pacakge usefull for cross compilation

[Sandro Knauß]

knauss created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
knauss requested review of this revision.

REVISION SUMMARY
  kauth-gen-policy appears to be a tool for turning a text file in
  qsettings format (similar to .ini) into an xml file. Both are textual,
  so it seems like putting kauth-gen-policy into a Multi-Arch: foreign
  package (like kconfig_compiler_kf5 in #887452).
  
  In a cross compilation environment, kauth-gen-policy is called from the
  host system and not from the target system, so a arch depdend path
  (/usr/lib/) do not make sense in that case and a arch indepdend
  should be used. As we do not want to break other usecases we used the
  non indrudive way possible, to change this to an option, so we can
  modify the path with a camke option.
  
  The bigger picture is to fix libexec path in extra-cmake-modules to a
  arch-independed path, as recommended in the FHS 3.0.
  
  887452 https://bugs.debian.org/887452
  
  Bug-Debian: https://bugs.debian.org/887521

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10075

AFFECTED FILES
  CMakeLists.txt

To: knauss
Cc: #frameworks

Re: KHolidays as Framework (redux)

[Sandro Knauß]

Hey,

@Volker:  Is there a need to rush releasing KHolidays it under frameworks?

As far I see it, the include mechanism do not change find_package do not need 
to change and also the target_libraries do not need to changed also the API is 
fixed so far -> no changes in kdepim needed. The only thing that changes is 
the big bump of the version number and there will be some BIC cleanup, so 
there will be BIC breakage with that move. Distributions need to rebuild 
everything against the new framework. With only BIC changes there should be no 
big issue for distributions to ship a uptodate kdepim (17.12.X) with a 
uptodate KDE frameworks.

sandro

PS: please also inform distributi...@kde.org, if the switch has a fixed date. 

On Sonntag, 14. Januar 2018 15:59:46 CET Allen Winter wrote:
> I don't object to making KHolidays a framework.
> I kinda object to the short timeline.
> 
> I wanted to finish up some BIC cleaning.  No API changes planned at this
> time. I'll try to hurry.
> 
> On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote:
> > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:
> > > On Friday 01 January 2016 18:24:17 David Faure wrote:
> > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > > > > Hi,
> > > > > 
> > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays
> > > > > again
> > > > > for inclusion as a Framework. As far as I am aware there are no
> > > > > outstanding
> > > > > porting issues with KHolidays and it is ready for review to be
> > > > > included
> > > > > as
> > > > > a Tier 1 Framework in the next possible release. What's the next
> > > > > step?
> > > > 
> > > > Please make sure it passes all of the items in this checklist
> > > > https://community.kde.org/Frameworks/CreationGuidelines
> > > 
> > > AFAICS this is followed, apart from using the KF5 version number and
> > > actually being marked as a framework, which I guess is pending framework
> > > approval.
> > 
> > This got lost somehow, any objection to executing the move to frameworks
> > for 5.43, say end of this week?
> > 
> > Regards,
> > Volker




signature.asc
Description: This is a digitally signed message part.

Review Request 129611: Make Gpgme a required dependency if we build Gpgme interface.

[Sandro Knauß]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129611/
---

Review request for KDE Frameworks.


Repository: kwallet


Description
---

Acording to the README of QGpgME, we cannot expect to be gpgme.h be available, 
so we need to search for GpgME by our own.

See 
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=blob;f=lang/cpp/README;h=b9a48da15ce424a08d0e8c5d20846af8882da193;hb=HEAD#l31

  31 7. Complete abstraction of the C-API so "gpgme.h" should not
  32be needed in your project using GpgME++.


Diffs
-

  src/runtime/kwalletd/CMakeLists.txt 5092a7e77a1ca7203827e444c11310566b2cc8b5 

Diff: https://git.reviewboard.kde.org/r/129611/diff/


Testing
---


Thanks,

Sandro Knauß

Re: Review Request 127462: Add support for get QStandardPaths locations.

[Sandro Knauß]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/
---

(Updated March 28, 2016, 3:47 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

Submitted with commit 50f191eaba9b076675a52252dd8f2a5aaf5b1bb0 by Sandro Knauß 
to branch master.


Repository: kconfig


Description
---

Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.


Diffs
-

  autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
  autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
  docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
  src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 

Diff: https://git.reviewboard.kde.org/r/127462/diff/


Testing
---

Adding tests for QT_*_HOME variables.


Thanks,

Sandro Knauß

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for get QStandardPaths locations.

[Sandro Knauß]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/
---

(Updated März 28, 2016, 3:21 nachm.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

Get rid of explitly ask XDG_*_HOME variables.


Repository: kconfig


Description
---

Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.


Diffs (updated)
-

  autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
  autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
  docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
  src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 

Diff: https://git.reviewboard.kde.org/r/127462/diff/


Testing (updated)
---

Adding tests for QT_*_HOME variables.


Thanks,

Sandro Knauß

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for get QStandardPaths locations.

[Sandro Knauß]

> On März 28, 2016, 5:39 vorm., Matthew Dawson wrote:
> > Much better!  I don't think this should handle XDG* variables explicitly, 
> > as they won't be used on other platforms and may cause confusion there.  On 
> > platforms using XDG* variables, Qt handles this for us internally.  I 
> > opened issues accordingly below.  Other then that, looks good to me.

But where does Qt handles these internally? At the moment Qt isn't doing this 
at all. If we don't respect XDG_*_Home it is a unexpected result for XDG 
conform desktops. Do you suggest to #ifdef the XDG handling?


> On März 28, 2016, 5:39 vorm., Matthew Dawson wrote:
> > autotests/kconfigtest.cpp, line 581
> > <https://git.reviewboard.kde.org/r/127462/diff/2/?file=454401#file454401line581>
> >
> > We unfortunately can't test XDG* variables due to Qt, but I think we'll 
> > be ok for now.  The rest of the looks fine.

Well the test is green, so this works :D


- Sandro


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/#review94057
-------


On März 27, 2016, 2:22 nachm., Sandro Knauß wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127462/
> ---
> 
> (Updated März 27, 2016, 2:22 nachm.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Inside desktop files we want to reach also data, cache and config home
> to create files inside these directories.
> 
> 
> Diffs
> -
> 
>   autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
>   autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
>   docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
>   src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 
> 
> Diff: https://git.reviewboard.kde.org/r/127462/diff/
> 
> 
> Testing
> ---
> 
> Adding tests for XDG_*_HOME variables.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for get QStandardPaths locations.

[Sandro Knauß]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/
---

(Updated März 27, 2016, 2:22 nachm.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

Fixed raised issues.

Rename the varaibles to QT_*_HOME and update the tests.


Summary (updated)
-

Add support for get QStandardPaths locations.


Repository: kconfig


Description (updated)
---

Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.


Diffs (updated)
-

  autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
  autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
  docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
  src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 

Diff: https://git.reviewboard.kde.org/r/127462/diff/


Testing
---

Adding tests for XDG_*_HOME variables.


Thanks,

Sandro Knauß

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

[Sandro Knauß]

> On März 24, 2016, 9:15 vorm., Jarosław Staniek wrote:
> > My thoughts mostly related to non-Plasma, non-XDG run environments.
> > 
> > KF5 is a great addition, in hierarchy often sitting aside of Qt, not a part 
> > of XDG-compliant desktop. As such we can't say too much about the 
> > underlying OS. It may be XDG-compliant but athis can be a decission at 
> > various levels: by application developer or on deployment. Things can of 
> > course also change after the binary is compiled.
> > 
> > It's hard to see any benefit that apps 'pretend' being XDG-compliant by 
> > setting vartiables this way on, say, MS Windows or Mac. Qt applications on 
> > these systems do not traditionally alter the OS' paradigm, they are.. just 
> > apps, as native as possible/reasonable. Example: there are portable apps 
> > (on an USB stick) - I believe we can benefit if we help making them. These 
> > apps choose not to integrate too much with what's found on the system, 
> > often the user account is shared or temporary.
> > 
> > Setting the variable makes KConfig closer to specific groups of desktop, 
> > which is a a small step back. People may be interested in KConfig lib as a 
> > general purpose utility in their apps.
> > I'd compare setting the variable this way to setting Windows' USERPROFILE 
> > variable on Linux systems, just because it's standard under the former and 
> > under Wine. it does not hurt but leaves bad taste.
> > 
> > So the behaviour at least shall be ifdef'd and the ifdef shall depend on OS 
> > for which we're building. But if the same binary should behave well in 
> > various environments, I am unsure about hardcoding the behaviour. Also I am 
> > not sure if this behaviour should be ON by default. I'd rather have it OFF 
> > if it's present at all.

Well I see it the other way around. Without support of XDG variables 
replacement, we need to use env varaible that are available on all systems 
f.ex. $HOME, so the only way to set the datalocaltion to write it hardcoded in 
the config to $HOME/.local/share. This is really ony true for linux for others 
OSes you want to have other diretories. So now we are able to use XDG_DATA_HOME 
to be used in kconfig and it will be replaced for linux to $HOME/.local/share, 
for windows to C:/Users//AppData/Local and so on.
We use QStandardsPaths for replacing so if the replacement is not correct for 
an OS this is a bug on Qt side, that should be fixed :D

And I can't see how this support can harm anyone - if the env is set this is 
prefered and only if it is not set it is replaced. No dependecy is added and 
applications are free to not use it at all. If you use XDG_*_HOME without this 
patch you will return an empty string for it:

i[$e] = $XDG_DATA_HOME/bla

-> will return /bla

with the patch you will get:
$HOME/.local/share/bla ( for linux)
C:/Users//AppData/Local/bla ( for windows)
[...]


- Sandro


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/#review93920
---


On März 22, 2016, 3:23 nachm., Sandro Knauß wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127462/
> ---
> 
> (Updated März 22, 2016, 3:23 nachm.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> According to freedesktop specification XDG_*_HOME env varaible should be
> replaced, if they are not setted with default values.
> 
> https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
> 
> as qgetenv only calls getenv, so no path is traslated to it default values. 
> So we have to add this replacement manually. This would help to use 
> XDG_*_HOME more often in configfiles.
> 
> 
> Diffs
> -
> 
>   autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
>   src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 
> 
> Diff: https://git.reviewboard.kde.org/r/127462/diff/
> 
> 
> Testing
> ---
> 
> Adding tests for XDG_*_HOME variables.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

[Sandro Knauß]

> On März 24, 2016, 8:16 vorm., David Faure wrote:
> > autotests/kconfigtest.cpp, line 536
> > <https://git.reviewboard.kde.org/r/127462/diff/1/?file=453758#file453758line536>
> >
> > Why? On my system this wouldn't pass.
> > If you want to make sure it's empty, use qunsetenv.

Okay I mostly written this, to get a first impression if the patch will enter 
kconfig.
for sure we need a test with XDG env set to a value, and one where XDG is not 
set. To test both ways.


> On März 24, 2016, 8:16 vorm., David Faure wrote:
> > autotests/kconfigtest.cpp, line 538
> > <https://git.reviewboard.kde.org/r/127462/diff/1/?file=453758#file453758line538>
> >
> > writableLocaion, not displayName.
> > 
> > This shows the limitations of a unittest that uses the same code in the 
> > code and in the test. If both are wrong, the test still passes :-)

Do you have a better solution for getting away from "a unittest that uses the 
same code" in this case?


- Sandro


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/#review93914
---


On März 22, 2016, 3:23 nachm., Sandro Knauß wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127462/
> ---
> 
> (Updated März 22, 2016, 3:23 nachm.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> According to freedesktop specification XDG_*_HOME env varaible should be
> replaced, if they are not setted with default values.
> 
> https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
> 
> as qgetenv only calls getenv, so no path is traslated to it default values. 
> So we have to add this replacement manually. This would help to use 
> XDG_*_HOME more often in configfiles.
> 
> 
> Diffs
> -
> 
>   autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
>   src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 
> 
> Diff: https://git.reviewboard.kde.org/r/127462/diff/
> 
> 
> Testing
> ---
> 
> Adding tests for XDG_*_HOME variables.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127462: Add support for XDG_*_HOME enviroment variables.

[Sandro Knauß]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/
---

Review request for KDE Frameworks and Matthew Dawson.


Repository: kconfig


Description
---

According to freedesktop specification XDG_*_HOME env varaible should be
replaced, if they are not setted with default values.

https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

as qgetenv only calls getenv, so no path is traslated to it default values. So 
we have to add this replacement manually. This would help to use XDG_*_HOME 
more often in configfiles.


Diffs
-

  autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
  src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 

Diff: https://git.reviewboard.kde.org/r/127462/diff/


Testing
---

Adding tests for XDG_*_HOME variables.


Thanks,

Sandro Knauß

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Versioning of Frameworks

[Sandro Knauß]

Hey,

 Or the other way around -- if it is at one point indeed working with these
 versions, what will happen is that someone will use a new feature from an
 underlying framework at some point, and forget to upgrade the required
 version. This will happen many times per month, not just once a year, I know
 this for sure. See the number of times where someone commits Qt-5.4-only
 code right now in frameworks that are supposed to work with Qt 5.2, but
 they don't realize when writing QSignalSpy(obj, Class::member) that this
 syntax wasn't available in Qt 5.2. It's already a fight to get this right
 with the *one* Qt version number, I can't even imagine how tricky this
 would become with 62 * 5 = 310 version numbers to keep right (62 frameworks
 each depending on an average of 5 other frameworks - I made up that number,
 feel free to calculate it more precisely).

The minimal build dependency can also be tested via CI. For example on debian 
we create symbol files, with ther version, where they were added. With these 
debian sets the minimal dependency. And frameworks have BIC guarantee, so the 
symbols should be tested via CI anyhow, to prove that guarantee.

I know that, also if the symbols haven't changed, important bugs can be fixed 
in newer version, so newer version are needed/recommended. But a minimal build 
dependecy never says, that it is not recommended to use never ones :)

 Making the release dude's life (i.e. my life) harder is one thing I'll fight 
against, but the other reason is that a version zoo also makes things harder 
for everyone else: packagers, developers and users.

me as packagers: no, still download the nestest hottest shit and package this. 
Via symbolfiles I can set the mininimal dependency. Put the packages at a repo 
and users will get the new ones.

me as developers: no, if I work for example at kdepim I need many frameworks, 
so I compile them once. Afterwards i only compile newer frameworks, if i need 
to :) This either happens, because a featuers need a new frameworks (fails 
compiling) or cmake says so. If i have to update one framework i get master.

Regards,

sandro
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel