On 28/12/2019 23:30, Friedrich W. H. Kossebau wrote:
Why are you proposing to do a step back instead to the old state, which
everyone including you considered not that satisfying?
Because it's a temporary situation. We still have a way forward in KF6
(which will open in a few months).
On 22/12/2019 16:08, Stephen Kelly wrote:
On 21/12/2019 23:55, Friedrich W. H. Kossebau wrote:
Perhaps joining the "Release Service" (formerly known as "KDE
Applications")
is a better place then, it also contains a set of libraries already.
That would serve the purpos
On 21/12/2019 23:55, Friedrich W. H. Kossebau wrote:
Perhaps joining the "Release Service" (formerly known as "KDE Applications")
is a better place then, it also contains a set of libraries already.
That would serve the purpose of having releases happening regularly.
The goals of making
On 21/12/2019 19:12, Friedrich W. H. Kossebau wrote:
Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly:
Great, Grantlee is now available at g...@git.kde.org:grantlee.git.
I've pushed a few commits to make it depend on ECM etc.
Once the review period is finished it can
On 21/12/2019 21:33, Volker Krause wrote:
* Attracting external components and having them opt to move under the
Frameworks umbrella is a sign that we are doing things right IMHO. So let's
make this easy for people and avoid scaring off their users by forcing a
larger migration on them when
On 08/12/2019 10:12, laurent Montel wrote:
Le dimanche 8 décembre 2019, 10:52:19 CET Volker Krause a écrit :
Hi,
very happy to see Grantlee "coming home" :)
Technically I think it's largely in line with Frameworks requirements
already, and it has been reliably powering e.g. KMail's message
Hi Ben,
Thanks for looking into this!
>From reading your email, it seems that the correct path is in
GPB_PYTHON3_INCLUDE_DIR, but that is not being added as an include
directory to compile the code.
>From reading the ECM code (FindPythonModuleGeneration.cmake) I don't see
how that could be.
skelly added a comment.
My preference would be to use the ClangConfig.cmake instead of introducing
these new files.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5289
To: heikobecker, #frameworks, #build_system, skelly, kfunk
Cc: rdieter, shaheed,
On 05/26/2017 10:21 PM, Albert Astals Cid wrote:
> El dijous, 25 de maig de 2017, a les 1:02:58 CEST, Stephen Kelly va escriure:
>> On 04/15/2017 10:53 PM, Luca Beltrame wrote:
>>> I can't understand the error thrown by ki18n (when it does not build) or
>>> I'd have
On 04/15/2017 10:53 PM, Luca Beltrame wrote:
> I can't understand the error thrown by ki18n (when it does not build) or I'd
> have attempted to fix it myself...
Hi, sorry for my delayed response.
Should we disable the ki18n bindings at this point? I'm fine with doing
that until someone can
On 05/05/2017 11:21 AM, David Faure wrote:
> On samedi 15 avril 2017 16:17:43 CEST Luca Beltrame wrote:
>> In data sabato 15 aprile 2017 16:10:24 CEST, Luca Beltrame ha scritto:
>>> https://build.opensuse.org/build/
>>> home:luca_b:branches:KDE:Unstable:Frameworks/openSUSE_Factory/x86_64/ki18n
>>>
skelly added a comment.
In https://phabricator.kde.org/D4509#85725, @shaheed wrote:
> The PEP-8 changes are some blank line changes.
There is exactly one blank line insertion, and it makes this TypedefRuleDb
documentation inconsistent with, say, the VariableRuleDb, which doesn't
skelly added inline comments.
INLINE COMMENTS
> sip_generator.py:172
> """
> +if member.kind == CursorKind.UNEXPOSED_ATTR and
> text.find("_DEPRECATED") != -1:
> +sip["annotations"].add("Deprecated")
It was possible to handle exports without looking for the text
skelly added inline comments.
INLINE COMMENTS
> rules_engine.py:58
> +# Keep PyCharm happy.
> +_ = _
> +
I don't think this should be here.
> rules_engine.py:494
> nameThe name of the
> typedef.
> +
skelly added a comment.
Is anything here actually a PEP 8 fix?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4509
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: shaheed, #build_system, #frameworks, skelly
Cc:
On 02/04/2017 12:49 PM, David Faure wrote:
>> @David Faure, when do you plan on tagging this change? For now I committed
>> a change to the auto test so it will at least build on Windows
>> (b939b48f8d5e5eaf9a51a7e9bda2ad8cedca27d9) which should be included. Would
>> there be time to remove
;>> exported.
>> Hi,
>> Apparently it is since eab822e20620 (Jan 15).
>> The bug #375654 does not seem to provide version info but the fix isn't
>> just released, right? CC'd Stephen Kelly.
> It seems this class was exported so it can be accessed through the Pyth
skelly added a comment.
It's true that QFlags has a ctor taking a nullptr. The bindings-related
problem was in our handling of enums by prepending a namespace, so we would end
up with Qt::nullptr. I've fixed that in ECM, and also fixed handling of = {}
for various types too.
So, at
eviewboard.kde.org/r/129724/
> ---
>
> (Updated Jan. 16, 2017, 9:12 a.m.)
>
>
> Review request for Build System, KDE Frameworks and Stephen Kelly.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> ---
>
> Gives a nice warning about something that sh
skelly added a comment.
In https://phabricator.kde.org/D3987#78468, @dfaure wrote:
> {} sounds like the best solution to me.
I think that should be used instead of nullptr anyway.
void foo(const QModelIndex& idx = {});
is obviously better than
void foo(const
On 01/18/2017 12:41 PM, Shaheed Haque wrote:
> Hi Steve,
>
> I have verified this works on KDE/master, and will close the review.
>
> I did see a "funny" in that I had to run CMake twice in a fresh
> directory before it would run clean. You might want to look into that
> as it was not clear to me
> On Jan. 5, 2017, 10:56 p.m., Stephen Kelly wrote:
> > I've added the change to the unit test. It already passes, so it's not
> > clear to me what else is needed from this review request.
>
> Shaheed Haque wrote:
> What version of SIP compiler and C++ com
> On Jan. 5, 2017, 10:56 p.m., Stephen Kelly wrote:
> > I've added the change to the unit test. It already passes, so it's not
> > clear to me what else is needed from this review request.
>
> Shaheed Haque wrote:
> What version of SIP compiler and C++ com
, so it's not clear to
me what else is needed from this review request.
- Stephen Kelly
On Jan. 3, 2017, 12:47 p.m., Shaheed Haque wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewb
n frameworks,
>>> which
>>> is where the benefit of "override" is.
>> What's the plan to enforce that? How is build.kde.org checking that we
>> don't use override instead of Q_DECL_OVERRIDE?
> I guess you can stop worrying. Stephen Kelly just reverted that change
st" +
QByteArray::number(testNumber)).data())
+ << static_cast(kspm_mode) << connectSelectionModelFirst
<< false
+ << QStringList{"6", "8", "11"} << 4
+ << 0
+ << Q
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129657/#review101463
---
Ship it!
Ship It!
- Stephen Kelly
On Dec. 15, 2016
Harald Sitter wrote:
> Alohas
>
> I am currently trying to package kitemmodels' python bindings. The
> module generator installs
>
> -./usr/lib/python2.7/dist-packages/PyKF5/__init__.py
> -./usr/lib/python2.7/dist-packages/PyKF5/KItemModels.so
>
> This will cause a fairly shitty problem on
/127141/diff/
Testing
---
Thanks,
Stephen Kelly
: https://git.reviewboard.kde.org/r/127139/diff/
Testing
---
Thanks,
Stephen Kelly
1b676e87128d83586b62f94f9652b25111e766a5
Diff: https://git.reviewboard.kde.org/r/127148/diff/
Testing
---
Thanks,
Stephen Kelly
/klinkitemselectionmodeltest.cpp
74d72e4858dfd8bab48a71d260af86d838484d26
src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d
src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5
Diff: https://git.reviewboard.kde.org/r/127147/diff/
Testing
---
Thanks,
Stephen
-
src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5
Diff: https://git.reviewboard.kde.org/r/127145/diff/
Testing
---
Thanks,
Stephen Kelly
if it
is changed., 2015-03-12)
Diffs
-
autotests/kselectionproxymodeltest.cpp
b9f1277f1469970195dfb1fd0be68c6e8411fb23
src/kselectionproxymodel.cpp 428b849eedd0c4f187be30a5879b72e0df268c5a
Diff: https://git.reviewboard.kde.org/r/127143/diff/
Testing
---
Thanks,
Stephen Kelly
/klinkitemselectionmodeltest.cpp
74d72e4858dfd8bab48a71d260af86d838484d26
src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5
Diff: https://git.reviewboard.kde.org/r/127146/diff/
Testing
---
Thanks,
Stephen Kelly
6e9c178cd99ed5479e2cee34492a8acd7e5a3f75
autotests/klinkitemselectionmodeltest.cpp
74d72e4858dfd8bab48a71d260af86d838484d26
Diff: https://git.reviewboard.kde.org/r/127149/diff/
Testing
---
Thanks,
Stephen Kelly
/kselectionproxymodeltest.cpp
b9f1277f1469970195dfb1fd0be68c6e8411fb23
src/kselectionproxymodel.cpp 428b849eedd0c4f187be30a5879b72e0df268c5a
Diff: https://git.reviewboard.kde.org/r/127144/diff/
Testing
---
Thanks,
Stephen Kelly
/klinkitemselectionmodeltest.cpp
74d72e4858dfd8bab48a71d260af86d838484d26
Diff: https://git.reviewboard.kde.org/r/127150/diff/
Testing
---
Thanks,
Stephen Kelly
> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote:
> > Do you still have the sample application you made to test/verify this? I'd
> > like to try it and it should probably be committed too.
>
> Pino Toscano wrote:
> No I don't :-/ I remember it was just removing
David Faure wrote:
> versionfile=$here/versions/$repo
> if [ ! -f $versionfile ]; then echo "$versionfile not found"; exit 1; fi
> b=`sed '2q;d' $versionfile`
> echo $b
> checkout=$(findCheckout $repo)
> cd $checkout || exit 2
> echo $PWD
> $cmd git fetch --tags || exit 2
> $cmd git tag -a
Harald Sitter wrote:
> I am actually not sure how we handle this for ECM. CCing Stephen
> Kelly who I think is semi-maintaining ECM right now.
Hi,
Thanks for the heads-up.
I'm afraid I'm way out of the loop. I don't know what appstream or /metainfo
are. However, let's see if I can cont
David Faure wrote:
> On Sunday 24 April 2016 13:54:02 Stephen Kelly wrote:
>>
>> Why doesn't v5.21.0 tag the d2e7c78c94e6 commit directly instead?
>
> Don't know.
>
> I just call git tag, then git does its magic.
>
> cat $here/modules.git | while read
If you look in gitk at karchive (or any other repo), you can see that commit
d2e7c78c94e6 is tagged with both v5.21.0-rc2 and v5.21.0.
If you click on the v5.21.0-rc2 tag, you can see that it tags the commit.
That is the usual thing to do.
Tag: v5.21.0-rc2
object
René J.V. Bertin wrote:
> I've stumbled upon the importance of that location for at least 2
> libraries (grantlee and mobipocket); their cmake modules determine the
> installation prefix dynamically, using the install location of those same
> modules. IOW, those modules have to be installed into
/verify this? I'd like
to try it and it should probably be committed too.
- Stephen Kelly
On March 28, 2016, 1:41 p.m., Pino Toscano wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Aleix Pol Gonzalez wrote:
>> I think it would be good to have changes be better understood,
>> otherwise we end up with lots of mess. However, it looks like several
>> people really want this, and I don't want to stand in the way.
>
> I don't mind spending some time to explain it
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific
say what it is? I would expect
the libs go in the same place, but maybe the plugins are affected by this? Can
you be more specific?
Thanks,
- Stephen Kelly
On Feb. 24, 2016, 5:09 p.m., Aleix Pol Gonzalez wrote
hanks,
- Stephen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/#review92693
---
On Feb. 22, 2016, 4:30 p.m., St
://git.reviewboard.kde.org/r/127148/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
1b676e87128d83586b62f94f9652b25111e766a5
Diff: https://git.reviewboard.kde.org/r/127145/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hi,
I just pushed a bunch of reviewboard review requests for kitemmodels.
These have been reviewed by two colleagues here at Ableton. For your
convenience you can find them as a git branch here:
https://github.com/ske-ableton/kitemmodels/commits/master
I can of course rebase and merge
428b849eedd0c4f187be30a5879b72e0df268c5a
Diff: https://git.reviewboard.kde.org/r/127144/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
KModelIndexProxyMapper: Add some asserts
Diffs
-
src/kmodelindexproxymapper.cpp ae9e69a558f90bf498da730f96af773e3eb91901
Diff: https://git.reviewboard.kde.org/r/127140/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde
ae9e69a558f90bf498da730f96af773e3eb91901
Diff: https://git.reviewboard.kde.org/r/127142/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
---
KModelIndexProxyMapper: Simplify logic of connected check
Diffs
-
src/kmodelindexproxymapper.cpp ae9e69a558f90bf498da730f96af773e3eb91901
Diff: https://git.reviewboard.kde.org/r/127141/diff/
Testing
---
Thanks,
Stephen Kelly
://git.reviewboard.kde.org/r/127145/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
1b676e87128d83586b62f94f9652b25111e766a5
Diff: https://git.reviewboard.kde.org/r/127146/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
b9f1277f1469970195dfb1fd0be68c6e8411fb23
src/kselectionproxymodel.cpp 428b849eedd0c4f187be30a5879b72e0df268c5a
Diff: https://git.reviewboard.kde.org/r/127143/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks
,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
c871121fa9a791b6030f5ff3a104d8d3bdcbe79d
src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5
Diff: https://git.reviewboard.kde.org/r/127147/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde
74d72e4858dfd8bab48a71d260af86d838484d26
Diff: https://git.reviewboard.kde.org/r/127149/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/diff/
Testing
---
Thanks,
Stephen Kelly
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Aleix Pol wrote:
>> QML bindings are "one layer above" the class they bind. Just like
>> kdebindings is separate rather than "mixed into every framework". Having
>> the javascript bindings for KIO in KIO would tick all your criterias
>> above ("simpler to use because part of the framework", "all
wrote:
On 28/03/15 03:48, Alex Merry wrote:
On Wednesday 25 March 2015 22:35:24 Stephen Kelly wrote:
Hello,
ECM release numbers are in sync with KF5 release numbers, except for the
major component.
This means that if you want to build the 5.x.y release you have to download
the 1.x.y
://git.reviewboard.kde.org/r/116096/ ?
- Stephen Kelly
On April 25, 2014, 7:18 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/11
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote:
And I agree with Aurélien, a bug should be filed and Stephen involved in
that issue.
Stephen Kelly wrote:
Please provide a minimal testcase. The feature is unit tested in cmake.
If it's broken, it needs to be fixed soon (before
Frameworks and Stephen Kelly.
Repository: kservice
Description
---
Fix kservice_desktop_to_json for Visual Studio
The CMake generator for Visual Studio cannot handle the new build-time
kservice_desktop_to_json macro - fall back to configure-time generation
Diffs
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote:
And I agree with Aurélien, a bug should be filed and Stephen involved in
that issue.
Stephen Kelly wrote:
Please provide a minimal testcase. The feature is unit tested in cmake.
If it's broken, it needs to be fixed soon (before
On Feb. 25, 2014, 3:56 p.m., Stephen Kelly wrote:
docs/writing-find-modules.md, line 9
https://git.reviewboard.kde.org/r/116025/diff/2/?file=246011#file246011line9
You can link to
http://www.cmake.org/cmake/help/git-master/manual/cmake-packages.7.html
). CMake will resolve that itself.
- Stephen Kelly
On Feb. 25, 2014, 10:59 a.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116025
sorts of
headaches later on.
I tried to make the same point, but I wasn't believed :).
- Stephen Kelly
On Feb. 16, 2014, 5:54 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On 02/02/2014 04:54 PM, Alex Merry wrote:
On 02/02/14 07:27, Stephen Kelly wrote:
On 02/02/2014 12:45 AM, Alex Merry wrote:
The obvious thing to do is set a package property (or something
equivalent) that says it was found as a dependency. The danger there is
that if something is first found
On 02/02/2014 05:26 PM, Alex Merry wrote:
On 02/02/14 16:10, Stephen Kelly wrote:
On 02/02/2014 04:54 PM, Alex Merry wrote:
Either that,
or have it as a completly orthogonal property that nevertheless
interacts with TYPE, but I think that's overcomplicating matters.
It is not clear to me
On 02/01/2014 08:22 PM, Alex Merry wrote:
(CC'ing Stephen because this is relevant to the version of
find_dependency in CMake master)
Currently, the find_dependency() macro does not pass the QUIET argument
to find_package unless the parent package was being found quietly. This
means that
On 02/02/2014 12:45 AM, Alex Merry wrote:
On 01/02/14 20:21, Stephen Kelly wrote:
On 02/01/2014 08:22 PM, Alex Merry wrote:
So, I think that find_dependency should pass QUIET to find_package
whether or not the parent package is being found quietly.
Do other people agree?
I agree
https://git.reviewboard.kde.org/r/115123/#comment33844
I would simply add a fatal_error if cmake version is VERSION_LESS 2.8.12,
and remove the rest of this version stuff.
- Stephen Kelly
On Jan. 19, 2014, 1:15 p.m., Alex Merry wrote
/115123/#comment33847
What is in PC_OpenEXR_CFLAGS_OTHER ?
INTERFACE_COMPILE_DEFINITIONS is only suitable for compile definitions,
whereas the compile_definitions() command also accepts other flags.
- Stephen Kelly
On Jan. 19, 2014, 3:49 p.m., Alex Merry wrote
On Jan. 7, 2014, 3:36 p.m., Stephen Kelly wrote:
kde-modules/KDECompilerSettings.cmake, line 25
https://git.reviewboard.kde.org/r/114885/diff/1/?file=233187#file233187line25
Setting CMAKE_CXX_FLAGS is not 'modern cmake'. Prefer to use
add_compile_options instead
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114897/#review46984
---
Why is -UQT_NO_EXCEPTIONS needed?
- Stephen Kelly
On Jan
?
- Stephen Kelly
On Jan. 7, 2014, 5:01 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114898
Alex Merry wrote:
On 07/01/14 18:00, Stephen Kelly wrote:
Alex Merry wrote:
Hrm. After some investigation: I'm not entirely sure. The simplest
answer is that's what qmake does
Please tell me you noticed that I asked about -U, not -D ...
Yes. qmake actually doesn't use -U directly
Aurélien Gâteau wrote:
Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:
${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}
)
Note that this makes the resulting package non
Aurélien Gâteau wrote:
Le lundi 9 décembre 2013 21:59:58 Stephen Kelly a écrit :
Aurélien Gâteau wrote:
+set(INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/KF5)
Don't you instead want to install to ${INCLUDE_INSTALL_DIR}/KF5/$Name ?
Not for all frameworks. For frameworks where all headers
Aurélien Gâteau wrote:
when CMake 3.0.0 is depended on.
Sounds good, we will be able to simplify the macro at this point then.
The two threads on this is causing confusion.
Thanks,
Steve.
___
Kde-frameworks-devel mailing list
Aurélien Gâteau wrote:
target_include_directories(${library} INTERFACE
$INSTALL_INTERFACE:
${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}
)
Note that this makes the resulting package non-relocatable. If using CMake
3.0.0, you can specify a relative path here. With 2.8.12, you
Aurélien Gâteau wrote:
+set(INCLUDE_INSTALL_DIR ${INCLUDE_INSTALL_DIR}/KF5)
Don't you instead want to install to ${INCLUDE_INSTALL_DIR}/KF5/$Name ?
What does _set_fancy do? Should it be removed? INCLUDE_INSTALL_DIR is set by
_set_fancy in ecm.
Thanks,
Steve.
Aurélien Gâteau wrote:
On Dec. 6, 2013, 5:15 p.m., Alexander Richardson wrote:
Just wondering, should include/KF5 also be the include dir for
applications that install headers e.g. for writing plugins? Since I
guess they will also be using KDEInstallDirs.cmake
Good question. This
Kevin Ottens wrote:
Tiers above 1 are not especially relevant. A tier is a fluid label. It
doesn't matter when we are using split repos.
If you could stop spreading that it'd be nice. It's not because you see no
value in tier 2 and 3 distinction that this value doesn't exist.
I think this
Jonathan Riddell wrote:
developer files matter to some people to be co-installable.
Header files and others can probably be moved to a
separate directory
Can you be more specific about why this is easy with header files? Does this
refer to installing to a include/KF5 directory?
but
David Faure wrote:
Conclusion:
I think it's a lot simpler to keep things as is,
I can't say I understand fully, but thanks for looking into it!
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
On Nov. 24, 2013, 9:20 p.m., Stephen Kelly wrote:
Nothing should need find_package(KDELibs4) at all anymore. Uses of it should be
removed (or replaced with kde4support, if that's not already there), and then
KDELibs4Config.cmake should be removed from kdelibs.git/frameworks.
- Stephen
sense to add the REQUIRED keyword here, and possibly even a
version, to show good practice.
- Stephen Kelly
On Nov. 20, 2013, 6:50 p.m., Maarten De Meyer wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
David Faure wrote:
It doesn't link to kde4support, and KConfigCore doesn't install forwarding
headers yet. So this is a temporary measure, the real fix being to
generate and install forwarding headers; but this fix allows to move the
two things forward independently.
Given the issues that I
David Faure wrote:
On Sunday 24 November 2013 23:11:25 Stephen Kelly wrote:
David Faure wrote:
It doesn't link to kde4support, and KConfigCore doesn't install
forwarding headers yet. So this is a temporary measure, the real fix
being to generate and install forwarding headers
Aurélien Gâteau wrote:
Looks like we have an agreement then. Let me recap:
# Installation dir
All header files are installed in $PREFIX/include/KF5/$Framework.
This includes 'k' prefixed headers like kfoo and KFoo,
non-prefixed headers such as bar.h and Bar, as well as special headers
1 - 100 of 319 matches
Mail list logo
