D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris added a comment.


  Sounds good, thanks.  I just emailed you at your KDE address.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris requested review of this revision.
smokris added a comment.


  In D22662#511424 , @cullmann wrote:
  
  > I am not sure we want to override F# for .fs.
  >  Either we should not add that or we shall lower the priority of this 
highlighting to loose against F#.
  
  
  The test I added verifies that F# is still being chosen for the `.fs` 
extension (and that GLSL, added by this change, loses to F#'s higher priority).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris added a reviewer: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris created this revision.
smokris added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
smokris requested review of this revision.

REVISION SUMMARY
  These 2-letter extensions are used by, for example:
  
  - https://www.interactiveshaderformat.com/about
  - https://github.com/euler0/sublime-glsl
  - https://github.com/polym0rph/GLSL.tmbundle
  - http://plugins.netbeans.org/plugin/46515/glsl-syntax-highlighter

TEST PLAN
  This commit also adds a test to ensure that .fs still defaults to FSharp.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

AFFECTED FILES
  syntax/glsl.xml
  syntaxrepository_test.cpp

To: smokris
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22095: Fix CMake COMMAND nested paren highlighting

[Steve Mokris]

smokris updated this revision to Diff 60819.
smokris retitled this revision from "Fix CMake add_custom_command() paren 
highlighting" to "Fix CMake COMMAND nested paren highlighting".
smokris edited the summary of this revision.
smokris edited the test plan for this revision.
smokris added a comment.


  Ah, yes.  Here's a revised patch that also applies that change (and adds 
tests) for `add_custom_target`, `execute_process`, and `add_test`.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22095?vs=60669=60819

REVISION DETAIL
  https://phabricator.kde.org/D22095

AFFECTED FILES
  generators/cmake.xml.tpl
  generators/cmake.yaml
  html/highlight.cmake.html
  input/highlight.cmake
  reference/highlight.cmake.ref
  syntax/cmake.xml

To: smokris, #framework_syntax_highlighting, cullmann
Cc: turbov, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, 
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, vkrause, 
sars, dhaumann

D22095: Fix CMake add_custom_command() paren highlighting

[Steve Mokris]

smokris updated this revision to Diff 60669.
smokris added a comment.


  Updated cmake.xml + cmake.xml.tpl version number.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22095?vs=60662=60669

REVISION DETAIL
  https://phabricator.kde.org/D22095

AFFECTED FILES
  generators/cmake.xml.tpl
  generators/cmake.yaml
  html/highlight.cmake.html
  input/highlight.cmake
  reference/highlight.cmake.ref
  syntax/cmake.xml

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D22095: Fix CMake add_custom_command() paren highlighting

[Steve Mokris]

smokris added a reviewer: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22095

To: smokris, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D22095: Fix CMake add_custom_command() paren highlighting

[Steve Mokris]

smokris created this revision.
smokris added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
smokris requested review of this revision.

REVISION SUMMARY
  The CMake syntax highlighter was getting confused by balanced
  parentheses in add_custom_command()'s COMMAND arguments.
  This patch turns on the 'nested-parentheses' flag for that
  command, enabling parentheses to be parsed correctly.

TEST PLAN
  Added a test in `autotests/input/highlight.cmake` and updated the 
corresponding reference output files.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22095

AFFECTED FILES
  generators/cmake.yaml
  html/highlight.cmake.html
  input/highlight.cmake
  reference/highlight.cmake.ref
  syntax/cmake.xml

To: smokris
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann