D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-14 Thread Sune Vuorela
svuorela added a comment. I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. Also, while I might be a unconventional developer, but given this is a tier 1 library, I'm often hand patching the required ECM version to a much lower

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

2020-05-10 Thread Sune Vuorela
svuorela accepted this revision. svuorela added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dialog.cpp:317 > const QStringList dirs = > QStandardPaths::locateAll(QStandardPaths::DataLocation, > QStringLiteral("ksettingsdialog"),

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-03 Thread Sune Vuorela
svuorela added a comment. I've been looking at it for a while, and after trying to decipher the long lambdas, which might have been better as named functions, I think it is, beside Kossebau's comments, fine. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29385 To:

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-04-24 Thread Sune Vuorela
svuorela accepted this revision. svuorela added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcmoduleinfo.cpp:73 > +lib = pluginInfo.libraryPath(); > +keywords = > pluginInfo.property(QStringLiteral("Keywords")).toStringList(); > } At a later

D28030: Also expose the true minimum size to QML

2020-03-14 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D28030 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27952: Simplify minimum size handling

2020-03-11 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27952 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27989: Add a new set of barcode size functions

2020-03-11 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27989 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-08 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27909 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-06 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. thanks. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27730 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-04 Thread Sune Vuorela
svuorela requested changes to this revision. svuorela added a comment. This revision now requires changes to proceed. I'm not sure I like the implementation. The current AbstractBarcode can also be implemented, at least theoretically, by software providing other barcodes that forever reason

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. These are leftovers from when all constructor was public. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D27727 To: vkrause, svuorela Cc:

D22419: Fix cant enter directory error on Android FTP servers

2019-07-15 Thread Sune Vuorela
svuorela added a comment. According to the RFC, the server should ignore case: > Upper and lower case alphabetic characters are to be treated > identically. Thus any of the following may represent the retrieve > command: > > RETR Retr retr ReTr rETr I'm not sure how many

D20938: Add Mounts Backend

2019-05-01 Thread Sune Vuorela
svuorela added a comment. After reading the code a bit, I wonder - can't some of the parsing code be made testable (and tests added) - This likely also requires to get rid of the global static. - rather than poll /proc/mounts every second, I was wondering if one of the filesystem

D20939: Aztec: Fix padding if the last partial codeword is all one bits

2019-05-01 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D20939 To: vkrause, svuorela, nicolasfella Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

2019-04-09 Thread Sune Vuorela
svuorela added a comment. In D20312#445122 , @ahmedbilal wrote: > > @svuorela If system have user with same Real Name it would return the username of first user. I think, this function should be in Okular instead because there

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

2019-04-06 Thread Sune Vuorela
svuorela requested changes to this revision. svuorela added a comment. This revision now requires changes to proceed. I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name. My systems have several users named "

D20149: Fix compilation

2019-03-31 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20149 To: aacid, svuorela Cc: svuorela, apol, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20143: ora:kra: qstrcmp -> qstrncmp

2019-03-31 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH arcpatch-D20143 REVISION DETAIL https://phabricator.kde.org/D20143 To: aacid, svuorela Cc: apol, pino, security-team, rempt, kde-frameworks-devel, michaelh, ngraham,

D20145: Fix RGBHandler::canRead

2019-03-31 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. I'm not sure why it as such is needed, but it isn't wrong. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20145 To: aacid, svuorela

D18369: Create tel: links for phone numbers

2019-02-09 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D18369 To: vkrause, svuorela Cc: apol, aacid, svuorela, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D18369: Create tel: links for phone numbers

2019-01-20 Thread Sune Vuorela
svuorela added inline comments. INLINE COMMENTS > ktexttohtml.cpp:159 > +// this isn't 100% accurate, we filter stuff below that is too hard to > capture with a regexp > +static const QRegularExpression telPattern(QStringLiteral(R"([+0](( |( > ?[/-] ?)?)\(?\d+\)?+){6,30})")); > +

D16561: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D16561 To: aacid, svuorela Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16567: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D16567 To: aacid, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16569: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D16569 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16568: Remove unused variables

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16568 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16571: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D16571 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16572: don't assign variable to itself

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D16572 To: aacid, svuorela Cc: kde-frameworks-devel, mart, michaelh, ngraham, bruns

D16573: Remove unused variables

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D16573 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16574: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D16574 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16565: Remove unused variable

2018-11-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D16565 To: aacid, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Sune Vuorela
svuorela added a comment. > Did you imagine something like what I changed in D16137#343060 (the latest change) ? I think Albert imagined something like that. It is at least what I imagined when I read his comments. I think I also like it

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Sune Vuorela
svuorela added a comment. from a source & binary compatibility point of view, this looks great. I guess we should maybe plan deprecating (and at kf6 time remove) the old ones ? (But this is not an objection to the current change) I'm not a KConfigWidgets maintainer, so I will not

D15833: extend test coverage to all supported mimetypes for taglibextractor

2018-09-29 Thread Sune Vuorela
svuorela added a comment. What's the origin/license of these files ? How are they created ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-23 Thread Sune Vuorela
svuorela added inline comments. INLINE COMMENTS > astippich wrote in taglibwritertest.cpp:66 > To be sure I understand correctly, using stringSuffix.toUTF8() is what you > would like to see here? Something along those lines, yes please, to compare with. REPOSITORY R286 KFileMetaData

D15715: remove own implementation of QString to TString conversion for taglibwriter

2018-09-23 Thread Sune Vuorela
svuorela added a comment. In D15715#330743 , @astippich wrote: > since I'm still unsure about those things: the q2t function was not declared static, but was never exported. It is still safe to remove, right? Yes. not exported (and not

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-23 Thread Sune Vuorela
svuorela added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:66 > ? > The file/tags are written inside this test. yeah. given you write and read it, if somehow it gets encoded e.g. as iso-8859-15 rather than utf8, the euro sign would be encoded as 0xa4 rather than

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-23 Thread Sune Vuorela
svuorela added inline comments. INLINE COMMENTS > taglibwritertest.cpp:66 > +QCOMPARE(extractedGenre, QString(QStringLiteral("Genre1") + > stringSuffix)); > +QCOMPARE(extractedComment, QString(QStringLiteral("Comment1") + > stringSuffix)); > I suggest checking that the last bytes of

D15704: increase test coverage of taglibwriter

2018-09-23 Thread Sune Vuorela
svuorela added a comment. Looks good to me. A nice and simple way to drastically increase test coverage. INLINE COMMENTS > taglibwriter.cpp:22 > { > QStringList types = { > QStringLiteral("audio/mpeg"), Unrelated. but consider making this static ? REPOSITORY R286

D15615: bump required taglib version

2018-09-22 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH bumb_taglib_version REVISION DETAIL https://phabricator.kde.org/D15615 To: astippich, mgallien, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15614: remove usage of own TString to QString conversion function

2018-09-22 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglib_extractor_string_conversion REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien, svuorela Cc: kde-frameworks-devel, #baloo,

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

2018-09-22 Thread Sune Vuorela
svuorela added a comment. @fvogt mostly a unit test that ensures that all these 3 codepaths in slotData works. I'm not sure that the current unit tests ensures that. I might be wrong though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks,

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

2018-09-22 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. Though unit tests would be nice. It looks like something that quite easy could break if next author is not careful. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D15526: Fix rendering glitches caused by rounding errors in Code 128

2018-09-15 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15526 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15527: Remove assumption about the barcode aspect ratio from the QML integration

2018-09-15 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15527 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15511: Add support for Code 128 barcodes

2018-09-14 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15511 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15511: Add support for Code 128 barcodes

2018-09-14 Thread Sune Vuorela
svuorela added inline comments. INLINE COMMENTS > CMakeLists.txt:26 > +) > +# qt5_add_resources(aztecbarcodetest_srcs aztec/aztec.qrc) > + copy/paste error ? > code128barcodetest.cpp:111 > +qDebug() << "Expected:" << output; > +} > +QCOMPARE(v, output); doesn't

D15364: Plasma style: Remove hardcoded textFormat

2018-09-09 Thread Sune Vuorela
svuorela added a comment. I think it is undesireable to change the default, because all users are now used to having it PlainText, so they are now dumping things-that-looks-like-html into it and expecting it to be plaintext. so all users of Label that don't have textFormat set now needs

D14529: Android: Make sure Qm translations get loaded

2018-08-17 Thread Sune Vuorela
svuorela added a comment. In D14529#302624 , @aacid wrote: > Ok, second option, we are actually installing these files ourselves, right? It is where androiddeployqt puts things (I guess to avoid conflict with javastuff) REPOSITORY

D14896: Fix bzip main page

2018-08-17 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. yesplease. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D14896 To: ltoscano, svuorela Cc: svuorela, kde-frameworks-devel, michaelh,

D14772: Deprecate KFilterProxySearchLine

2018-08-13 Thread Sune Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R276:f5fef035e5a2: Deprecate KFilterProxySearchLine (authored by svuorela). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14772?vs=39579=39580 REVISION DETAIL

D14772: Deprecate KFilterProxySearchLine

2018-08-13 Thread Sune Vuorela
svuorela updated this revision to Diff 39579. svuorela added a comment. Improve deprecation documentation REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14772?vs=39528=39579 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14772

D14772: Deprecate KFilterProxySearchLine

2018-08-12 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: kossebau, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. svuorela requested review of this revision. REVISION SUMMARY It is too primitive and simple for

D14565: Fix overflow in rounding code

2018-08-03 Thread Sune Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R244:ea2779611800: Fix overflow in rounding code (authored by svuorela). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14565?vs=39024=39025 REVISION DETAIL

D14565: Fix overflow in rounding code

2018-08-03 Thread Sune Vuorela
svuorela added a comment. In D14565#302581 , @cfeck wrote: > In D14565#302551 , @safaalfulaij wrote: > > > Maybe you should use `largeValue` instead of `largevalue`. > > > Yes, that would be

D14565: Fix overflow in rounding code

2018-08-03 Thread Sune Vuorela
svuorela updated this revision to Diff 39024. svuorela added a comment. s/largevalue/largeValue/ REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14565?vs=38978=39024 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14565 AFFECTED FILES

D14565: Fix overflow in rounding code

2018-08-02 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: cfeck, safaalfulaij. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. svuorela requested review of this revision. REVISION SUMMARY qRound works with int. BUG:

D14400: Fix Mixed to Upper mode latching in Aztec code generation

2018-08-02 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D14400 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12477: Add unit test to see that :/ files can work

2018-04-23 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: dfaure, kossebau, Frameworks. Restricted Application added a project: Frameworks. svuorela requested review of this revision. REVISION SUMMARY I wasn't sure if :/foo stuff would work, so I tried writing a unit test to help me. Let's

D10826: Introduce DocumentId class

2018-02-26 Thread Sune Vuorela
svuorela added inline comments. INLINE COMMENTS > anthonyfieroni wrote in documentid.h:51-52 > Make a d poniter in exported class. it depends on why it is exported. If it is exported just for unit test (and the header file not installed), then we don't need to have the mental and code wise

D10826: Introduce DocumentId class

2018-02-25 Thread Sune Vuorela
svuorela added a comment. A quick review of some quirks and weirdnesses in c++ INLINE COMMENTS > documentid.cpp:67 > +#if(0) > +// Due to operator DeviceIdAndInode(), apparently the following > +// became obsolete. if you make operator DeviceIdAndInode explicit, you probably end up with a

D10433: Add QML support for Prison

2018-02-24 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10433 To: vkrause, #frameworks, svuorela Cc: broulik, davidedmundson, michaelh

D10433: Add QML support for Prison

2018-02-18 Thread Sune Vuorela
svuorela added a comment. I am a bit unsure if this is the right approach. I can still be convinced both ways. one of the big differences from prison/qt4 to prison/qt5 was that it changed from being a barcode display library to a barcode generation library, removing all means of

D10631: Update links to dependencies, and mark Android as officially supported

2018-02-18 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10631 To: vkrause, svuorela Cc: #frameworks, michaelh

D10603: Make DMTX dependency optional

2018-02-18 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10603 To: vkrause, #frameworks, svuorela Cc: michaelh

D10603: Make DMTX dependency optional

2018-02-18 Thread Sune Vuorela
svuorela added a comment. Thanks. The ability to cleanly do something like that was one of the reasons for the api changes I did between qt4 and qt5. INLINE COMMENTS > prison.cpp:44 > +#ifdef HAVE_DMTX > case Prison::DataMatrix: > return new DataMatrixBarcode; I'm

D10432: Set minimum size on 1D barcodes as well

2018-02-11 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D10432 To: vkrause, #frameworks, svuorela Cc: michaelh

D8546: Add Aztec code generator

2017-11-24 Thread Sune Vuorela
svuorela accepted this revision. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D8546 To: vkrause, #frameworks, svuorela, dfaure Cc: dfaure, #frameworks

D8546: Add Aztec code generator

2017-11-12 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. I like it. Though I haven't fully reviewed the bit magic and actually tested it, but the first can be fixed at a later point, and the latter I trust you on. INLINE COMMENTS > vkrause wrote in aztec-compact-data-0011.png:1 > There

D8546: Add Aztec code generator

2017-11-06 Thread Sune Vuorela
svuorela added a comment. Thanks for this contribution. I think it is good and needed. INLINE COMMENTS > CMakeLists.txt:1 > +set(aztecbarcodetest_srcs > +aztecbarcodetest.cpp I'd like an extra level of directories given the large amount of test files, so we have e.g. autotests/aztec/

[Differential] [Closed] D4448: Don't use tier3 frameworks in unit tests

2017-02-14 Thread Sune Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b42483f4cbdb: Rewrite tests to not use tier3 frameworks (authored by svuorela). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4448?vs=10942=11351#toc REPOSITORY R266 Breeze Icons CHANGES

[Differential] [Request, 177 lines] D4448: Don't use tier3 frameworks in unit tests

2017-02-05 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: sitter, vonreth, kde-frameworks-devel. svuorela set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Port

[Differential] [Accepted] D4444: Make tier3 dependency for tests optional

2017-02-05 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a reviewer: svuorela. svuorela added a comment. This revision is now accepted and ready to land. I'm not fully sure what the scalable test does, but having tier3 libraries required for tests in tier1 thingns is a bit bad to me. REPOSITORY

Re: Minimum required cmake version

2016-12-30 Thread Sune Vuorela
On 2016-12-27, Aleix Pol wrote: > Now everything makes sense, thanks! > > I confirm Q_GADGET is mentioned in cmake 3.0.0 codebase while it isn't > in 2.8.11. > +1 on changing to 3.0. As a datapoint, Debian stable has cmake 3.0 /Sune

Shipping prison with next frameworks version

2016-09-18 Thread Sune Vuorela
Hi Other than asking sysadmin to move prison from kdesupport to kdeframeworks, are there other bits I'm supposed to do? I *think* I have followed the checklists. Thanks in advance. /Sune

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-18 Thread Sune Vuorela
> On Sept. 16, 2016, 4:57 p.m., Sune Vuorela wrote: > > autotests/kconfigtest.cpp, line 1376 > > <https://git.reviewboard.kde.org/r/128916/diff/4/?file=476949#file476949line1376> > > > > Isn't a QSKIP if user is root in the beginning of the test a better >

Re: Help requested with KAuth backends : OS X

2016-09-17 Thread Sune Vuorela
On 2016-09-17, René J.V Bertin wrote: > Can someone please give me some help setting up a working Mac backend for > KAuth? I know nothing about mac, and only have a limited knowledge of KAuth, on linux, but I'll give it a go replying anyways. On linux, there is a thing

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-16 Thread Sune Vuorela
tps://git.reviewboard.kde.org/r/128916/#comment66819> Isn't a QSKIP if user is root in the beginning of the test a better approach ? - Sune Vuorela On Sept. 16, 2016, 7:17 a.m., Evgeniy Sadovnik wrote: > > --- > This is an automatica

Re: Review Request 128904: Avoid creating a KPluginInfo from a KPluginMetaData instance

2016-09-14 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128904/#review99158 --- Ship it! Ship It! - Sune Vuorela On Sept. 14, 2016, 1

Re: Review Request 128887: ctime/mtime => 0 (which is perfectly OK) => baloo dead

2016-09-11 Thread Sune Vuorela
if ever possible. It would be an easy bug to reintroduce. - Sune Vuorela On Sept. 11, 2016, 11:49 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines

2016-09-11 Thread Sune Vuorela
no problems in changing the data types from a binary compatibility point of view. - Sune Vuorela On Sept. 11, 2016, 10:57 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 128810: Documentation update

2016-09-02 Thread Sune Vuorela
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0496fe68640b19ac568ceabc85a75c1b2fb5ca44 by Sune Vuorela to branch master. Repository: kitemmodels Description --- Apparantly the class name was changed at some point, and not all docs

Re: Review Request 128811: Unit tests of seperator handling - and proper emission of signals

2016-09-02 Thread Sune Vuorela
marked as submitted. Review request for KDE Frameworks, David Faure and Stephen Kelly. Changes --- Submitted with commit 35bad64f2e19b66c699c56b9bc2f0b675920dd74 by Sune Vuorela to branch master. Repository: kitemmodels Description --- Verify that correct signals are emitted when

Review Request 128811: Unit tests of seperator handling - and proper emission of signals

2016-09-01 Thread Sune Vuorela
--- Thanks, Sune Vuorela

Review Request 128810: Documentation update

2016-09-01 Thread Sune Vuorela
--- Apparantly the class name was changed at some point, and not all docs was updated. Diffs - src/kbreadcrumbselectionmodel.h 8e8fd60 Diff: https://git.reviewboard.kde.org/r/128810/diff/ Testing --- Thanks, Sune Vuorela

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-02 Thread Sune Vuorela
to look over his comments as well, but besides that, I'd say shipit. - Sune Vuorela On Aug. 2, 2016, 5:47 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-01 Thread Sune Vuorela
ust seems ... candidates for extreme growth. isPlatformSurfaceFlinger isPlatformWindows isPlatformWindowsRT isPlatformMacOsForWatch isPlatformMacOsForTV isPlatform.... Do we need them? - Sune Vuorela On Aug. 1, 2016, 3:27 p.

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-29 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/#review97915 --- Ship it! Ship It! - Sune Vuorela On July 24, 2016, 9

Re: Review Request 128513: Unittest for content test of kdescendantsproxymodel

2016-07-24 Thread Sune Vuorela
marked as submitted. Review request for KDE Frameworks, David Faure, Friedrich W. H. Kossebau, and Stephen Kelly. Changes --- Submitted with commit 3244f2ff34959f3e5c0a2c864a08737f47f96922 by Sune Vuorela to branch master. Repository: kitemmodels Description --- A skipped unit

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

2016-07-24 Thread Sune Vuorela
> On July 21, 2016, 5:43 a.m., Sune Vuorela wrote: > > I tried writing a small test for it, and it seemed like I could reproduce > > the issue. But my test didn't pass when I added this changeset. > > > > Maybe I should publish my test case somewhere... https:

Review Request 128513: Unittest for content test of kdescendantsproxymodel

2016-07-24 Thread Sune Vuorela
PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128513/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

2016-07-20 Thread Sune Vuorela
could reproduce the issue. But my test didn't pass when I added this changeset. Maybe I should publish my test case somewhere... - Sune Vuorela On July 8, 2016, 2:58 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an auto

Re: Review Request 128464: Allow scrolling in config windows for small screens

2016-07-16 Thread Sune Vuorela
> On July 16, 2016, 9:53 a.m., Sune Vuorela wrote: > > looks good. > > Olivier Churlaud wrote: > Who should provide the ship it flag? I don't know who is the maintainer... if no one else gives a more formal shipit by monday, consider this

Re: Review Request 128464: Allow scrolling in config windows for small screens

2016-07-16 Thread Sune Vuorela
> On July 16, 2016, 1:06 a.m., Olivier Churlaud wrote: > > Same patch should be applied to Konversation. I think you need to submit i to konversation as well, then. - Sune --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128464: Allow scrolling in config windows for small screens

2016-07-16 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97467 --- looks good. - Sune Vuorela On July 16, 2016, 12:52 a.m

Re: Review Request 128420: Name supported platforms in YAML file.

2016-07-10 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128420/#review97259 --- Ship it! Ship It! - Sune Vuorela On July 10, 2016, 10

Re: Review Request 128233: Don't trust files claiming to be created on unix more than other files

2016-07-04 Thread Sune Vuorela
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit b7d8fce0a7167f4cea7127c6142ea10c92ff546d by Sune Vuorela to branch master. Repository: karchive Description --- Don't trust files claiming to be created on unix more than other

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-04 Thread Sune Vuorela
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit dda62267aab8893db0ff695391d0fd8b37ace1f6 by Sune Vuorela to branch master. Repository: karchive Description --- Add unit test to prevent later changes to abandon directory

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-04 Thread Sune Vuorela
Previous unit test does the same - Sune --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/#review97066 ------- On

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-03 Thread Sune Vuorela
my.zip 7* Diffs - autotests/karchivetest.h 5a6375c autotests/karchivetest.cpp dd03dac Diff: https://git.reviewboard.kde.org/r/128353/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 128353: Unit tests of directory permissions in zip files

2016-07-03 Thread Sune Vuorela
Description --- Add unit test to prevent later changes to abandon directory permissions in zip files Diffs - autotests/karchivetest.h 5a6375c autotests/karchivetest.cpp dd03dac Diff: https://git.reviewboard.kde.org/r/128353/diff/ Testing --- Thanks, Sune Vuorela

  1   2   >