D7446: [Places panel] Add a Recently Used item by default

2018-09-25 Thread Sven Mauch
svenmauch added a comment.


  While I wouldn't use it (yet?) I think it's a great addition and would 
benefit a lot of people. I give it a +1, especially if D15739 
 gets approved aswell. ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, feverfew, michaelh, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp


D15739: [Places panel] Don't show Root by default

2018-09-25 Thread Sven Mauch
svenmauch added a comment.


  All arguments make sense. It even looks a lot better without the red folder 
icon. +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, 
bruns


D11880: Add firewall-config and firewall-applet icons

2018-09-24 Thread Sven Mauch
svenmauch added a comment.


  In D11880#330810 , @ndavis wrote:
  
  > While orange may mean "warning", it could mean any kind of warning. In this 
case, it's a warning that an extreme setting is being used, but there is a lock 
in the corner to show that it is at least safe.
  
  
  Exactly what I thought!
  
  In D11880#330865 , @ndavis wrote:
  
  > Like this? This is #4d4d4d (icon grey), the standard color for small breeze 
icons, not black.
  >  F6281673: Screenshot_20180924_000854.png 
F6281669: Screenshot_20180924_000627.png 

  
  
  Looks great! +1
  
  In D11880#330788 , @ngraham wrote:
  
  > I think that `firewall-applet` looks maybe a bit too plain at its 22px 
size. The wall seems to need something.
  
  
  I think the 22px firewall-applet looks really good and would fit perfectly 
with the notifications popup and task icons. I'm not sure why the 48px version 
is colored though?
  
  Thank you for the superb work @ndavis & @bruns!

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh


D11880: Add firewall-config and firewall-applet icons

2018-09-21 Thread Sven Mauch
svenmauch added a comment.


  Yup! +1

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh


D11880: Add firewall-config and firewall-applet icons

2018-09-21 Thread Sven Mauch
svenmauch added a comment.


  I like the regular icon, looks great!
  
  Though I'm unsure about the panic icon. It communicates "all is well" to me 
instead of "all network traffic blocked". Maybe there is a better way to 
achieve this. An orange icon with a spread out hand in front of it? Just an 
idea.

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: svenmauch, kde-frameworks-devel, ngraham, michaelh, bruns