Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-10 Thread Teo Mrnjavac
/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-10 Thread Teo Mrnjavac
100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-10 Thread Teo Mrnjavac
include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-07 Thread Teo Mrnjavac
fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-07 Thread Teo Mrnjavac
. Diffs - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-21 Thread Teo Mrnjavac
--- On Oct. 19, 2013, 11:30 a.m., Teo Mrnjavac wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/ --- (Updated Oct. 19, 2013

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-21 Thread Teo Mrnjavac
824ac563f3f8c463426f0a45e792f107ac402a40 Diff: http://git.reviewboard.kde.org/r/113302/diff/ Testing --- Seems to work fine in a test app. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-19 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/#review41957 --- On Oct. 17, 2013, 2:04 p.m., Teo Mrnjavac wrote

Re: Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-19 Thread Teo Mrnjavac
/113302/diff/ Testing --- Seems to work fine in a test app. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113302: Static KEncodingFileDialog in staging/kio

2013-10-17 Thread Teo Mrnjavac
in a test app. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Teo Mrnjavac
. Diffs - staging/kde4support/src/kssl/kcm/cacertificatespage.cpp e0a66c54633f457322729eecc0395baae8a5c548 kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 Diff: http://git.reviewboard.kde.org/r/113095/diff/ Testing --- Thanks, Teo Mrnjavac

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Teo Mrnjavac
, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Teo Mrnjavac
://git.reviewboard.kde.org/r/113095/diff/ Testing --- Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-20 Thread Teo Mrnjavac
8b35c2a73f0f2caa3e385568d32428fdbb00bba4 kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-15 Thread Teo Mrnjavac
ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-15 Thread Teo Mrnjavac
it needs. - Teo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review37641 --- On Aug. 15, 2013, 3:36 p.m., Teo Mrnjavac

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-14 Thread Teo Mrnjavac
ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel

Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-12 Thread Teo Mrnjavac
kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https