Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 11:39 a.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Fixed indentation. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs (updated) - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 5:35 p.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- Added explanation for #define as a comment. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs (updated) - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 6:51 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- Review request for KDE Frameworks. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 7, 2014, 4:54 p.m.) Review request for KDE Frameworks and Ivan Romanov. Changes --- I've gotten word that Ivan Romanov is the current maintainer. Apologies to people I pinged needlessly. Repository: qca Description --- KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA headers contain instances of implicit conversion of string literals into QString, and this makes it hard for frameworks to use QCA. This proposed change wraps those instances in QStringLiteral (Qt5) or QString::fromUtf8 (Qt4). Note: submitting this to kdeframeworks because there seems to be no qca group, and emailing the QCA maintainers. Diffs - include/QtCrypto/qca_basic.h 100c626 include/QtCrypto/qcaprovider.h b3d40ce Diff: https://git.reviewboard.kde.org/r/115540/diff/ Testing --- Builds fine, KSecretsService links fine against it. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113302: Static KEncodingFileDialog in staging/kio
On Oct. 20, 2013, 9:32 a.m., David Faure wrote: OK, I'm just wondering if it still makes sense to make it static-methods-only. It can still very well work the other way, which can allow extra flexibility if needed (e.g. for kate to add another widget into it, or use it non-modal, etc.). What's the reason for making it less flexible? Just the fact that nobody uses the constructor right now? (I assume you checked that?). Kévin? Kevin Ottens wrote: Initially I think I proposed even a namespace. :-) But seeing the current solution I think you're right, we could indeed allow instances to be created. Ok, but that would add some more duplication over what KFileDialog already does. Afaict, the only non-static usage of KEncodingFileDialog was in KMail's messagecomposer. I had checked with kdepim people a while ago, and they have no problem with KEncodingFileDialog becoming static only in KF5. - Teo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/#review42003 --- On Oct. 19, 2013, 11:30 a.m., Teo Mrnjavac wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/ --- (Updated Oct. 19, 2013, 11:30 a.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kdelibs Description --- This makes KEncodingFileDialog static, moves it to staging/kio and moves some stuff from KFileDialog to KFileWidget to reduce duplication. Diffs - kio/CMakeLists.txt ac80e393c877280dd8033ec13e8e772afea6d2f9 kio/kfile/kencodingfiledialog.h abb939abeb000126005f1a1a9c6fd50b8bd322bd kio/kfile/kencodingfiledialog.cpp d55d908473aae2859838d88fd776cc65cecf3317 kio/kfile/kfiledialog.cpp 32eb98a4490a31c5ed51150ca3cb7af5375dc67e staging/kio/src/filewidgets/CMakeLists.txt e8d8c2edf11ad6352e13eb6e7436f828a4a55e3a staging/kio/src/filewidgets/kencodingfiledialog.cpp PRE-CREATION staging/kio/src/filewidgets/kfilewidget.h f7b162ab39b997274b21f9eff0c6374545e0a9ad staging/kio/src/filewidgets/kfilewidget.cpp 824ac563f3f8c463426f0a45e792f107ac402a40 Diff: http://git.reviewboard.kde.org/r/113302/diff/ Testing --- Seems to work fine in a test app. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113302: Static KEncodingFileDialog in staging/kio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/ --- (Updated Oct. 21, 2013, 12:40 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kdelibs Description --- This makes KEncodingFileDialog static, moves it to staging/kio and moves some stuff from KFileDialog to KFileWidget to reduce duplication. Diffs - kio/CMakeLists.txt ac80e393c877280dd8033ec13e8e772afea6d2f9 kio/kfile/kencodingfiledialog.h abb939abeb000126005f1a1a9c6fd50b8bd322bd kio/kfile/kencodingfiledialog.cpp d55d908473aae2859838d88fd776cc65cecf3317 kio/kfile/kfiledialog.cpp 32eb98a4490a31c5ed51150ca3cb7af5375dc67e staging/kio/src/filewidgets/CMakeLists.txt e8d8c2edf11ad6352e13eb6e7436f828a4a55e3a staging/kio/src/filewidgets/kencodingfiledialog.cpp PRE-CREATION staging/kio/src/filewidgets/kfilewidget.h f7b162ab39b997274b21f9eff0c6374545e0a9ad staging/kio/src/filewidgets/kfilewidget.cpp 824ac563f3f8c463426f0a45e792f107ac402a40 Diff: http://git.reviewboard.kde.org/r/113302/diff/ Testing --- Seems to work fine in a test app. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113302: Static KEncodingFileDialog in staging/kio
On Oct. 19, 2013, 8:58 a.m., David Faure wrote: kio/kfile/kencodingfiledialog.h, line 128 http://git.reviewboard.kde.org/r/113302/diff/1/?file=202321#file202321line128 If you export the class again, no need to export the static methods individually. Or was it intended to make the class private, even with this new solution? (in that case it should be documented, the ctor should be private, etc.) Yes, the intention was to only export the static methods. I'll make the ctor private and document a bit. - Teo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/#review41957 --- On Oct. 17, 2013, 2:04 p.m., Teo Mrnjavac wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/ --- (Updated Oct. 17, 2013, 2:04 p.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kdelibs Description --- This makes KEncodingFileDialog static, moves it to staging/kio and moves some stuff from KFileDialog to KFileWidget to reduce duplication. Diffs - kio/CMakeLists.txt ac80e393c877280dd8033ec13e8e772afea6d2f9 kio/kfile/kencodingfiledialog.h abb939abeb000126005f1a1a9c6fd50b8bd322bd kio/kfile/kencodingfiledialog.cpp d55d908473aae2859838d88fd776cc65cecf3317 kio/kfile/kfiledialog.cpp 32eb98a4490a31c5ed51150ca3cb7af5375dc67e staging/kio/src/filewidgets/CMakeLists.txt e8d8c2edf11ad6352e13eb6e7436f828a4a55e3a staging/kio/src/filewidgets/kencodingfiledialog.cpp PRE-CREATION staging/kio/src/filewidgets/kfilewidget.h f7b162ab39b997274b21f9eff0c6374545e0a9ad staging/kio/src/filewidgets/kfilewidget.cpp 824ac563f3f8c463426f0a45e792f107ac402a40 Diff: http://git.reviewboard.kde.org/r/113302/diff/ Testing --- Seems to work fine in a test app. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113302: Static KEncodingFileDialog in staging/kio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/ --- (Updated Oct. 19, 2013, 11:30 a.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kdelibs Description --- This makes KEncodingFileDialog static, moves it to staging/kio and moves some stuff from KFileDialog to KFileWidget to reduce duplication. Diffs (updated) - kio/CMakeLists.txt ac80e393c877280dd8033ec13e8e772afea6d2f9 kio/kfile/kencodingfiledialog.h abb939abeb000126005f1a1a9c6fd50b8bd322bd kio/kfile/kencodingfiledialog.cpp d55d908473aae2859838d88fd776cc65cecf3317 kio/kfile/kfiledialog.cpp 32eb98a4490a31c5ed51150ca3cb7af5375dc67e staging/kio/src/filewidgets/CMakeLists.txt e8d8c2edf11ad6352e13eb6e7436f828a4a55e3a staging/kio/src/filewidgets/kencodingfiledialog.cpp PRE-CREATION staging/kio/src/filewidgets/kfilewidget.h f7b162ab39b997274b21f9eff0c6374545e0a9ad staging/kio/src/filewidgets/kfilewidget.cpp 824ac563f3f8c463426f0a45e792f107ac402a40 Diff: http://git.reviewboard.kde.org/r/113302/diff/ Testing --- Seems to work fine in a test app. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113302: Static KEncodingFileDialog in staging/kio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113302/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kdelibs Description --- This makes KEncodingFileDialog static, moves it to staging/kio and moves some stuff from KFileDialog to KFileWidget to reduce duplication. Diffs - kio/CMakeLists.txt ac80e393c877280dd8033ec13e8e772afea6d2f9 kio/kfile/kencodingfiledialog.h abb939abeb000126005f1a1a9c6fd50b8bd322bd kio/kfile/kencodingfiledialog.cpp d55d908473aae2859838d88fd776cc65cecf3317 kio/kfile/kfiledialog.cpp 32eb98a4490a31c5ed51150ca3cb7af5375dc67e staging/kio/src/filewidgets/CMakeLists.txt e8d8c2edf11ad6352e13eb6e7436f828a4a55e3a staging/kio/src/filewidgets/kencodingfiledialog.cpp PRE-CREATION staging/kio/src/filewidgets/kfilewidget.h f7b162ab39b997274b21f9eff0c6374545e0a9ad staging/kio/src/filewidgets/kfilewidget.cpp 824ac563f3f8c463426f0a45e792f107ac402a40 Diff: http://git.reviewboard.kde.org/r/113302/diff/ Testing --- Seems to work fine in a test app. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kdelibs Description --- Now that https://codereview.qt-project.org/#change,63345 is merged, this commit replaces usage of setNameFilters in some QFileDialog instances in favor of setMimeTypeFilters to avoid repeating the same conversion from mime types to globs in multiple places. Diffs - staging/kde4support/src/kssl/kcm/cacertificatespage.cpp e0a66c54633f457322729eecc0395baae8a5c548 kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 Diff: http://git.reviewboard.kde.org/r/113095/diff/ Testing --- Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/ --- (Updated Oct. 4, 2013, 11:25 a.m.) Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kdelibs Description --- Now that https://codereview.qt-project.org/#change,63345 is merged, this commit replaces usage of setNameFilters in some QFileDialog instances in favor of setMimeTypeFilters to avoid repeating the same conversion from mime types to globs in multiple places. Diffs (updated) - staging/kde4support/src/kssl/kcm/cacertificatespage.cpp e0a66c54633f457322729eecc0395baae8a5c548 kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 Diff: http://git.reviewboard.kde.org/r/113095/diff/ Testing --- Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/ --- (Updated Oct. 4, 2013, 12:02 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Kevin Ottens. Repository: kdelibs Description --- Now that https://codereview.qt-project.org/#change,63345 is merged, this commit replaces usage of setNameFilters in some QFileDialog instances in favor of setMimeTypeFilters to avoid repeating the same conversion from mime types to globs in multiple places. Diffs - staging/kde4support/src/kssl/kcm/cacertificatespage.cpp e0a66c54633f457322729eecc0395baae8a5c548 kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 Diff: http://git.reviewboard.kde.org/r/113095/diff/ Testing --- Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 20, 2013, 1:21 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support. kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic) Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical. With this all uses of KFileDialog are removed, except for KEncodingFileDialog. Diffs - kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 15, 2013, 3:36 p.m.) Review request for KDE Frameworks. Description --- KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support. kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic) Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical. With this all uses of KFileDialog are removed, except for KEncodingFileDialog. Diffs (updated) - kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog
On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: kfile/kdirselectdialog.cpp, line 408 http://git.reviewboard.kde.org/r/112037/diff/1/?file=178338#file178338line408 Hmmm it makes me realize, couldn't KEncodingFileDialog be made to depend on the file module only? That would remove the dependency on KFileDialog (the file module is planned to stay). I've investigated a bit, and we could try to make KEncodingFileDialog static-only. The majority of KEncodingFileDialog uses are static, however in a few instances kdepim/messagecomposer uses KEncodingFileDialog with instantiation and some customization (e.g. http://lxr.kde.org/source/kde/kdepim/messagecomposer/attachment/attachmentcontrollerbase.cpp#770). Maybe we can factor this into a separate kdelibs cleanups dashboard task that would involve staticifying KEncodingFileDialog while making sure kdepim can get what it needs. - Teo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review37641 --- On Aug. 15, 2013, 3:36 p.m., Teo Mrnjavac wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 15, 2013, 3:36 p.m.) Review request for KDE Frameworks. Description --- KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support. kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic) Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical. With this all uses of KFileDialog are removed, except for KEncodingFileDialog. Diffs - kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 14, 2013, 12:20 p.m.) Review request for KDE Frameworks. Description --- KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support. kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic) Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical. With this all uses of KFileDialog are removed, except for KEncodingFileDialog. Diffs (updated) - kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112037: Replace most instances of KFileDialog with QFileDialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- Review request for KDE Frameworks. Description --- KFileDialog is deprecated in favor of QFileDialog. The original intention was to completely replace the former with the latter and move KFileDialog to kde4support. kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static methods are in Qt (see the 5.1 epic) Unfortunately, it turned out that KEncodingFileDialog inherits from KFileDialog, and is still used in a bunch of places, making the complete removal of KFileDialog impractical. With this all uses of KFileDialog are removed, except for KEncodingFileDialog. Diffs - kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 kio/kssl/kcm/cacertificatespage.cpp 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 Diff: http://git.reviewboard.kde.org/r/112037/diff/ Testing --- Does not break any tests. Thanks, Teo Mrnjavac ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
