D23721: Fix race condition in TextBuffer

thomassc abandoned this revision. thomassc added a comment. Okay, thanks for your feedback. Discarding this then. I think I might have found the problematic access in KDevelop already in the meantime ... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23721 To:

D23721: Fix race condition in TextBuffer

thomassc added a comment. Okay, I wasn't aware of the overall situation wrt. threading. Still, couldn't it be useful to at least allow for concurrent read accesses which is probably not a large effort (in contrast to concurrent read and write)? I guess that people might not expect

D23721: Fix race condition in TextBuffer

thomassc edited the summary of this revision. thomassc added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23721 To: thomassc, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D23721: Fix race condition in TextBuffer

thomassc created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. thomassc requested review of this revision. REVISION SUMMARY In the "shortcut: try last block first" branch in TextBuffer::blockForLine(), m_lastUsedBlock is

D22315: Add setting to enable/disable text drag-and-drop (on by default)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c0321472330b: Add setting to enable/disable text drag-and-drop (on by default) (authored by thomassc). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D22315: Add setting to enable/disable text drag-and-drop (on by default)

thomassc added a comment. Thanks for having a look. Here is a screenshot of the config page with the new option on it (third from the bottom): F6991601: kate-config-text-drag-and-drop.png Do you think that the label there is okay as-is? Or

D22315: Add setting to enable/disable text drag-and-drop (on by default)

thomassc added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22315 To: thomassc, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22315: Add setting to enable/disable text drag-and-drop (on by default)

thomassc created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. thomassc requested review of this revision. REVISION SUMMARY This change adds a setting to enable or disable the ability to move the selected text by

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. I guess the previous situation is still more practical, since by temporarily adding a newline there below the oversized line, it is at least possible to edit that line. With the line cut off, it is impossible to edit. Also, in cases where a line is only slightly

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. > If you keep the overpainting, you will just overpaint the next line partially with it, that won't help that much, IMHO. > > Take a look at bug 404713. I totally agree, but this is a different issue that is out of scope here as far as I see. Bugs 403868

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. > The summary of this diff reads a bit as if it doesn't noticeably improve behaviour The line height change (a part of this commit) does noticeably improve behavior for the font that is used on my system. REPOSITORY R39 KTextEditor REVISION DETAIL

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. > We trade one bug for another. Which one is worse? Without having had a detailed look, it seems to me like the problem reported by @rjvbb might be caused by the removal of the workaround with the second drawing passes in this commit (the changes in

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. I think that this change will fix bug 403470 as well. Suggestion: in updateFontHeight() in katerenderer.cpp, add a comment saying that the line height needs to match that which is used by Qt, since Qt may handle some parts of the drawing, e.g. selection

D17932: Improvements to completion

thomassc updated this revision to Diff 49397. thomassc added a comment. Change to a single setter for match_cs and exact_match_cs to avoid restriction on call order of functions REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17932?vs=49343=49397

D17932: Improvements to completion

thomassc updated this revision to Diff 49343. thomassc added a comment. Update according to Milian's comments REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17932?vs=48574=49343 BRANCH improvements_to_completion (branched from master) REVISION

D17932: Improvements to completion

thomassc marked 4 inline comments as done. thomassc added a comment. Thanks for reviewing. Regarding the question about which models would have an insensitive exact match, and which ones have sensitive exact matches: - An example for case-insensitive exact matches might be plain text, or

D17932: Improvements to completion

thomassc created this revision. thomassc added a reviewer: KTextEditor. thomassc added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. thomassc requested review of this revision. REVISION SUMMARY My goal is to fix

D17904: Highlight CUDA .cu and .cuh files as C++

thomassc updated this revision to Diff 48519. thomassc added a comment. Thanks for having a look. I assume that the "version" attribute needs to be increased and the "kateversion" does not. I updated the diff accordingly. I don't think that I have any commit rights, can you commit?

D17904: Highlight CUDA .cu and .cuh files as C++

thomassc created this revision. thomassc added a reviewer: Framework: Syntax Highlighting. thomassc added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. thomassc requested review of this revision.