D29003: Use Q_EMIT and build with QT_NO_KEYWORDS
junghans added a comment. Thank you for committing! Although I recently gained push rights, I did not have time yet to dig into the details of how to create/push commit respecting the KDE standards etc. Next time, I'll try on my own :) REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29003: Use Q_EMIT and build with QT_NO_KEYWORDS
junghans updated this revision to Diff 80852. junghans added a comment. The initial diff was incomplete. This one covers all occurrences of Q_EMIT. REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29003?vs=80610=80852 REVISION DETAIL https://phabricator.kde.org/D29003 AFFECTED FILES CMakeLists.txt autotests/proxymodeltestsuite/dynamictreemodel.cpp src/core/kcheckableproxymodel.cpp src/core/kconcatenaterowsproxymodel.cpp src/core/kdescendantsproxymodel.cpp src/core/kextracolumnsproxymodel.cpp src/core/knumbermodel.cpp src/core/kselectionproxymodel.cpp tests/proxymodeltestapp/kreparentingproxymodel.cpp tests/proxymodeltestapp/lessthanwidget.cpp To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29003: Use Q_EMIT and build with QT_NO_KEYWORDS
junghans created this revision. junghans added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. junghans requested review of this revision. REVISION SUMMARY QT_NO_KEYWORDS will be default in Qt 6 so all occurrences of `emit` should be replaced by `Q_EMIT`. TEST PLAN Build with QT_NO_KEYWORDS define enabled and observe succesful build. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 AFFECTED FILES CMakeLists.txt autotests/proxymodeltestsuite/dynamictreemodel.cpp src/core/kcheckableproxymodel.cpp src/core/kconcatenaterowsproxymodel.cpp src/core/kdescendantsproxymodel.cpp src/core/kextracolumnsproxymodel.cpp src/core/kselectionproxymodel.cpp tests/proxymodeltestapp/kreparentingproxymodel.cpp tests/proxymodeltestapp/lessthanwidget.cpp To: junghans, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
