Policy on forward declarations for things from external libraries

2020-07-31 Thread Vlad Zahorodnii
Howdy, From time to time, I find myself in a situation where a code reviewer suggests to replace #include with the corresponding class forward declaration. Such discussions usually get us nowhere because neither the code reviewer nor I mind to seek for a compromise. A policy would prevent

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-06-11 Thread Vlad Zahorodnii
zzag closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26503 To: zzag, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-06-11 Thread Vlad Zahorodnii
zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26503 To: zzag, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-06-11 Thread Vlad Zahorodnii
zzag updated this revision to Diff 83261. zzag added a comment. Fix merge conflict. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26503?vs=74590=83261 BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26503

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

2020-06-05 Thread Vlad Zahorodnii
zzag added a comment. > This added field to Application desktop entries allows to declare an access request to a DBUS interface. Just to be sure. Does X-KDE-DBUS-Restricted-Interfaces indicate a D-Bus interface or a D-Bus service? REPOSITORY R309 KService REVISION DETAIL

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-05-20 Thread Vlad Zahorodnii
zzag added a comment. In D29815#672682 , @anthonyfieroni wrote: > Is that KWin that set titlebar menus? from `#plasma` irc 5:02:41 PM kded does not load kwin 5:03:15 PM I believe the appmenu version where it's shown in the title

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-05-20 Thread Vlad Zahorodnii
zzag removed a reviewer: zzag. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

2020-05-14 Thread Vlad Zahorodnii
zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. In general, it's better to use QScreen::availableGeometry(). REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D29569 To: printesoi, davidedmundson, #kwin, zzag

D29256: [server] Introduce mapped() signal

2020-05-04 Thread Vlad Zahorodnii
zzag closed this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29256 To: zzag, #kwin, davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29278: Port KWin to KWaylandServer

2020-04-30 Thread Vlad Zahorodnii
zzag accepted this revision. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson, zzag Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski,

D29278: Port KWin to KWaylandServer

2020-04-30 Thread Vlad Zahorodnii
zzag added a comment. Hmm, I can't build kwin /home/vlad/Workspace/KDE/src/kde/workspace/kwin/libkwineffects/kwineffects.cpp:44:10: fatal error: KWaylandServer/surface_interface.h: No such file or directory 44 | #include |

D29231: Add keyboard_shortcuts_inhibit protocol

2020-04-29 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in keyboard_shortcuts_inhibit_interface.cpp:21 > Q_DECL_PRIVATE You've probably meant Q_DECL_HIDDEN, right? On an unrelated note: there are valid arguments against nested private classes so it would be really nice if we

D29256: [server] Introduce mapped() signal

2020-04-28 Thread Vlad Zahorodnii
zzag marked an inline comment as done. REPOSITORY R127 KWayland BRANCH introduce-mapped-signal REVISION DETAIL https://phabricator.kde.org/D29256 To: zzag, #kwin, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29256: [server] Introduce mapped() signal

2020-04-28 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > apol wrote in surface_interface.cpp:333 > I don't understand, ^ and != are logically equivalent, ^ is the bitwise > counterpart. > > Am I missing something? Oh, I thought you suggested to do `source->buffer != target->buffer`. REPOSITORY R127

D29256: [server] Introduce mapped() signal

2020-04-28 Thread Vlad Zahorodnii
zzag updated this revision to Diff 81456. zzag marked 2 inline comments as done. zzag added a comment. Use != REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29256?vs=81453=81456 BRANCH introduce-mapped-signal REVISION DETAIL

D29256: [server] Introduce mapped() signal

2020-04-28 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > apol wrote in surface_interface.cpp:333 > Using != would probably be more readable and accurate (we're don't need it to > be bitwise, we're assuming bool changes it to 1 or 0). We can't use != because mapped() will be emitted each time a

D29256: [server] Introduce mapped() signal

2020-04-28 Thread Vlad Zahorodnii
zzag updated this revision to Diff 81453. zzag added a comment. Check whether the attached buffer flip-flopped between non-null and null only when bufferChanged is true. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29256?vs=81432=81453 BRANCH

D29256: [server] Introduce mapped() signal

2020-04-28 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY In KWin, we need to know when a sub-surface becomes mapped or unmapped so we can generate or

Re: Splitting KWayland

2020-04-28 Thread Vlad Zahorodnii
On 4/27/20 4:12 PM, David Edmundson wrote: I don't think we want to remove client or server tests on this one. As the client tests covered the server side too Hmm, does this mean we are going to keep both the client and the server side in KWaylandServer? Cheers, Vlad

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

2020-04-27 Thread Vlad Zahorodnii
zzag added a comment. Thanks, this patch looks good to me. Although it would be nice to see the kwin side before leaving a +1. :) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: romangg, crossi, kde-frameworks-devel,

D28882: Create protocol to manage video feeds

2020-04-27 Thread Vlad Zahorodnii
zzag added a comment. In D28882#658780 , @apol wrote: > > In future, it might be faster to put up just the interface xml for review first. > > @davidedmundson @zzag I don't really see how it would have made a difference, you only decided

D28882: Create protocol to manage video feeds

2020-04-27 Thread Vlad Zahorodnii
zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. > In future, it might be faster to put up just the interface xml for review first. ++ --- What about using existing `wl_output` objects? The `add_source` event can be

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

2020-04-27 Thread Vlad Zahorodnii
zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. I don't want to be selfish, but I'm not really used to the coding style in this patch. Could you please move method definitions outside class declarations? INLINE COMMENTS >

D27859: [server] Expose SurfaceRole class

2020-04-27 Thread Vlad Zahorodnii
zzag abandoned this revision. zzag added a comment. Given our planned kwaylandserver changes, we don't need this patch. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27859 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-24 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasma-window-management.xml:74 > > + > + To be in-line with upstream standards, please add ``. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: meven,

D27860: [server] Add some sub-surface life cycle signals

2020-04-23 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R127:8945c1f7baaf: [server] Add some sub-surface life cycle signals (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27860?vs=76996=80998#toc REPOSITORY R127 KWayland CHANGES

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:297 > > +void PlasmaWindowManagementInterface::setStackingOrder(const > QVector& stackingOrder) > +{ coding style: whitespace before `&` REPOSITORY R127 KWayland REVISION DETAIL

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement.cpp:47 > void windowCreated(org_kde_plasma_window *id, quint32 internalId); > +void setStackingOrder(const QVector& ids); > Coding style: whitespace before `&` and `*` > plasmawindowmanagement_interface.cpp:297 >

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement.cpp:242 > > +void PlasmaWindowManagement::Private::stackingOrderCallback(void *data, > org_kde_plasma_window_management *interface, wl_array *ids) { > +auto wm = reinterpret_cast(data); The opening brace must be on a

D29033: Remove duplicated code

2020-04-21 Thread Vlad Zahorodnii
zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > waylandintegration.cpp:191 > [this] (PlasmaWindow *w) { > -emit KWindowSystem::self()->windowAdded(w->internalId()); > -

D29036: Print meaningful warning when there is no QGuiApplication

2020-04-21 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D29036 To: broulik, #plasma, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-17 Thread Vlad Zahorodnii
zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. This seems super complicated. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28892 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel,

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-14 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > display.h:281-288 > /** > * Creates the XdgOutputManagerInterface > * > * @return the created manager > * @since 5.47 > + * @deprecated use the version that takes a version > */ Please use

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-03 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > apol wrote in display.h:296 > Passing an enum as const& is wrong although it doesn't make much of a > difference in practice. > > `You can't introduce another createXdgOutputManager() because it's not > overloaded`. He's adding an overload, I

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-02 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > display.h:297 > + */ > +XdgOutputManagerInterface *createXdgOutputManager(const > XdgOutputInterfaceVersion , QObject *parent = nullptr); > + You can't introduce another createXdgOutputManager() because it's not overloaded. You probably

D28442: Fix warnings

2020-03-30 Thread Vlad Zahorodnii
zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > buffer_interface.cpp:287-291 > size.width(), > size.height(), >

D27338: Provide an initial implementation for input-method-unstable-v1

2020-03-30 Thread Vlad Zahorodnii
zzag added a comment. In D27338#638128 , @davidedmundson wrote: > We can't just make up policy changes ad-hoc on a review request to make it different to every other class in KWayland. Heh, if we really don't want to deviate from the

D27338: Provide an initial implementation for input-method-unstable-v1

2020-03-30 Thread Vlad Zahorodnii
zzag added a comment. > If it makes you happy. But we're building with opt-in export symbols, it shouldn't make much of a difference. After reading some inline comments in D28295 , I think it would be better to get rid of the nested private class

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

2020-03-30 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R278:d3bc79da9256: Fix EWMH non-compliance for NET::{OnScreenDisplay,CriticalNotification} (authored by catherinez, committed by zzag). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D27338: Provide an initial implementation for input-method-unstable-v1

2020-03-26 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > inputmethod_interface.cpp:153-154 > +{ > +for (auto r : d->resourceMap()) > +d->send_commit_state(r->handle, serial); > +} I don't understand why we need `resourceMap()` here. zwp_input_method_context_v1 is not a global so I would

D27338: Provide an initial implementation for input-method-unstable-v1

2020-03-26 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > inputmethod_interface.cpp:128 > +{ > +wl_resource_destroy(resource->handle); > +if (resourceMap().isEmpty()) Don't call wl_resource_destroy() in foobar_destroy_resource(), it's dangerous. void

D27338: Provide an initial implementation for input-method-unstable-v1

2020-03-26 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > inputmethod_interface.cpp:128-129 > +wl_resource_destroy(resource->handle); > +if (resourceMap().isEmpty()) > +q->deleteLater(); > +} Destroy `q` in zwp_input_method_context_v1_destroy_resource(). In the destructor

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-03-25 Thread Vlad Zahorodnii
Hi, On 3/23/20 4:44 PM, David Edmundson wrote: Yeah, I feel that's what kwayland was originally going for. Seat, for example, does a lot of dispatching and logic internally. Then it drifted into being just wrappers. We do need to answer that question definitively otherwise we'll be forever

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-03-25 Thread Vlad Zahorodnii
Hi, On 3/24/20 4:35 PM, Aleix Pol wrote: We can decide what we want for KF6 and act accordingly. If for example, we were to split kwayland into kwaylandclient and kwaylandserver and the latter be in plasma, we could consider putting new code in KWin or a shared repository. I was also thinking

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-03-25 Thread Vlad Zahorodnii
Hi, On 3/24/20 6:55 PM, David Edmundson wrote: I just had a near miss with XdgOutputV1(version2) which luckily we were able to easily guard. Had the spec claimed that in version2 sending xdg_output.name was mandatory we would have been completely screwed. Unfortunately, I have bad news. We're

D27338: Provide an initial implementation for input-method-unstable-v1

2020-03-25 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > display.cpp:49 > +#include "inputmethod_interface.h" > + > Stray new line. Please remove it. > inputmethod_interface.cpp:25 > + > +class InputMethodContextInterface::Private : public > QtWaylandServer::zwp_input_method_context_v1 > +{ Add

D28245: [xdgoutput] Only send initial name and description if set

2020-03-24 Thread Vlad Zahorodnii
zzag added a comment. In D28245#633649 , @davidedmundson wrote: > I interpreted the spec the same way when I wrote this...but we don't have a choice. I think we do. (a) Revert the recent xdg-output patches and land them in KF 5.70

D28245: [xdgoutput] Only send initial name and description if set

2020-03-24 Thread Vlad Zahorodnii
zzag added a comment. The spec says that `name` and `description` events will be sent after the `xdg-output` is created. I believe it might be a problem. We should remove these `if`s in KF 5.70. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28245 To:

D28245: [xdgoutput] Only send initial name and description if set

2020-03-24 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28245 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28168: Broadcast application menu to resources when registering them

2020-03-20 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH cblack/broadcast-appmenu-on-resource-register (branched from master) REVISION DETAIL https://phabricator.kde.org/D28168 To: cblack, #kwin, zzag Cc: kde-frameworks-devel, zzag,

D28164: Add test for application menu in PWM interface

2020-03-20 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH cblack/appmenu-tests (branched from master) REVISION DETAIL https://phabricator.kde.org/D28164 To: cblack, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

2020-03-19 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R127:ff9cadf00f21: [server] Dont make assumptions about the order of damage_buffer and attach… (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

2020-03-19 Thread Vlad Zahorodnii
zzag added a comment. In general, the idea of raising a protocol error when the client tries to damage a surface with no buffer seems sensible. But the spec doesn't say damage_buffer requests must be followed by attach requests and we can't really predict the future. REPOSITORY R127

D28147: [server] Don't make assumptions about the order of damage_buffer and attach requests

2020-03-19 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The spec says nothing about the order between damage_buffer and attach requests. TEST PLAN

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

2020-03-19 Thread Vlad Zahorodnii
zzag added a comment. Urgh, the authorship information is screwed up. :/ REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14910 To: graesslin, #kwin, #frameworks, davidedmundson, zzag Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

2020-03-19 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R127:6bfa71d89aee: Pass a dedicated fd to each keyboard for the xkb keymap (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14910?vs=77916=78000

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-19 Thread Vlad Zahorodnii
zzag added a comment. Maybe it would be worth to send an email to wm-spec-list proposing to deprecate LAUNCHED_BY, but on the other hand fixing X11 stuff in any way is like beating a dead horse. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL

D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH appmenu-x11 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n,

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-18 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R127:deb476e47d47: [server] Introduce SurfaceInterface::boundingRect() (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27828?vs=76922=77918

D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > netwm.cpp:3554 > + > +const char* NETWinInfo::appMenuObjectPath() const > +{ nit: add whitespace before `*` > netwm.cpp:3559 > + > +const char* NETWinInfo::appMenuServiceName() const > +{ ditto REPOSITORY R278 KWindowSystem REVISION DETAIL

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

2020-03-18 Thread Vlad Zahorodnii
zzag updated this revision to Diff 77916. zzag added a comment. Rebase on master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14910?vs=39945=77916 BRANCH arcpatch-D14910 REVISION DETAIL https://phabricator.kde.org/D14910 AFFECTED FILES

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-03-18 Thread Vlad Zahorodnii
On 3/17/20 12:27 PM, David Edmundson wrote: IMHO we're lacking a "what actually is kwayland?" and an accurate definition of what's the added value compared to just using the auto generated classes directly. That's a good question! On one hand, it's nice to have Qt-friendly wrappers for

D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > netwm.cpp:4697-4707 > if (dirty2 & WM2GTKFrameExtents) { > p->gtk_frame_extents = NETStrut(); > > QVector data = get_array_reply(p->conn, > cookies[c++], XCB_ATOM_CARDINAL); > if (data.count() == 4) { >

D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > zzag wrote in netwininfotestclient.cpp:281-319 > You have to change properties via xcb_change_property(). > > void NetWinInfoTestClient::testAppMenuObjectPath() > { > ATOM(_KDE_NET_WM_APPMENU_OBJECT_PATH) > INFO > >

D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Vlad Zahorodnii
zzag requested changes to this revision. zzag added a reviewer: KWin. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > netwininfotestclient.cpp:281-319 > +void NetWinInfoTestClient::testAppMenuObjectPath() > +{ > +

D26858: Provide an implementation for the tablet interface

2020-03-17 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > test_tablet_interface.cpp:1-19 > +/ > +Copyright 2020 Aleix Pol Gonzalez > + > +This library is free software; you can redistribute it and/or > +modify it under the terms of the GNU

D28056: KWindowSystem: Convert license headers to SPDX expressions

2020-03-15 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D28056 To: cordlandwehr, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28058: KWayland: Convert license headers to SPDX

2020-03-15 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D28058 To: cordlandwehr, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-13 Thread Vlad Zahorodnii
zzag added a comment. Do you know why LAUNCHED_BY was added? The spec [1] has no a single word about its potential use cases. [1] https://specifications.freedesktop.org/startup-notification-spec/startup-notification-latest.txt REPOSITORY R278 KWindowSystem REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-10 Thread Vlad Zahorodnii
zzag added a comment. In D27464#625403 , @broulik wrote: > Didn't we have a dedicated protocol for window menu in plasma-integration? Or is this just for reading? We surely don't want all apps to use plasma surface interface for announcing the

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-10 Thread Vlad Zahorodnii
zzag added a comment. In D27464#625403 , @broulik wrote: > Didn't we have a dedicated protocol for window menu in plasma-integration? That protocol is for announcing global menus. > Or is this just for reading? Yes, it's for

Problems in KWayland causes by API and ABI compatibility promises

2020-03-05 Thread Vlad Zahorodnii
Hi, KWayland is a library that provides convenience wrappers for Wayland protocols. Usually, when we want to implement some Wayland protocol, first, we add corresponding wrappers in KWayland and after that we actually implement the protocol in KWin. Unfortunately, we made a bad design

D27859: [server] Expose SurfaceRole class

2020-03-05 Thread Vlad Zahorodnii
zzag added a dependent revision: D27860: [server] Add some sub-surface life cycle signals. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27859 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-05 Thread Vlad Zahorodnii
zzag added a dependent revision: D27859: [server] Expose SurfaceRole class. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27828 To: zzag, #kwin, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

2020-03-05 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY These signals can be very useful when one wants to monitor changes in a sub-surface tree.

D27860: [server] Add some sub-surface life cycle signals

2020-03-05 Thread Vlad Zahorodnii
zzag added a dependency: D27859: [server] Expose SurfaceRole class. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27860 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27859: [server] Expose SurfaceRole class

2020-03-05 Thread Vlad Zahorodnii
zzag added a dependency: D27828: [server] Introduce SurfaceInterface::boundingRect(). REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27859 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27859: [server] Expose SurfaceRole class

2020-03-05 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY This can be useful for implementing out-of-tree shell surface protocols. REPOSITORY R127

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii
zzag added a comment. I'll merge this patch after 5.68 is tagged. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27828 To: zzag, #kwin, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii
zzag added a comment. In D27828#621821 , @apol wrote: > Maybe producing the patch that is meant to consume this will help see what's the use for this patch. D27831 REPOSITORY R127 KWayland

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii
zzag updated this revision to Diff 76922. zzag added a comment. Add missing @since REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27828?vs=76921=76922 REVISION DETAIL https://phabricator.kde.org/D27828 AFFECTED FILES src/server/surface_interface.cpp

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The new method provides a convenient way for determining the rectangle that bounds the given

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Vlad Zahorodnii
zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Thanks. Even though the patch is accepted, please do not land it yet. https://phabricator.kde.org/D27464#621521 REPOSITORY R127 KWayland BRANCH cblack/appmenu-listener REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Vlad Zahorodnii
zzag added a comment. Looks good to me, but please don't land without corresponding KWin patch. INLINE COMMENTS > plasmawindowmanagement.h:700 > +/** > + * TODO: Documentation. > + **/ You missed this one. REPOSITORY R127 KWayland REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement.cpp:372 > + > +Q_UNUSED(window); > +} Please move it to the top of the method and remove the semicolon. > plasmawindowmanagement.h:526-527 > > +QString applicationMenuServiceName() const; > +QString

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-02 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:85 > void setGeometry(const QRect ); > +void setApplicationMenuPaths(const QString& service, const QString& > object); > wl_resource *resourceForParent(PlasmaWindowInterface *parent, > wl_resource

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-02 Thread Vlad Zahorodnii
zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > plasmawindowmanagement.cpp:363 > > +void PlasmaWindow::Private::appmenuChangedCallback(void *data, > org_kde_plasma_window *window, const char* service_name,

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-02 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > plasma-window-management.xml:20 > > > version="10" > plasma-window-management.xml:87 > > - > + > version="10" > plasma-window-management.xml:312 > > + > + and this one should be > davidedmundson

D27538: Registry: don't destroy the callback on globalsync

2020-02-21 Thread Vlad Zahorodnii
zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D27538 To: dvratil, #kwin, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27535: Add XdgOutputV1 version 2

2020-02-21 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D27535 To: davidedmundson, #kwin, zzag Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27190: [surface] Fix buffer offset when attaching buffers to surfaces

2020-02-06 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D27190 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag added a comment. In D27087#604479 , @broulik wrote: > There's a Qt heif image plug in in the works in Qt. If any, we should help there or at least get our own into kimageformats, so Gwenview and others can open such files properly.

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag added a comment. In D27087#604477 , @ngraham wrote: > Very cool. So QImage supports this file format now such that you could open the image in, say, Gwenview? No, as far as I know there is no `QImageIOHandler` for HEIF files.

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag updated this revision to Diff 74836. zzag added a comment. missing copyright stuff in Findlibheif.cmake REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27087?vs=74835=74836 BRANCH heic-thumbnailer REVISION DETAIL

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: Plasma. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. zzag requested review of this revision. REPOSITORY R320 KIO Extras BRANCH heic-thumbnailer REVISION DETAIL

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-01-29 Thread Vlad Zahorodnii
zzag updated this revision to Diff 74590. zzag added a comment. s/const QWindow/QWindow/ REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26503?vs=74098=74590 BRANCH port-to-shadows-api REVISION DETAIL

D26960: RFC: [KWindowShadows] Check for X connection

2020-01-28 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D26960 To: broulik, #plasma, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26858: Provide an implementation for the tablet interface

2020-01-28 Thread Vlad Zahorodnii
zzag accepted this revision. zzag added a subscriber: davidedmundson. zzag added a comment. This revision is now accepted and ready to land. Code-wise, this change looks good. I don't have a tablet device to test this patch so you may want to wait for a +1 from @davidedmundson. INLINE

  1   2   >