D26331: Removed reading description from .desktop files AND .directory files

[count negative]

count added a comment.


  In D26331#588073 <https://phabricator.kde.org/D26331#588073>, @ngraham wrote:
  
  > Thanks! @count, can you provide us with your full name and email address so 
we can land this patch with accurate authorship information?
  
  
  It's count negative 
  count(dot)negative(at)gmx(dot)de

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from .desktop files AND .directory files

[count negative]

count updated this revision to Diff 72807.
count added a comment.


  added removing of .directory files reading

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26331?vs=72803=72807

REVISION DETAIL
  https://phabricator.kde.org/D26331

AFFECTED FILES
  src/core/kfileitem.cpp

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from .desktop files AND .directory files

[count negative]

count set the repository for this revision to R241 KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from .desktop files AND .directory files

[count negative]

count updated this revision to Diff 72803.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26331?vs=72490=72803

REVISION DETAIL
  https://phabricator.kde.org/D26331

AFFECTED FILES
  src/core/kfileitem.cpp

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from .desktop files AND .directory files

[count negative]

count retitled this revision from "Removed reading description from desktop 
files" to "Removed reading description from .desktop files AND .directory 
files".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from desktop files

[count negative]

count added a comment.


  Ok, I've played a little around, and imho we should remove the support for 
.directory file comments too:
  
  Here you see, the type column is read from the comment field inside the 
.directory file
  F7861776: screen.png 
  
  [Desktop Entry]
  Name=Neue Menükategorie
  Comment=Blabla from .directory file
  Icon=passendes_Symbol
  Type=Directory
  
  And here is the independent comment metadata
  F7861781: comment.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26331: Removed reading description from desktop files

[count negative]

count added a comment.


  In D26331#586565 , @broulik wrote:
  
  > What about the directory Comment "feature" a few lines below? It is equally 
as questionable and causes significant slowdowns when browsing folders on nfs 
mounts, cf. D13757 
  
  
  I thought, the !d->isSlow() would skip that part for (fsType == 
KFileSystemType::Nfs || fsType == KFileSystemType::Smb) as seen in 
kfileitem.cpp:763. So I would leave that here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26331: Removed reading description from desktop files

[count negative]

count edited the summary of this revision.
count edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26331: Removed reading description from desktop files

[count negative]

count added a reviewer: broulik.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

[count negative]

count created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
count requested review of this revision.

REVISION SUMMARY
  For https://bugs.kde.org/show_bug.cgi?id=382325 i've removed reading comments 
inside desktop files.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

AFFECTED FILES
  src/core/kfileitem.cpp

To: count
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns