D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-14 Thread eudoxos
eudoxos updated this revision to Diff 75727. eudoxos added a comment. Fix indentation lines shown spuriously when horizontal space was unsufficient for indent fill REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27285?vs=75533&id=75727 BRANCH dyn

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-14 Thread eudoxos
eudoxos added a comment. Note to myself: should handle the case when width percentage disallows the indent, e.g. here: F8104336: image.png <https://phabricator.kde.org/F8104336> REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27285 To: eudoxos, #vdg Cc:

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-13 Thread eudoxos
eudoxos added a comment. (side note: I am not sure whether to use phabricator.kde.org or invent.kde.org for this. Are they complementary or orthogonal?) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27285 To: eudoxos, #vdg Cc: dhaumann, kwrite-devel, kde

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-13 Thread eudoxos
eudoxos added a comment. > No offense meant, but even with the screenshots I still have no idea what this is about :) Good point, I somehow missed to explain the rationale for the change. :) If you are familiar with vim, this would be the `breakindent` and `breakindentopt` setti

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-12 Thread eudoxos
eudoxos added a comment. This is the current dialogue, with two new options at the bottom (the circle had horizontal spring before an unrelated option, I think it was there by accident...?!). F8099358: image.png <https://phabricator.kde.org/F8099358> REPOSITORY R39 KText

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-12 Thread eudoxos
eudoxos updated this revision to Diff 75533. eudoxos added a comment. Rename config keys as per discussion under D27238 <https://phabricator.kde.org/D27238> REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27285?vs=75440&id=75533 BRANCH dynw

D27238: Add an option to dynamic-break inside words

2020-02-11 Thread eudoxos
eudoxos updated this revision to Diff 75509. eudoxos added a comment. Change config key to `dynamic-word-wrap-anywhere` as suggested. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27238?vs=75231&id=75509 REVISION DETAIL https://phabricator.kde.org/D27238 AFFECTED FILES

D27238: Add an option to dynamic-break inside words

2020-02-11 Thread eudoxos
eudoxos added a comment. In D27238#609494 <https://phabricator.kde.org/D27238#609494>, @cullmann wrote: > I am ok with this. > Thought I would like to have a more consistent name for the config key. > We have already "dynamic-word-wrap", I would like &q

D27238: Add an option to dynamic-break inside words

2020-02-11 Thread eudoxos
eudoxos added a comment. A complementary (also related to dynamic wrapping) change is tracked under D27285 <https://phabricator.kde.org/D27285>. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27238 To: eudoxos Cc: dhaumann, cullmann, kwrite-deve

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-11 Thread eudoxos
eudoxos updated this revision to Diff 75440. eudoxos added a comment. Fix tab/space indentation, fix maximum width. No other glitches known at present. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27285?vs=75361&id=75440 BRANCH dynwrap-ma

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-10 Thread eudoxos
eudoxos added a comment. Note: extra space (right fill) is not computed correctly if tabs are used for line indentation. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27285 To: eudoxos, #vdg Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-10 Thread eudoxos
eudoxos added a comment. This is an example with right fill of 3 characters, left fill off, with indentation lines (note that they spend all visual lines of the dynamically wrapped line). F8095407: image.png <https://phabricator.kde.org/F8095407> REPOSITORY R39 KTextEditor RE

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

2020-02-10 Thread eudoxos
eudoxos created this revision. eudoxos added a reviewer: VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. eudoxos requested review of this revision. REVISION SUMMARY The configuration UI is somewhat clumsy, some better arrangement

D27238: Add an option to dynamic-break inside words

2020-02-08 Thread eudoxos
eudoxos created this revision. eudoxos added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. eudoxos requested review of this revision. REVISION SUMMARY Add option to break lines longer than view width (or static