[Differential] [Updated, 36 lines] D4003: Fix "byte order marker" -> "byte order mark", use upper-case "Unicode" name

2017-01-08 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 9849. kossebau marked 3 inline comments as done. kossebau added a comment. rename modline var + backward compat code REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4003?vs=9821=9849 BRANCH

[Differential] [Commented On] D4003: Fix "byte order marker" -> "byte order mark", use upper-case "Unicode" name

2017-01-07 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. In https://phabricator.kde.org/D4003#74814, @cullmann wrote: > Guess the wrong naming is my fault, fixing that is a good idea. > Perhaps for the mode line, just add the "byte-order-mark" as alternative (and keep the old one to be compatible)? For now

[Differential] [Request, 31 lines] D4003: Fix "byte order marker" -> "byte order mark", use upper-case "Unicode" name

2017-01-07 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added a reviewer: Kate. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY The official names are "byte order mark" and "Unicode". Also consistently use "(BOM)"

[Differential] [Updated, 147 lines] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

2017-01-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 9781. kossebau marked an inline comment as done. kossebau added a comment. Use Q_DECL_OVERRIDE & nullpt REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3977?vs=9775=9781 BRANCH fixKDynamicJobTracker REVISION DETAIL

[Differential] [Updated, 147 lines] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

2017-01-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 9775. kossebau added a comment. add unittest for crash by qwidgets without qapplication instance REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3977?vs=9740=9775 BRANCH fixKDynamicJobTracker REVISION DETAIL

[Differential] [Request, 77 lines] D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

2017-01-04 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY KDynamicJobTracker was not cleaning up its internal job tracking data structure on finished jobs. Also was it trying to create a KWidgetJobTracker even

[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-23 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. Okay, thanks for fixing for Qt 5.8. Cherry-picked your commit also for the Plasma/5.8 branch now for upcoming Plasma 5.8.4 release, given Plasma 5.9.0 will only appear after Qt 5.8.0 (by schedules at least), so chances are people will want to run 5.8 with 5.8 :)

[Differential] [Commented On] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-23 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kdeplatformfiledialoghelper.cpp:368 > This does NOT build for me. > > qplatformdialoghelper.h:295:5: error: > ‘QFileDialogOptions::QFileDialogOptions(const QFileDialogOptions&)’ is private >

[Differential] [Closed] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-22 Thread kossebau (Friedrich W. H. Kossebau)
kossebau closed this revision. kossebau marked an inline comment as done. kossebau added a comment. Committed with 7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3796 EMAIL PREFERENCES

[Differential] [Request, 25 lines] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-22 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added reviewers: Plasma, Frameworks, dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QFileDialog does not set the initialDirectory option in codepaths from

[Differential] [Closed] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
This revision was automatically updated to reflect the committed changes. Closed by commit R240:5f17bf2c0c65: Ignore host libs/includes/cmakeconfig files in Android toolchain (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3646?vs=9166=9180#toc REPOSITORY R240

[Differential] [Closed] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R240:957e00fe3d32: Document usage of gnustl_shared with Android toolchain (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the summary for this revision. REPOSITORY R240 Extra CMake Modules BRANCH avoidHostLibsIncludesinAndroidToolchain REVISION DETAIL https://phabricator.kde.org/D3646 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau,

[Differential] [Updated, 8 lines] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 9168. kossebau added a comment. - Added explanation for hardcoding gnustl_shared for now - Removed comment as proposed REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3732?vs=9167=9168 BRANCH

[Differential] [Commented On] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. http://doc.qt.io/qbs/android-ndk-module.html allows to control which helper runtime to use, so hardcoding gnustl_shared in the ECM toolchain could have been done for a certain reason or perhaps just was done once to get started, but never revisited? REPOSITORY

[Differential] [Commented On] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:188 > It's where the STL lives: > https://developer.android.com/ndk/guides/cpp-support.html Moved to separate https://phabricator.kde.org/D3732 REPOSITORY R240 Extra CMake Modules BRANCH

[Differential] [Request, 7 lines] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added reviewers: Frameworks, apol, cordlandwehr. REPOSITORY R240 Extra CMake Modules BRANCH addCommentAboutGNUSTLCheck REVISION DETAIL https://phabricator.kde.org/D3732 AFFECTED FILES toolchain/Android.cmake EMAIL PREFERENCES

[Differential] [Updated, 50 lines] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 9166. kossebau added a comment. - Rename ECM_ANDROID_ROOT_PATH -> ECM_ADDITIONAL_FIND_ROOT_PATH - drop gnustl_shared documenting todo for a separate review REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-18 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:163 > Maybe call it `ECM_ALTERNATIVE_ROOT_PATH`, in case we ever need to use it on > other platforms as well? Hm, indeed a point in that ECM_ANDROID_ROOT_PATH sounds like this is the only one and might replace the

[Differential] [Commented On] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-18 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. Ping?`@apol, @cordlandwehr, any comment on this? And does this improve or at least not regress with how GCompris & KStars Light developers build for Android? I would like to avoid having to fork the toolchain file for Marble :/ REPOSITORY R240 Extra CMake

[Differential] [Request, 51 lines] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-11 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added reviewers: Frameworks, GCompris, Minuet, apol, cordlandwehr, mutlaqja, sandsmark, nienhueser. REVISION SUMMARY Currently (since https://phabricator.kde.org/R240:123d0d14017a25fb387efd8fe3c2c1323f9c3815) any find_library() and find_path() calls

[Differential] [Updated, 1,239 lines] D2854: New: ECMAddQch, for generating qch & doxygen tag files

2016-12-08 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8863. kossebau added a comment. lowercase virtual folder name for consistency with the Qt ones REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8856=8863 BRANCH addApiDox REVISION DETAIL

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

2016-12-08 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the summary for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz,

[Differential] [Updated, 1,239 lines] D2854: New: ECMAddQch, for generating qch & doxygen tag files

2016-12-08 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8856. kossebau added a comment. support inheriting LINK_QCHS, drop LINK_QCHS_VERSIONED for now REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8783=8856 BRANCH addApiDox REVISION DETAIL

[Differential] [Request, 38 lines] D3609: Create a QCH file with the API dox, optionally, using ECMAddQch

2016-12-06 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added a reviewer: Frameworks. REVISION SUMMARY See https://phabricator.kde.org/D2854 for central discussion of new ECMAddQCH TEST PLAN KF5SyntaxHighlighting.qch created by this: https://share.kde.org/index.php/s/tCP48mbIHu5TTTJ REPOSITORY R216

[Differential] [Commented On] D2854: New: ECMAddQch, for generating qch & doxygen tag files

2016-12-06 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > Hm, i guess i haven't checked KDEInstallDirs in a while. Somehow i remember > KDE_INSTALL_USE_QT_SYS_PATHS was only activated by default if > CMAKE_INSTALL_PREFIX was /usr. > > Ok, so the

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

2016-12-06 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the summary for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz,

[Differential] [Updated, 37 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8792. kossebau added a comment. update to latest ECMAddQch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8589=8792 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt

[Differential] [Updated, 34 lines] D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8791. kossebau added a comment. update to latest ECMAddQch REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3438?vs=8588=8791 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3438 AFFECTED

[Differential] [Updated, 35 lines] D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8789. kossebau added a comment. update to latest ECMAddQch REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3458?vs=8590=8789 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3458 AFFECTED FILES

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau retitled this revision from "New: ECMAddQCH, for generating qch & doxygen tag files" to "New: ECMAddQch, for generating qch & doxygen tag files". kossebau updated the summary for this revision. kossebau updated the test plan for this revision. REPOSITORY R240 Extra CMake Modules

[Differential] [Updated, 1,178 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8783. kossebau added a comment. s/QCH/Qch/, use find_oackage for needed tools, more control over output REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8639=8783 BRANCH addApiDox REVISION DETAIL

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-30 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > It is :) But with this latest revision it is not when that var is off =) I'm > saying that for both cases it should happen. Fear I am still missing what you mean. So let's go explicitely, here is what

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-30 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > Right. But if you install a framework to same prefix as Qt, you get free > recognition of plugins, qml imports, etc... This is valid for both /usr and > custom prefix installs. > I guess what i want

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-30 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > I mean, addition of qch subdir is 'your' invention here. > If Frameworks were to use only qmake build-system, i'm sure qch files would > end up in QT_INSTALL_DOCS directory. > I.e. for

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-30 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla > Qt's. QCH files are thus installed straight into QT_INSTALL_DOCS dir AFAICS > ... Not sure what you mean, please point out

[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-30 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8639. kossebau added a comment. adapt also documentation to doc/QCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8635=8639 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES

[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-30 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8635. kossebau added a comment. Use rather subfolder doc/QCH for installing QCH files CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8586=8635 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-28 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop

[Differential] [Updated, 34 lines] D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-28 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8590. kossebau added a comment. update to latest version of proposed ECMAddQCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3458?vs=8486=8590 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3458 AFFECTED FILES

[Differential] [Updated, 36 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-28 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8589. kossebau added a comment. update to latest version of proposed ECMAddQCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8488=8589 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES

[Differential] [Updated, 33 lines] D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-28 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8588. kossebau added a comment. update to latest version of proposed ECMAddQCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3438?vs=8487=8588 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3438 AFFECTED FILES

[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-28 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8586. kossebau added a comment. integrate feedback from review with use for kdb, kproperty & kreport CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8485=8586 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854

[Differential] [Updated] D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a dependency: D2854: New: ECMAddQCH, for generating qch & doxygen tag files. REVISION DETAIL https://phabricator.kde.org/D3458 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added dependent revisions: D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH, D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH, D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH. REVISION DETAIL

[Differential] [Updated] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a dependency: D2854: New: ECMAddQCH, for generating qch & doxygen tag files. REVISION DETAIL https://phabricator.kde.org/D3439 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud Cc: shumski

[Differential] [Updated] D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a dependency: D2854: New: ECMAddQCH, for generating qch & doxygen tag files. REVISION DETAIL https://phabricator.kde.org/D3438 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the summary for this revision. kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek,

[Differential] [Updated, 32 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8488. kossebau added a comment. Use new KDE_INSTALL_FULL_QTQCHDIR CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8357=8488 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt

[Differential] [Updated, 29 lines] D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8487. kossebau added a comment. Use new KDE_INSTALL_FULL_QTQCHDIR CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3438?vs=8356=8487 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3438 AFFECTED FILES CMakeLists.txt

[Differential] [Updated, 30 lines] D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8486. kossebau added a comment. Use new KDE_INSTALL_FULL_QTQCHDIR CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3458?vs=8404=8486 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3458 AFFECTED FILES CMakeLists.txt

[Differential] [Updated, 1,059 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8485. kossebau added a comment. Add QTQCHDIR and QCHDIR to KDEInstallDirs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8364=8485 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-24 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. In https://phabricator.kde.org/D2854#64179, @shumski wrote: > > a) recommended install path for qch and tag files? > > At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use QT_INSTALL_DOCS (via ECMQueryQmake) var. Good proposal, I think

[Differential] [Request, 30 lines] D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-22 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added a reviewer: Frameworks. REVISION SUMMARY See https://phabricator.kde.org/D2854 for central discussion of new ECMAddQCH TEST PLAN KF5Archive.qch created by this: https://share.kde.org/index.php/s/PGBChkDDHgGyo5f BRANCH addQCHBuild REVISION

[Differential] [Updated, 1,039 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-21 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8364. kossebau updated the test plan for this revision. kossebau added a comment. Small fixes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8348=8364 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED

[Differential] [Commented On] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-21 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > shumski wrote in CMakeLists.txt:82 > I wonder about the reasoning behind the existence of this export, and > installation of it... Imagine another project with a lib MyLib linking against KJobWidgets (in the public interface). For MyLib also a

[Differential] [Request, 32 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-21 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added reviewers: Frameworks, ochurlaud. REVISION SUMMARY See https://phabricator.kde.org/D2854 for central discussion of new ECMAddQCH TEST PLAN KF5JobWidgets.qch created by this: https://share.kde.org/index.php/s/UhVPFAy2cTb8cBL BRANCH

[Differential] [Request, 29 lines] D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-11-21 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added reviewers: Frameworks, ochurlaud. REVISION SUMMARY See https://phabricator.kde.org/D2854 for central discussion of new ECMAddQCH TEST PLAN KF5CoreAddons.qch created by this: https://share.kde.org/index.php/s/IuaDnjh704zu5wM BRANCH

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-11-21 Thread kossebau (Friedrich W. H. Kossebau)
kossebau retitled this revision from "New: ECMGenerateApiDox, for generating qch & tag files" to "New: ECMAddQCH, for generating qch & doxygen tag files". kossebau updated the summary for this revision. kossebau updated the test plan for this revision. kossebau added a reviewer: Frameworks.

[Differential] [Updated, 1,043 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-11-21 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8348. kossebau added a comment. Rename methods apidox->qch, use targets instead of pattern vars, more apidox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=6993=8348 BRANCH addApiDox REVISION DETAIL

[Differential] [Updated, 751 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-29 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 6993. kossebau added a comment. Add support for multiple qch in same build, example dir, MD mainpage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=6979=6993 BRANCH addGenerateApiDox REVISION DETAIL

[Differential] [Updated, 640 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-28 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 6979. kossebau added a comment. Add alternative SOURCES, add IMAGE_DIRS, improve status messages CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=6941=6979 BRANCH addGenerateApiDox REVISION DETAIL https://phabricator.kde.org/D2854

[Differential] [Updated] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-27 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the summary for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau Cc: staniek, winterz, ochurlaud, #kdevelop, #frameworks

[Differential] [Updated, 609 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-26 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 6941. kossebau added a comment. Fixing value of exported ${name}_APIDOX_TAGSFILE & tiny improvements CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=6927=6941 BRANCH addGenerateApiDox REVISION DETAIL

[Differential] [Updated] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-26 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the summary for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau Cc: staniek, winterz, ochurlaud, #kdevelop, #frameworks

[Differential] [Updated, 603 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-26 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 6927. kossebau added a comment. Fix generated inter-qch links, add support for unversioned namespace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=6917=6927 BRANCH addGenerateApiDox REVISION DETAIL

[Differential] [Changed Subscribers] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-25 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added subscribers: winterz, staniek. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau Cc: staniek, winterz, ochurlaud, #kdevelop, #frameworks

[Differential] [Updated] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-25 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the summary for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau Cc: ochurlaud, #kdevelop, #frameworks

[Differential] [Request, 598 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-25 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added subscribers: Frameworks, KDevelop, ochurlaud. REVISION SUMMARY To enable creation of qch files during a normal build, for documenting the public API of a lib. These macros are especially done with release builds in mind, so distributed