D19785: DocumentPrivate: Review del/backspace

2019-05-28 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:7e739920fd23: Dont delete entire previous line by backspace in pos 0 (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19785?vs=58682=58796#toc REPOSITORY R39 KTextEditor

D19785: DocumentPrivate: Review del/backspace

2019-05-28 Thread loh tar
loh.tar added a comment. That may fix it. diff --git a/src/document/katedocument.cpp b/src/document/katedocument.cpp index e365c380..7c24f67f 100644 --- a/src/document/katedocument.cpp +++ b/src/document/katedocument.cpp @@ -3350,7 +3350,9 @@ void

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

2019-05-26 Thread loh tar
loh.tar added a comment. > What would be the concrete content of the combobox then? What? Which box? These box can became these 4th "Smart" option but the code should then only work on spacesto be "correct/right". How about one extra bool which covers all normaly hidden stuff to

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

2019-05-26 Thread loh tar
loh.tar added a comment. > Given we already have now some enum for the show spaces stuff (None/Trailing/All) I would just vote to have some "Smart" 4th variant inside Can do, but this combobox reads to me for true spaces only, no tabs. See also Dominiks comment

D19785: DocumentPrivate: Review del/backspace

2019-05-26 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:bcba89914136: Review del/backspace (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19785?vs=53955=58682 REVISION DETAIL

D20815: Ensure highlighted folding marker after unfold

2019-05-23 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:e539697f5cbd: Ensure highlighted range begin/end marker after unfold (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20815?vs=57002=58551#toc REPOSITORY R39 KTextEditor

D20815: Ensure highlighted folding marker after unfold

2019-05-23 Thread loh tar
loh.tar added a comment. > And why is the delete not useful? After one month, no idea on first sight, sorry. Guess it is deleted prior or later anyway/already. > is it intentional that the folding start/end tokens are only sometimes highlighted on folding, still? I don't

D19771: Use placeholder instead of label

2019-05-22 Thread loh tar
loh.tar added a comment. > Hi, any more feedback on this? When in power mode, and the fields are filled, it is not clear what which field is. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: cullmann, cfeck, loh.tar,

D21287: Try to find always an unique visible document name without a number suffix

2019-05-22 Thread loh tar
loh.tar added a comment. > the path is appended behind the document name. What about this solution? Don't like that idea. And fit not well to the shown "Document List" problem. > to be efficient one could hash all documents I'm always in favor for such. But here I had no idea

D21287: Try to find always an unique visible document name without a number suffix

2019-05-19 Thread loh tar
loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21287 To: loh.tar, #ktexteditor Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D21287: Try to find always an unique visible document name without a number suffix

2019-05-19 Thread loh tar
loh.tar added a comment. > PS: The tab switcher also has something similar to make a distiction between files with the same name D16054 I noticed this patch. It's more a workaround for the core issue. > besides that the quick open already

D21287: Try to find always an unique visible document name without a number suffix

2019-05-19 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY When you e.g. work on multiple projects at the same time you

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

2019-05-08 Thread loh tar
loh.tar added a comment. Well, I'm also not full convinced about the current way, but how else? The point is, you can now add as much sets as you like and rel. quickly change between your presets. I read you request so, that we have at the end only some hardcoded offers which the user

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

2019-05-08 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:783647154a0e: Avoid infinite loop in Toggle Contained Nodes action (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21078?vs=57747=57772#toc REPOSITORY R39 KTextEditor

D20958: New menu of syntax highlighting in the status bar

2019-05-08 Thread loh tar
loh.tar added a comment. >> I could add a "Recent" section to the beginning of the menu, it would be useful. > > Nice! Just to be clear. That should to be work over session borders, not only the current one. Should you do it, here some bug report

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

2019-05-07 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. TEST PLAN Try and empty folding range like

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

2019-05-07 Thread loh tar
loh.tar updated this revision to Diff 57733. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a reviewer: VDG. loh.tar added a comment. - Make feature configurable CHANGES SINCE LAST UPDATE

D21007: Review kate config pages to improve maintenance friendliness

2019-05-04 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:2af8bdae9ae2: Review kate config pages to improve maintenance friendliness (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21007?vs=57518=57522#toc REPOSITORY R39

D21007: Review kate config pages to improve maintenance friendliness

2019-05-03 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Use new signal/slot style by new added helper functions -

D20958: New menu of syntax highlighting in the status bar

2019-05-03 Thread loh tar
loh.tar added a comment. > I could add a "Recent" section to the beginning of the menu, it would be useful. Nice! Just to be clear. That should to be work over session borders, not only the current one. >> The blue frame (in dark theme) looks compared to the other plain menus

D20963: Code cosmetic

2019-05-02 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:d572d3276358: Code cosmetic (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20963?vs=57380=57428 REVISION DETAIL

D20958: New menu of syntax highlighting in the status bar

2019-05-02 Thread loh tar
loh.tar added a comment. > When the menu is opened, clear any text in the search field left over from a prior search For my taste would that the usability only worsen, this way may not be usual but works charming. Perhaps may a change to select the field in that case a

D20958: New menu of syntax highlighting in the status bar

2019-05-02 Thread loh tar
loh.tar added a comment. Wow, look very nice :-) The only thing I would like to have is an auto generated "most often used" list. That was also suggested somewhere. This way you could quickly change between preferred styles instead to search for them. Your code looks lovely and well

D20963: Code cosmetic

2019-05-02 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Sort and group lines in the hope it's cause no hassle but

D20924: ViewConfig: Use new generic config interface

2019-05-02 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:743cbe13fda0: ViewConfig: Use new generic config interface (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20924?vs=57354=57378 REVISION

D20924: ViewConfig: Use new generic config interface

2019-05-01 Thread loh tar
loh.tar updated this revision to Diff 57354. loh.tar retitled this revision from "[WIP] ViewConfig: Use new generic config interface " to "ViewConfig: Use new generic config interface ". loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a

D20924: [WIP] ViewConfig: Use new generic config interface

2019-05-01 Thread loh tar
loh.tar updated this revision to Diff 57346. loh.tar edited the summary of this revision. loh.tar added a comment. - BookmarkSorting - AutoCenterLines - DefaultMarkType - PersistentSelection - InputMode - ViInputModeStealKeys - ViRelativeLineNumbers -

D20924: [WIP] ViewConfig: Use new generic config interface

2019-05-01 Thread loh tar
loh.tar updated this revision to Diff 57323. loh.tar edited the summary of this revision. loh.tar added a comment. - Use the power of new the interface in DocumentPrivate::setViewVariable - ShowFoldingPreview - ShowLineModification - ShowFoldingBar CHANGES SINCE LAST UPDATE

D20924: [WIP] ViewConfig: Use new generic config interface

2019-05-01 Thread loh tar
loh.tar updated this revision to Diff 57309. loh.tar edited the summary of this revision. loh.tar added a comment. - Use the power of new the interface in ViewPrivate::setConfigValue - Add missed finalizeConfigEntries() call - Add check to finalizeConfigEntries() for key to be unique -

D20924: [WIP] ViewConfig: Use new generic config interface

2019-05-01 Thread loh tar
loh.tar updated this revision to Diff 57300. loh.tar edited the summary of this revision. loh.tar added a comment. - Rebase on master - ShowScrollBarMiniMap - ShowScrollBarMiniMapAll - ScrollBarMiniMapWidth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20924?vs=57293=57300

D20924: [WIP] ViewConfig: Use new generic config interface

2019-05-01 Thread loh tar
loh.tar added inline comments. INLINE COMMENTS > dhaumann wrote in kateconfig.h:964 > Are training commas allowed meanwhile? Yes. It's handy while still on work here, but can remove it when I'm done, if desired. Thanks for your look, pls do it again later. REVISION DETAIL

D20924: [WIP] ViewConfig: Use new generic config interface

2019-04-30 Thread loh tar
loh.tar updated this revision to Diff 57293. loh.tar edited the summary of this revision. loh.tar added a comment. - ShowScrollBarPreview - ShowScrollBarMarks - ShowLineNumbers - Add some validator functions, please look at them CHANGES SINCE LAST UPDATE

D20924: [WIP] ViewConfig: Use new generic config interface

2019-04-30 Thread loh tar
loh.tar added a comment. Ah, last hint: The diff is not against master. Should you really like to try it, I can fix that earlier, otherwise will do it when I'm done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20924 To: loh.tar, #ktexteditor Cc: kwrite-devel,

D20924: [WIP] ViewConfig: Use new generic config interface

2019-04-30 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Done so far: - DynWordWrapAlignIndent -

D20903: Fix bookmark pixmap painting on icon bar

2019-04-30 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:08d1537b7565: Fix bookmark pixmap painting on icon bar (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20903?vs=57203=57268 REVISION

D20897: Ensure the left border miss no change of the count of line number digits

2019-04-30 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:34fec148d283: Ensure the left border miss no change of the count of line number digits (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20903: Fix bookmark pixmap painting on icon bar

2019-04-29 Thread loh tar
loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20903 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20903: Fix bookmark pixmap painting on icon bar

2019-04-29 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Hopefully this time really! TEST PLAN F6800396:

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

2019-04-29 Thread loh tar
loh.tar updated this revision to Diff 57192. loh.tar edited the test plan for this revision. loh.tar added a comment. - Remove special angle bracket check, will be back in a smarter may later (hopefully) - Move getter config functions into header CHANGES SINCE LAST UPDATE

D20897: Ensure the left border miss no change of the count of line number digits

2019-04-29 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This check was accidentally removed by 57781f34

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

2019-04-28 Thread loh tar
loh.tar updated this revision to Diff 57125. loh.tar retitled this revision from "DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection" to "Add option to treat some chars also as "auto bracket" only when we have a selection". loh.tar edited the summary of this

D20870: Fix vimode_keys AltGr test

2019-04-27 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:710a951d3053: Fix vimode_keys AltGr test (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20870?vs=57109=57112 REVISION DETAIL

D20870: Fix vimode_keys AltGr test

2019-04-27 Thread loh tar
loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20870 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20870: Fix vimode_keys AltGr test

2019-04-27 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Test has here always failed, now it passes again REPOSITORY

D20852: Fix to show folding preview when move the mouse from bottom to top

2019-04-27 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:2c2e345d4fbf: Fix to show folding preview when move the mouse from bottom to top (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20852: Fix to show folding preview when move the mouse from bottom to top

2019-04-27 Thread loh tar
mit a8d726dbf651fde07fe2ebb1d00a055a6a0dac5d (HEAD -> fix-drag+drop-test) Author: loh tar Date: Sat Apr 27 11:47:08 2019 +0200 Fix kateview_test testDragAndDrop Since a while has that test not reliable worked, looks now OK here diff --git a/autotes

D20852: Fix to show folding preview when move the mouse from bottom to top

2019-04-26 Thread loh tar
loh.tar updated this revision to Diff 57082. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a comment. - Fix missing cleanup in case of unvalid mouse position - Give members more fitting names - Remove unneeded

D20852: Fix to show folding preview when move the mouse from bottom to top

2019-04-26 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch happens in that case nothing. You have to

D20815: Ensure highlighted folding marker after unfold

2019-04-25 Thread loh tar
loh.tar updated this revision to Diff 57002. loh.tar edited the test plan for this revision. loh.tar added a comment. - Fix jump of big unfold II :-/ I notice that this not yet works when done by Short-Cut/Menu and there are nested folding ranges CHANGES SINCE LAST UPDATE

D20815: Ensure highlighted folding marker after unfold

2019-04-25 Thread loh tar
loh.tar updated this revision to Diff 56977. loh.tar added a comment. - Ensure cursor don't move when isssue toggleFoldingsInRange CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20815?vs=56970=56977 REVISION DETAIL https://phabricator.kde.org/D20815 AFFECTED FILES

D20815: Ensure highlighted folding marker after unfold

2019-04-25 Thread loh tar
loh.tar added a comment. I think about a patch to issue the foldingPreview in case of unfold when done by click on the icon bar. Unfortunately would that need some bigger changes at the toggleFolding functions to return what was done. Oops! Noticed that we have now some odd behavior

D20815: Ensure highlighted folding marker after unfold

2019-04-25 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this patch behaves the unfold like the fold to highlight

D20697: Review IconBorder

2019-04-24 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:0d70744ed67b: Fix broken InlineNoteTest (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20697?vs=56843=56895#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20606: Add action to toggle folding of child ranges

2019-04-23 Thread loh tar
loh.tar added a comment. In D20606#451744 , @mwolff wrote: > In D20606#451459 , @dhaumann wrote: > > > I would prefer a context menu that has this as action. This is much better discoverable and

D20697: Review IconBorder

2019-04-23 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:57781f34d234: Review IconBorder (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20697?vs=56839=56843 REVISION DETAIL

D20697: Review IconBorder

2019-04-23 Thread loh tar
loh.tar updated this revision to Diff 56839. loh.tar edited the test plan for this revision. loh.tar added a comment. try to fix annotation issue completely untested :-/ CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20697?vs=56694=56839 REVISION DETAIL

D20742: Paint the folding marker in propper color and make it more visible

2019-04-22 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:d9171c391267: Paint the folding marker in proper color and make it more visible (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20742: Paint the folding marker in propper color and make it more visible

2019-04-22 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Prior to this patch was the line in a color of the word wrap

D20697: Review IconBorder

2019-04-22 Thread loh tar
loh.tar added a comment. In D20697#453841 , @dhaumann wrote: > Did you test that the annotation border still works? You can do so in KDevelop by invoking git blame. :-/ ...OK, thanks > Besides I still gave no issues with this patch,

D20697: Review IconBorder

2019-04-21 Thread loh tar
loh.tar added a comment. @dhaumann Beside these annotation stuff I think I'm done with this now. Should you, or someone else, not stop me in the next few days I may treat this as OK and push it. There are still some issues in the mouse move handling but will try to fix that in some other

D20697: Review IconBorder

2019-04-21 Thread loh tar
loh.tar edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D20697: Review IconBorder

2019-04-21 Thread loh tar
loh.tar updated this revision to Diff 56694. loh.tar edited the summary of this revision. loh.tar added a comment. - Fix bookmark pixmap painting Left before, right with fix F6786476: bookmark-pixmap.png CHANGES SINCE LAST UPDATE

D20697: Review IconBorder

2019-04-21 Thread loh tar
loh.tar updated this revision to Diff 56693. loh.tar edited the summary of this revision. loh.tar added a comment. - Add margin to the edit area, but I'm not sure if it should be done here. I guess renderer should do it - Simplify "additional folding highlighting", there is now the slightly

D20264: Add test for "Auto Reload Document" option

2019-04-21 Thread loh tar
loh.tar added a comment. @dhaumann asked elsewhere > Instead of waiting so long, we could alternatively also have a while loop waiting up to 20 times for 50ms. This way, the test would be faster if possible. Like this? diff --git a/autotests/src/katedocument_test.cpp

D20697: Review IconBorder

2019-04-21 Thread loh tar
loh.tar updated this revision to Diff 56644. loh.tar added a comment. - Fix missing printed background in proper theme color - Fix scroll past end of document - Fix less pushy paint unfolded icon in not dark themes and don't try to use currentLineNumberColor, the folded icon gets also not

D20697: Review IconBorder

2019-04-20 Thread loh tar
loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns,

D20697: Review IconBorder

2019-04-20 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY The only two included changes noticeable by the user are:

D20565: Ensure not to fold the end marker

2019-04-20 Thread loh tar
loh.tar abandoned this revision. loh.tar added a comment. Patch is part of D20606 > And happy Easter ;=) Thank you! :-) REVISION DETAIL https://phabricator.kde.org/D20565 To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham Cc: kwrite-devel,

D20264: Add test for "Auto Reload Document" option

2019-04-20 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:f5f715ea1441: Add test for Auto Reload Document option (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20264?vs=55576=56623#toc REPOSITORY R39 KTextEditor CHANGES

D20606: Add action to toggle folding of child ranges

2019-04-20 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:5c83e29561e3: Add action to toggle folding of child ranges (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20606?vs=56527=56624#toc REPOSITORY R39 KTextEditor CHANGES

D20606: Add action to toggle folding of child ranges

2019-04-18 Thread loh tar
loh.tar marked an inline comment as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann,

D20606: Add action to toggle folding of child ranges

2019-04-18 Thread loh tar
loh.tar updated this revision to Diff 56527. loh.tar retitled this revision from "Toggle folding of child ranges by right click" to "Add action to toggle folding of child ranges". loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar

D20606: Toggle folding of child ranges by right click

2019-04-17 Thread loh tar
loh.tar added a comment. hm, there is already a folding action in the View menu. I understood Dominik so, not to add a context menu to the icon border, but to add the action to the context menu of the "edit range". Whatever, as said I'm not in the mood for that, and it should be done in

D20606: Toggle folding of child ranges by right click

2019-04-17 Thread loh tar
loh.tar updated this revision to Diff 56444. loh.tar added a comment. - Add docu to header, not full happy with - Add desired adjustment checks - Make toggleFoldingInRange more action friendly - Add first try to unfold range itself into toggleFoldingInRange - Be a smart ass,

D20606: Toggle folding of child ranges by right click

2019-04-16 Thread loh tar
loh.tar added a comment. Oh, may that fit too? Bug 352868 - Folding for all nodes (not just top-level) and/or siblings to current REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann Cc: kwrite-devel, kde-frameworks-devel,

D20606: Toggle folding of child ranges by right click

2019-04-16 Thread loh tar
loh.tar added a comment. A possible improvement could be to add slots to make the folding accessible by some keyboard action, but I'm not in the mood for that now. Bug 343060 - global folding code keyboard shortcuts REPOSITORY R39 KTextEditor REVISION DETAIL

D20606: Toggle folding of child ranges by right click

2019-04-16 Thread loh tar
loh.tar added a comment. This patch supersedes D20565 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20606 To: loh.tar, #ktexteditor, cullmann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham,

D20606: Toggle folding of child ranges by right click

2019-04-16 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this patch will all, and only, the nested

D20565: Ensure not to fold the end marker

2019-04-15 Thread loh tar
loh.tar updated this revision to Diff 56306. loh.tar edited the test plan for this revision. loh.tar added a comment. - Adjust only on token based folding CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20565?vs=56267=56306 REVISION DETAIL https://phabricator.kde.org/D20565

D20565: Ensure not to fold the end marker

2019-04-14 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...to avoid a deceptive look With recent fixes

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

2019-04-14 Thread loh tar
loh.tar added a comment. Yes! A short test looked very promising. Will play a little more, because had done some changes to this patch here :-/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund,

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

2019-04-14 Thread loh tar
loh.tar added a comment. Looks to me a call to KateLayoutCache::updateViewCache may help at some point. But have no idea where to place and with which parms. In KateLayoutCache::displayViewLine is "limit=0" on second call. REPOSITORY R39 KTextEditor REVISION DETAIL

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

2019-04-14 Thread loh tar
loh.tar added a comment. Did anyone tried this patch? While coding my focus was only on behavior while enter text. Now I notice that the folding is "broken" in a way that the view jumps to the bottom :-S First digging indicate that makeVisible(..) is called twice, and the second time

D19450: DocumentPrivate: Respect indention mode when block selection

2019-04-13 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:78a2e5d1daa5: DocumentPrivate: Respect indention mode when block selection (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D19511: ViewPrivate: Disable read-only mode action when doc is modified

2019-04-13 Thread loh tar
loh.tar abandoned this revision. loh.tar added a comment. To relieve the maintainer it's droped now. But I still have the feeling there could be something improved at these "Read-Only Stuff" REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19511 To: loh.tar,

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

2019-04-13 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:cfb0af25bdfa: ViewInternal: Fix makeVisible(..) (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17857?vs=53252=56144 REVISION DETAIL

D19450: DocumentPrivate: Respect indention mode when block selection

2019-04-13 Thread loh tar
loh.tar updated this revision to Diff 56115. loh.tar edited the summary of this revision. loh.tar added a comment. - Rebase on master No interest in this? An autotest (place) for this may KateDocumentTest::testReplaceTabs, but not sure. There are slightly other things checked. CHANGES

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

2019-04-13 Thread loh tar
loh.tar updated this revision to Diff 56110. loh.tar added a comment. - Rebase on master to keep it compile - Not further investigated if changes by D19163 needs more tweeks here > PS: Better naming for foobar ? :-) Yes :-) > I think this

D20264: Add test for "Auto Reload Document" option

2019-04-12 Thread loh tar
loh.tar added a comment. I spend a couple of time for this stuff. Would be nice someone else could try it or do some investigation with tools I'm not familiar with, and don't want to be atm. Without feedback I will push it in the next few days. REVISION DETAIL

D19608: DocumentPrivate: Make bracket handling smart

2019-04-12 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:8f0813f6c7ed: DocumentPrivate: Make bracket handling smart (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19608?vs=53444=56105#toc REPOSITORY R39 KTextEditor CHANGES

D19691: ViewInternal: Review drop event

2019-04-12 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:1a0da40ae3da: ViewInternal: Review drop event (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19691?vs=53702=56103#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST

D20264: Add test for "Auto Reload Document" option

2019-04-12 Thread loh tar
loh.tar added a comment. In D20264#448583 , @dhaumann wrote: > I think KateViewInternal::updateView is called for cursor blinking for instance. May that be an issue? Regarding ... > KateViewInternal::updateView is very often called

D20495: KateIconBorder: Fix folding popup width and height

2019-04-12 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Now take the popup the whole width of the view instead of

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

2019-04-11 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:c95655f845da: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

2019-04-10 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:6ba329f8d451: KateIconBorder: Ensure Dyn Wrap Marker are shown (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20431?vs=55893=55957

D20425: KateIconBorder: Code cosmetic

2019-04-10 Thread loh tar
This revision was automatically updated to reflect the committed changes. Closed by commit R39:6906368aa6b3: KateIconBorder: Code cosmetic (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20425?vs=55877=55956 REVISION DETAIL

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

2019-04-10 Thread loh tar
loh.tar updated this revision to Diff 55955. loh.tar edited the summary of this revision. loh.tar added a comment. - Use unicode code point QChar constructor - Due to comment by @cfeck remove fallback/config hint and... - Init in header as const - Add hint about different char sizes

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

2019-04-10 Thread loh tar
loh.tar added a comment. Diff on top of D20425 /D20431 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20434 To: loh.tar, cullmann, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel,

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

2019-04-10 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: cullmann, KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY The old special created pixmap is once working fine

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

2019-04-10 Thread loh tar
loh.tar added a comment. Diff on top of D20425 , not sure if depend on REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20431 To: loh.tar, cullmann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh,

  1   2   3   4   5   >