D19785: DocumentPrivate: Review del/backspace

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:7e739920fd23: Dont delete entire previous line by 
backspace in pos 0 (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19785?vs=58682=58796#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19785?vs=58682=58796

REVISION DETAIL
  https://phabricator.kde.org/D19785

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19785: DocumentPrivate: Review del/backspace

[loh tar]

loh.tar added a comment.


  That may fix it.
  
diff --git a/src/document/katedocument.cpp b/src/document/katedocument.cpp
index e365c380..7c24f67f 100644
--- a/src/document/katedocument.cpp
+++ b/src/document/katedocument.cpp
@@ -3350,7 +3350,9 @@ void 
KTextEditor::DocumentPrivate::backspace(KTextEditor::ViewPrivate *view, con
 
 } else {
 // col == 0: wrap to previous line
-if (line > 0) {
+const Kate::TextLine textLine = m_buffer->plainLine(line - 1);
+
+if (line > 0 && textLine) {
 if (config()->wordWrap() && textLine->endsWith(QLatin1String(" 
"))) {
 // gg: in hard wordwrap mode, backspace must also eat the 
trailing space
 removeText(KTextEditor::Range(line - 1, textLine->length() 
- 1, line, 0));

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19785

To: loh.tar, #ktexteditor, cullmann
Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

[loh tar]

loh.tar added a comment.


  > What would be the concrete content of the combobox then?
  
  What? Which box? These box can became these 4th "Smart" option but the code 
should then only work on spacesto be "correct/right".
  
  How about one extra bool which covers all normaly hidden stuff to be shown 
the smart way? Guess much easier to implement.

REVISION DETAIL
  https://phabricator.kde.org/D19254

To: loh.tar, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

[loh tar]

loh.tar added a comment.


  > Given we already have now some enum for the show spaces stuff 
(None/Trailing/All) I would just vote to have some "Smart" 4th variant inside
  
  Can do, but this combobox reads to me for true spaces only, no tabs. See also 
Dominiks comment https://phabricator.kde.org/D19254#418143 
  So, changing all bools to comboboxes?

REVISION DETAIL
  https://phabricator.kde.org/D19254

To: loh.tar, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D19785: DocumentPrivate: Review del/backspace

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:bcba89914136: Review del/backspace (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19785?vs=53955=58682

REVISION DETAIL
  https://phabricator.kde.org/D19785

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20815: Ensure highlighted folding marker after unfold

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:e539697f5cbd: Ensure highlighted range begin/end marker 
after unfold (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20815?vs=57002=58551#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20815?vs=57002=58551

REVISION DETAIL
  https://phabricator.kde.org/D20815

AFFECTED FILES
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20815: Ensure highlighted folding marker after unfold

[loh tar]

loh.tar added a comment.


  
  
  > And why is the delete not useful?
  
  After one month, no idea on first sight, sorry. Guess it is deleted prior or 
later anyway/already.
  
  > is it intentional that the folding start/end tokens are only sometimes 
highlighted on folding, still?
  
  I don't think so, no. But can't reproduce the given example. Looks working 
here.
  
  F6843962: 1558611751.png 
  
  OTH Seems my stated "With this patch behaves the unfold like the fold to 
highlight the start and end marker" only valid when fold by Short-Cut and not 
by mouse click on the left border.
  
  So, compare where the cursor is when click on the left border. Without patch 
on pos 0 (first column), with patch just before the open brace.
  
  I was often slightly irritated when unfold something. "What exact was now 
unfold?" The text jumps to quickly. A soft, fluid animation may nice, but not 
so easy to do. So I came up with this idea.

REVISION DETAIL
  https://phabricator.kde.org/D20815

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19771: Use placeholder instead of label

[loh tar]

loh.tar added a comment.


  > Hi, any more feedback on this?
  
  When in power mode, and the fields are filled, it is not clear what which 
field is.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, 
domson, michaelh, bruns, demsking, sars, dhaumann

D21287: Try to find always an unique visible document name without a number suffix

[loh tar]

loh.tar added a comment.


  > the path is appended behind the document name. What about this solution?
  
  Don't like that idea. And fit not well to the shown "Document List" problem.
  
  > to be efficient one could hash all documents
  
  I'm always in favor for such. But here I had no idea how to do that nicely 
and reliable. One Document is not the place to hold such hash, and the patch 
lives only there.
  
  The "file rename case" may indeed not catch here when it goes from duplicate 
to unique, but how often is that the case? Guess nearby never and it is no big 
harm to keep the prefix in that case. "Untitled" documnets are handled as 
before.
  
  > that would avoid that one needs to iterate always again over all documents 
to collect duplicates.
  
  Is a loop running once over 10 to 1000 (one should rethink his workflow when 
he has so many files open) turns on a file name update such an issue and any 
optimization worth? Well, currently lead that on session restore to one million 
loops, how long may take that? And compared to the other needed work to open 
one file. Guess it's not a big thing.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21287

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D21287: Try to find always an unique visible document name without a number suffix

[loh tar]

loh.tar edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21287

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D21287: Try to find always an unique visible document name without a number suffix

[loh tar]

loh.tar added a comment.


  
  
  > PS: The tab switcher also has something similar to make a distiction 
between files with the same name D16054 
  
  I noticed this patch. It's more a workaround for the core issue.
  
  > besides that the quick open already shows the path to distinguish the files
  
  Like D16054 , but without harm. Not so 
bad to see the full path there
  
  > Looking at the screenshots, I find it rather intransparent which document 
gets what name,
  
  Yes it is. Better solutions are welcome.
  My examples, or better test files, are of course the worst thinkable case and 
not well suited to demonstrate the (hoped) benefit of this patch.
  
  > is this really an improvement?
  
  It's the right place to fix the issue. You have then every where the unique 
names without extra quirks. Consider e.g. confirmation dialogues.
  
  > And: I have the feeling this patch should pay attention to performance. 
Sometimes, users have hundreds of files open, and this should not slow down any 
open operation.
  
  Well, speedups are always nice. On session restore is it really often called 
and with my test setup the names often renamed. But should that really cause a 
noticable slowdown? I have doubts.
  
  Perhaps has session restore potential for improvements, and the whole naming 
process too. The function is called for each file surprising often just to set 
the first true name. "Emtpty/NoName"->"Untitled"->"FileName"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21287

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D21287: Try to find always an unique visible document name without a number suffix

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  When you e.g. work on multiple projects at the same time you have often the 
case that you have documents with a number suffix on tabs or other places like 
side bars. These suffix give no hint which file it really is.
  This patch add some folder name to the document to make the name unique, 
which should be in any case more helpful than the number suffix.
  
  Drawbacks
  
  - The unique names can change when you open a file
  - The numbering is kept as fallback for rare cases. When it is in use are 
these numbers also not "static" like in case of "Untitled" documents

TEST PLAN
  No Patch
  F6834935: no-patch.png 
  Patch
  F6834936: patch.png 
  
  Hint: The shown "Documents" plugin did not notice name changes, keep this in 
mind when you play around

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21287

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

[loh tar]

loh.tar added a comment.


  Well, I'm also not full convinced about the current way, but how else?
  
  The point is, you can now add as much sets as you like and rel. quickly 
change between your presets. I read you request so, that we have at the end 
only some hardcoded offers which the user can modify, but saved is only one 
setting. Not so user-friendly :-/
  
  When one setting always fit, why at all make it configurable?

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor, cullmann, mwolff, #vdg
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, dhaumann

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:783647154a0e: Avoid infinite loop in Toggle 
Contained Nodes action (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21078?vs=57747=57772#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21078?vs=57747=57772

REVISION DETAIL
  https://phabricator.kde.org/D21078

AFFECTED FILES
  src/document/katebuffer.cpp
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20958: New menu of syntax highlighting in the status bar

[loh tar]

loh.tar added a comment.


  >> I could add a "Recent" section to the beginning of the menu, it would be 
useful.
  > 
  > Nice! Just to be clear. That should to be work over session borders, not 
only the current one.
  
  Should you do it, here some bug report 
https://bugs.kde.org/show_bug.cgi?id=397563 but perhaps can this be closed in 
any case

REPOSITORY
  R39 KTextEditor

BRANCH
  new-mode-menu

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

TEST PLAN
  Try and empty folding range like 
  ktexteditor/src/utils/kateconfig.cpp:634
  
  Where...
  
  KateRendererConfig::~KateRendererConfig()
  {
  }
  
  ...cause the hassle
  
  Each part of this patch solve the issue of its own, but I'm unsure which way 
to go. 
  I think it shouldn't be a folding range offered in such a case, will look at 
it later.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21078

AFFECTED FILES
  src/document/katebuffer.cpp
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

[loh tar]

loh.tar updated this revision to Diff 57733.
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a reviewer: VDG.
loh.tar added a comment.


  - Make feature configurable

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17693?vs=57192=57733

REVISION DETAIL
  https://phabricator.kde.org/D17693

AFFECTED FILES
  src/dialogs/editconfigwidget.ui
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: loh.tar, #ktexteditor, cullmann, mwolff, #vdg
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, dhaumann

D21007: Review kate config pages to improve maintenance friendliness

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2af8bdae9ae2: Review kate config pages to improve 
maintenance friendliness (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21007?vs=57518=57522#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21007?vs=57518=57522

REVISION DETAIL
  https://phabricator.kde.org/D21007

AFFECTED FILES
  src/dialogs/kateconfigpage.cpp
  src/dialogs/kateconfigpage.h
  src/dialogs/katedialogs.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D21007: Review kate config pages to improve maintenance friendliness

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Use new signal/slot style by new added helper functions
  - Unified comments, added some new, removed some obsolete

TEST PLAN
  I hope nothing got damaged

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21007

AFFECTED FILES
  src/dialogs/kateconfigpage.cpp
  src/dialogs/kateconfigpage.h
  src/dialogs/katedialogs.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20958: New menu of syntax highlighting in the status bar

[loh tar]

loh.tar added a comment.


  
  
  > I could add a "Recent" section to the beginning of the menu, it would be 
useful.
  
  Nice! Just to be clear. That should to be work over session borders, not only 
the current one.
  
  >> The blue frame (in dark theme) looks compared to the other plain menus 
slightly strange, any possibility to remove this?
  > 
  > You can erase the edge, but I'm not sure if the brightness..., since that 
brightness indicates that the widget is in focus.
  
  These focus is in general fine, and I didn't wanted to poke around here to 
get rid of it. Just to use perhaps some differend construction of these popup. 
Know idea what exactly :-) These "edge" may enough.
  
  >> Is your new great menu easy usable for other parts? Like the encoding?
  > 
  > It could be done.
  
  Nice! Maybe on Kde-Wide level? :-) But Kate-Only as first step may great 
enough.
  
  >> .cp does not show c++, same for cp
  > 
  > I checked the XML file of "C++", and *.cp isn't an extension associated 
with that language, so it isn't displayed.
  
  It's a little strange that while enter "c-p-p" it is shown/gone/shown iirc. 
How about some fuzzy search?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg
Cc: cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, bruns, demsking, sars, dhaumann

D20963: Code cosmetic

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:d572d3276358: Code cosmetic (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20963?vs=57380=57428

REVISION DETAIL
  https://phabricator.kde.org/D20963

AFFECTED FILES
  src/dialogs/katedialogs.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20958: New menu of syntax highlighting in the status bar

[loh tar]

loh.tar added a comment.


  
  
  > When the menu is opened, clear any text in the search field left over from 
a prior search
  
  For my taste would that the usability only worsen, this way may not be usual 
but works charming. Perhaps may a change to select the field in that case a 
possibility, so you could clear it easily
  
  > Single-clicking on an item in the list should select it and close the menu; 
double-click doesn't gain us anything here
  
  hm, works here exact this way (?)
  
  Some comments/ideas, no real criticism
  
  - .cp does not show c++, same for cp
  - These ctrl-return is handy! Would be good to have this on right or middle 
too or in conjunction with some modifier key alt/ctrl/shift
  - The blue frame (in dark theme) looks compared to the other plain menus 
slightly strange, any possibility to remove this?
  - Is your new great menu easy usable for other parts? Like the encoding?
  - As said: Would like to see these history stuff as part of this menu
  
  Great work!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg
Cc: ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
bruns, demsking, cullmann, sars, dhaumann

D20958: New menu of syntax highlighting in the status bar

[loh tar]

loh.tar added a comment.


  Wow, look very nice :-)
  The only thing I would like to have is an auto generated "most often used" 
list. That was also suggested somewhere. This way you could quickly change 
between preferred styles instead to search for them.
  
  Your code looks lovely and well documented. However, I always try to 
establish a docu style to avoid the use of multiline comments /**/ in the code 
itself and use // style. It doesn't waste so much space.
  
  Will try this later.

INLINE COMMENTS

> katemodemenulist.cpp:45
> + */
> +inline bool isDelimiter(const uint c)
> +{

perhaps static instead of inline?

> katemodemenulist.cpp:101
> +if (searchBarPos == Top)
> +layoutContainer->addLayout(layoutSearchBar);
> +layoutContainer->addLayout(m_layoutList);

coding style: brace always single liner

> katemodemenulist.cpp:114
> + */
> +connect(m_list, SIGNAL(itemActivated(QListWidgetItem *)),
> +this, SLOT(selectHighlighting(QListWidgetItem *)));

use new style

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate
Cc: loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D20963: Code cosmetic

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Sort and group lines in the hope it's cause no hassle but looks friendlier

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20963

AFFECTED FILES
  src/dialogs/katedialogs.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20924: ViewConfig: Use new generic config interface

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:743cbe13fda0: ViewConfig: Use new generic config interface 
(authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20924?vs=57354=57378

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/kateview_test.cpp
  autotests/src/testutils.cpp
  autotests/src/vimode/base.cpp
  autotests/src/vimode/completion.cpp
  autotests/src/vimode/emulatedcommandbarsetupandteardown.cpp
  autotests/src/vimode/keys.cpp
  autotests/src/vimode/view.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/katestatusbar.cpp
  src/view/kateview.cpp
  src/view/kateviewhelpers.cpp
  src/vimode/config/configtab.cpp

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D20924: ViewConfig: Use new generic config interface

[loh tar]

loh.tar updated this revision to Diff 57354.
loh.tar retitled this revision from "[WIP] ViewConfig: Use new generic config 
interface " to "ViewConfig: Use new generic config interface ".
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Last missed settings
  - Some cleanup

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20924?vs=57346=57354

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/kateview_test.cpp
  autotests/src/testutils.cpp
  autotests/src/vimode/base.cpp
  autotests/src/vimode/completion.cpp
  autotests/src/vimode/emulatedcommandbarsetupandteardown.cpp
  autotests/src/vimode/keys.cpp
  autotests/src/vimode/view.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/katestatusbar.cpp
  src/view/kateview.cpp
  src/view/kateviewhelpers.cpp
  src/vimode/config/configtab.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar updated this revision to Diff 57346.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - BookmarkSorting
  - AutoCenterLines
  - DefaultMarkType
  - PersistentSelection
  - InputMode
  - ViInputModeStealKeys
  - ViRelativeLineNumbers
  - AutomaticCompletionInvocation
  - WordCompletion
  - KeywordCompletion
  - WordCompletionMinimalWordLength
  - WordCompletionRemoveTail
  
  7 more and we are done :-/

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20924?vs=57323=57346

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/kateview_test.cpp
  autotests/src/vimode/base.cpp
  autotests/src/vimode/completion.cpp
  autotests/src/vimode/emulatedcommandbarsetupandteardown.cpp
  autotests/src/vimode/keys.cpp
  autotests/src/vimode/view.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateview.cpp
  src/view/kateviewhelpers.cpp
  src/vimode/config/configtab.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar updated this revision to Diff 57323.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Use the power of new the interface in DocumentPrivate::setViewVariable
  - ShowFoldingPreview
  - ShowLineModification
  - ShowFoldingBar

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20924?vs=57309=57323

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/vimode/base.cpp
  autotests/src/vimode/view.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar updated this revision to Diff 57309.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Use the power of new the interface in ViewPrivate::setConfigValue
  - Add missed finalizeConfigEntries() call
  - Add check to finalizeConfigEntries() for key to be unique
  - ShowIconBar
  - ShowScrollbars

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20924?vs=57300=57309

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/vimode/base.cpp
  autotests/src/vimode/view.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar updated this revision to Diff 57300.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Rebase on master
  
  - ShowScrollBarMiniMap
  - ShowScrollBarMiniMapAll
  - ScrollBarMiniMapWidth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20924?vs=57293=57300

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/vimode/base.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar added inline comments.

INLINE COMMENTS

> dhaumann wrote in kateconfig.h:964
> Are training commas allowed meanwhile?

Yes. It's handy while still on work here, but can remove it when I'm done, if 
desired.
Thanks for your look, pls do it again later.

REVISION DETAIL
  https://phabricator.kde.org/D20924

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar updated this revision to Diff 57293.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - ShowScrollBarPreview
  - ShowScrollBarMarks
  - ShowLineNumbers
  - Add some validator functions, please look at them

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20924?vs=57285=57293

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/vimode/base.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar added a comment.


  Ah, last hint: The diff is not against master. Should you really like to try 
it, I can fix that earlier, otherwise will do it when I'm done

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20924

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Done so far:
  
  - DynWordWrapAlignIndent
  - DynWordWrapIndicators
  - DynWrapAtStaticMarker
  - DynamicWordWrap
  - ShowWordCount
  - MaxHistorySize
  - SearchFlags
  - BackspaceRemoveComposedCharacters

TEST PLAN
  Please take a look, point me to mistakes, but wait until WIP is gone for a 
final "OK"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  src/dialogs/katedialogs.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20903: Fix bookmark pixmap painting on icon bar

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:08d1537b7565: Fix bookmark pixmap painting on icon bar 
(authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20903?vs=57203=57268

REVISION DETAIL
  https://phabricator.kde.org/D20903

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20897: Ensure the left border miss no change of the count of line number digits

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:34fec148d283: Ensure the left border miss no change of the 
count of line number digits (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20897?vs=57180=57267

REVISION DETAIL
  https://phabricator.kde.org/D20897

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20903: Fix bookmark pixmap painting on icon bar

[loh tar]

loh.tar edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20903

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20903: Fix bookmark pixmap painting on icon bar

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Hopefully this time really!

TEST PLAN
  F6800396: 1556552941.png 
  
  Well, not tested with fractal screen scaling like 1.2
  My first try to fix this issue was done with such scaling but now I'm back to 
1.0

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20903

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

[loh tar]

loh.tar updated this revision to Diff 57192.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Remove special angle bracket check, will be back in a smarter may later 
(hopefully)
  - Move getter config functions into header

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17693?vs=57125=57192

REVISION DETAIL
  https://phabricator.kde.org/D17693

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, dhaumann

D20897: Ensure the left border miss no change of the count of line number digits

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  This check was accidentally removed by 57781f34 
 - 
Review IconBorder

TEST PLAN
  Open new file, hit 10+ times the return key, watch the line numbers :-/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20897

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

[loh tar]

loh.tar updated this revision to Diff 57125.
loh.tar retitled this revision from "DocumentPrivate: Treat some chars also as 
"auto bracket" only when we have a selection" to "Add option to treat some 
chars also as "auto bracket" only when we have a selection".
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a subscriber: ngraham.
loh.tar added a comment.


  - Make feature optional by new config interface
  - Make feature independent from auto bracket option
  - Remove redundant const QChar typedChar
  - Use dummy config value from dialog
  
  TODO
  
  - Add QLineEdit or similar to config dialog
  - Oops, remove/change special angle bracket stuff
  
  QUESTIONS
  
  - Would it be this way in general OK? @mwolff
  - Is the chosen option name fitting and descriptive enough? @ngraham

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17693?vs=50061=57125

REVISION DETAIL
  https://phabricator.kde.org/D17693

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, dhaumann

D20870: Fix vimode_keys AltGr test

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:710a951d3053: Fix vimode_keys AltGr test (authored by 
loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20870?vs=57109=57112

REVISION DETAIL
  https://phabricator.kde.org/D20870

AFFECTED FILES
  autotests/src/vimode/keys.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20870: Fix vimode_keys AltGr test

[loh tar]

loh.tar edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20870

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20870: Fix vimode_keys AltGr test

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Test has here always failed, now it passes again

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20870

AFFECTED FILES
  autotests/src/vimode/keys.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20852: Fix to show folding preview when move the mouse from bottom to top

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2c2e345d4fbf: Fix to show folding preview when move the 
mouse from bottom to top (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20852?vs=57082=57105

REVISION DETAIL
  https://phabricator.kde.org/D20852

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, brauch, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20852: Fix to show folding preview when move the mouse from bottom to top

[loh tar]

loh.tar added a comment.


  > Have the feeling kateview_test testDragAndDrop fails more and more often. 
Have already spend a lot of time in look at that but without success
  
  Harr, with that change it looks good here. Need that a Diff here or can I 
commit without?
  
 commit a8d726dbf651fde07fe2ebb1d00a055a6a0dac5d (HEAD -> 
fix-drag+drop-test)
 Author: loh tar 
 Date:   Sat Apr 27 11:47:08 2019 +0200

 Fix kateview_test testDragAndDrop
 
 Since a while has that test not reliable worked, looks now OK here

diff --git a/autotests/src/kateview_test.cpp 
b/autotests/src/kateview_test.cpp
 index cb7cb3d4..1b8d71eb 100644
 --- a/autotests/src/kateview_test.cpp
 +++ b/autotests/src/kateview_test.cpp
 @@ -451,6 +451,8 @@ void KateViewTest::testDragAndDrop()
 QCOMPARE(view->selectionRange(), Range(1, 0, 2, 0));
 
 QVERIFY(QTest::qWaitForWindowExposed(view));
 +QTest::qWait(0); // For whatever reason needed
 +
 const QPoint startDragPos = internalView->mapFrom(view, 
view->cursorToCoordinate(KTextEditor::Cursor(1, 2)));
 const QPoint endDragPos = internalView->mapFrom(view, 
view->cursorToCoordinate(KTextEditor::Cursor(3, 0)));
 const QPoint gStartDragPos = internalView->mapToGlobal(startDragPos);

REVISION DETAIL
  https://phabricator.kde.org/D20852

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, brauch, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20852: Fix to show folding preview when move the mouse from bottom to top

[loh tar]

loh.tar updated this revision to Diff 57082.
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Fix missing cleanup in case of unvalid mouse position
  - Give members more fitting names
  - Remove unneeded m_nextHighlightBlock
  - Remove repaint()
  - Remove commented event filter hint

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20852?vs=57064=57082

REVISION DETAIL
  https://phabricator.kde.org/D20852

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor
Cc: brauch, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20852: Fix to show folding preview when move the mouse from bottom to top

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Without this patch happens in that case nothing. You have to leave the area
  an hover again the folding begin to trigger the popup.
  
  - Tried to simplify the code

TEST PLAN
  TODO/QUESTIONS
  
  - Increase m_delayFoldingHlTimer to 500ms just for interest, 150 is not to 
notice
  - The working of these timer looks to me broken. I guess the intend was to 
delay only the popup, or maybe always, but currently it looks somehow pointless.
  - With this new value you have at least a flicker protection when you try to 
reach the areas behind the folding area. Perhaps is that the only intend(?)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20852

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20815: Ensure highlighted folding marker after unfold

[loh tar]

loh.tar updated this revision to Diff 57002.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Fix jump of big unfold II :-/
  
  I notice that this not yet works when done by Short-Cut/Menu and there are 
nested folding ranges

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20815?vs=56977=57002

REVISION DETAIL
  https://phabricator.kde.org/D20815

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20815: Ensure highlighted folding marker after unfold

[loh tar]

loh.tar updated this revision to Diff 56977.
loh.tar added a comment.


  - Ensure cursor don't move when isssue toggleFoldingsInRange

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20815?vs=56970=56977

REVISION DETAIL
  https://phabricator.kde.org/D20815

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20815: Ensure highlighted folding marker after unfold

[loh tar]

loh.tar added a comment.


  I think about a patch to issue the foldingPreview in case of unfold when done 
by click on the icon bar. Unfortunately would that need some bigger changes at 
the toggleFolding functions to return what was done.
  
  Oops! Noticed that we have now some odd behavior when issued the toggle child 
action, will take a look.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20815

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20815: Ensure highlighted folding marker after unfold

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  With this patch behaves the unfold like the fold to highlight the start and 
end marker
  
  - Remove unneeded delete

TEST PLAN
  autotest looks good :-S

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20815

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20697: Review IconBorder

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0d70744ed67b: Fix broken InlineNoteTest (authored by 
loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20697?vs=56843=56895#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56843=56895

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  autotests/src/inlinenote_test.cpp

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: dfaure, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D20606: Add action to toggle folding of child ranges

[loh tar]

loh.tar added a comment.


  In D20606#451744 , @mwolff wrote:
  
  > In D20606#451459 , @dhaumann 
wrote:
  >
  > > I would prefer a context menu that has this as action. This is much 
better discoverable and also extensible with more folding actions.
  >
  >
  > I agree. Right-click should show a context menu. Middle-click could toggle, 
if you need it.
  
  
  Me wrote:
  
  > But a context menu on the icon border would I very much dislike. Middle 
click is not so handy and perform atm "paste to begin of line"
  
  Well, as long the menu works everywhere but not the folding area, may that 
indeed not so bad. There could also be actions to toggle the visibility of 
parts of the border. 
  Or you make the current right-click the left-click action. That may even more 
handy and give current left-click the middle button.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20697: Review IconBorder

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:57781f34d234: Review IconBorder (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56839=56843

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D20697: Review IconBorder

[loh tar]

loh.tar updated this revision to Diff 56839.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  try to fix annotation issue
  
  completely untested :-/

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56694=56839

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D20742: Paint the folding marker in propper color and make it more visible

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:d9171c391267: Paint the folding marker in proper color and 
make it more visible (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20742?vs=56758=56767

REVISION DETAIL
  https://phabricator.kde.org/D20742

AFFECTED FILES
  src/render/katerenderer.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20742: Paint the folding marker in propper color and make it more visible

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Prior to this patch was the line in a color of the word wrap marker painted, 
now its the folding color.
  The line was, at least here, always hard to see, so it's now painted thicker 
and slightly more above. 
  To avoid the line will overpaint the text is the code moved up, before the 
text painting.

TEST PLAN
  F6787435: 1555954064.png 
  For your convenience the raw change before the lines are moved up
  
@@ -886,12 +886,13 @@ void KateRenderer::paintTextLine(QPainter , 
KateLineLayoutPtr range, int x
if (!(flags & SkipDrawFirstInvisibleLineUnderlined) && 
range->startsInvisibleBlock()) {
const QPainter::RenderHints backupRenderHints = paint.renderHints();
paint.setRenderHint(QPainter::Antialiasing, false);
-QPen pen(config()->wordWrapMarkerColor());
+QPen pen(config()->foldingColor());
pen.setCosmetic(true);
pen.setStyle(Qt::DashLine);
pen.setDashOffset(xStart);
+pen.setWidth(2);
paint.setPen(pen);
-paint.drawLine(0, (lineHeight() * range->viewLineCount()) - 1, 
xEnd - xStart, (lineHeight() * range->viewLineCount()) - 1);
+paint.drawLine(0, (lineHeight() * range->viewLineCount()) - 2, 
xEnd - xStart, (lineHeight() * range->viewLineCount()) - 2);
paint.setRenderHints(backupRenderHints);
}

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20742

AFFECTED FILES
  src/render/katerenderer.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20697: Review IconBorder

[loh tar]

loh.tar added a comment.


  In D20697#453841 , @dhaumann wrote:
  
  > Did you test that the annotation border still works? You can do so in 
KDevelop by invoking git blame.
  
  
  :-/ ...OK, thanks
  
  > Besides I still gave no issues with this patch, except that I did not test 
myself. If you say there are mouse move issues, then these issues should be 
fixed asap :)
  
  It's no new issue..so it's not so urgent  :P

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20697: Review IconBorder

[loh tar]

loh.tar added a comment.


  @dhaumann Beside these annotation stuff I think I'm done with this now. 
Should you, or someone else, not stop me in the next few days I may treat this 
as OK and push it.
  There are still some issues in the mouse move handling but will try to fix 
that in some other patch

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20697: Review IconBorder

[loh tar]

loh.tar edited the test plan for this revision.

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20697: Review IconBorder

[loh tar]

loh.tar updated this revision to Diff 56694.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Fix bookmark pixmap painting
  
  Left before, right with fix
  F6786476: bookmark-pixmap.png 

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56693=56694

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20697: Review IconBorder

[loh tar]

loh.tar updated this revision to Diff 56693.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Add margin to the edit area, but I'm not sure if it should be done here. I 
guess renderer should do it
  - Simplify "additional folding highlighting", there is now the slightly 
gradient gone, bad?
  - Rename backGroundColor->iconBarColor to fit orig name, but that name sounds 
to me as it's only for the icon area of the border
  
  F6786421: pic.png 

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56644=56693

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20264: Add test for "Auto Reload Document" option

[loh tar]

loh.tar added a comment.


  @dhaumann asked elsewhere
  
  > Instead of waiting so long, we could alternatively also have a while loop 
waiting up to 20 times for 50ms. This way, the test would be faster if possible.
  
  Like this?
  
diff --git a/autotests/src/katedocument_test.cpp 
b/autotests/src/katedocument_test.cpp
index 4be9d7c3..e24a8ad9 100644
--- a/autotests/src/katedocument_test.cpp
+++ b/autotests/src/katedocument_test.cpp
@@ -655,14 +655,23 @@ void KateDocumentTest::testAutoReload()
// without to wait before it doesn't work here. It mostly fails with 
500,
// it tend to work with 600, but is not guarantied to work even with 800
QTest::qWait(1000);
+// No idea how to do some slice test here

stream << "\nTest";
stream.flush();

- // Hardcoded delay m_modOnHdTimer in DocumentPrivate
+// Try not to waste more time than needed, but we need to wait
+const int timeSlice = 50;
+// Hardcoded delay m_modOnHdTimer in DocumentPrivate
// + min val with which it looks working reliable here
-QTest::qWait(200 + 800);
-QCOMPARE(doc.text(), "Hello\nTest");
+const int totalPatience = 200 + 800;
+
+QString refTxT = ("Hello\nTest");
+for (int w = 0; w <= totalPatience; w += timeSlice) {
+QTest::qWait(timeSlice);
+if (doc.text() == refTxT) break;
+}
+QCOMPARE(doc.text(), refTxT);
// ...stay in the last line after reload!
QCOMPARE(view->cursorPosition().line(), doc.documentEnd().line());

@@ -674,8 +683,12 @@ void KateDocumentTest::testAutoReload()
stream.flush();
file.close();

-QTest::qWait(200 + 800);
-QCOMPARE(doc.text(), "Hello\nTest\nWorld!");
+refTxT = ("Hello\nTest\nWorld!");
+for (int w = 0; w <= totalPatience; w += timeSlice) {
+QTest::qWait(timeSlice);
+if (doc.text() == refTxT) break;
+}
+QCOMPARE(doc.text(), refTxT);
// ...and ensure we have not move around
QCOMPARE(view->cursorPosition(), c);
}
  
  No Patch
  
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 3152ms
  
  With Patch
  
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 2619ms
533ms saved
  
  But it can still fail now :-(
  
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 3127ms
  
  also with increased waiting times
  
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 3787ms
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 4802ms
  
  Does maybe the check "if (doc.text() == " disturbs the nice waiting?
  Playing with longer slice shows an effect around a 500ms slice, but then we 
have no benefit
  
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 3147ms

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20264

To: loh.tar, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20697: Review IconBorder

[loh tar]

loh.tar updated this revision to Diff 56644.
loh.tar added a comment.


  - Fix missing printed background in proper theme color
  - Fix scroll past end of document
  - Fix less pushy paint unfolded icon in not dark themes and don't try to use 
currentLineNumberColor, the folded icon gets also not highligted
  - Some more cosmetic
  
  F6785125: pic.png 

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56625=56644

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20697: Review IconBorder

[loh tar]

loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20697: Review IconBorder

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  The only two included changes noticeable by the user are:
  

  
  - Use line number color for unfolded triangle to be less intrusive
  - Move the line modification hint away from the edit area between the line 
numbers and the folding area to be less irritating when cursor is in first 
column
  
  Most of the changes in this patch could you see as code cosmetic or an 
attempt to make it more maintenance-friendly.
  

  
  - Cleanup, avoid redundancies and nesting
  - Rename members, make them unified named
  - Give each area an own value name
  - Remove m_oldBackgroundColor, can't see any benefit
  - Make positionToArea() and sizeHint() less error prone in case of design 
changes

TEST PLAN
  Pls try it, but I'm not sure if I'm done with it
  
  F6783737: 1555761488.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

[loh tar]

loh.tar abandoned this revision.
loh.tar added a comment.


  Patch is part of D20606 
  
  > And happy Easter ;=)
  
  Thank you! :-)

REVISION DETAIL
  https://phabricator.kde.org/D20565

To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20264: Add test for "Auto Reload Document" option

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f5f715ea1441: Add test for Auto Reload 
Document option (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20264?vs=55576=56623#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20264?vs=55576=56623

REVISION DETAIL
  https://phabricator.kde.org/D20264

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp

To: loh.tar, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20606: Add action to toggle folding of child ranges

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:5c83e29561e3: Add action to toggle folding of child ranges 
(authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20606?vs=56527=56624#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20606?vs=56527=56624

REVISION DETAIL
  https://phabricator.kde.org/D20606

AFFECTED FILES
  src/data/katepart5ui.rc
  src/document/katebuffer.cpp
  src/document/katebuffer.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Add action to toggle folding of child ranges

[loh tar]

loh.tar marked an inline comment as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Add action to toggle folding of child ranges

[loh tar]

loh.tar updated this revision to Diff 56527.
loh.tar retitled this revision from "Toggle folding of child ranges by right 
click" to "Add action to toggle folding of child ranges".
loh.tar edited the summary of this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Add menu action
  - Replace old two actions "Fold/Unfold Current Node" by "Toggle Current Node"
  - Move logic to ViewPrivate
  - KateBuffer: Add checks where they should be

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20606?vs=56444=56527

REVISION DETAIL
  https://phabricator.kde.org/D20606

AFFECTED FILES
  src/data/katepart5ui.rc
  src/document/katebuffer.cpp
  src/document/katebuffer.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar added a comment.


  hm, there is already a folding action in the View menu. 
  I understood Dominik so, not to add a context menu to the icon border, but to 
add the action to the context menu of the "edit range".
  Whatever, as said I'm not in the mood for that,  and it should be done in a 
2nd patch, when needed.
  But a context menu on the icon border would I very much dislike. Middle click 
is not so handy and perform atm "paste to begin of line"

INLINE COMMENTS

> kateviewhelpers.cpp:2484
> +// Don't try to fold a single line, which can happens due to adjustment 
> above'
> +// FIXME Avoid to offer a such folding marker
> +if (!foldingRange.onSingleLine()) {

oops, "to offer such a folding"

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar updated this revision to Diff 56444.
loh.tar added a comment.


  - Add docu to header, not full happy with
  - Add desired adjustment checks
  - Make toggleFoldingInRange more action friendly
- Add first try to unfold range itself into toggleFoldingInRange
- Be a smart ass, minimize if nesting in mouseReleaseEvent
  - Fix to eager toggleFoldingInRange, don't fold else part when written on one 
line } else {
  
  Regading toggleFoldingInRange
  
  - The return value is not needed anymore and will only in rare cases say 
"false"
  - Should now be useable as slot, so remove the return value?
  - Better name idea?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20606?vs=56375=56444

REVISION DETAIL
  https://phabricator.kde.org/D20606

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar added a comment.


  Oh, may that fit too?
  Bug 352868 - Folding for all nodes (not just top-level) and/or siblings to 
current

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar added a comment.


  A possible improvement could be to add slots to make the folding accessible 
by some keyboard action, but I'm not in the mood for that now.
  Bug 343060 - global folding code keyboard shortcuts

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar added a comment.


  This patch supersedes D20565 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  With this patch will all, and only, the nested foldings of a range
  (un)folded by right mouse click on the left hand icon border.
  
  The range itself keep untouched, not toggled.
  
  For convenience toggle the right button also a range which doesn't
  contain other folding ranges.
  
  The noted bug report request a slightly different behavior, but I think
  it's close enough to considered that as "fixed".
  
  BUG: 344414
  FIXED-IN: 5.58

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

[loh tar]

loh.tar updated this revision to Diff 56306.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Adjust only on token based folding

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20565?vs=56267=56306

REVISION DETAIL
  https://phabricator.kde.org/D20565

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ...to avoid a deceptive look
  
  With recent fixes was also the closing brace folded which can cause a false 
look of the remaining visible code

TEST PLAN
  Fold differend kind of code, only tested yet with C/C++ where it seems to 
work.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20565

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[loh tar]

loh.tar added a comment.


  Yes! A short test looked very promising.
  Will play a little more, because had done some changes to this patch here :-/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[loh tar]

loh.tar added a comment.


  Looks to me a call to KateLayoutCache::updateViewCache may help at some point.
  But have no idea where to place and with which parms. 
  In KateLayoutCache::displayViewLine is "limit=0" on second call.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[loh tar]

loh.tar added a comment.


  Did anyone tried this patch?
  While coding my focus was only on behavior while enter text. Now I notice 
that the folding is "broken" in a way that the view jumps to the bottom :-S
  
  First digging indicate that makeVisible(..) is called twice, and the second 
time reported  cache()->displayViewLine(..) "out of view" which is pretty 
surprising. The given cursor position is the same.
  Will look at this later this day.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D19450: DocumentPrivate: Respect indention mode when block selection

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:78a2e5d1daa5: DocumentPrivate: Respect indention mode when 
block selection (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19450?vs=56115=56154

REVISION DETAIL
  https://phabricator.kde.org/D19450

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19511: ViewPrivate: Disable read-only mode action when doc is modified

[loh tar]

loh.tar abandoned this revision.
loh.tar added a comment.


  To relieve the maintainer it's droped now.
  But I still have the feeling there could be something improved at these 
"Read-Only Stuff"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19511

To: loh.tar, #ktexteditor, cullmann
Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, sars, dhaumann

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:cfb0af25bdfa: ViewInternal: Fix makeVisible(..) (authored 
by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17857?vs=53252=56144

REVISION DETAIL
  https://phabricator.kde.org/D17857

AFFECTED FILES
  autotests/src/kateview_test.cpp
  src/view/kateview.cpp
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, sars

D19450: DocumentPrivate: Respect indention mode when block selection

[loh tar]

loh.tar updated this revision to Diff 56115.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Rebase on master
  
  No interest in this?
  An autotest (place) for this may KateDocumentTest::testReplaceTabs, but not 
sure. There are slightly other things checked.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19450?vs=52914=56115

REVISION DETAIL
  https://phabricator.kde.org/D19450

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

[loh tar]

loh.tar updated this revision to Diff 56110.
loh.tar added a comment.


  - Rebase on master to keep it compile
  - Not further investigated if changes by D19163 
 needs more tweeks here
  
  > PS: Better naming for foobar ? :-)
  
  Yes :-)
  
  > I think this should be configurable...
  
  ATM me too
  Without more feedback, like "what a great feature" it has very low prio for me

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19254?vs=52382=56110

REVISION DETAIL
  https://phabricator.kde.org/D19254

AFFECTED FILES
  src/render/katerenderer.cpp

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20264: Add test for "Auto Reload Document" option

[loh tar]

loh.tar added a comment.


  I spend a couple of time for this stuff. 
  Would be nice someone else could try it or do some investigation with tools 
I'm not familiar with, and don't want to be atm. Without feedback I will push 
it in the next few days.

REVISION DETAIL
  https://phabricator.kde.org/D20264

To: loh.tar, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19608: DocumentPrivate: Make bracket handling smart

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:8f0813f6c7ed: DocumentPrivate: Make bracket handling smart 
(authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19608?vs=53444=56105#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19608?vs=53444=56105

REVISION DETAIL
  https://phabricator.kde.org/D19608

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19691: ViewInternal: Review drop event

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:1a0da40ae3da: ViewInternal: Review drop event (authored by 
loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19691?vs=53702=56103#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19691?vs=53702=56103

REVISION DETAIL
  https://phabricator.kde.org/D19691

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20264: Add test for "Auto Reload Document" option

[loh tar]

loh.tar added a comment.


  In D20264#448583 , @dhaumann wrote:
  
  > I think KateViewInternal::updateView is called for cursor blinking for 
instance. May that be an issue?
  
  
  Regarding ...
  
  > KateViewInternal::updateView is very often called
  
  ...I don't think so. It was much more frequently than some blinking. That 
observation was only a general notice, not to this test...IIRC
  So, what do with this? Commit as it is?

REVISION DETAIL
  https://phabricator.kde.org/D20264

To: loh.tar, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20495: KateIconBorder: Fix folding popup width and height

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Now take the popup the whole width of the view instead of the half
  - The height computation is fixed to use all possible space left and allow 
slightly overpainting of the view bottom to cover all lines properly
  
  I hope the latter point cause no distaste.
  When other lines are still visible is that for me always confusing.
  There is a patch left which fix the not correct end of the folding range,
  where the closing brace is not covered. (No pic sorry)
  Works for the preview nicely but cause trouble while perform the fold,
  so need some more work/ideas...

TEST PLAN
  F6768794: pic.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20495

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c95655f845da: KateIconBorder: Use UTF-8 char instead of 
special pixmap as dyn wrap indicator (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20434?vs=55955=55983

REVISION DETAIL
  https://phabricator.kde.org/D20434

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, cullmann, #ktexteditor, dhaumann
Cc: dhaumann, cfeck, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, cullmann, sars

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6ba329f8d451: KateIconBorder: Ensure Dyn Wrap Marker are 
shown (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20431?vs=55893=55957

REVISION DETAIL
  https://phabricator.kde.org/D20431

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20425: KateIconBorder: Code cosmetic

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6906368aa6b3: KateIconBorder: Code cosmetic (authored by 
loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20425?vs=55877=55956

REVISION DETAIL
  https://phabricator.kde.org/D20425

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, szutmael, gennad, domson, 
michaelh, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[loh tar]

loh.tar updated this revision to Diff 55955.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Use unicode code point QChar constructor
  - Due to comment by @cfeck remove fallback/config hint and...
  - Init in header as const
  - Add hint about different char sizes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20434?vs=55896=55955

REVISION DETAIL
  https://phabricator.kde.org/D20434

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, cullmann, #ktexteditor, dhaumann
Cc: dhaumann, cfeck, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, cullmann, sars

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[loh tar]

loh.tar added a comment.


  Diff on top of D20425 /D20431 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20434

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: cullmann, KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  The old special created pixmap is once working fine but not so easy to 
maintain. The look however special too.
  
  The new code looks much more simpler but has the potential to fail when there 
is no such char in the desired font available.

TEST PLAN
  New look, the old you will know
  F6764371: 1554904220.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20434

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20431: KateIconBorder: Ensure Dyn Wrap Marker are shown

[loh tar]

loh.tar added a comment.


  Diff on top of D20425 , not sure if 
depend on

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20431

To: loh.tar, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann