D10437: Update file ioslave's temporary authorization list

[Chinmoy Ranjan Pradhan]

chinmoyr closed this revision.
chinmoyr added a comment.


  Merged with D10818 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh, ngraham

D10437: Update file ioslave's temporary authorization list

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  (Reusing the same phab request is fine in this case, because there were no 
review comments yet.
  Once there are, and they don't apply to a completely redesigned commit, then 
indeed better start a new phab request.)
  
  This commit looks ok, but I would merge it with the one that adds the method 
addTemporaryAuthorization(actionId), they go together.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D10437: Update file ioslave's temporary authorization list

[Chinmoy Ranjan Pradhan]

chinmoyr edited dependencies, added: D10818: Store PolicyKit action which the 
slave is authorized to perform; removed: D10641: Revoke temporary authorization 
of KIO slave before sending status to IdleSlave.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh, kmorwinski

D10437: Update file ioslave's temporary authorization list

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 28009.
chinmoyr retitled this revision from "Revoke authorization of file ioslave 
before it is used by another process" to "Update file ioslave's temporary 
authorization list".
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Updated function name.
  Updated title and summary.
  With this it is the third time I am completely changing the title and 
summary. When will it be too much? Or should I create a new patch everytime 
there's a change in approach?

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10437?vs=27483=28009

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10437

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh, kmorwinski