D10732: Help automoc to find metadata JSON files referenced in the code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:c03c2d526593: Help automoc to find metadata JSON files referenced in the code (authored by kossebau). CHANGED PRIOR

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau added a comment. Given there was no principal objection and this code is following the pattern of D10724 , going to push now as well, so it gets some more field-testing before next weeks tagging. REPOSITORY R242 Plasma Framework (Library)

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau updated this revision to Diff 27868. kossebau added a comment. have each macro added only once (closer to current draft of ECM macro) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10732?vs=27751=27868 BRANCH

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau added a comment. Thanks for review. > Can't we reuse this same code from kcoreaddons? Maybe kcoreaddons can offer a macro that does this? As hinted in the commit message, plan is to have some ECM macro instead, but only for 5.45 in a month, to not hurry macro signature

D10732: Help automoc to find metadata JSON files referenced in the code

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:176 > +endforeach() > +foreach(macro_name ${Plasma_AUTOMOC_MACRO_NAMES_WITH_JSON_ARG3}) > +# tell automoc how to find names of plugin metadata files Can't we reuse this same code from kcoreaddons? Maybe kcoreaddons

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau added a comment. For more details see comments on D10724 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10732 To: kossebau, #frameworks, #build_system, apol Cc: michaelh

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau created this revision. kossebau added reviewers: Frameworks, Build System, apol. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY automoc by itself can only detect metadata files referenced by direct usage of the