D10989: Check for nullptr in indexForNode

jtamate abandoned this revision. jtamate added a comment. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10989 To: jtamate, #frameworks, dfaure Cc: kde-frameworks-devel, mpyne, LeGast00n, cblack, michaelh, ngraham, bruns

D10989: Check for nullptr in indexForNode

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Herald added a subscriber: kde-frameworks-devel. I pushed https://commits.kde.org/kio/d219f304319cb61aa51aae78c46872cbe49f8ff0 instead, you can drop this. REPOSITORY R241 KIO

D10989: Check for nullptr in indexForNode

dfaure added a comment. helgrind and drd are for multithreading data races, but KDirModel can't be used in a multithreading context, so I'm not sure why you're mentioning those tools. If you do want to detect data races, please note that helgrind and drd have lots of false positives

D10989: Check for nullptr in indexForNode

jtamate added a comment. In D10989#219594 , @mpyne wrote: > I think valgrind has some flags you can use to try to generate a backtrace for where a freed block of memory was freed from, which might be useful for debugging. Thanks. The

D10989: Check for nullptr in indexForNode

dfaure added a comment. That's actually valgrind-memcheck's default behaviour. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10989 To: jtamate, #frameworks, dfaure Cc: mpyne, michaelh

D10989: Check for nullptr in indexForNode

mpyne added a comment. I'm not sure the job could have been deleted before `KDialogJobUiDelegate::showErrorMessage()` since much of the call stack before then involves making method calls on the job. KDirLister::handleError(KIO::Job*) (kdirlister.cpp:81) makes a call to `job->error()`

D10989: Check for nullptr in indexForNode

jtamate added a comment. > I tried testing > > kdialog --getexistingdirectory smb:// > > but this gives an error here "Unable to find any workgroups in your local network." even with samba started locally. Don't know why. I get always a crash trying kdialog

D10989: Check for nullptr in indexForNode

jtamate added a dependency: D11013: Remove trailing data in the protocol parameter in findProtocol. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10989 To: jtamate, #frameworks, dfaure Cc: michaelh

D10989: Check for nullptr in indexForNode

dfaure added a comment. It would be much better to fix those two issues instead... kf5.kio.core: Refilling KProtocolInfoFactory cache in the hope to find "" (which sounds like a wrongly constructed URL with no scheme) kf5.kio.widgets: Items emitted in directory QUrl("smb://") but

D10989: Check for nullptr in indexForNode

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY CCBUG: 390288 Checking for nullptr will avoid the crash and return an empty QModelIndex. TEST PLAN