D11604: kdirlistertest doesn't fail at random

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0c8cd4076b7d: kdirlistertest doesnt fail at random (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11604?vs=39991=3 REVISION DETAIL

D11604: kdirlistertest doesn't fail at random

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Those comments were all for a single line of code ;) But yes, your last change is exactly what I meant. "wait for nothing" is when waiting for a spy to get to 0. The line above that

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 39991. jtamate marked an inline comment as done. jtamate added a comment. I'm never sure at how many lines the comments affects, but the last one should be: QTRY_COMPARE(m_dirLister.spyClear.count(), 1);

D11604: kdirlistertest doesn't fail at random

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks. Almost there :-) INLINE COMMENTS > kdirlistertest.cpp:658 > +QTRY_COMPARE(dirLister2.spyStarted.count(), 1); > QCOMPARE(dirLister2.spyCompleted.count(), 1); >

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 39990. jtamate marked 11 inline comments as done. jtamate added a comment. Fixed the inline comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11604?vs=39836=39990 REVISION DETAIL

D11604: kdirlistertest doesn't fail at random

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdirlistertest.cpp:374 > +QTRY_COMPARE(m_dirLister.spyStarted.count(), 0); // fast path: no > directory listing needed > +

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 39836. jtamate marked 3 inline comments as done. jtamate added a comment. Restored all the signalSpy wait wrongly deleted. Removed the use of qmimedatabase. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D11604: kdirlistertest doesn't fail at random

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdirlistertest.cpp:530 > +const QMimeType htmlType = > db.mimeTypeForUrl(QUrl(QLatin1String("file:///index.html"))); > +qDebug() << "html mimeType="

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 39801. jtamate edited the summary of this revision. jtamate added a comment. Herald added a subscriber: kde-frameworks-devel. Removed the use of enterLoop and exitLoop in favor of QTRY_COMPARE and QTRY_VERIFY. Removed some waits Changed all the

D11604: kdirlistertest doesn't fail at random

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please add QStandardPaths::setTestModeEnabled(true) in initTestCase() so that your (broken, thank you WinE) locally defined mimetypes don't interfer with the test. Then

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 33623. jtamate edited the summary of this revision. jtamate added a comment. Add the new tests instead of replace. Use QTRY_COMPARE instead of custom loops. Reduce the number of files to 100. In my machine, the mime type of file.html is

D11604: kdirlistertest doesn't fail at random

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I'm all for making tests more stable, but changing what the test is testing, sounds dangerous to me (it might hide bugs in the cases that the test intended to be testing).

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 30323. jtamate added a comment. QStringLiteral instead of QString. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11604?vs=30285=30323 REVISION DETAIL https://phabricator.kde.org/D11604 AFFECTED FILES

D11604: kdirlistertest doesn't fail at random

apol added inline comments. INLINE COMMENTS > kdirlistertest.cpp:194 > +for (int i = 0; i < 1000 ; i++) { > +createSimpleFile(path + QString("toplevelfile_new_%1").arg(i)); > +} Should be QStringLiteral("") instead of QString(""). REPOSITORY R241 KIO REVISION DETAIL

D11604: kdirlistertest doesn't fail at random

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY - Instead of testing the creation and deletion of one file, do it with 1000 files. - test the mime type