D11652: Don't show the background if Button.flat

2018-04-17 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:49ef90bcb985: Dont show the background if 
Button.flat (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11652?vs=31309=32377

REVISION DETAIL
  https://phabricator.kde.org/D11652

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  tests/buttons_pc3.0.qml

To: apol, #plasma, mart
Cc: mart, #frameworks, michaelh, ngraham, bruns

D11652: Don't show the background if Button.flat

2018-04-17 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11652

To: apol, #plasma, mart
Cc: mart, #frameworks, michaelh, ngraham, bruns

D11652: Don't show the background if Button.flat

2018-04-04 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 31309.
apol added a comment.


  Now both Button {flat: true} and ToolButton look the same

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11652?vs=30414=31309

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11652

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  tests/buttons_pc3.0.qml

To: apol, #plasma
Cc: mart, #frameworks, michaelh, ngraham

D11652: Don't show the background if Button.flat

2018-04-03 Thread Marco Martin 
mart added a comment.


  how does it look when the mouse is over the toolbutton?
  the plasma button svg also has an element for that, to look like breeze 
toolbuttons (look at the navigation controls for the calendar for instance

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11652

To: apol, #plasma
Cc: mart, #frameworks, michaelh, ngraham

D11652: Don't show the background if Button.flat

2018-03-24 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise the flat property is ignored

TEST PLAN
  Tested on KDE Connect port to use PlasmaComponents

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11652

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml

To: apol, #plasma
Cc: #frameworks, michaelh, ngraham