D11925: [WIP] Add "SkipSwitcher" to API

2018-04-19 Thread Scott Harvey 
sharvey added a subscriber: Plasma.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: #plasma, graesslin, #frameworks, michaelh, bruns

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-19 Thread Scott Harvey 
sharvey added a comment.


  Polite "bump" for my reviewers. Please see D12363 
 - the Kubuntu team has had to manually 
disable some autotests stemming from D11924 
.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, bruns

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey marked 5 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey updated this revision to Diff 31311.
sharvey marked an inline comment as done.
sharvey added a comment.


  - Correct & update version numbers in XML entries

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=31308=31311

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey marked 2 inline comments as done.
sharvey added inline comments.

INLINE COMMENTS

> graesslin wrote in plasmawindowmodel.h:110
> I normally update those just before pushing to the next frameworks release 
> number.

Sorry. Was busy uploading before seeing your reply. Will gladly change again if 
necessary.

> sharvey wrote in plasmashell_interface.h:144
> Version 5.45?

Will change again if necessary.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey updated this revision to Diff 31308.
sharvey added a comment.


  - Add `@since 5.45` tag to SkipSwitcher doxygen comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11925?vs=31296=31308

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Martin Flöser 
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> sharvey wrote in plasmawindowmodel.h:110
> Correct version number? 5.45?

I normally update those just before pushing to the next frameworks release 
number.

> plasma-shell.xml:339
> +
> +
> +

The since is wrong. It must be higher than the current version. You also need 
to increase the version number and I think this should be added as last request 
and not in between.

> plasma-window-management.xml:49
> since="3"/>
> +  
>  

Here also the since is wrong

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey added inline comments.

INLINE COMMENTS

> plasmawindowmodel.h:110
> +/**
> + * @since 5.??
> + */

Correct version number? 5.45?

> plasmashell_interface.h:144
> + * in a window switcher
> + * @since 5.??
> + **/

Version 5.45?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey added a comment.


  F5787709: kwayland-test-exception.txt 
  KWayland test results / exception report

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey added a comment.


  NOTE: This is a junior job and a work in progress!
  
  Following discussion in BUG 375921 
, it was decided to add 
`SkipSwitcher` to the API. This is my first submission to the 
KWin/KWayland/KWindowSystem group, and @hein has graciously offered to help me 
out.
  
  As Martin wrote in the bug report, this should be straightforward, following 
the implementation of `SkipTaskbar`. For the most part, it is - the autotest 
results include
  
PASS   : TestWindowManagement::testRequestsBoolean(skipSwitcher)
  
  However, autotest #6 (`kwayland-testWaylandSurface`) is failing with an 
exception. I got the same exception when testing KWayland without my changes. 
I'm attaching the test output, in case it helps figure out what's wrong. All 
the other tests succeed.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

2018-04-04 Thread Scott Harvey 
sharvey created this revision.
sharvey added a reviewer: hein.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sharvey requested review of this revision.

REVISION SUMMARY
  Adding "SkipSwitcher" to API, as a result of discussion in
  BUG 375921
  
  Depends on / related to D11924 

REPOSITORY
  R127 KWayland

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11925

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-window-management.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  tests/plasmasurfacetest.cpp

To: sharvey, hein
Cc: #frameworks, michaelh, ngraham