D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham added a comment.


  Done in D19849 .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Alex Nemeth]

anemeth abandoned this revision.
anemeth added a comment.


  @ngraham  I'm sorry, but because of my new job I don't have much free time 
left so I can't actively develop anymore. I'd really like if someone took over 
this patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham added a comment.


  @anemeth, any updates on this? Do you need a hand with anything?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Henrik Fehlauer]

rkflx resigned from this revision.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Henrik Fehlauer]

rkflx added a comment.


  In D12545#256043 , @anemeth wrote:
  
  > I'm thinking about abandoning this revision in favor of proper tab ordering 
instead.
  
  
  As Nate already said, tabstop ordering would also be good to have. But given 
that the feature already works for single-click users, maybe you could make it 
work for double-click users too (i.e. for the first "selection" click) instead 
of abandoning? After all, in D12538  we are 
doing something similar (add a double-click feature for single-click users).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham added a comment.


  In D12545#256043 , @anemeth wrote:
  
  > In D12545#254473 , @rkflx wrote:
  >
  > > I could imagine a different spin here: [⇥] should switch focus from the 
item view to the name line edit, which it currently does not. (And as the 
dialog starts with focus on the name line edit, [⇧] + [⇥] should switch focus 
immediately to the item view.)
  > >
  > > Probably needs proper tabstop ordering.
  >
  >
  > This patch really breaks keyboard navigation.
  >  I'm thinking about abandoning this revision in favor of proper tab 
ordering instead.
  >  @ngraham are you ok with this?
  
  
  Proper tab ordering is important too. But IMHO this feature is worth keeping. 
When you've clicked on an existing file, the next thing you're going to do with 
it is either overwrite it, or slightly change the name of the file you're 
saving. Both of those use cases benefit from the focus automatically moving to 
the name field.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Alex Nemeth]

anemeth added a comment.


  In D12545#254473 , @rkflx wrote:
  
  > I could imagine a different spin here: [⇥] should switch focus from the 
item view to the name line edit, which it currently does not. (And as the 
dialog starts with focus on the name line edit, [⇧] + [⇥] should switch focus 
immediately to the item view.)
  >
  > Probably needs proper tabstop ordering.
  
  
  This patch really breaks keyboard navigation.
  I'm thinking about abandoning this revision in favor of proper tab ordering 
instead.
  @ngraham are you ok with this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Henrik Fehlauer]

rkflx edited the summary of this revision.
rkflx edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham added a comment.


  Good point. :) So yes, this is an enhancement for the double-click use case.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Henrik Fehlauer]

rkflx added a comment.


  In D12545#254479 , @ngraham wrote:
  
  > No, it doesn't actually work. Turn on double-click,
  
  
  Aha! This is what I'm missing. It should be mentioned in the summary if 
non-default settings are used :D

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham added a comment.


  In D12545#254477 , @rkflx wrote:
  
  > In D12545#254475 , @ngraham 
wrote:
  >
  > > Good point @rkflx, we definitely don't want to break keyboard navigation. 
We want this behavior only when clicking, and only for the save dialog.
  >
  >
  > Yeah, but not sure I understand. Isn't this exactly the behaviour we 
currently have, without the patch?
  
  
  No, it doesn't actually work. Turn on double-click, open a save dialog, click 
once on a file, and start typing. The typing is inrerpreted as type-ahead 
navigation instead of replacing the filename.
  
  I can reproduce this behavior with git master as well as Frameworks 5.45.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Henrik Fehlauer]

rkflx added a comment.


  In D12545#254475 , @ngraham wrote:
  
  > Good point @rkflx, we definitely don't want to break keyboard navigation. 
We want this behavior only when clicking, and only for the save dialog.
  
  
  Yeah, but not sure I understand. Isn't this exactly the behaviour we 
currently have, without the patch?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham added a comment.


  Good point @rkflx, we definitely don't want to break keyboard navigation. We 
want this behavior only when clicking, and only for the save dialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Henrik Fehlauer]

rkflx requested changes to this revision.
rkflx added a comment.


  Hm, this breaks selecting files and even navigating directories with the 
keyboard (e.g. via the arrow keys), and as such cannot possibly be something we 
want.
  
  I could imagine a different spin here: [⇥] should switch focus from the item 
view to the name line edit, which it currently does not. (And as the dialog 
starts with focus on the name line edit, [⇧] + [⇥] should switch focus 
immediately to the item view.)
  
  Probably needs proper tabstop ordering.
  
  ---
  
  In D12545#254437 , @ngraham wrote:
  
  > This is clearly what the code was //trying// to do, based on inline 
comments: 
https://cgit.kde.org/kio.git/tree/src/filewidgets/kfilewidget.cpp#n1176
  
  
  From observing the behaviour, to me this seems to affect the save dialog, and 
only upon //clicking// on a file. When navigating via the keyboard and thus 
merely //selecting// a file, this does not seem to be called. IOW, this part of 
the code seems fine to me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham added a dependent revision: D12544: Don't select file extension.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham
Cc: ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham
Cc: ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This is clearly what the code was //trying// to do, based on inline comments: 
https://cgit.kde.org/kio.git/tree/src/filewidgets/kfilewidget.cpp#n1176
  
  However, are we sure this is the right fix? This will have the effect of 
adding the select-text-when-clicked behavior the Open dialogs too, which does 
not seem to have been intended and which I don't think is helpful. Perhaps we 
should change the `locationEdit->setFocus();` to 
`locationEdit->lineEdit()->setFocus();` on line 1179 instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham
Cc: ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Alex Nemeth]

anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: Frameworks, VDG.
anemeth added a subscriber: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
anemeth requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  focus_lineedit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12545

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: anemeth
Cc: #frameworks, michaelh, bruns