D12950: add test which checks the property types

2019-02-23 Thread Alexander Stippich 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:24359a020a1a: add test which checks the property types 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12950?vs=51550=52384

REVISION DETAIL
  https://phabricator.kde.org/D12950

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D12950: add test which checks the property types

2019-02-12 Thread Alexander Stippich 
astippich added a comment.


  If no-one objects, I will land this next week

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12950

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12950: add test which checks the property types

2019-02-12 Thread Alexander Stippich 
astippich updated this revision to Diff 51550.
astippich added a comment.


  - fix space

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12950?vs=48691=51550

BRANCH
  property_tests

REVISION DETAIL
  https://phabricator.kde.org/D12950

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12950: add test which checks the property types

2019-01-29 Thread Alexander Stippich 
astippich added a comment.


  ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12950

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12950: add test which checks the property types

2019-01-04 Thread Alexander Stippich 
astippich added a comment.


  ping! I would like to land this as a preparation for T8196 


REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12950

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12950: add test which checks the property types

2019-01-04 Thread Alexander Stippich 
astippich updated this revision to Diff 48691.
astippich added a comment.


  - rebase
  - cleanup

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12950?vs=34396=48691

BRANCH
  property_tests

REVISION DETAIL
  https://phabricator.kde.org/D12950

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12950: add test which checks the property types

2018-09-06 Thread Alexander Stippich 
astippich added a comment.


  ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12950

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12950: add test which checks the property types

2018-07-12 Thread Alexander Stippich 
astippich added a comment.


  I would like to work on D11365  again 
where it was suggested to add the test first. As you can see from the tests, 
the types defined for each property in KFileMetaData do not match the output 
for the taglibextractor. The types are actually different if you query via 
Baloo or if you use KFileMetaData directly.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12950

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12950: add test which checks the property types

2018-07-12 Thread Matthieu Gallien 
mgallien added a comment.


  Sorry for the delay on my side.
  Why are you adding this test ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12950

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D12950: add test which checks the property types

2018-05-17 Thread Alexander Stippich 
astippich created this revision.
astippich added reviewers: mgallien, bruns.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Check the type of the properties defined in kfilemetadata vs. the actual 
returned types obtained from QVariant.
  Testing only one file is sufficient as this is shared code. Expected failures 
are declared as such.

REPOSITORY
  R286 KFileMetaData

BRANCH
  property_tests

REVISION DETAIL
  https://phabricator.kde.org/D12950

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns