D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham added a comment. Abandoning in favor of D13048 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham added a comment. Hmm, you're right. I guess there's no way around that if we want custom icon support here... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham,

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

broulik added a comment. Imho fine in principle, but: `QFileInfo` stats internally and `KDesktopFile` actually reads file contents. I don't see how you came to the conclusion this doesn't stat. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham,

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham added a dependent revision: D13083: Respect custom directory icons in iconNameForURL(). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham created this revision. ngraham added reviewers: Frameworks, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This allows us to use them in