D14472: Set Dialog flag for JobDialog

2018-10-29 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R495:b82b62e87a4e: Set Dialog flag for JobDialog (authored by 
nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14472?vs=38729=44468

REVISION DETAIL
  https://phabricator.kde.org/D14472

AFFECTED FILES
  src/widgets/JobDialog.qml

To: nicolasfella, apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14472: Set Dialog flag for JobDialog

2018-10-29 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  dialog

REVISION DETAIL
  https://phabricator.kde.org/D14472

To: nicolasfella, apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14472: Set Dialog flag for JobDialog

2018-09-27 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, cfeck.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D14472

To: nicolasfella, apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14472: Set Dialog flag for JobDialog

2018-09-27 Thread Nicolas Fella
nicolasfella added a comment.


  Ping?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D14472

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14472: Set Dialog flag for JobDialog

2018-07-29 Thread Nicolas Fella
nicolasfella edited the test plan for this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D14472

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14472: Set Dialog flag for JobDialog

2018-07-29 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The JobDialog window is treated as a "normal" window. When using a tiling 
window manager it gets as much space assigned as the other windows, which is 
quite unnecessary. With this patch it has the same size as when using a 
  floating WM and is floating above the "normal" windows (e.g. Dolphin), which 
seems more appropriate.

REPOSITORY
  R495 Purpose Library

BRANCH
  dialog

REVISION DETAIL
  https://phabricator.kde.org/D14472

AFFECTED FILES
  src/widgets/JobDialog.qml

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns