D14744: Make Definition::isDelimiter() also work for invalid definitions
This revision was automatically updated to reflect the committed changes. Closed by commit R216:eef5bce7080f: Make Definition::isDelimiter() also work for invalid definitions (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14744?vs=39470=39472 REVISION DETAIL https://phabricator.kde.org/D14744 AFFECTED FILES autotests/syntaxrepository_test.cpp src/lib/definition.cpp To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14744: Make Definition::isDelimiter() also work for invalid definitions
vkrause accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH delimiters-for-invalid-definitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D14744 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14744: Make Definition::isDelimiter() also work for invalid definitions
dhaumann updated this revision to Diff 39470. dhaumann added a comment. - Add support for getters of invalid Definitions REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14744?vs=39455=39470 BRANCH delimiters-for-invalid-definitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D14744 AFFECTED FILES autotests/syntaxrepository_test.cpp src/lib/definition.cpp To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14744: Make Definition::isDelimiter() also work for invalid definitions
vkrause accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH delimiters-for-invalid-definitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D14744 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14744: Make Definition::isDelimiter() also work for invalid definitions
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Avoids to have that workaround on the user side. Actually I think we want that, too, for things like "formats", that you always have some default normal format. But that is a different issue. REPOSITORY R216 Syntax Highlighting BRANCH delimiters-for-invalid-definitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D14744 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14744: Make Definition::isDelimiter() also work for invalid definitions
dhaumann created this revision. dhaumann added reviewers: cullmann, vkrause. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Used by KTextEditor. TEST PLAN make && make test REPOSITORY R216 Syntax Highlighting BRANCH delimiters-for-invalid-definitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D14744 AFFECTED FILES src/lib/definition.cpp To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
