ngraham added inline comments.
INLINE COMMENTS
> ksysguard.cpp:149
> +
> + // setup 'Settings' menu
> + KToggleAction* showMenuBar = KStandardAction::showMenubar(nullptr,
> nullptr, actionCollection());
Minor nitpick: "setup" is a noun; it should be "set up" so that there's a verb
in
ngraham added a comment.
Thanks! Please also remove ` - Bug 395349` from the title and replace it with
`BUG: 395349` in the Summary section.
---
Now the patch looks better, applies cleanly, and works in my testing.
However--and this is a complaint with other KDE software as
lsartorelli updated this revision to Diff 42101.
lsartorelli retitled this revision from "Bug 395349" to "Provide option to hide
menu bar for Ksysguard - Bug 395349".
lsartorelli edited the summary of this revision.
lsartorelli added a comment.
Thank you, for all the feedback.
Yes, I
