D15821: fix pop up positioning for !compositing mode

mvourlakos added inline comments. INLINE COMMENTS > dialog.cpp:910 > const bool outsideParentWindow = ((winInfo.windowType(NET::AllTypesMask) > == NET::Dock) || (item->window()->flags() & Qt::X11BypassWindowManagerHint)) > -&& item->window()->mask().isNull(); > +

D15821: fix pop up positioning for !compositing mode

mvourlakos updated this revision to Diff 42536. mvourlakos added a comment. - dont use mask() to identify popups placement REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15821?vs=42510=42536 BRANCH maskPositioning REVISION DETAIL

D15821: fix pop up positioning for !compositing mode

abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15821 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

mvourlakos added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15821 To: mvourlakos, #plasma, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

mvourlakos added a comment. F6292209: εικόνα.png [BEFORE: popup placement in plasma panel in !compositing] F6292214: εικόνα.png [AFTER: popup placement in plasma panel in !compositing] REPOSITORY R242

D15821: fix pop up positioning for !compositing mode

mvourlakos created this revision. mvourlakos added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mvourlakos requested review of this revision. REVISION SUMMARY --pop up positioning that was introduced in order to a dock pop up