D15830: Properly scope CMAKE_REQUIRED_LIBRARIES change

2018-09-29 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:bfe6134916f3: Properly scope CMAKE_REQUIRED_LIBRARIES 
change (authored by vkrause).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15830?vs=42543&id=42553

REVISION DETAIL
  https://phabricator.kde.org/D15830

AFFECTED FILES
  cmake/FindLibIntl.cmake

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15830: Properly scope CMAKE_REQUIRED_LIBRARIES change

2018-09-29 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Let's see what happens...

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15830

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D15830: Properly scope CMAKE_REQUIRED_LIBRARIES change

2018-09-29 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  It's the clean thing to do anyway, and it looks like this has side-effects
  on the coverage build of the CI.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15830

AFFECTED FILES
  cmake/FindLibIntl.cmake

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns