D15833: extend test coverage to all supported mimetypes for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:601059a3c0b6: extend test coverage to all supported mimetypes for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15833: extend test coverage to all supported mimetypes for taglibextractor

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Thx! REPOSITORY R286 KFileMetaData BRANCH taglib_extractor_additional_tests REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc:

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich updated this revision to Diff 43031. astippich added a comment. - update aiff and wav test files so that they are smaller REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15833?vs=42551=43031 BRANCH taglib_extractor_additional_tests

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich added a comment. In D15833#333933 , @svuorela wrote: > What's the origin/license of these files ? How are they created ? Forgot to mention it, I added this information to the summary. In D15833#333944

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15833: extend test coverage to all supported mimetypes for taglibextractor

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please lower bitdepth. Also, can you provide the commandline or the like to generate the files? - probably this is also stuff for an accompanying `README` file. REPOSITORY R286

D15833: extend test coverage to all supported mimetypes for taglibextractor

bruns added a comment. In D15833#333933 , @svuorela wrote: > What's the origin/license of these files ? How are they created ? The files contain just silence. @astippich - can you convert the wav file to 8bit (32bit float currently),

D15833: extend test coverage to all supported mimetypes for taglibextractor

svuorela added a comment. What's the origin/license of these files ? How are they created ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich updated this revision to Diff 42551. astippich added a comment. - modify permissions of binary files REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15833?vs=42549=42551 BRANCH taglib_extractor_additional_tests REVISION DETAIL

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich added a dependency: D15825: move testing of common tags of test files to a new data-driven test for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo,

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add new test files such that all mime types