D15842: Lower log level for X-KDE-DBus-ServiceName missing message

2018-10-24 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  If it's not a requirement for it to be set (and it isn't) I agree it's not a 
useful warning. But it's also not remotely useful debug.
  
  It's easy to see when something is registered, and we still have a warning if 
registration fails.
  
  Just delete it.

REPOSITORY
  R297 KDED

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15842

To: bruns, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15842: Lower log level for X-KDE-DBus-ServiceName missing message

2018-10-24 Thread Stefan Brüns
bruns added a comment.


  Ping!

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D15842

To: bruns, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15842: Lower log level for X-KDE-DBus-ServiceName missing message

2018-10-15 Thread Nathaniel Graham
ngraham added a reviewer: davidedmundson.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D15842

To: bruns, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15842: Lower log level for X-KDE-DBus-ServiceName missing message

2018-10-15 Thread Stefan Brüns
bruns added a comment.


  The current state causes unnecessary log spam, would be good to have this in.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D15842

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15842: Lower log level for X-KDE-DBus-ServiceName missing message

2018-09-29 Thread Stefan Brüns
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  None of the KDED modules provide a X-KDE-DBus-ServiceName, so there are
  a lot of warnings during session startup.
  Not providing the entry actually is no error, as:
  
  1. modules are loaded and requested using the org.kde.kded5 service
  2. org.kde.kded5 already is a singleton, so protecting against multiple
  
  instances of the module is not necessary.

TEST PLAN
  make

REPOSITORY
  R297 KDED

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15842

AFFECTED FILES
  src/kded.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns