D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham added a comment.


  Thanks again for this lovely icon, @ndavis. Next up, we need a variant of it 
that communicates "I'm the OS/root volume!" See 
https://bugs.kde.org/show_bug.cgi?id=399307
  
  This supports one of the next open tasks for T8349: Improve Places panel 
usability and presentation  that is a 
prerequisite for D15739: [Places panel] Don't show Root by default 
.
  
  Thanks!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: broulik, mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:3f7ca1b59557: Change drive-harddisk to more adaptable 
style (authored by ndavis, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15853?vs=42621=42667

REVISION DETAIL
  https://phabricator.kde.org/D15853

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk.svg
  icons-dark/devices/22/drive-harddisk.svg
  icons-dark/devices/64/drive-harddisk.svg
  icons/devices/16/drive-harddisk.svg
  icons/devices/22/drive-harddisk.svg
  icons/devices/64/drive-harddisk.svg

To: ndavis, #vdg, ngraham, pstefan
Cc: broulik, mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Stefan Brüns]

bruns added a comment.


  In D15853#334680 , @broulik wrote:
  
  > In D15853#334609 , @mart wrote:
  >
  > > What's that white blob on top of the hard disk? it looks really weird
  >
  >
  > Hard drives typically have this swivel elevated section that this tries to 
simulate.
  >  For a lack of a better picture: 
https://de.wikipedia.org/wiki/Datei:Damaged_Hard_disk_drive_for_data_protection_.JPG
 see the elevated sections on the top case?
  
  
  Two examples, a good matching one and a slighly different:
  https://gzhls.at/i/75/63/757563-n0.jpg
  https://gzhls.at/i/82/31/1508231-n1.jpg

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: broulik, mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Kai Uwe Broulik]

broulik added a comment.


  In D15853#334609 , @mart wrote:
  
  > What's that white blob on top of the hard disk? it looks really weird
  
  
  Hard drives typically have this swivel elevated section that this tries to 
simulate.
  For a lack of a better picture: 
https://de.wikipedia.org/wiki/Datei:Damaged_Hard_disk_drive_for_data_protection_.JPG
 see the elevated sections on the top case?

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: broulik, mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Marco Martin]

mart added a comment.


  What's that white blob on top of the hard disk? it looks really weird

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Phil Stefan]

pstefan accepted this revision.
pstefan added a comment.
This revision is now accepted and ready to land.


  Thank you for the changes!
  
  And I will change once I come around to it.

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham added a comment.


  Makes sense. @pstefan, could you take charge on that since you seem to have 
some knowledge about this process that the rest of us lack?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis added a comment.


  In D15853#334455 , @ngraham wrote:
  
  > In D15853#334425 , @ndavis wrote:
  >
  > > Ouch, I was not aware of this. All of the other monochrome icons I made 
that have been committed to master probably lack this as as well. It would be 
nice to have all the required info for making icons on a wiki somewhere. The 
icon HIG doesn't say anything about this.
  >
  >
  > Sounds like we should document it there. Wanna submit a patch? The repo is 
git://anongit.kde.org/websites/hig-kde-org.git :)
  >
  > Feel free to also submit a patch to do this for the other icons you've 
recently made.
  
  
  I would, but I feel like there may be other things I don't know and I don't 
want to be a blind man leading the blind. Right now, what I know is "copy this 
code into the file". Why? Because it somehow improves compatibility with the 
system colors. It's not only an unsatisfying answer, but it seems like an 
inelegant solution as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham added a comment.


  In D15853#334425 , @ndavis wrote:
  
  > Ouch, I was not aware of this. All of the other monochrome icons I made 
that have been committed to master probably lack this as as well. It would be 
nice to have all the required info for making icons on a wiki somewhere. The 
icon HIG doesn't say anything about this.
  
  
  Sounds like we should document it there. Wanna submit a patch? The repo is 
git://anongit.kde.org/websites/hig-kde-org.git :)
  
  Feel free to also submit a patch to do this for the other icons you've 
recently made.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis updated this revision to Diff 42621.
ndavis added a comment.


  Fix stylesheet

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15853?vs=42591=42621

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk.svg
  icons-dark/devices/22/drive-harddisk.svg
  icons-dark/devices/64/drive-harddisk.svg
  icons/devices/16/drive-harddisk.svg
  icons/devices/22/drive-harddisk.svg
  icons/devices/64/drive-harddisk.svg

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis added a comment.


  In D15853#334415 , @pstefan wrote:
  
  > In the monochrome icons (size 16px and 22px) you forgot to add the 
stylesheet. Without it, the monochrome icons won't be able to adapt to a 
changing color scheme. 
  >  You will have to run the scripts "apply-stylesheet.sh" and 
"currentColorFillFix.sh" –from here 
– with your 
files as arguments. You will need the program "xmlstarlet" as dependency. 
  >  Or, if these scripts do not work correctly, you'll have to do it by hand. 
I will take icons-dark/devices/16/drive-harddisk.svg as an example.
  >  You'd need to copy line 2-9 from the old file to the new file. You would 
also need to change the fill to "fill:currentColor", and then add the 
"class="ColorScheme-Text" ". But if you are lucky the script will work and you 
won't need to do a thing :)
  >
  > PS somewhere there's a script that changes the color of your monochrome 
automagically to the dark variant. So you don't have to do it by hand.
  
  
  Ouch, I was not aware of this. All of the other monochrome icons I made that 
have been committed to master probably lack this as as well. It would be nice 
to have all the required info for making icons on a wiki somewhere. The icon 
HIG doesn't say anything about this.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Phil Stefan]

pstefan requested changes to this revision.
pstefan added a comment.
This revision now requires changes to proceed.


  In the monochrome icons (size 16px and 22px) you forgot to add the 
stylesheet. Without it, the monochrome icons won't be able to adapt to a 
changing color scheme. 
  You will have to run the scripts "apply-stylesheet.sh" and 
"currentColorFillFix.sh" –from here 
– with your 
files as arguments. You will need the program "xmlstarlet" as dependency. 
  Or, if these scripts do not work correctly, you'll have to do it by hand. I 
will take icons-dark/devices/16/drive-harddisk.svg as an example.
  You'd need to copy line 2-9 from the old file to the new file. You would also 
need to change the fill to "fill:currentColor", and then add the 
"class="ColorScheme-Text" ". But if you are lucky the script will work and you 
won't need to do a thing :)
  
  PS somewhere there's a script that changes the color of your monochrome 
automagically to the dark variant. So you don't have to do it by hand.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Wow, this is amazingly better. Here's how it looks in the Places Panel at 
various sizes:
  
  Small (default): F6295828: Small.png 
  
  Large: F6295829: Large.png 
  
  Huge: F6295830: Huge.png 

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Nathaniel Graham]

ngraham added a task: T9740: Improve disk presentation in the Places panel.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D15853: Change drive-harddisk to more adaptable style

[Stefan Brüns]

bruns added a comment.


  In D15853#334188 , @ndavis wrote:
  
  > I only added 16, 22 and 64 px icons in the current revision, but I also 
have a 32px version. Is there a reason that there are only 16, 22 and 64 px 
versions for all device icons?
  >
  > The 64 px version already scales down to 50% size quite well, but the 32px 
version might be useful to people making icons for alternative harddrive types.
  
  
  I think "64 px version already scales down to 50% size quite well" is the 
reason to omit these icons. 16/22 have to be specifically designed to be 
recognizable, but omitting 32 avoids wasting disk space and avoids the 
potential problem of differing design for 32/64/128.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis added a comment.


  I only added 16, 22 and 64 px icons in the current revision, but I also have 
a 32px version. Is there a reason that there are only 16, 22 and 64 px versions 
for all device icons?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  T9740 
  
  The old 16 and 22 px drive-harddisk icons didn't look like hard drives. The 
new design for 16, 22 and 64 px is easier to resize and adapt. Symbols can be 
added to the light area on top of the 64px icon to show different types of 
drives (e.g., a globe for iSCSI)

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk.svg
  icons-dark/devices/22/drive-harddisk.svg
  icons-dark/devices/64/drive-harddisk.svg
  icons/devices/16/drive-harddisk.svg
  icons/devices/22/drive-harddisk.svg
  icons/devices/64/drive-harddisk.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns