This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8100e99e1465: Add the possibility to have a keyboard
shortcut to create a file (authored by thsurrel).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
newfileshortcut (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D16412
To: thsurrel, #frameworks, dfaure, elvisangelaccio
Cc: elvisangelaccio,
thsurrel marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16412
To: thsurrel, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
thsurrel updated this revision to Diff 44202.
thsurrel added a comment.
Fixes as per elvisangelaccio
Thank you very much for the review!
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16412?vs=44178=44202
BRANCH
newfileshortcut (branched from master)
elvisangelaccio added inline comments.
INLINE COMMENTS
> knewfilemenu.cpp:755
> } else {
> +if (m_firstFileEntry == nullptr) {
> +m_firstFileEntry =
`!m_firstFileEntry`
> knewfilemenu.cpp:1263-1299
> +QString text =
thsurrel added a dependent revision: D16413: Add a keyboard shortcut to create
file.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16412
To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
thsurrel created this revision.
thsurrel added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.
REVISION SUMMARY
It is already possible to create a directory with a keyboard shortcut (F10 in
