D16431: Guard data source being deleted before processing dataoffer receive event

2018-10-29 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:8fe4a2756cdb: Guard data source being deleted before 
processing dataoffer receive event (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16431?vs=44227=44422

REVISION DETAIL
  https://phabricator.kde.org/D16431

AFFECTED FILES
  src/server/dataoffer_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16431: Guard data source being deleted before processing dataoffer receive event

2018-10-29 Thread Roman Gilg 
romangg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16431

To: davidedmundson, #kwin, romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16431: Guard data source being deleted before processing dataoffer receive event

2018-10-25 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  A data source can disappear at any moment, it's plausible a client could
  have requested data whilst the client was alive and we are processing it
  afterwards.
  
  The accept and finish callback guard against the source being deleted,
  but recieve did not.
  
  BUG: 400311

TEST PLAN
  Could still copy/paste as before

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16431

AFFECTED FILES
  src/server/dataoffer_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns