D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-10 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16674

To: dfaure, akrutzler, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-05 Thread Andreas Krutzler
akrutzler accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16674

To: dfaure, akrutzler, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-05 Thread Elvis Angelaccio
elvisangelaccio accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16674

To: dfaure, akrutzler, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-04 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16674

To: dfaure, akrutzler, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-04 Thread David Faure
dfaure created this revision.
dfaure added reviewers: akrutzler, elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald edited subscribers, added: kfm-devel, kde-frameworks-devel; removed: 
Dolphin.
dfaure requested review of this revision.

REVISION SUMMARY
  KIO says the following:
  listDir() did not call finished() or error()! Please fix the "kio_mtp" KIO 
slave
  
  and message boxes are annoying anyway, better use the error mechanism
  for actual errors.

TEST PLAN
  Not fully tested I admit, but seems obvious :-)

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16674

AFFECTED FILES
  mtp/kio_mtp.cpp

To: dfaure, akrutzler, elvisangelaccio
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov