D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  Thanks for catching this. Did re-run tests locally, seems no other issue 
remaining. Please check.

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin updated this revision to Diff 45260.
dlevin added a comment.


  Replaced missing "code" attribute with "g".

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16677?vs=44885=45260

REVISION DETAIL
  https://phabricator.kde.org/D16677

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/input/brightscript.brs.syntax
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Hi, I tried to land the patch but the consistency checks of the indexer tell 
me:
  
  
"/home/cullmann/local/kde/src/frameworks/syntax-highlighting/data/syntax/brightscript.xml"
 Reference of non-existing itemData attributes: QSet("code")
  
  I think the
  
  
  
  line needs some fix ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  You can find my credentials at the beginning of the file I added in this 
patch: data/syntax/brightscript.xml

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Christoph Cullmann]

cullmann added a comment.


  That's all fine, its inside the xml syntax file: "Daniel Levin 
(dendy...@gmail.com)" ;=)
  I will use that for the commit, otherwise I would have asked ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Nathaniel Graham]

ngraham added a comment.


  @dlevin
  
  That comment was meant for other KDE developers. :) There's nothing you need 
to do on that front... however, since you submitted the patch using the web 
interface rather than using `arc` 
, your 
authorship information was not included with the patch and we'll need your full 
name and preferred email address before we can land the patch. Can you provide 
that?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  @ngraham, so I have to match commit authors in syntax-highlighting Git 
project against that list? Curious whether all those people have rights to push 
patches particularly into this project. Still it feels like this is not an easy 
task to do that manually, so I would rather annoy you guys in this message 
thread with my push request (-:

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Nathaniel Graham]

ngraham added a comment.


  In D16677#356620 , @dhaumann wrote:
  
  > Unless you have a KDE commit account you can not commit yourself. 
Unfortunately we cannot see on Phabricator whether you have one or not.
  
  
  BTW, you can check to see whether someone has a contributor account by trying 
to find their username on 
https://websvn.kde.org/trunk/kde-common/accounts?view=markup

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Christoph Cullmann]

cullmann added a comment.


  The merge should show up here and you should get a notification mail like for 
any other action.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  Thanks a lot for helping me with this! One last question: how do I know that 
patch was finally merged, by periodically checking the github mirror git 
repository? https://github.com/KDE/syntax-highlighting.git

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Christoph Cullmann]

cullmann added a comment.


  I can push that for you, just need to fixup my local dev setup again ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  I do not have a KDE commit account, so I guess I need your help to integrate 
this patch.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Dominik Haumann]

dhaumann added a comment.


  Unless you have a KDE commit account you can not commit yourself. 
Unfortunately we cannot see on Phabricator whether you have one or not. We can 
integrate this patch and then it will be in the next KDE Frameworks release, 
i.e. early next month.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  Just double checking whether any additional actions required from my side or 
'landing' a patch means it will be a part of the next release automatically.
  If so then where I could find a release roadmap?
  Thanks in advance!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  There are various reasons I was using 1-element keyword lists instead of 
StringDetect:
  
  1. keyword properly recognizes value surrounded by non-word characters, 
StringDetect does not.
  2. BrightScript language is case insensitive, adding insensitive="true" to 
every single StringDetect is too verbose in my case.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16677: Add BrightScript syntax

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, beside that I am not sure why you use 1-element keyword list instead of 
StringDetect at some places, I see no issues with that.
  If you like, you can change that, otherwise I am fine with that as is.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin updated this revision to Diff 44885.
dlevin added a comment.


  Changed syntax license to MIT.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16677?vs=44881=44885

REVISION DETAIL
  https://phabricator.kde.org/D16677

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/input/brightscript.brs.syntax
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, #framework_syntax_highlighting
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16677: Add BrightScript syntax

[Christoph Cullmann]

cullmann added a comment.


  Hi, thanks for the contribution.
  Could you use the MIT license for the files?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin created this revision.
dlevin added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dlevin requested review of this revision.

REVISION SUMMARY
  Accurate implementation of BrightScript language, mostly used by Roku
  channel developers and documented at Roku SDK portal:
  
  https://sdkdocs.roku.com/display/sdkdoc/Roku+SDK+Documentation
  
  Highlight sytax covers:
  
  - function and sub definitions, both global and inline
  - comments: ' and REM
  - macros
  - print statement
  - library imports
  - literal type narrowing with: $, %, !, #, &
  - conditionals and loops with: if, for and while
  - built-in and library functions
  - standard Roku Scene Graph keywords: m, top, global
  - array, function calls
  - goto and label statements
  - built-in types used in function/sub arguments and return
  - constants: true, false, invalid
  - distinct assignment and unary/binary ops, e.g.: if a = b c = d ' first = is 
a comparison, second = is an assignment
  - invalid syntax detection in some cases
  
  No folding is supported at this point.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/input/brightscript.brs.syntax
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann